Re: [devel] [PATCH 0/1] Review Request for msg: implement metadata size and limit fetch operations [#2626]

2018-02-02 Thread Srinivas Mangipudy
Hi Alex,   Ack from me, code review only.   Thank you Srinivas   From: Alex Jones [mailto:ajo...@rbbn.com] Sent: Wednesday, January 31, 2018 8:02 PM To: Srinivas Mangipudy Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [PATCH 0/1] Review Request for

Re: [devel] [PATCH 0/1] Review Request for log: update saflogtest to limit timeout when handling try again [#2764]

2018-02-02 Thread Canh Van Truong
Hi Lennart, I am not sure if there is confusion for "logtest" and "saflogtest" with you. I have a check the printout of help (-h) of command "saflogtest" and does not fully understand your comments. Could you give me the example? Thanks Canh -Original Message- From: Lennart Lund

Re: [devel] [PATCH 0/1] Review Request for log: update saflogtest to limit timeout when handling try again [#2764]

2018-02-02 Thread Lennart Lund
Hi Canh, Yes I may have mixed up saflogtest and logtest. I am sorry if that's the case. In any case the comment about the help printout and options is not a remark on this fix. It was based on a finding for something that should be handled in a separate ticket. But as you mention I may have

Re: [devel] [PATCH 1/1] log: update saflogtest to limit timeout when handling try again [#2764]

2018-02-02 Thread Vu Minh Nguyen
Ack. Thanks, Vu > -Original Message- > From: Canh Van Truong [mailto:canh.v.tru...@dektech.com.au] > Sent: Monday, January 29, 2018 6:06 AM > To: lennart.l...@ericsson.com; vu.m.ngu...@dektech.com.au; > srinivas.mangip...@oracle.com > Cc: opensaf-devel@lists.sourceforge.net; Canh Van