[devel] [PATCH 0/1] Review Request for mds: Update test suite 14 to avoid perpetually hanging [#2831]

Summary: mds: Update test suite 14 to avoid perpetually hanging [#2831] Review request for Ticket(s): 2831 Peer Reviewer(s): Hans, Anders Pull request to: Hans, Anders Affected branch(es): develop, release Development branch: ticket-2831 Base revision: 1c302a300e449e8a8527671fbd6c7f4e2b41e95d

[devel] [PATCH 1/1] mds: Update test suite 14 to avoid perpetually hanging [#2831]

Currently in suite 14, mdstest sends messages with MDS_SENDTYPE_SNDACK and MDS_SENDTYPE_SNDRSP types to the same destination, this sometimes makes the Response thread to catch the wrong event and does not respond to MDS_SENDTYPE_SNDRSP call. This causes the test case to hang forever. This patch

[devel] [PATCH 0/1] Review Request for base: Re-factor the timer implementation [#2440]

Summary: base: Re-factor the timer implementation [#2440] Review request for Ticket(s): 2440 Peer Reviewer(s): Ravi Pull request to: Affected branch(es): develop Development branch: ticket-2440 Base revision: b83be452a25a37c7f5b568b436d1af544afb7350 Personal repository:

Re: [devel] [PATCH 1/1] smfd: Fix incorrect handling of SMFND NCSMDS_UP/DOWN events [#2821]

Hi Nguyen, Reviewed the Patch. Ack from my side. Thanks, Syam. -Original Message- From: Nguyen Luu [mailto:nguyen.tk@dektech.com.au] Sent: Monday, April 9, 2018 7:56 AM To: Lennart Lund ; Vijay Roy Cc:

Re: [devel] [PATCH 1/1] smfd: Fix incorrect handling of SMFND NCSMDS_UP/DOWN events [#2821]

Hi Nguyen, My comment was just a minor comment. Just handle it based on what you think is best. Thanks Lennart > -Original Message- > From: Syam Prasad Talluri [mailto:syam.tall...@oracle.com] > Sent: den 9 april 2018 11:28 > To: Nguyen Tran Khoi Luu ;

Re: [devel] [PATCH 1/1] build: Add support for google gmock framework V2 [#2823]

Hi Anders, I'll remove the turtle example. Perhaps we also can add a git pull if the repo is older than some date? /Thanks HansN On 04/09/2018 10:09 AM, Anders Widell wrote: Ack with comments: 1) You must replace the turtle example with something that you have written yourself, to avoid

Re: [devel] [PATCH 1/1] build: Add support for google gmock framework V2 [#2823]

Ack with comments: 1) You must replace the turtle example with something that you have written yourself, to avoid potential license problems. 2) One inline comment below, marked AndersW> regards, Anders Widell On 04/03/2018 01:05 PM, Hans Nordeback wrote: --- 00-README.unittest

Re: [devel] [PATCH 1/1] base: Check return code from unlink in nid_create_ipc [#2829]

Hi Anders, yes, I'll change to you suggestion. /Thanks HansN On 04/06/2018 04:10 PM, Anders Widell wrote: Ack with minor comment: instead of calling access(), you could maybe simply check for the ENOENT errno value from unlink()? regards, Anders Widell On 04/05/2018 11:53 AM, Hans

[devel] [PATCH 0/1] Review Request for smf: Improve error logging when applying a CCB [#2832]

Summary: smf: Improve error logging when applying a CCB [#2832] Review request for Ticket(s): 2832 Peer Reviewer(s): vijay@oracle.com Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2832 Base revision:

[devel] [PATCH 1/1] smf: Improve error logging when applying a CCB [#2832]

When applying a CCB fail the return code is SA_AIS_ERR_FAILED_OPERATION. There is a number of reasons for this return code. Add logging of the reason. Also add logging if failing to delete a node group where the return code is othervise ignored. --- src/smf/smfd/SmfAdminState.cc