An enhancement for IMM to print out 5 last FEVS events into syslog when
IMMND down for any reason.
---
src/imm/Makefile.am | 4 +-
src/imm/common/immsv_evt.c | 2 +-
src/imm/common/immsv_evt.h | 1 +
src/imm/immnd/immnd_evt.c| 7 ++
src/imm/immnd/immnd_utils.cc | 201 +
Summary: imm: syslog recent fevs evts when immnd down [#2898]
Review request for Ticket(s): 2898
Peer Reviewer(s): Hans Nordeback, Lennart Lund, Gary Lee, Vu Minh Nguyen
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development branch: ticket-2898
Base
Hi Danh,
Ack with minor comments.
Regards, Vu
> -Original Message-
> From: Danh Vo
> Sent: Wednesday, August 1, 2018 3:29 PM
> To: hans.nordeb...@ericsson.com; lennart.l...@ericsson.com;
> gary@dektech.com.au; vu.m.ngu...@dektech.com.au
> Cc: opensaf-devel@lists.sourceforge.net; Dan
Hi Hoa Le
Ack with comments. See attached diff file that can be applied on the review
branch.
Summary of comments:
- Misspelling
- Non informative/misleading comment for timed out event loops
- Redundant code
- Incorrect handling in some (rare) cases if timeout
Thanks
Lennart
> -Original M
Hi Danh Vo,
Ack with comments.
I have checked comments from Vu and have not duplicated any of those. I do have
some additional comments. See attached diff that can be applied on the review
branch.
Thanks
Lennart
> -Original Message-
> From: Danh Vo
> Sent: den 1 augusti 2018 10:29
>
Hi Vu
In what situation may a configuration xml file be created where a class
definition has a tag with no default value?
Does not seems correct and should probably not be allowed (loading such file
should fail). I there some reason for allowing that?
Thanks
Lennart
> -Original Message--
Hi Canh,
I am not sure this is a correct fix. Please answer my comments [Lennart]:
Test case logtest 2 49 creates some cfg app to test the limitation, then
deleting these stream at the end. But the deleting fails due to timeout for
waiting the implementer. After that test case logtest 6 42 need t
Hi Guys,
I realized I forgot to put some notes in this review request...
75% of this code is from Praveen. I added some stuff that wasn't
there like shutting down contained sus when the container goes down,
allowing TRY_AGAIN in contained instantiation, and some more
con
Hi Lennart,
We have many classes which have empty value in tags.
If you look at the src/imm/config/SAI-AIS-IMM-XSD-A.02.17.xsd, there is no
restrictions on the length of
string value for tag. We should use minLength constraints
such as
`` if we do not allow empty value for
tag.
Since empty
An enhancement for IMM to print out 5 last FEVS events into syslog
when IMMND down for any reason.
---
src/imm/Makefile.am | 4 +-
src/imm/common/immsv_evt.c | 2 +-
src/imm/common/immsv_evt.h | 1 +
src/imm/immnd/immnd_evt.c| 6 ++
src/imm/immnd/immnd_utils.cc | 200 +
Summary: imm: syslog recent fevs evts when immnd down [#2898]
Review request for Ticket(s): 2898
Peer Reviewer(s): Hans Nordeback, Lennart Lund, Gary Lee, Vu Minh Nguyen
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development branch: ticket-2898
Base
Hi Lennart
Please see my reply inline
Thanks
Canh
-Original Message-
From: Lennart Lund
Sent: Wednesday, August 1, 2018 9:20 PM
To: Canh Van Truong ; Vu Minh Nguyen
Cc: opensaf-devel@lists.sourceforge.net; Canh Van Truong
; Lennart Lund
Subject: RE: [PATCH 0/1] Review Reque
Hi Danh,
Do type casting from `char*` to `const char*` in ` CollectRecentFevsLogData`
function is probably not needed.
Update that point then send the patch to me, I will push it. Lennart and I
acked, you don't need to send it out for review again.
Regards, Vu
> -Original Message-
> Fr
13 matches
Mail list logo
