Summary: amfnd: V2 Improve logging for error escalation decisions [#870]
Review request for Trac Ticket(s): 870
Peer Reviewer(s): Hans F, Hans N, Nagendra, Praveen
Pull request to:
Affected branch(es): default
Development branch: default
Impacted area
osaf/services/saf/amf/amfnd/err.cc | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/osaf/services/saf/amf/amfnd/err.cc
b/osaf/services/saf/amf/amfnd/err.cc
--- a/osaf/services/saf/amf/amfnd/err.cc
+++ b/osaf/services/saf/amf/amfnd/err.cc
@@ -1152,7 +1152,7 @@ uint32_t
osaf/services/saf/amf/amfnd/err.cc| 77 --
osaf/services/saf/amf/amfnd/include/avnd_cb.h | 2 +
osaf/services/saf/amf/amfnd/include/avnd_su.h | 3 +
osaf/services/saf/amf/amfnd/su.cc | 23
4 files changed, 98 insertions(+), 7
Summary: Fix SU constructor (again)
Review request for Trac Ticket(s): 713
Peer Reviewer(s): Hans N
Pull request to: LIST THE PERSON WITH PUSH ACCESS HERE
Affected branch(es): LIST ALL AFFECTED BRANCH(ES)
Development branch: IF ANY GIVE THE REPO URL
Impacted area
Summary: AMF: Use IMM applier in the AMF node director V3
Review request for Trac Ticket(s): #819
Peer Reviewer(s): hansf, nagu, praveen
Pull request to:
Affected branch(es): default
Development branch: default
Impacted area Impact y/n
I have few concerns:
1. It has severe performance issues(when number of nodes increases with
configurations) as we had discussed in #517 patch(Sent on 2 Sep 2013).
2. Due to syncing between directors and node directors(when complete
configuration of sg is loaded at one go), there may
See inline and please comment.
/HansF
-Original Message-
From: Nagendra Kumar [mailto:nagendr...@oracle.com]
Sent: den 28 maj 2014 12:13
To: Hans Nordebäck; Hans Feldt; Praveen Malviya
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [PATCH 1 of 1] AMF: Use IMM applier in the
Patch looks fine, but it cannot be pushed without making the compatible
changes in already changed and committed databases like AVD_SU, AVD_SI etc.
Are you going to float the patches for them.
Thanks
Praveen
On 26-May-14 6:40 PM, Hans Nordeback wrote:
osaf/libs/saf/include/saAis.h
Hi, see inline. /Regards HansN
On 05/28/14 12:18, Hans Feldt wrote:
See inline and please comment.
/HansF
-Original Message-
From: Nagendra Kumar [mailto:nagendr...@oracle.com]
Sent: den 28 maj 2014 12:13
To: Hans Nordebäck; Hans Feldt; Praveen Malviya
Cc:
Ack.
Thanks
-Nagu
-Original Message-
From: Gary Lee [mailto:gary@dektech.com.au]
Sent: 28 May 2014 12:50
To: hans.fe...@ericsson.com; hans.nordeb...@ericsson.com; Nagendra
Kumar; Praveen Malviya
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] amfd: Remove
Can you please push it asap as we need to rebase our patches on yours. It
blocks us.
Thanks
-Nagu
-Original Message-
From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com]
Sent: 28 May 2014 16:01
To: praveen malviya
Cc: hans.fe...@ericsson.com; Nagendra Kumar; opensaf-
Hi Nagu, do you mean I should push this patch without updating dependent/broken
code? /Regrads HansN
-Original Message-
From: Nagendra Kumar [mailto:nagendr...@oracle.com]
Sent: den 28 maj 2014 13:09
To: Hans Nordebäck; Praveen Malviya
Cc: Hans Feldt;
Hi Nagu, I think it is good practice to use explicit for constructors taking
one argument to avoid implicit conversions. If implicit conversions is needed
it
should be removed/Regards HansN
-Original Message-
From: Nagendra Kumar [mailto:nagendr...@oracle.com]
Sent: den 28 maj 2014
ack, two minor comments:
1. specify the initializers in declaration order, (thats how they get
called).
2. if, as also IngvarB pointed out, SaNameT contained a default
constructor initializing its length to 0, it don't need to be initialized in
the class. I have already sent out a patch for
Hi Nagu, yes, that is also accoording to the Google style
recommendations. /Thanks HansN
On 05/28/14 13:21, Nagendra Kumar wrote:
Hi Hans N,
Thanks for your response. So, I guess, we are going to follow
the same for other class constructors as well in Amf ?
Thanks
-Nagu
Ack with one minor comment.
Thanks,
Praveen
On 21-May-14 9:56 PM, Alex Jones wrote:
osaf/services/saf/amf/amfnd/clc.cc | 20
1 files changed, 20 insertions(+), 0 deletions(-)
May 2 15:22:11 linux osafamfnd[2990]: NO
Summary: remove some use of EDU
Review request for Trac Ticket(s): 713
Peer Reviewer(s): AMF devels
Pull request to: LIST THE PERSON WITH PUSH ACCESS HERE
Affected branch(es): LIST ALL AFFECTED BRANCH(ES)
Development branch: IF ANY GIVE THE REPO URL
Impacted area
osaf/services/saf/amf/amfd/ckpt_edu.cc| 59 ---
osaf/services/saf/amf/amfd/ckpt_enc.cc| 139 -
osaf/services/saf/amf/amfd/include/ckpt_edu.h |3 -
3 files changed, 48 insertions(+), 153 deletions(-)
diff --git
osaf/services/saf/amf/amfd/ckpt_dec.cc | 265 +---
1 files changed, 73 insertions(+), 192 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/ckpt_dec.cc
b/osaf/services/saf/amf/amfd/ckpt_dec.cc
--- a/osaf/services/saf/amf/amfd/ckpt_dec.cc
+++
Appreciate Hans and Mahesh for unblocking the performance factors
existing in MDS (legacy) code.
Can we add the instructions mentioned under IMP Note: to the README of
IMM?.
Cheers,
Ramesh.
On 5/29/2014 10:32 AM, A V Mahesh wrote:
Attaching the Table in PDF ( few people doesn't receive image
20 matches
Mail list logo
