Re: [devel] [PATCH 2 of 3] amfd: Move sirankedsu declarations to its own header file [#713]

2014-06-15 Thread Nagendra Kumar
Ack Thanks -Nagu > -Original Message- > From: Gary Lee [mailto:gary@dektech.com.au] > Sent: 13 June 2014 11:19 > To: hans.fe...@ericsson.com; hans.nordeb...@ericsson.com; Nagendra > Kumar; Praveen Malviya > Cc: opensaf-devel@lists.sourceforge.net > Subject: [PATCH 2 of 3] amfd: Move s

Re: [devel] [PATCH 3 of 3] amfd: convert remaining macros in si.cc to functions [#713]

2014-06-15 Thread Nagendra Kumar
Ack Thanks -Nagu > -Original Message- > From: Gary Lee [mailto:gary@dektech.com.au] > Sent: 13 June 2014 11:19 > To: hans.fe...@ericsson.com; hans.nordeb...@ericsson.com; Nagendra > Kumar; Praveen Malviya > Cc: opensaf-devel@lists.sourceforge.net > Subject: [PATCH 3 of 3] amfd: conver

Re: [devel] [PATCH 1 of 3] amfd: move svctype and svctypecstype declarations to separate files [#713]

2014-06-15 Thread Nagendra Kumar
Ack Thanks -Nagu > -Original Message- > From: Gary Lee [mailto:gary@dektech.com.au] > Sent: 13 June 2014 11:19 > To: hans.fe...@ericsson.com; hans.nordeb...@ericsson.com; Nagendra > Kumar; Praveen Malviya > Cc: opensaf-devel@lists.sourceforge.net > Subject: [PATCH 1 of 3] amfd: move s

[devel] [PATCH 1 of 1] amfd : use of db_template in si_dep.cc [#713]

2014-06-15 Thread praveen . malviya
osaf/services/saf/amf/amfd/include/cb.h |7 - osaf/services/saf/amf/amfd/include/si_dep.h | 53 +- osaf/services/saf/amf/amfd/include/timer.h |4 +- osaf/services/saf/amf/amfd/si_dep.cc| 709 --- osaf/services/saf/amf/amfd/siass.cc | 32 +-

[devel] [PATCH 0 of 1] Review Request for amfd : use of db_template in si_dep.cc [#713]

2014-06-15 Thread praveen . malviya
Summary:amfd : use of db_template in si_dep.cc [#713] Review request for Trac Ticket(s): #713 Peer Reviewer(s): AMF developers. Pull request to: <> Affected branch(es): Default Development branch: <> Impacted area Impact y/n --

[devel] [PATCH 0 of 4] Review Request for AMF SG refactoring part 1 V2 #713

2014-06-15 Thread Hans Feldt
Summary: Start of SG refactoring v2 Review request for Trac Ticket(s): 713 Peer Reviewer(s): AMF developers Pull request to: <> Affected branch(es): default Development branch: <> Impacted area Impact y/n Docs

[devel] [PATCH 3 of 4] amfd: change SG node_fail function ptr to method [#713]

2014-06-15 Thread Hans Feldt
osaf/services/saf/amf/amfd/include/sg.h | 18 ++ osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 23 ++- osaf/services/saf/amf/amfd/sg_nored_fsm.cc | 22 +- osaf/services/saf/amf/amfd/sg_npm_fsm.cc | 22 +- o

[devel] [PATCH 2 of 4] amfd: add specialized red model specific SG classes [#713]

2014-06-15 Thread Hans Feldt
osaf/services/saf/amf/amfd/ckpt_dec.cc | 4 +- osaf/services/saf/amf/amfd/include/sg.h | 48 +-- osaf/services/saf/amf/amfd/sg.cc | 36 +++- osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 4 ++ osaf/services/saf/amf/amfd/sg_nored

[devel] [PATCH 1 of 4] amfd: change struct AVD_SG to class [#713]

2014-06-15 Thread Hans Feldt
osaf/services/saf/amf/amfd/include/app.h| 6 +- osaf/services/saf/amf/amfd/include/csi.h| 2 +- osaf/services/saf/amf/amfd/include/sg.h | 18 +++--- osaf/services/saf/amf/amfd/include/sgtype.h | 8 ++-- osaf/services/saf/amf/amfd/include/si.h | 2 +- osaf/services/saf/

[devel] [PATCH 4 of 4] amfd: change SG realign function ptr to method [#713]

2014-06-15 Thread Hans Feldt
osaf/services/saf/amf/amfd/include/sg.h | 19 +-- osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 27 +-- osaf/services/saf/amf/amfd/sg_nored_fsm.cc | 27 +-- osaf/services/saf/amf/amfd/sg_npm_fsm.cc | 27 +--

Re: [devel] [PATCH 3 of 3] amfd: convert remaining macros in si.cc to functions [#713]

2014-06-15 Thread Gary Lee
Hi Hans On 13/06/14 20:49, Hans Feldt wrote: > diff --git a/osaf/services/saf/amf/amfd/include/si.h > b/osaf/services/saf/amf/amfd/include/si.h > --- a/osaf/services/saf/amf/amfd/include/si.h > +++ b/osaf/services/saf/amf/amfd/include/si.h > @@ -122,6 +122,11 @@ public: > void remove_ranked