date:20160920

[devel] OpenSAF 5.1.RC2 tagged, change control applies

2016-09-20 Thread Anders Widell

Hi all!

We have now tagged and released OpenSAF 5.1.RC2 (release candidate 2). 
To reduce the risk of introducing new faults close to the release, all 
branches except the default branch are now under change control. This 
means that only approved bug fixes and documentation-only changes may be 
pushed between 5.1.RC2 and the final 5.1.0 release. The default branch 
will of course be open all the time for development of new features that 
will go into the next release, as usual.

Currently, the following tickets are approved to be pushed: 2049, 2046, 
2029 and 1993. The list of approved tickets is subject to change.

Please check if some documentation needs to be updated for any of the 
enhancements you have implemented in the OpenSAF 5.1 release. The full 
list of 5.1 enhancement tickets can be listed using the following link:

https://sourceforge.net/p/opensaf/tickets/search/?q=status%3A%28accepted+review+fixed%29+AND+_milestone%3A%285.1.FC+5.1.RC1+5.1.RC2+5.1.0%29+AND+_type%3Aenhancement=100

thanks,

Anders Widell


--
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

[devel] Review request for Doc: Extensions PR document for 5.1

2016-09-20 Thread Anders Widell


Hi!

Please find the OpenSAF Extensions PR document for 5.1 release for 
review. I have updated Section 4.1 to list all the services that support 
the extended SaNameT type in the OpenSAF 5.1 release.


regards,
Anders Widell




OpenSAF_Extensions_PR.odt
Description: application/vnd.oasis.opendocument.text
--
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

[devel] [PATCH 0 of 1] Review Request for amf: add support for cluster reboot [#2053]

2016-09-20 Thread Hans Nordeback

Summary: amf: add support for cluster reboot 
Review request for Trac Ticket(s): #2053
Peer Reviewer(s): Nagu, Praveen, Gary, AndersW
Pull request to: 
Affected branch(es): default
Development branch: default


Impacted area   Impact y/n

 Docsn
 Build systemn
 RPM/packaging   n
 Configuration files n
 Startup scripts n
 SAF servicesy
 OpenSAF servicesn
 Core libraries  n
 Samples n
 Tests   n
 Other   n


Comments (indicate scope for each "y" above):
-
 <>

changeset 6572461c5b3495ff7450800edeed9232899a76fc
Author: Hans Nordeback 
Date:   Tue, 20 Sep 2016 14:55:06 +0200

amf: add support for cluster reboot [#2053]

Use command immadm -a safAmfService -o 100 safAmfService to order 
cluster
reboot


Complete diffstat:
--
 osaf/services/saf/amf/amfd/imm.cc |   9 -
 osaf/services/saf/amf/amfd/include/util.h |   1 +
 osaf/services/saf/amf/amfd/util.cc|  22 ++
 3 files changed, 31 insertions(+), 1 deletions(-)


Testing Commands:
-
 <>


Testing, Expected Results:
--
 <>


Conditions of Submission:
-
 <>


Arch  Built StartedLinux distro
---
mipsn  n
mips64  n  n
x86 n  n
x86_64  n  n
powerpc n  n
powerpc64   n  n


Reviewer Checklist:
---
[Submitters: make sure that your review doesn't trigger any checkmarks!]


Your checkin has not passed review because (see checked entries):

___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.

___ You have failed to nominate the proper persons for review and push.

___ Your patches do not have proper short+long header

___ You have grammar/spelling in your header that is unacceptable.

___ You have exceeded a sensible line length in your headers/comments/text.

___ You have failed to put in a proper Trac Ticket # into your commits.

___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)

___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.

___ You have ^M present in some of your files. These have to be removed.

___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.

___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.

___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.

___ You have extraneous garbage in your review (merge commits etc)

___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.

___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.

___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.

___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.

___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)

___ Your computer have a badly configured date and time; confusing the
the threaded patch review.

___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.

___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.


--
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Re: [devel] [PATCH 1 of 1] MDS: Log TIPC dropped messages [#1957]

2016-09-20 Thread Hans Nordebäck

Hi Mahesh,

I think only logging is needed as proposed in the patch, as some services are 
already handling dropped messages. This logging will help in
trouble shooting. Keeping TIPC_DEST_DROPPABLE to true will only make TIPC to 
silently drop messages, the original problem persists and needs investigation,
i.e. why the socket receive buffer is overloaded, one reason may be that the 
MDS poll/receive loop together with the "big" mutex lock, (ticket #520).
Did you check why MDS message loss mechanism doesn't detect on TIPC dropped 
messages, AMF 
do detect this via e.g "out of sync", "msg id mismatch" and so on?

/Regards HansN

-Original Message-
From: A V Mahesh [mailto:mahesh.va...@oracle.com] 
Sent: den 20 september 2016 12:29
To: Anders Widell ; Hans Nordebäck 

Cc: opensaf-devel@lists.sourceforge.net; mathi.naic...@oracle.com
Subject: Re: [PATCH 1 of 1] MDS: Log TIPC dropped messages [#1957]

HI Anders Widell / HansN,

On 9/16/2016 2:03 PM, Anders Widell wrote:
> The idea was to just log reception of error info messages, for 
> trouble-shooting purposes.

After multiple attempts,  i manged to simulate TIPC_ERR_OVERLOAD 
error.After  TIPC_ERR_OVERLOAD error is hit
the cluster going to UN-recoverable state , because the send buffers are full.

So we have two options :

1)  Set  TIPC_DEST_DROPPABLE to false ,  log TIPC_ERR_OVERLOAD error and then  
graceful  exist of sender,
  which allows remaining nodes to be survived.

2)  keep the current configuration as it is ( TIPC_DEST_DROPPABLE to true )

=
Sep 20 15:14:09 SC-1 osafamfd[3759]: NO Received node_up from 2040f: 
msg_id 1
Sep 20 15:14:09 SC-1 osafamfd[3759]: NO Node 'PL-4' joined the cluster Sep 20 
15:14:09 SC-1 osafimmnd[3695]: NO Implementer connected: 19
(MsgQueueService132111) <0, 2040f>
*Sep 20 15:16:59 SC-1 osafimmd[3684]: 77 MDTM: undelivered message condition 
ancillary data: TIPC_ERR_OVERLOAD* Sep 20 15:17:00 SC-1 osafimmnd[3695]: WA 
Director Service in NOACTIVE state - fevs replies pending:1 fevs highest 
processed:218744 Sep 20 15:17:00 SC-1 osafamfnd[3773]: NO 
'safComp=IMMD,safSu=SC-1,safSg=2N,safApp=OpenSAF' faulted due to 'avaDown' : 
Recovery is 'nodeFailfast'
Sep 20 15:17:00 SC-1 osafamfnd[3773]: ER 
safComp=IMMD,safSu=SC-1,safSg=2N,safApp=OpenSAF Faulted due to:avaDown Recovery 
is:nodeFailfast Sep 20 15:17:00 SC-1 osafamfnd[3773]: Rebooting OpenSAF NodeId 
= 131343 EE Name = , Reason: Component faulted: recovery is node failfast, 
OwnNodeId = 131343, SupervisionTime = 60 Sep 20 15:17:00 SC-1 osafimmnd[3695]: 
WA DISCARD DUPLICATE FEVS
message:218744
Sep 20 15:17:00 SC-1 osafimmnd[3695]: WA Error code 2 returned for message type 
82 - ignoring Sep 20 15:17:00 SC-1 opensaf_reboot: Rebooting local node; 
timeout=60 Sep 20 15:17:00 SC-1 osafimmnd[3695]: WA SC Absence IS allowed:900 
IMMD service is DOWN Sep 20 15:17:00 SC-1 osafimmnd[3695]: NO IMMD SERVICE IS 
DOWN, HYDRA IS CONFIGURED => UNREGISTERING IMMND form MDS Sep 20 15:17:00 SC-1 
osafntfimcnd[3742]: NO saImmOiDispatch() Fail SA_AIS_ERR_BAD_HANDLE (9) Sep 20 
15:17:00 SC-1 osafimmnd[3695]: NO Removing client id:20002010f
sv_id:27
Sep 20 15:17:00 SC-1 osafimmnd[3695]: NO Implementer disconnected 1 <2, 
2010f> (safLogService)
Sep 20 15:17:00 SC-1 osafimmnd[3695]: NO Removing client id:d0d0002010f
sv_id:26
Sep 20 15:17:00 SC-1 osafimmnd[3695]: NO Removing client id:12010f
sv_id:27
Sep 20 15:17:00 SC-1 osafimmnd[3695]: NO Implementer disconnected 2 <16, 
2010f> (@safLogService_appl)
Sep 20 15:17:00 SC-1 osafimmnd[3695]: NO Removing client id:130002010f
sv_id:27
Sep 20 15:17:00 SC-1 osafimmnd[3695]: NO Implementer disconnected 3 <19, 
2010f> (@OpenSafImmReplicatorA)
Sep 20 15:17:00 SC-1 osafimmnd[3695]: NO Removing client id:140002010f
sv_id:26
Sep 20 15:17:00 SC-1 osafimmnd[3695]: NO Removing client id:150002010f
sv_id:27
Sep 20 15:17:00 SC-1 osafimmnd[3695]: NO Implementer disconnected 4 <21, 
2010f> (safClmService)
Sep 20 15:17:00 SC-1 osafimmnd[3695]: NO Removing client id:1a0002010f
sv_id:27
Sep 20 15:17:00 SC-1 osafimmnd[3695]: NO Implementer disconnected 5 <26, 
2010f> (safAmfService)
Sep 20 15:17:00 SC-1 osafimmnd[3695]: NO Removing client id:1b0002010f
sv_id:26
Sep 20 15:17:00 SC-1 osafimmnd[3695]: NO Removing client id:5bc0002010f
sv_id:26
Sep 20 15:17:00 SC-1 osafimmnd[3695]: NO Removing client id:5bd0002010f
sv_id:27
Sep 20 15:17:00 SC-1 osafimmnd[3695]: NO Implementer disconnected 6 <1469, 
2010f> (MsgQueueService131343) Sep 20 15:17:00 SC-1 osafimmnd[3695]: NO 
Removing client id:5c2010f
sv_id:27
Sep 20 15:17:00 SC-1 osafimmnd[3695]: NO Implementer disconnected 10 <1472, 
2010f> (safEvtService) Sep 20 15:17:00 SC-1 osafimmnd[3695]: NO Removing client 
id:5c40002010f
sv_id:27
Sep 20 15:17:00 SC-1 osafimmnd[3695]: NO Implementer disconnected 8 <1476, 
2010f> (safSmfService) Sep

Re: [devel] [PATCH 1 of 1] amf: fix activeCompName in csiStateDescriptor used in CSI SET cbk [#2021]

2016-09-20 Thread minh chau

Hi Praveen,

ack for code review.

Thanks,
Minh

On 15/09/16 19:41, praveen.malv...@oracle.com wrote:
>   osaf/libs/agents/saf/amfa/ava_hdl.cc |  28 +++-
>   osaf/libs/common/amf/n2avamsg.c  |  14 ++
>   osaf/services/saf/amf/amfd/util.cc   |   2 +-
>   osaf/services/saf/amf/amfnd/comp.cc  |   1 -
>   4 files changed, 26 insertions(+), 19 deletions(-)
>
>
> In the reported problem, active compname is improperly as \'sa\'
> in CSI SET callback for HA state.
>
> After setting activeCompName in standby descriptor, AMFND is wrongly calling
> osaf_extended_name_clear() for active descriptor. Since 
> SaAmfCSIStateDescriptorT
> is a union, it clears the filled value.
> Along with the above problems there are other minor problems like:
> -AMFND is copying activecompName using osaf_extended_name_alloc() in agent 
> message,
>   only when it is an extended name.
>   osaf_extended_name_alloc() should be done irrespective of short or long dn.
> -Agent should perform validation check on dn based on HA state of the CSI SET 
> callback,
>   as activecompname is not populated for all the HA states.
> -When above problems are fixed, one more problem pops up:
>   a standby component gets its own name in activeCompName in CSI set callback 
> for standby.
>   There is a minor regression at AMFD.
>
> Patch fixes all these problems.
>
> diff --git a/osaf/libs/agents/saf/amfa/ava_hdl.cc 
> b/osaf/libs/agents/saf/amfa/ava_hdl.cc
> --- a/osaf/libs/agents/saf/amfa/ava_hdl.cc
> +++ b/osaf/libs/agents/saf/amfa/ava_hdl.cc
> @@ -624,21 +624,31 @@ uint32_t ava_hdl_cbk_rec_prc(AVSV_AMF_CB
>   AVSV_AMF_CSI_SET_PARAM *csi_set = >param.csi_set;
>   
>   if (!ava_sanamet_is_valid(_set->csi_desc.csiName) ||
> - !ava_sanamet_is_valid(_set->comp_name) ||
> - 
> !ava_sanamet_is_valid(_set->csi_desc.csiStateDescriptor.activeDescriptor.activeCompName)
>  ||
> - 
> !ava_sanamet_is_valid(_set->csi_desc.csiStateDescriptor.standbyDescriptor.activeCompName))
>  {
> + !ava_sanamet_is_valid(_set->comp_name)) {
>   rc = SA_AIS_ERR_NAME_TOO_LONG;
>   }
> + bool actv_or_stdby = true;
> + if ((csi_set->ha == SA_AMF_HA_ACTIVE) &&
> + 
> (csi_set->csi_desc.csiStateDescriptor.activeDescriptor.transitionDescriptor 
> != SA_AMF_CSI_NEW_ASSIGN)) {
> + actv_or_stdby = 
> ava_sanamet_is_valid(_set->csi_desc.csiStateDescriptor.activeDescriptor.activeCompName);
> + } else if (csi_set->ha == SA_AMF_HA_STANDBY) {
> + actv_or_stdby = 
> ava_sanamet_is_valid(_set->csi_desc.csiStateDescriptor.standbyDescriptor.activeCompName);
> + }
> + if (!actv_or_stdby)
> + rc = SA_AIS_ERR_NAME_TOO_LONG;
>   
>   if (rc == SA_AIS_OK && reg_cbk->saAmfCSISetCallback) {
>   TRACE("CSISet: CSIName = %s, CSIFlags = %d, HA 
> state = %d",
>   
> osaf_extended_name_borrow(_set->csi_desc.csiName),csi_set->csi_desc.csiFlags,csi_set->ha);
> - TRACE("CSISet: Active Transition Descriptor = 
> %u, Active Component Name = %s",
> - 
> csi_set->csi_desc.csiStateDescriptor.activeDescriptor.transitionDescriptor,
> - 
> osaf_extended_name_borrow(_set->csi_desc.csiStateDescriptor.activeDescriptor.activeCompName));
> - TRACE("CSISet: ActiveCompName = %s, StandbyRank 
> = %u",
> - 
> osaf_extended_name_borrow(_set->csi_desc.csiStateDescriptor.standbyDescriptor.activeCompName),
> - 
> csi_set->csi_desc.csiStateDescriptor.standbyDescriptor.standbyRank);
> + if ((csi_set->ha == SA_AMF_HA_ACTIVE) &&
> + 
> (csi_set->csi_desc.csiStateDescriptor.activeDescriptor.transitionDescriptor 
> != SA_AMF_CSI_NEW_ASSIGN))
> + TRACE("CSISet: Active Transition 
> Descriptor = %u, Active Component Name = %s",
> + 
> csi_set->csi_desc.csiStateDescriptor.activeDescriptor.transitionDescriptor,
> + 
> osaf_extended_name_borrow(_set->csi_desc.csiStateDescriptor.activeDescriptor.activeCompName));
> + if (csi_set->ha == SA_AMF_HA_STANDBY)
> + TRACE("CSISet: ActiveCompName = %s, 
> StandbyRank = %u",
> + 
>

Re: [devel] [PATCH 1 of 1] MDS: Log TIPC dropped messages [#1957]

2016-09-20 Thread A V Mahesh

HI Anders Widell / HansN,

On 9/16/2016 2:03 PM, Anders Widell wrote:
> The idea was to just log reception of error info messages, for 
> trouble-shooting purposes.

After multiple attempts,  i manged to simulate TIPC_ERR_OVERLOAD 
error.After  TIPC_ERR_OVERLOAD error is hit
the cluster going to UN-recoverable state , because the send buffers are 
full.

So we have two options :

1)  Set  TIPC_DEST_DROPPABLE to false ,  log TIPC_ERR_OVERLOAD error  
and then  graceful  exist of sender,
  which allows remaining nodes to be survived.

2)  keep the current configuration as it is ( TIPC_DEST_DROPPABLE to true )

=
Sep 20 15:14:09 SC-1 osafamfd[3759]: NO Received node_up from 2040f: 
msg_id 1
Sep 20 15:14:09 SC-1 osafamfd[3759]: NO Node 'PL-4' joined the cluster
Sep 20 15:14:09 SC-1 osafimmnd[3695]: NO Implementer connected: 19 
(MsgQueueService132111) <0, 2040f>
*Sep 20 15:16:59 SC-1 osafimmd[3684]: 77 MDTM: undelivered message 
condition ancillary data: TIPC_ERR_OVERLOAD*
Sep 20 15:17:00 SC-1 osafimmnd[3695]: WA Director Service in NOACTIVE 
state - fevs replies pending:1 fevs highest processed:218744
Sep 20 15:17:00 SC-1 osafamfnd[3773]: NO 
'safComp=IMMD,safSu=SC-1,safSg=2N,safApp=OpenSAF' faulted due to 
'avaDown' : Recovery is 'nodeFailfast'
Sep 20 15:17:00 SC-1 osafamfnd[3773]: ER 
safComp=IMMD,safSu=SC-1,safSg=2N,safApp=OpenSAF Faulted due to:avaDown 
Recovery is:nodeFailfast
Sep 20 15:17:00 SC-1 osafamfnd[3773]: Rebooting OpenSAF NodeId = 131343 
EE Name = , Reason: Component faulted: recovery is node failfast, 
OwnNodeId = 131343, SupervisionTime = 60
Sep 20 15:17:00 SC-1 osafimmnd[3695]: WA DISCARD DUPLICATE FEVS 
message:218744
Sep 20 15:17:00 SC-1 osafimmnd[3695]: WA Error code 2 returned for 
message type 82 - ignoring
Sep 20 15:17:00 SC-1 opensaf_reboot: Rebooting local node; timeout=60
Sep 20 15:17:00 SC-1 osafimmnd[3695]: WA SC Absence IS allowed:900 IMMD 
service is DOWN
Sep 20 15:17:00 SC-1 osafimmnd[3695]: NO IMMD SERVICE IS DOWN, HYDRA IS 
CONFIGURED => UNREGISTERING IMMND form MDS
Sep 20 15:17:00 SC-1 osafntfimcnd[3742]: NO saImmOiDispatch() Fail 
SA_AIS_ERR_BAD_HANDLE (9)
Sep 20 15:17:00 SC-1 osafimmnd[3695]: NO Removing client id:20002010f 
sv_id:27
Sep 20 15:17:00 SC-1 osafimmnd[3695]: NO Implementer disconnected 1 <2, 
2010f> (safLogService)
Sep 20 15:17:00 SC-1 osafimmnd[3695]: NO Removing client id:d0d0002010f 
sv_id:26
Sep 20 15:17:00 SC-1 osafimmnd[3695]: NO Removing client id:12010f 
sv_id:27
Sep 20 15:17:00 SC-1 osafimmnd[3695]: NO Implementer disconnected 2 <16, 
2010f> (@safLogService_appl)
Sep 20 15:17:00 SC-1 osafimmnd[3695]: NO Removing client id:130002010f 
sv_id:27
Sep 20 15:17:00 SC-1 osafimmnd[3695]: NO Implementer disconnected 3 <19, 
2010f> (@OpenSafImmReplicatorA)
Sep 20 15:17:00 SC-1 osafimmnd[3695]: NO Removing client id:140002010f 
sv_id:26
Sep 20 15:17:00 SC-1 osafimmnd[3695]: NO Removing client id:150002010f 
sv_id:27
Sep 20 15:17:00 SC-1 osafimmnd[3695]: NO Implementer disconnected 4 <21, 
2010f> (safClmService)
Sep 20 15:17:00 SC-1 osafimmnd[3695]: NO Removing client id:1a0002010f 
sv_id:27
Sep 20 15:17:00 SC-1 osafimmnd[3695]: NO Implementer disconnected 5 <26, 
2010f> (safAmfService)
Sep 20 15:17:00 SC-1 osafimmnd[3695]: NO Removing client id:1b0002010f 
sv_id:26
Sep 20 15:17:00 SC-1 osafimmnd[3695]: NO Removing client id:5bc0002010f 
sv_id:26
Sep 20 15:17:00 SC-1 osafimmnd[3695]: NO Removing client id:5bd0002010f 
sv_id:27
Sep 20 15:17:00 SC-1 osafimmnd[3695]: NO Implementer disconnected 6 
<1469, 2010f> (MsgQueueService131343)
Sep 20 15:17:00 SC-1 osafimmnd[3695]: NO Removing client id:5c2010f 
sv_id:27
Sep 20 15:17:00 SC-1 osafimmnd[3695]: NO Implementer disconnected 10 
<1472, 2010f> (safEvtService)
Sep 20 15:17:00 SC-1 osafimmnd[3695]: NO Removing client id:5c40002010f 
sv_id:27
Sep 20 15:17:00 SC-1 osafimmnd[3695]: NO Implementer disconnected 8 
<1476, 2010f> (safSmfService)
Sep 20 15:17:00 SC-1 osafimmnd[3695]: NO Removing client id:5c60002010f 
sv_id:27
Sep 20 15:17:00 SC-1 osafimmnd[3695]: NO Implementer disconnected 9 
<1478, 2010f> (safLckService)
Sep 20 15:17:00 SC-1 osafimmnd[3695]: NO Removing client id:5c70002010f 
sv_id:27
Sep 20 15:17:00 SC-1 osafimmnd[3695]: NO Implementer disconnected 7 
<1479, 2010f> (safMsgGrpService)
Sep 20 15:17:00 SC-1 osafimmnd[3695]: NO Removing client id:5cc0002010f 
sv_id:27
Sep 20 15:17:00 SC-1 osafimmnd[3695]: NO Removing client id:5ce0002010f 
sv_id:27
Sep 20 15:17:00 SC-1 osafimmnd[3695]: NO Implementer disconnected 12 
<1486, 2010f> (safCheckPointService)
Sep 20 15:17:00 SC-1 osafimmnd[3695]: NO Implementer disconnected 13 <0, 
2020f(down)> (MsgQueueService131599)
Sep 20 15:17:00 SC-1 osafimmnd[3695]: NO Implementer disconnected 14 <0, 
2020f(down)> (@OpenSafImmReplicatorB)
Sep 20 15:17:00 SC-1 osafimmnd[3695]: NO Implementer disconnected 15 <0, 
2020f(down)> (@safAmfService2020f)

Re: [devel] [PATCH 1 of 1] clm: fill SaNameT value with zeros [#2015]

2016-09-20 Thread Mathivanan Naickan Palanivelu

Ack,
Mathi.

> -Original Message-
> From: Zoran Milinkovic [mailto:zoran.milinko...@ericsson.com]
> Sent: Tuesday, September 20, 2016 2:26 PM
> To: Mathivanan Naickan Palanivelu
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: [PATCH 1 of 1] clm: fill SaNameT value with zeros [#2015]
> 
>  osaf/libs/common/clmsv/clmsv_enc_dec.c |  1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> 
> Set zeros in SaNameT value before SaNameT is populated with incoming
> SaNameT string from the network.
> This will make node name unique in patricia tree, and the node name search
> mismatch will be avoided.
> 
> diff --git a/osaf/libs/common/clmsv/clmsv_enc_dec.c
> b/osaf/libs/common/clmsv/clmsv_enc_dec.c
> --- a/osaf/libs/common/clmsv/clmsv_enc_dec.c
> +++ b/osaf/libs/common/clmsv/clmsv_enc_dec.c
> @@ -42,6 +42,7 @@ uint32_t clmsv_decodeSaNameT(NCS_UBAID *
>   total_bytes += 2;
>   ncs_decode_n_octets_from_uba(uba, (uint8_t *)value,
> (uint32_t)length);
>   value[length] = 0;
> + memset(name, 0, sizeof(SaNameT));
>   osaf_extended_name_lend(value, name);
>   total_bytes += length;
>   return total_bytes;

--
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

[devel] [PATCH 1 of 1] clm: fill SaNameT value with zeros [#2015]

2016-09-20 Thread Zoran Milinkovic

 osaf/libs/common/clmsv/clmsv_enc_dec.c |  1 +
 1 files changed, 1 insertions(+), 0 deletions(-)


Set zeros in SaNameT value before SaNameT is populated with incoming SaNameT 
string from the network.
This will make node name unique in patricia tree, and the node name search 
mismatch will be avoided.

diff --git a/osaf/libs/common/clmsv/clmsv_enc_dec.c 
b/osaf/libs/common/clmsv/clmsv_enc_dec.c
--- a/osaf/libs/common/clmsv/clmsv_enc_dec.c
+++ b/osaf/libs/common/clmsv/clmsv_enc_dec.c
@@ -42,6 +42,7 @@ uint32_t clmsv_decodeSaNameT(NCS_UBAID *
total_bytes += 2;
ncs_decode_n_octets_from_uba(uba, (uint8_t *)value, (uint32_t)length);
value[length] = 0;
+   memset(name, 0, sizeof(SaNameT));
osaf_extended_name_lend(value, name);
total_bytes += length;
return total_bytes;

--
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

[devel] [PATCH 0 of 1] Review Request for clm: fill SaNameT value with zeros [#2015]

2016-09-20 Thread Zoran Milinkovic

Summary: clm: fill SaNameT value with zeros [#2015]
Review request for Trac Ticket(s): 2015
Peer Reviewer(s): Mathi
Pull request to: Zoran
Affected branch(es): opensaf-5.1.x, default(5.2)
Development branch: default(5.2)


Impacted area   Impact y/n

 Docsn
 Build systemn
 RPM/packaging   n
 Configuration files n
 Startup scripts n
 SAF servicesy
 OpenSAF servicesn
 Core libraries  n
 Samples n
 Tests   n
 Other   n


Comments (indicate scope for each "y" above):
-

changeset 096dd54d77c4c15392a38ff91d5f37e4cbdb8a04
Author: Zoran Milinkovic 
Date:   Tue, 20 Sep 2016 10:52:41 +0200

clm: fill SaNameT value with zeros [#2015]

Set zeros in SaNameT value before SaNameT is populated with incoming 
SaNameT
string from the network. This will make node name unique in patricia 
tree,
and the node name search mismatch will be avoided.


Complete diffstat:
--
 osaf/libs/common/clmsv/clmsv_enc_dec.c |  1 +
 1 files changed, 1 insertions(+), 0 deletions(-)


Testing Commands:
-


Testing, Expected Results:
--


Conditions of Submission:
-
Ack from Mathi


Arch  Built StartedLinux distro
---
mipsn  n
mips64  n  n
x86 n  n
x86_64  n  n
powerpc n  n
powerpc64   n  n


Reviewer Checklist:
---
[Submitters: make sure that your review doesn't trigger any checkmarks!]


Your checkin has not passed review because (see checked entries):

___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.

___ You have failed to nominate the proper persons for review and push.

___ Your patches do not have proper short+long header

___ You have grammar/spelling in your header that is unacceptable.

___ You have exceeded a sensible line length in your headers/comments/text.

___ You have failed to put in a proper Trac Ticket # into your commits.

___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)

___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.

___ You have ^M present in some of your files. These have to be removed.

___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.

___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.

___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.

___ You have extraneous garbage in your review (merge commits etc)

___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.

___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.

___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.

___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.

___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)

___ Your computer have a badly configured date and time; confusing the
the threaded patch review.

___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.

___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.


--
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Re: [devel] [PATCH 1 of 1] [mq]: 2032_fix_ckpttest.patch

2016-09-20 Thread A V Mahesh

Hi,

ACK,

Not tested , change the subject cpsvtest.

-AVM


On 9/20/2016 11:51 AM, Hoang Vo wrote:
>   tests/cpsv/test_cpa.c  |  2 +-
>   tests/cpsv/test_cpa_util.c |  6 +++---
>   2 files changed, 4 insertions(+), 4 deletions(-)
>
>
> diff --git a/tests/cpsv/test_cpa.c b/tests/cpsv/test_cpa.c
> --- a/tests/cpsv/test_cpa.c
> +++ b/tests/cpsv/test_cpa.c
> @@ -45,7 +45,7 @@ const char *saf_error_string[] = {
>   #endif
>   
>   #define VALID_EXTENDED_NAME_LENGTH 400
> -#define INVALID_EXTENDED_NAME_LENGTH 2049
> +#define INVALID_EXTENDED_NAME_LENGTH 2050
>   
>   
>   extern int gl_prev_act;
> diff --git a/tests/cpsv/test_cpa_util.c b/tests/cpsv/test_cpa_util.c
> --- a/tests/cpsv/test_cpa_util.c
> +++ b/tests/cpsv/test_cpa_util.c
> @@ -391,7 +391,7 @@ struct SafCheckpointOpen API_Open[]={
>   [CKPT_OPEN_ALL_CREATE_EXTENDED_NAME_SUCCESS_T] = 
> {,_replicas_ckpt_with_valid_extended_name_length,_replicas,SA_CKPT_CHECKPOINT_CREATE,
>
> APP_TIMEOUT,_replicas_Createhdl,SA_AIS_OK,"ckpt with ALL_REPLICAS and 
> valid extended name created"},
>   [CKPT_OPEN_ALL_CREATE_EXTENDED_NAME_INVALID_PARAM_T] = 
> {,_replicas_ckpt_with_invalid_extended_name_length,_replicas,SA_CKPT_CHECKPOINT_CREATE,
> - 
> APP_TIMEOUT,_replicas_Createhdl,SA_AIS_ERR_INVALID_PARAM,"ckpt with 
> ALL_REPLICAS and invalid extended name created"},
> + 
> APP_TIMEOUT,_replicas_Createhdl,SA_AIS_ERR_TOO_BIG,"ckpt with 
> ALL_REPLICAS and invalid extended name created"},
>   
>   /* NULL ckptHandle, */
>   
> @@ -560,7 +560,7 @@ struct SafCheckpointOpenAsync API_OpenAs
>   [CKPT_OPEN_ASYNC_ALL_CREATE_EXTENDED_NAME_SUCCESS_T] = 
> {,1021, 
> _replicas_ckpt_with_valid_extended_name_length, _replicas,
>
> SA_CKPT_CHECKPOINT_CREATE,SA_AIS_OK,"all replicas ckpt with valid extended 
> name created with invocation 1021"},
>   [CKPT_OPEN_ASYNC_ALL_CREATE_EXTENDED_NAME_INVALID_PARAM_T] = 
> {,0, _replicas_ckpt_with_invalid_extended_name_length, 
> _replicas,
> - 
> SA_CKPT_CHECKPOINT_CREATE,SA_AIS_ERR_INVALID_PARAM,"all replicas ckpt invalid 
> with extended name created"},
> + 
> SA_CKPT_CHECKPOINT_CREATE,SA_AIS_ERR_TOO_BIG,"all replicas ckpt invalid with 
> extended name created"},
>   };
>   
>   int test_ckptOpenAsync(int i,CONFIG_FLAG cfg_flg)
> @@ -1946,7 +1946,7 @@ struct SafCheckpointUnlink API_Unlink[]=
>   
> [CKPT_UNLINK_ALL_REPLICAS_EXTENDED_NAME_SUCCESS_T] = 
> {,_replicas_ckpt_with_valid_extended_name_length,SA_AIS_OK,"Unlinked
>  ckpt all replicas with extended name length"},
>   
> -  [CKPT_UNLINK_ALL_REPLICAS_EXTENDED_NAME_INVALID_PARAM_T] = 
> {,_replicas_ckpt_with_invalid_extended_name_length,SA_AIS_ERR_INVALID_PARAM,"Unlinked
>  ckpt all replicas with invalid extended name length"},
> +  [CKPT_UNLINK_ALL_REPLICAS_EXTENDED_NAME_INVALID_PARAM_T] = 
> {,_replicas_ckpt_with_invalid_extended_name_length,SA_AIS_ERR_TOO_BIG,"Unlinked
>  ckpt all replicas with invalid extended name length"},
>   
> #if 0
> [CKPT_UNLINK_NOT_EXIST4_T] = 
> {,_ckpt,SA_AIS_OK,"Unlinked ckpt collcated 
> replicas"},


--
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Re: [devel] [PATCH 1 of 1] amfd: do not flush imm jobs on active controller[#2016]

2016-09-20 Thread minh chau

Hi Praveen,

ack for code review.

Thanks,
Minh

On 09/09/16 22:15, praveen.malv...@oracle.com wrote:
>   osaf/services/saf/amf/amfd/imm.cc |  2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
>
> AMF pushes IMM updates in a queue to be updated after finishing main job.
> currently, standby amfd as a applier flushes job queue if number of elements
> reaches to 200. Since check is on implementer status, active controller may
> flush it when it loses implementer status and goes for reinit with IMM(one 
> case
> is when IMM returns BAD_HANDLE, a rare case).
>
> Patch checks the role of amfd besides implemeter status before flusing the
> job queue.
>
> diff --git a/osaf/services/saf/amf/amfd/imm.cc 
> b/osaf/services/saf/amf/amfd/imm.cc
> --- a/osaf/services/saf/amf/amfd/imm.cc
> +++ b/osaf/services/saf/amf/amfd/imm.cc
> @@ -385,7 +385,7 @@ AvdJobDequeueResultT Fifo::execute(SaImm
>   if (!avd_cb->active_services_exist)
>   return JOB_ETRYAGAIN;
>   
> - if (!avd_cb->is_implementer) {
> + if ((!avd_cb->is_implementer) && (avd_cb->avail_state_avd == 
> SA_AMF_HA_STANDBY)) {
>   check_and_flush_job_queue_standby_amfd();
>   return JOB_EINVH;
>   }
>


--
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

[devel] [PATCH 0 of 1] Review Request for ckpt: ckpttest for long dn 5_55 5_57 7_12 is failing #2032

2016-09-20 Thread Hoang Vo

Summary: ckpt: ckpttest for long dn is failing #2032
Review request for Trac Ticket(s): #2032
Peer Reviewer(s): mahesh.va...@oracle.com; anders.wid...@ericsson.com
Pull request to: mahesh.va...@oracle.com
Affected branch(es): default
Development branch: default


Impacted area   Impact y/n

 Docsn
 Build systemn
 RPM/packaging   n
 Configuration files n
 Startup scripts n
 SAF servicesn
 OpenSAF servicesn
 Core libraries  n
 Samples n
 Tests   y
 Other   n


Comments (indicate scope for each "y" above):
-

changeset 0a8d025d3bbdcaa9e752b8a8f1d7c605787701b7
Author: Hoang Vo 
Date:   Tue, 20 Sep 2016 13:08:31 +0700

[mq]: 2032_fix_ckpttest.patch


Complete diffstat:
--
 tests/cpsv/test_cpa.c  |  2 +-
 tests/cpsv/test_cpa_util.c |  6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)


Testing Commands:
-
Enable long DN:
immcfg -a longDnsAllowed=1 opensafImm=opensafImm,safApp=safImmService
export SA_ENABLE_EXTENDED_NAMES=1
RUn test
ckpttest

Testing, Expected Results:
--
All test cases must passed

Conditions of Submission:
-
ACK from maintainer

Arch  Built StartedLinux distro
---
mipsn  n
mips64  n  n
x86 n  n
x86_64  y  y
powerpc n  n
powerpc64   n  n


Reviewer Checklist:
---
[Submitters: make sure that your review doesn't trigger any checkmarks!]


Your checkin has not passed review because (see checked entries):

___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.

___ You have failed to nominate the proper persons for review and push.

___ Your patches do not have proper short+long header

___ You have grammar/spelling in your header that is unacceptable.

___ You have exceeded a sensible line length in your headers/comments/text.

___ You have failed to put in a proper Trac Ticket # into your commits.

___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)

___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.

___ You have ^M present in some of your files. These have to be removed.

___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.

___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.

___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.

___ You have extraneous garbage in your review (merge commits etc)

___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.

___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.

___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.

___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.

___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)

___ Your computer have a badly configured date and time; confusing the
the threaded patch review.

___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.

___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.


--
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

[devel] [PATCH 1 of 1] [mq]: 2032_fix_ckpttest.patch

2016-09-20 Thread Hoang Vo

 tests/cpsv/test_cpa.c  |  2 +-
 tests/cpsv/test_cpa_util.c |  6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)


diff --git a/tests/cpsv/test_cpa.c b/tests/cpsv/test_cpa.c
--- a/tests/cpsv/test_cpa.c
+++ b/tests/cpsv/test_cpa.c
@@ -45,7 +45,7 @@ const char *saf_error_string[] = {
 #endif
 
 #define VALID_EXTENDED_NAME_LENGTH 400
-#define INVALID_EXTENDED_NAME_LENGTH 2049
+#define INVALID_EXTENDED_NAME_LENGTH 2050
 
 
 extern int gl_prev_act;
diff --git a/tests/cpsv/test_cpa_util.c b/tests/cpsv/test_cpa_util.c
--- a/tests/cpsv/test_cpa_util.c
+++ b/tests/cpsv/test_cpa_util.c
@@ -391,7 +391,7 @@ struct SafCheckpointOpen API_Open[]={
 [CKPT_OPEN_ALL_CREATE_EXTENDED_NAME_SUCCESS_T] = 
{,_replicas_ckpt_with_valid_extended_name_length,_replicas,SA_CKPT_CHECKPOINT_CREATE,
  
APP_TIMEOUT,_replicas_Createhdl,SA_AIS_OK,"ckpt with ALL_REPLICAS and 
valid extended name created"},
 [CKPT_OPEN_ALL_CREATE_EXTENDED_NAME_INVALID_PARAM_T] = 
{,_replicas_ckpt_with_invalid_extended_name_length,_replicas,SA_CKPT_CHECKPOINT_CREATE,
- 
APP_TIMEOUT,_replicas_Createhdl,SA_AIS_ERR_INVALID_PARAM,"ckpt with 
ALL_REPLICAS and invalid extended name created"},
+ 
APP_TIMEOUT,_replicas_Createhdl,SA_AIS_ERR_TOO_BIG,"ckpt with 
ALL_REPLICAS and invalid extended name created"},
 
 /* NULL ckptHandle, */
 
@@ -560,7 +560,7 @@ struct SafCheckpointOpenAsync API_OpenAs
 [CKPT_OPEN_ASYNC_ALL_CREATE_EXTENDED_NAME_SUCCESS_T] = 
{,1021, _replicas_ckpt_with_valid_extended_name_length, 
_replicas,
  
SA_CKPT_CHECKPOINT_CREATE,SA_AIS_OK,"all replicas ckpt with valid extended name 
created with invocation 1021"},
 [CKPT_OPEN_ASYNC_ALL_CREATE_EXTENDED_NAME_INVALID_PARAM_T] = 
{,0, _replicas_ckpt_with_invalid_extended_name_length, 
_replicas,
- 
SA_CKPT_CHECKPOINT_CREATE,SA_AIS_ERR_INVALID_PARAM,"all replicas ckpt invalid 
with extended name created"},
+ 
SA_CKPT_CHECKPOINT_CREATE,SA_AIS_ERR_TOO_BIG,"all replicas ckpt invalid with 
extended name created"},
 };
 
 int test_ckptOpenAsync(int i,CONFIG_FLAG cfg_flg) 
@@ -1946,7 +1946,7 @@ struct SafCheckpointUnlink API_Unlink[]=
 
   [CKPT_UNLINK_ALL_REPLICAS_EXTENDED_NAME_SUCCESS_T] = 
{,_replicas_ckpt_with_valid_extended_name_length,SA_AIS_OK,"Unlinked
 ckpt all replicas with extended name length"},
 
-  [CKPT_UNLINK_ALL_REPLICAS_EXTENDED_NAME_INVALID_PARAM_T] = 
{,_replicas_ckpt_with_invalid_extended_name_length,SA_AIS_ERR_INVALID_PARAM,"Unlinked
 ckpt all replicas with invalid extended name length"},
+  [CKPT_UNLINK_ALL_REPLICAS_EXTENDED_NAME_INVALID_PARAM_T] = 
{,_replicas_ckpt_with_invalid_extended_name_length,SA_AIS_ERR_TOO_BIG,"Unlinked
 ckpt all replicas with invalid extended name length"},
 
   #if 0
   [CKPT_UNLINK_NOT_EXIST4_T] = 
{,_ckpt,SA_AIS_OK,"Unlinked ckpt collcated 
replicas"},

--
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

[devel] OpenSAF 5.1.RC2 tagged, change control applies

[devel] Review request for Doc: Extensions PR document for 5.1

[devel] [PATCH 0 of 1] Review Request for amf: add support for cluster reboot [#2053]

Re: [devel] [PATCH 1 of 1] MDS: Log TIPC dropped messages [#1957]

Re: [devel] [PATCH 1 of 1] amf: fix activeCompName in csiStateDescriptor used in CSI SET cbk [#2021]

Re: [devel] [PATCH 1 of 1] MDS: Log TIPC dropped messages [#1957]

Re: [devel] [PATCH 1 of 1] clm: fill SaNameT value with zeros [#2015]

[devel] [PATCH 1 of 1] clm: fill SaNameT value with zeros [#2015]

[devel] [PATCH 0 of 1] Review Request for clm: fill SaNameT value with zeros [#2015]

Re: [devel] [PATCH 1 of 1] [mq]: 2032_fix_ckpttest.patch

Re: [devel] [PATCH 1 of 1] amfd: do not flush imm jobs on active controller[#2016]

[devel] [PATCH 0 of 1] Review Request for ckpt: ckpttest for long dn 5_55 5_57 7_12 is failing #2032

[devel] [PATCH 1 of 1] [mq]: 2032_fix_ckpttest.patch

13 matches

Site Navigation

Mail list logo

Footer information