Hi Gary,
Sorry I over looked it , will see and fix it , while fixing other Amf
Dev review comments ( may be in V3 ).
-AVM
On 3/15/2017 11:01 AM, Gary Lee wrote:
> Hi Mahesh
>
> Did you see my proposed change?
>
> The ‘delete rec’ statement below will cause a double free, unless I’m
>
Hi Mahesh
Did you see my proposed change?
The ‘delete rec’ statement below will cause a double free, unless I’m mistaken.
Thanks
Gary
void avnd_comp_pm_rec_del(AVND_CB *cb, AVND_COMP *comp, AVND_COMP_PM_REC
*rec)
{
- uint32_t rc = NCSCC_RC_SUCCESS;
SaUint64T pid =
Hi Minh,
Ack with two comments in attached read me.
Thanks,
Praveen
On 10-Mar-17 11:14 AM, minh chau wrote:
Hi all,
Please help to review documentation changes. Files are attached, they
also can be found at below links:
Hi Gary,
The V1 patch is failing to apply cleanly on OpenSAF 5.2.RC1 tagged code, so i
re-based with V2 ,
also fixed additional issue , that you said in V1 and they are considerable
so I republished V2 with completely.
-AVM
On 3/14/2017 12:39 PM, Gary Lee wrote:
> Hi Mahesh
>
> Perhaps it's
src/amf/agent/ava_hdl.cc | 13 +
src/amf/agent/ava_mds.cc | 12
src/amf/agent/ava_op.cc | 11 ---
src/amf/amfwd/amf_wdog.c | 2 +-
src/amf/common/d2nmsg.c | 7 ++-
src/amf/common/n2avamsg.c | 1 -
src/amf/tools/amf_pm.c| 4 +---
7 files
src/amf/amfd/app.cc|3 +-
src/amf/amfd/apptype.cc| 20 ++
src/amf/amfd/chkop.cc |3 +-
src/amf/amfd/ckpt_dec.cc | 15 ++---
src/amf/amfd/ckpt_edu.cc |3 +-
src/amf/amfd/ckpt_enc.cc | 60
src/amf/amfd/clm.cc
Summary:amf: Fix all Cppcheck 1.77 issues [#2341] V2
Review request for Trac Ticket(s): #2341
Peer Reviewer(s): Amf Dev
Pull request to: <>
Affected branch(es): default
Development branch: default
Impacted area Impact y/n
src/amf/amfnd/amfnd.cc | 15 +--
src/amf/amfnd/cbq.cc | 9 +++--
src/amf/amfnd/chc.cc | 29 +++--
src/amf/amfnd/clc.cc | 37 ++---
src/amf/amfnd/comp.cc| 8 +++-
src/amf/amfnd/compdb.cc | 17
Ack.
regards,
Anders Widell
On 03/13/2017 01:16 PM, Hans Nordeback wrote:
> src/base/logtrace.c | 7 ++-
> 1 files changed, 6 insertions(+), 1 deletions(-)
>
>
> Even though not being LSB it would be good to use thread id instead of
> process id in trace.
>
> diff --git
Summary: build: Add missing README files to distribution tarball [#2374]
Review request for Trac Ticket(s): 2374
Peer Reviewer(s): Ramesh
Pull request to:
Affected branch(es): default(5.2)
Development branch: default
Impacted area Impact y/n
python/Makefile.am | 4 +++-
src/amf/Makefile.am | 9 -
src/ckpt/Makefile.am | 7 ++-
src/clm/Makefile.am | 6 +-
src/dtm/Makefile.am | 3 +++
src/imm/Makefile.am | 4 +++-
src/log/Makefile.am | 8 +++-
src/ntf/Makefile.am | 8 +++-
src/plm/Makefile.am |
Hi all!
We have now tagged and released OpenSAF 5.2.RC1 (release candidate 1), and we
are planning for a second release candidate within the next one or two weeks.
After the second release candidate (5.2.RC2) has been tagged, all branches in
the Mercurial repository will be under change
src/base/conf.cc| 66 +---
src/base/conf.h | 5
src/nid/nodeinit.cc | 5
3 files changed, 62 insertions(+), 14 deletions(-)
Read the fully qualified domain name once and store it in the local file system.
This will solve
Summary: base: Cache the FQDN to avoid problems caused by slow DNS responses
[#2347]
Review request for Trac Ticket(s): 2347
Peer Reviewer(s): Ramesh
Pull request to:
Affected branch(es): default(5.2)
Development branch: default
Impacted area Impact y/n
osaf/services/saf/amf/amfd/imm.cc | 18 +-
osaf/services/saf/amf/amfd/role.cc | 4 ++--
2 files changed, 15 insertions(+), 7 deletions(-)
If Immnd is killed, Amfd re-initializes with imm and re-reads configuration.
During configuration read if Immnd is again killed, Amfd
Summary: amfd: handle BAD_HANDLE return during config read [#2361]
Review request for Trac Ticket(s): #2361
Peer Reviewer(s): Amf Dev
Pull request to: <>
Affected branch(es): All
Development branch: opensaf-5.1.x
Impacted area Impact y/n
Ack with minor comment, see [Vu].
Regards, Vu
> -Original Message-
> From: Canh Van Truong [mailto:canh.v.tru...@dektech.com.au]
> Sent: Monday, March 13, 2017 1:19 PM
> To: lennart.l...@ericsson.com; vu.m.ngu...@dektech.com.au;
> mahesh.va...@oracle.com
> Cc:
Ack, code review only.
Thanks,
Praveen
On 14-Mar-17 11:54 AM, ramesh.bet...@oracle.com wrote:
> src/fm/fmd/fm_main.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>
> diff --git a/src/fm/fmd/fm_main.c b/src/fm/fmd/fm_main.c
> --- a/src/fm/fmd/fm_main.c
> +++
Summary: fm: changing the log level from ER to WA [#2363]
Review request for Trac Ticket(s): 2363
Peer Reviewer(s): praveen
Affected branch(es): default(5.2)
Development branch: default
Impacted area Impact y/n
Docs
src/fm/fmd/fm_main.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/fm/fmd/fm_main.c b/src/fm/fmd/fm_main.c
--- a/src/fm/fmd/fm_main.c
+++ b/src/fm/fmd/fm_main.c
@@ -608,7 +608,7 @@ static void fm_mbx_msg_handler(FM_CB *fm
* (old-Active) is still in
Hi Mahesh
Perhaps it's easier if you pushed V1 first. Otherwise the patches get even
bigger and harder to review. I was referring to regression tests failing
without the changes I proposed, when I said legacy tests failed.
thanks
> On 14 Mar 2017, at 6:01 pm, A V Mahesh
Hi Gary,
Previously you found some old application issue and you resolved it is
that related to this path or different issue ?
-AVM
On 3/14/2017 12:20 PM, A V Mahesh wrote:
> Hi Gar,
>
> Thanks for the review.
>
> On 3/14/2017 11:47 AM, Gary Lee wrote:
>> By the way, I still see cppcheck
Hi Gar,
Thanks for the review.
On 3/14/2017 11:47 AM, Gary Lee wrote:
> By the way, I still see cppcheck issues in AMF when I run ‘make cppcheck’,
> but this is a great improvement.
Ok will re-run the Cppcheck and if we find considerable , I will
re-publish the V2 patch.
-AVM
On 3/14/2017
Hi Mahesh
Ack for the series (regression tests run) with the following changes.
By the way, I still see cppcheck issues in AMF when I run ‘make cppcheck’, but
this is a great improvement.
Thanks
Gary
diff --git a/src/amf/amfd/csi.cc b/src/amf/amfd/csi.cc
--- a/src/amf/amfd/csi.cc
+++
24 matches
Mail list logo
