[devel] [PATCH 1/1] base: Try again for opensafd stop [#2459]

2017-06-01 Thread Rafael Odzakow
Internally opensafd creates a lock file during start/stop to avoid parallel execution. Wait for this lockfile to be released when a call to opensafd stop is done. --- src/nid/opensafd.in | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/src/nid/opensafd.in

[devel] [PATCH 0/3] Review Request for amf: support sc status change callback, non SAF [#2475]

2017-06-01 Thread Praveen
Summary: amf: support for sc status change callback, non SAF [#2475] Review request for Ticket(s): 2475 Peer Reviewer(s): AMF devs Pull request to: myself Affected branch(es): develop Development branch: ticket-2475 Base revision: 9e88cc8b28bee6e65c934961064b7125a8221bcb Personal repository:

[devel] [PATCH 2/3] amf: support SC status change callback, non SAF [#2475]

2017-06-01 Thread Praveen
* A callback that will be invoked by AMFA whenever a SC joins cluster and both SCs leaves cluster if SC Absence feature is enabled. Callback and its argument: void (*OsafAmfSCStatusChangeCallbackT)(OsafAmfSCStatusT state) where OsafAmfSCStatusT is defined as: typedef enum

[devel] [PATCH 3/3] amf: add a sample app for SC status change callback [#2475]

2017-06-01 Thread Praveen
--- samples/amf/sa_aware/Makefile.am | 13 +++- samples/amf/sa_aware/README | 8 +++ samples/amf/sa_aware/amf_sc_status_app.c | 115 +++ 3 files changed, 135 insertions(+), 1 deletion(-) create mode 100644

Re: [devel] [PATCH 1/1] base: Improve state report for opensafd [#2459]

2017-06-01 Thread Anders Widell
Ok I think 2. is a good solution. It is more generic and doesn't treat opensafd in any special way compared to the other init scripts that are installed on the system. / Anders Widell On 06/01/2017 10:52 AM, Rafael Odzakow wrote: 1. Not possible, check my other response. 2. I am OK with

Re: [devel] [PATCH 1/1] base: Improve state report for opensafd [#2459]

2017-06-01 Thread Rafael Odzakow
Only thing you are telling me is to ignore the implementation. It seems you still do not fully understand the issue. I am done repeating myself. On 06/01/2017 12:17 PM, Hans Nordebäck wrote: Again, opensaf status returns either 0 "opensaf system is running" or 3 "opensaf system is not

Re: [devel] [PATCH 1/1] base: Improve state report for opensafd [#2459]

2017-06-01 Thread Hans Nordebäck
Again, opensaf status returns either 0 "opensaf system is running" or 3 "opensaf system is not running". As I also commented before, what is the problem you are trying to solve? If SMF orders reboot and opensaf stop fails the node will be rebooted anyway, you replied ... " opensafd but from

[devel] [PATCH 0/1] Review Request for mds: clear mds lib valgrind warning [#2474]

2017-06-01 Thread A V Mahesh
Summary: mds: clear mds lib valgrind warning [#2474] Review request for Ticket(s): 2474 Peer Reviewer(s): praveen Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2474 Base revision: 9e88cc8b28bee6e65c934961064b7125a8221bcb

Re: [devel] [PATCH 1/1] base: Improve state report for opensafd [#2459]

2017-06-01 Thread Rafael Odzakow
1. Not possible, check my other response. 2. I am OK with that solution. On 06/01/2017 10:33 AM, Anders Widell wrote: Hi! Can't you return 150 from the opensafd stop command instead? Then the caller will know that he has to retry opensafd stop. Or maybe put the retry inside the opensafd

Re: [devel] [PATCH 1/1] base: Improve state report for opensafd [#2459]

2017-06-01 Thread Anders Widell
Hi! Can't you return 150 from the opensafd stop command instead? Then the caller will know that he has to retry opensafd stop. Or maybe put the retry inside the opensafd script? / Anders W On 05/19/2017 12:46 PM, Rafael Odzakow wrote: Internally opensafd creates a lock file during