Re: [devel] [PATCH 2/2] dtmd: change log wording [#2030]

2017-08-09 Thread A V Mahesh
Hi Ale, ACK, with following ( not tested). Please take care of alignment. -AVM On 8/9/2017 8:14 PM, Alex Jones wrote: return failure when unable to add new node --- src/dtm/dtmnd/dtm_node.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git

Re: [devel] [PATCH 1/1] dtmd: change log wording [#2030]

2017-08-09 Thread Anders Widell
As a general principle, we should never assert (or crash) due to the reception of unexpected or corrupted data over the network. So the assertion should be removed. But you are right that we need to do something sensible here. Maybe log an error message and terminate the connection to the node

[devel] [PATCH 1/1] imm: fix immnd coredump due to initialized CLM handle [#2549]

2017-08-09 Thread Zoran Milinkovic
Initially CLM handle is set to 0. When CLM handle is initialized, it can be initialized again only when saClmDispatch returns SA_AIS_ERR_BAD_HANDLE. This will prevent coredumps with initialized CLM handle caused with MDS UP message for AMF and CLM services. --- src/imm/immnd/immnd_clm.c | 7

[devel] [PATCH 0/1] Review Request for imm: fix immnd coredump due to initialized CLM handle [#2549]

2017-08-09 Thread Zoran Milinkovic
Summary: imm: fix immnd coredump due to initialized CLM handle [#2549] Review request for Ticket(s): 2549 Peer Reviewer(s): Hung, Mahesh Pull request to: Zoran Affected branch(es): develop, release Development branch: ticket-2549 Base revision: 56f638bc7ac2f5baa8988e6500eb63160de75a2d Personal

Re: [devel] [PATCH 1/1] log: fix cppcheck, cpplint and reorganize headers - part 1 [#2445]

2017-08-09 Thread Vu Minh Nguyen
Hi Canh, Ack with comments, with [Vu]. Regards, Vu > -Original Message- > From: Canh Van Truong [mailto:canh.v.tru...@dektech.com.au] > Sent: Thursday, July 20, 2017 1:31 PM > To: lennart.l...@ericsson.com; vu.m.ngu...@dektech.com.au; > mahesh.va...@oracle.com > Cc: