. std::set and
std::map provide tree data structures, and std::unordered_set and
std::unordered_map provide provide hash tables.
regards,
Anders Widell
--
This SF.net email is sponsored by Windows:
Build for Windows Store
these release candidates and report any problems found. We
are aiming to release OpenSAF 4.2.4 and 4.3.1 in the beginning of August.
regards,
Anders Widell
--
See everything from the browser to the database with AppDynamics
Get
);
/* Unassign the SUSI */
m_AVD_SU_SI_TRG_DEL(cb, i_su-list_of_susi);
}
-
regards,
Anders Widell
--
See everything from the browser to the database
, this is probably the reason why the
static code analysis tool thinks there is a use-after-free bug here.
regards,
Anders Widell
2013-07-30 06:45, Nagendra Kumar skrev:
Hi,
Just briefing it so that we are all on the same page:
Let us say, SU1 has three SIs(SI1, SI2 and SI3) assigned and
i_su
Tests n
Other n
Comments (indicate scope for each y above):
-
changeset 3c457ee245d95fbb2a0fa1d01658a4f923f5abdc
Author: Anders Widell anders.wid...@ericsson.com
Date: Wed, 31 Jul 2013 10:51:58 +0200
dtm
Ack (not tested).
Note that this does not completely solve the problem reported in ticket
451. amfwd must check if it is running with user id zero, and if not,
add the string sudo to the beginning of the command line when calling
the killall program.
regards,
Anders Widell
2013-07-31 14:46
Ack.
regards,
Anders Widell
2013-07-31 18:50, mathi.naic...@oracle.com skrev:
00-README.conf| 3 ++-
opensaf.spec.in | 2 +-
osaf/services/saf/avsv/amfwdog/amf_wdog.c | 12 ++--
3 files changed, 13 insertions(+), 4
Ack.
regards,
Anders Widell
2013-08-01 13:45, mathi.naic...@oracle.com skrev:
osaf/services/saf/plmsv/plms/hpi_intf/plms_epath_util.c | 3 ---
osaf/services/saf/plmsv/plms/hpi_intf/plms_hrb.c| 7 ---
osaf/services/saf/plmsv/plms/plms_imm.c | 14
It is possible to add (void) in front of strtok(), but it's not
necessary in order to get rid of the compiler warnings.
You can't remove the calls to strtok(), if that is what you mean.
strtok() has side effects!
regards,
Anders Widell
2013-08-01 13:52, Mathivanan Naickan Palanivelu skrev
Looks like we are in the need of a new non-blocking logging API. Maybe a
solution that can also be used to solve the MDS logging issue (where it
writes to a while while holding a lock).
regards,
Anders Widell
2013-08-09 09:03, Hans Nordebäck skrev:
Hi, we got feedback from one site
Wow, this was news to me. Ok then we must go through all functions we
use after fork() and check that they are safe.
So do we know if syslog() in general can block (if we disregard the case
when it is used after fork(), which apparently is a illegal).
regards,
Anders Widell
2013-08-09 09:17
in practice.
regards,
Anders Widell
2013-08-09 15:20, Lennart Lund skrev:
Summary: logsv: Fix hanging main thread when file i/o don't return
Review request for Trac Ticket(s): #9
Peer Reviewer(s): Madhurika Koppula, (Anders Widell, Hans Feldt)
Pull request to: NA
Affected branch(es): devel (4.4
One more comment:
* saf_logger.c needs to be updated to handle the error code
SA_AIS_ERR_TIMEOUT
regards,
Anders Widell
2013-08-16 12:16, Lennart Lund skrev:
Hi,
See my comments to Anders W below
Thanks'
Lennart
-Original Message-
From: Anders Widell [mailto:anders.wid
Yes, I can look into that. We used to have on the wiki, but the wiki has
not yet been moved to SourceForge (though the old wiki should still be
accessible).
regards,
Anders Widell
2013-08-19 10:28, Hans Feldt skrev:
The first one liner of the commit message should describe what the
patch
() to undo the write.
regards,
Anders Widell
2013-08-19 10:07, Lennart Lund skrev:
Summary: logsv: Fix hanging main thread when file i/o don't return
Review request for Trac Ticket(s): #9
Peer Reviewer(s): Madhurika Koppula, (Anders Widell, Hans Feldt)
Pull request to: NA
Affected branch(es): devel
the agent libraries are linked with
that library.
regards,
Anders Widell
--
Introducing Performance Central, a new site from SourceForge and
AppDynamics. Performance Central is your source for news, insights,
analysis
milestone. So please, when
possible, set the milestone field of the tickets you intend to
implement within the next few OpenSAF releases.
thanks,
Anders Widell
PS if you wish to see all open tickets for a service (including the
unplanned ones), you can still do so by clicking on the links at the top
(%s: wrong number of bytes to decode (%u vs %lu),
^
cc1: all warnings being treated as errors
It seems the sizeof(AVSV_NDA_AVA_MSG) needs to be casted to (unsigned long).
regards,
Anders Widell
--
Learn the latest
I think it looks like you require IP addresses to be configured
correctly in /etc/opensaf/dtmd.conf even when I am running with TIPC. Is
this neccessary? It was not necessary before this patch...
regards,
Anders Widell
2013-10-03 05:53, A V Mahesh skrev:
Hi Anders Widell ,
I didn't tested
tools/cluster_sim_uml/archive/scripts/40opensaf.rc | 1 +
tools/cluster_sim_uml/build_uml| 5 +
2 files changed, 6 insertions(+), 0 deletions(-)
Add support for the TCP transport in the UML environment. Select TIPC
transport when OpenSAF was built with TIPC enabled.
will be broken (or at least it won't work
out of the box).
regards,
Anders Widell
2013-09-26 05:54, mahesh.va...@oracle.com skrev:
Summary:opensaf:make MDS/TCP as the default opensaf transport[#232]
Review request for Trac Ticket(s): #232
Peer Reviewer(s): Hans Mathi
Pull request to: LIST THE PERSON
Europe, please see the link below:
http://events.linuxfoundation.org/events/linuxcon-europe
regards,
Anders Widell
--
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application
and
destruction. However, such variables are allowed if they are constexpr:
they have no dynamic initialization or destruction.
regards,
Anders Widell
2013-10-03 14:54, Hans Feldt skrev:
osaf/libs/core/common/daemon.c | 9 ++---
1 files changed, 6 insertions(+), 3 deletions(-)
By calling exit
thing we do in main() ?
regards,
Anders Widell
2013-10-09 16:12, Anders Björnerstedt skrev:
The imm uses static global (non-pointer) variables for a number of C++ STL
objects.
Maps, Sets, Vectors etc.
I have never seen any problems with this.
/AndersBj
-Original Message-
From
osaf/libs/agents/saf/lga/lga_api.c | 2 +-
osaf/libs/agents/saf/lga/lga_util.c | 7 ++-
osaf/tools/saflog/saflogger/saf_logger.c | 1 -
tests/logsv/Makefile.am | 6 --
4 files changed, 7 insertions(+), 9 deletions(-)
The select() function cannot handle
osaf/libs/agents/saf/amfa/ava_init.c | 8 +++-
1 files changed, 3 insertions(+), 5 deletions(-)
The select() function cannot handle file descriptors larger than 1023. To avoid
this limitation, we replace all usages of select() with poll().
diff --git a/osaf/libs/agents/saf/amfa/ava_init.c
osaf/libs/agents/saf/mqa/mqa_init.c | 13 +++--
1 files changed, 3 insertions(+), 10 deletions(-)
The select() function cannot handle file descriptors larger than 1023. To avoid
this limitation, we replace all usages of select() with poll().
diff --git
osaf/services/infrastructure/dtms/dtm/dtm_main.c | 12 +++-
1 files changed, 3 insertions(+), 9 deletions(-)
The select() function cannot handle file descriptors larger than 1023. To avoid
this limitation, we replace all usages of select() with poll().
diff --git
osaf/libs/agents/saf/eda/eda_mds.c | 10 +++---
osaf/libs/agents/saf/eda/eda_saf_api.c | 2 +-
2 files changed, 4 insertions(+), 8 deletions(-)
The select() function cannot handle file descriptors larger than 1023. To avoid
this limitation, we replace all usages of select() with
osaf/libs/core/include/ncs_osprm.h | 142 +-
osaf/libs/core/include/os_defs.h |1 -
osaf/libs/core/leap/os_defs.c | 203 +---
osaf/libs/core/leap/sysf_ipc.c |9 +-
osaf/libs/core/leap/sysf_tmr.c | 68 ++--
not yet been fixed. They will be fixed in
a patch that will be sent out later.
changeset 8bd7a81783f17268607be9ad703bc7978e1df7ff
Author: Anders Widell anders.wid...@ericsson.com
Date: Thu, 31 Oct 2013 14:13:50 +0100
amf: Replace select() with osaf_poll() to avoid 1024 fd limit [#452
osaf/libs/agents/infrastructure/rda/rda_papi.c | 36 +
1 files changed, 7 insertions(+), 29 deletions(-)
The select() function cannot handle file descriptors larger than 1023. To avoid
this limitation, we replace all usages of select() with poll().
diff --git
osaf/libs/agents/saf/ntfa/ntfa_api.c | 2 +-
osaf/libs/agents/saf/ntfa/ntfa_util.c | 8 +++-
osaf/tools/safntf/ntfread/ntfread.c | 1 -
osaf/tools/safntf/ntfsend/ntfsend.c | 1 -
osaf/tools/safntf/ntfsubscribe/ntfsubscribe.c | 1 -
, check that you have set the
correct milestone and accepted them.
thanks,
Anders Widell
--
Android is increasing in popularity, but the open development platform that
developers love is also attractive to malware
will be moved to the OpenSAF 4.5.FC milestone.
Anders Widell
191 IMM: SaNameT 256 byte size limit and RDN 64 byte size limit.
452 osaf: Allow us to use more than 1024 file descriptors
580 base: Add utilility functions for poll() and time handling
Anders Bjornerstedt
21 IMM: Allow
--enable-imm-pbe when
configuring OpenSAF.
regards,
Anders Widell
--
DreamFactory - Open Source REST JSON Services for HTML5 Native Apps
OAuth, Users, Roles, SQL, NoSQL, BLOB Storage and External API Access
Free app
Ok, I will add error loggings and push this later today.
regards,
Anders Widell
2013-11-29 09:53, Mathivanan Naickan Palanivelu skrev:
Ack.
Good that you were able to work on this ticket, would be a good value add.
One comment is that, we should log the fd and strerror(errno) in the cases
. Please check your
tickets and make sure that the only defect tickets with the 4.4.FC
milestone are defects for new functionality that is not present on
earlier branches.
regards,
Anders Widell
--
Rapidly troubleshoot
Oops, forgot about that one. It is fixed now.
thanks,
Anders Widell
2013-12-02 07:43, Ramesh Betham skrev:
Hi Anders,
make rpm fails, please check. (osaf_poll.h, osaf_time.h should add in
../osaf/libs/core/common/includeMakefile.am)
Thanks,
Ramesh.
libopensaf_common_la-osaf_poll.lo -MD
The POLLHUP seems to happen quite frequently (revents=17), so I will
filter the log messages in that case.
regards,
Anders Widell
2013-11-29 09:53, Mathivanan Naickan Palanivelu skrev:
Ack.
Good that you were able to work on this ticket, would be a good value add.
One comment is that, we
,
Anders Widell
--
Sponsored by Intel(R) XDK
Develop, test and display web and hybrid apps with a single code base.
Download it for free now!
http://pubads.g.doubleclick.net/gampad/clk?id=111408631iu=/4140/ostg.clktrk
I get the following build error in PLM:
plms_dbg_utils.c: In function ‘plms_cb_dump_routine’:
plms_dbg_utils.c:50:2: error: implicit declaration of function
‘m_GET_ASCII_DATE_TIME_STAMP’ [-Werror=implicit-function-declaration]
regards,
Anders Widell
2013-12-05 13:51, ramesh.bet...@oracle.com
was done (i.e. that we wish to dump coverage data on
termination, but that exit() cannot be used since it is not thread-safe).
2) I usually prefer to use _Exit() over _exit() since the former one is
declared as nothrow.
regards,
Anders Widell
2013-12-09 09:23, Hans Nordeback skrev:
osaf
00-README.conf | 2 +-
Makefile.common | 4 ++--
README | 16
configure.ac | 18 ++
tools/cluster_sim_uml/README | 2 +-
5 files changed, 34 insertions(+), 8 deletions(-)
By default, build
And it is only used at one place in PLM, so the macro can be removed and
code inserted at that place.
regards,
Anders Widell
2013-12-09 16:13, Hans Feldt skrev:
If PLM is now the only user of this please change PLM instead.
/Hans
On 12/09/2013 08:31 AM, ramesh.bet...@oracle.com wrote
m_KEY_CMP(const NCS_PATRICIA_TREE* t, const uint8_t*
k1, const uint8_t* k2)
{
return memcmp(k1, k2, t-params.key_size);
}
static inline int m_GET_BIT(const uint8_t* key, int bit)
{
return (bit 0) ? 0 : ((int) ((*(key + (bit 3))) (7 - (bit
0x07))) 0x01);
}
regards,
Anders Widell
2013
in all OpenSAF
services, these should be removed. Or if they are relevant, the printf's
can be converted to TRACE() and the fprintf's to LOG_ER().
regards,
Anders Widell
--
Sponsored by Intel(R) XDK
Develop, test
Ack with comment. The ticket number is still not surrounded with square
brackets [#581] in the first line of the commit message.
regards,
Anders Widell
2013-12-10 10:37, Hans Nordeback skrev:
Summary: base: use _Exit instead of exit in daemon_exit [#581]
Review request for Trac Ticket(s): 581
Ack with the comments I sent out in earlier mails.
Good work, this code is in need of some clean-up and this is a step in
the right direction!
regards,
Anders Widell
2013-12-05 13:51, ramesh.bet...@oracle.com skrev:
Summary: Clean up unused code in base [#537]
Review request for Trac Ticket
Ok, I will close both of them when this is fixed.
regards,
Anders Widell
2013-12-10 15:57, Hans Nordebäck skrev:
a ticket for this already exists
http://sourceforge.net/p/opensaf/tickets/320/ /BR HansN
-Original Message-
From: Anders Widell [mailto:anders.wid...@ericsson.com
n
Other n
Comments (indicate scope for each y above):
-
changeset 5c7edc02bb32b47b6bddde619a440fc1324675d9
Author: Anders Widell anders.wid...@ericsson.com
Date: Thu, 12 Dec 2013 16:34:13 +0100
java: Fix
,
Anders Widell
2013-12-13 13:47, Hans Feldt skrev:
osaf/libs/core/common/logtrace.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/osaf/libs/core/common/logtrace.c
b/osaf/libs/core/common/logtrace.c
--- a/osaf/libs/core/common/logtrace.c
+++ b/osaf/libs/core/common
the freeze either.
Below is a list of still open enhancement tickets for 4.4.FC:
Anders Widell
452 osaf: Allow us to use more than 1024 file descriptors
A V Mahesh (AVM)
561 CKPT: add CkptArrivalCallback as part of the CKPT API
617 Internal mds/base function/api to read ipaddress of the local
to Makefile.common look a bit strange. It seems
to work, but I find it more natural to do it this way:
AM_CFLAGS = -Wall -fno-strict-aliasing -Werror -fPIC @OSAF_HARDEN_FLAGS@
-DINTERNAL_VERSION_ID='@INTERNAL_VERSION_ID@'
regards,
Anders Widell
2013-12-19 09:22, Hans Nordeback skrev:
Makefile.common
I think something like this could do the trick:
In configure.ac:
INTERNAL_VERSION_ID=0:
AC_SUBST([INTERNAL_VERSION_ID])
In bootstrap.sh:
autoreconf -vi
sed -i s/^INTERNAL_VERSION_ID=.*\$/INTERNAL_VERSION_ID=$(hg parent
--template {rev}:{node|short})/ configure
regards,
Anders
Ack (not tested)
regards,
Anders Widell
2014-01-07 12:35, Hans Nordeback skrev:
Makefile.common | 4 ++--
bootstrap.sh | 4 +++-
configure.ac | 3 +++
osaf/libs/core
. In these cases, SaNameT.length would get a value that is
0x or = SA_MAX_NAME_LENGTH, respectively.
is_config_valid() is a validation function that seems to return 1 when
successful and 0 otherwise. So if the above case happens, I would guess
it is a good idea to return 0.
regards,
Anders Widell
n
Tests n
Other n
Comments (indicate scope for each y above):
-
changeset b030f158fa19817ac62b65cebf371a8b7167b2b6
Author: Anders Widell anders.wid...@ericsson.com
Date: Fri, 17 Jan 2014 15:43:56
osaf/libs/core/leap/os_defs.c | 13 +++--
1 files changed, 7 insertions(+), 6 deletions(-)
OpenSAF would fail to start when an invalid thread scheduling policy has been
configured, e.g. using the following configuration options for one of the
OpenSAF services:
export
osaf/libs/core/mds/mds_dt_tipc.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
Remove an unnecessary log message regarding the configured TIPC importance,
that was introduced in ticket [#589]. The information in the log message is
unnecessary since the same information can be found
n
Tests n
Other n
Comments (indicate scope for each y above):
-
changeset 7db32ad52774d8b371b43aa5aabccc6feafa13f2
Author: Anders Widell anders.wid...@ericsson.com
Date: Thu, 30 Jan 2014 16:46:04 +0100
n
Tests n
Other y
Comments (indicate scope for each y above):
-
changeset 8631919bdd815be3e70e9fc389d84c5911cc2b54
Author: Anders Widell anders.wid...@ericsson.com
Date: Fri, 31 Jan 2014 14:06:00 +0100
on this?
thanks
/ Anders Widell
2014-01-29 19:00, mathi.naic...@oracle.com skrev:
Summary: failover using OPENSAF_MANAGE_TIPC flag and failover after down of
critical services [#721]
Review request for Trac Ticket(s): #721
Peer Reviewer(s): ramesh.bet...@oracle.com, anders.wid...@ericsson.com
Ok, now I see what you mean. In the case of failover without OS reboot,
the FM process is terminated and will not perform the waiting.
/ Anders Widell
2014-02-04 12:56, Mathivanan Naickan Palanivelu skrev:
- anders.wid...@ericsson.com wrote:
I am not sure if I fully understand the use
Well, except for the code in the agent library. That code must be
written in C.
regards,
Anders Widell
2014-02-04 15:59, Anders Widell skrev:
Hi guys!
Just to let you know: we are trying to move away from the patricia tree
code and use C++ STL instead. So if you already have implemented
Hi guys!
Just to let you know: we are trying to move away from the patricia tree
code and use C++ STL instead. So if you already have implemented this
with an STL map, there is no need to port it to use the patricia tree.
regards,
Anders Widell
2014-02-04 15:24, Domrachev, Mikhail skrev:
Hi
tools/devel/review/00-README | 77 ++---
tools/devel/review/commit.template | 51 ++--
tools/devel/review/hgeditor.sh | 32 +++
3 files changed, 91 insertions(+), 69 deletions(-)
Update the commit message template with
n
Other y
Comments (indicate scope for each y above):
-
changeset 27485a5e44ed4fbc542f24ecc11a6c97df9c5bc8
Author: Anders Widell anders.wid...@ericsson.com
Date: Mon, 17 Feb 2014 17:40:30 +0100
osaf: Update
Ack with comments.
1) It is probably a good idea to validate that role is within bounds
before accessing the array with strings role_string[role]. It could be
done e.g. in the following way:
LOG_NO(RDE role set to %s, role = 0 role sizeof(role_string) /
sizeof(role_string[0]) ?
with:
+ while (osaf_poll(sel[0], NUM_FD, -1) 0) {
/ Anders Widell
2014-02-19 02:36, mathi.naic...@oracle.com skrev:
Summary: use common sigterm handler [#512]
Review request for Trac Ticket(s): #512
Peer Reviewer(s): anders.wid...@ericsson.com
Pull request to: LIST THE PERSON WITH PUSH
osaf/libs/saf/include/Makefile.am| 1 +
osaf/libs/saf/include/saAis.h| 2 +
osaf/libs/saf/include/saAis_B_5_14.h | 39
3 files changed, 42 insertions(+), 0 deletions(-)
Add a definition of SaConstStringT as an OpenSAF extension to the AIS
n
Comments (indicate scope for each y above):
-
changeset f2d124340ecbcb4cab0a16a66879b97fed9614ef
Author: Anders Widell anders.wid...@ericsson.com
Date: Fri, 07 Mar 2014 14:45:22 +0100
osaf: Add definition of the new type SaConstStringT
: https://sourceforge.net/p/opensaf/wiki/Home/
regards,
Anders Widell
--
Learn Graph Databases - Download FREE O'Reilly Book
Graph Databases is the definitive new guide to graph databases and their
applications. Written
- by adding a preprocessor
section at the top of them, e.g. like this:
#ifndef _SA_AIS_H
#error Don't include this file directly - include saAis.h instead
#endif
regards,
Anders Widell
2014-04-01 15:41, Mathivanan Naickan Palanivelu skrev:
One could say the header file convention for the IMM
names for all services at once.
regards,
Anders Widell
2014-04-02 09:52, Anders Björnerstedt skrev:
The direct inclusion prevention is a good idea and should be added to these
files.
I think the current include file extension for the imm should be kept for now.
This mainly to avoid rocking
() and realloc(),
where it can be very handy to be able to pass a NULL pointer in case no
memory has been allocated (yet). The API documentation here clearly says
what happens when you pass a NULL pointer.
regards,
Anders Widell
2014-04-04 15:04, Nagendra Kumar skrev:
Ack with comment
. Both humans and e.g. static analysis tools can make use of such
information.
regards,
Anders Widell
2014-04-04 16:33, Hans Nordebäck skrev:
external API normally needs to validate its input and further calling
internal function these validations are not needed. Asserts can be used to
detect bugs
In that case the child will have the same stdin/stdout/stderr as the
parent process. But if we know for sure that the parent already has
redirected its stdin/stdout/stderr to /dev/null then I think it ought to
be fine.
/ Anders Widell
2014-04-23 09:45, Hans Feldt skrev:
What happens
that all file descriptors have the FD_CLOEXEC flag.
Then we would easily be able to catch any such regression.
/ Anders Widell
2014-04-23 09:56, Hans Feldt skrev:
Yes we know that for sure, it is amfnd or smfnd calling this routine.
From what I remember one closeonexec is needed (some leap fd
by now, and I can see that they
have indeed inserted a link to the new project page at SourceForge, but
the old links also remain.
/ Anders Widell
2014-04-29 14:55, Guilherme Moro skrev:
Hi,
The project was completely migrated to Sourceforge, is this a valid
assumption?
if you go to http
00-README.conf | 18 ++
osaf/libs/saf/include/saAis.h| 4
osaf/libs/saf/include/saAis_B_5_14.h | 17 +
3 files changed, 39 insertions(+), 0 deletions(-)
Add declarations of saAisNameLend() and saAisNameBorrow() to saAis.h.
osaf/libs/agents/saf/imma/Makefile.am |1 +
osaf/libs/agents/saf/imma/aisa_api.c | 131 ++
osaf/libs/saf/libSaImm/libSaImmOm.map |2 +
3 files changed, 134 insertions(+), 0 deletions(-)
The functions saAisNameLend() and saAisNameBorrow() are defined in
osaf/libs/core/common/Makefile.am |1 +
osaf/libs/core/common/include/osaf_extended_name.h | 232 +
osaf/libs/core/common/osaf_extended_name.c | 184
osaf/libs/core/leap/sysf_def.c |3 +
4 files changed,
osaf/libs/core/common/ncs_main_pub.c | 2 +-
osaf/libs/core/common/ncs_sprr.c | 2 +-
osaf/libs/core/include/ncssysf_def.h | 4 ++--
osaf/libs/core/leap/hj_dec.c | 4 ++--
osaf/libs/core/leap/hj_enc.c | 8
Yes that should ALSO be done. :-) There are probably several more places
where we have printf.
This patch just fixes the missing parentheses. I could fix the printf
too, while touching that line.
/ Anders Widell
On 05/08/2014 03:33 PM, Hans Feldt wrote:
Why not just replace with trace
or a prior call to alarm(). Consider using the new
OpenSAF utility function osaf_nanosleep() instead, which has no risk of
interference and handles signal interruption for you. E.g. like this:
#include osaf_time.h
struct timespec interval = { 2, 0 };
osaf_nanosleep(interval);
/ Anders Widell
Ack.
/ Anders Widell
On 05/15/2014 03:16 PM, Ingvar Bergstrom wrote:
osaf/services/saf/smfsv/smfd/SmfUpgradeProcedure.cc | 10 +-
1 files changed, 9 insertions(+), 1 deletions(-)
Without this patch a cluster reboot in state execution completed will put
the upgrade campaign
n
Tests n
Other n
Comments (indicate scope for each y above):
-
changeset f9003f8108396773670f73403db5d6dc6d19337c
Author: Anders Widell anders.wid...@ericsson.com
Date: Wed, 21 May 2014 13:30:33 +0200
osaf/libs/core/leap/os_defs.c| 4 ++--
osaf/services/infrastructure/nid/scripts/opensafd.in | 9 +++--
2 files changed, 5 insertions(+), 8 deletions(-)
OpenSAF fails to start on systems with (e)glibc version 2.19, e.g. Ubuntu
14.04, openSUSE 13.2:
Error messages
Ack with comment:
osaf_timespec_compare(current_ts, evt-entered_at) 1
On the line above you compare with 1, i.e. you require current time to
be strictly greater than the entered time. In theory, the time stamps
could be exactly the same, so you should compare with zero instead.
/ Anders
Hi Alex!
Nice to see this performance enhancement out for review. Good work!
I have a few minor comments, see inline below (marked AndersW):
regards,
Anders Widell
On 05/20/2014 11:27 PM, Alex Jones wrote:
osaf/libs/common/cpsv/include/cpnd_cb.h |6 +-
osaf/libs/common/cpsv/include
00-README.conf | 18 ++
osaf/libs/saf/include/saAis.h| 4
osaf/libs/saf/include/saAis_B_5_14.h | 17 +
3 files changed, 39 insertions(+), 0 deletions(-)
Add declarations of saAisNameLend() and saAisNameBorrow() to
previous review:
* Fixed an off-by-one bug i saAisNameBorrow()
* Fixed RPM build problem
* Implemented review comment that the saAisNameLend and saAisBorrow shall
be available in all SAF libraries, instead of just in libSaImmOm
changeset a836344c6a36ad87cc5ad3e79da0499830733171
Author: Anders Widell
configure.ac |1 +
osaf/libs/common/Makefile.am |2 +-
osaf/libs/common/ais/Makefile.am | 27 ++
osaf/libs/common/ais/aisa_api.c | 140 ++
osaf/libs/saf/libSaAmf/Makefile.am|1 +
osaf/libs/core/common/Makefile.am |1 +
osaf/libs/core/common/include/Makefile.am |1 +
osaf/libs/core/common/include/osaf_extended_name.h | 232 +
osaf/libs/core/common/osaf_extended_name.c | 184
Comments (indicate scope for each y above):
-
changeset f3a7552039663e0884a45f4f94123401fe7b0807
Author: Anders Widell anders.wid...@ericsson.com
Date: Mon, 09 Jun 2014 17:12:43 +0200
build: Modernize autotools configuration [#901
Makefile.am| 4 +-
configure.ac | 11 +-
contrib/plmc/configure.ac | 6 +-
java/ais_api_impl_native/Makefile.am | 34 +++---
osaf/Makefile.am
get this message on your system? Do you get the
same log message? Maybe this configuration option has changed in recent
versions of systemd?
/ Anders Widell
On 06/02/2014 11:12 PM, Alex Jones wrote:
Summary: osaf: port existing daemonization and nid process to systemd
new-style daemon
Review
OpenSUSE 13.2, and fix the issues.
Alex
On 06/10/2014 10:25 AM, Anders Widell wrote:
Hi!
I have started testing this patch. When I build RPMs and install on
openSUSE 13.2.M0 I get the following log messages:
Jun 10 15:31:19 SC-1 systemd[1]: Configuration file
/usr/lib/systemd/system
accept bug fixes on the 4.5 branch.
regards,
Anders Widell
--
HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions
Find What Matters Most in Your Big Data with HPCC Systems
Open Source. Fast. Scalable
1 - 100 of 823 matches
Mail list logo
