Hi Nagu,
Can you describe your backward compatibility test case?
It looks to me that the new attr saAmfUnassignedAlarmStatus was not
added to IMM while standby amfd was running cloud resilience version
Thanks,
Minh
On 04/02/16 20:08, Nagendra Kumar wrote:
> Hi Minh,
> While testin
Hi Nagu,
Thanks for your testing, I'm investigating the issues 1 to 5 which seems
to me in priority order.
Regarding 5, we haven't tested much of proxy-proxied, do you see any
problem?
Thanks,
Minh
On 05/02/16 23:19, Nagendra Kumar wrote:
> Hi Minh,
>
> Doing some sanity testing and I am obser
>
>> -Original Message-
>> From: Nagendra Kumar [mailto:nagendr...@oracle.com]
>> Sent: 09 February 2016 15:56
>> To: 'minh chau'; 'hans.nordeb...@ericsson.com';
>> 'gary@dektech.com.au'; Praveen Malviya
>> Cc: 'o
Hi Lennart, Praveen
If you are not too busy, can you help to review the patches of #1180?
Thanks,
Minh
>> -Original Message-
>> From: Minh Hon Chau [mailto:minh.c...@dektech.com.au]
>> Sent: den 23 december 2015 05:02
>> To: Lennart Lund; praveen.malv...@oracle.com; Vu Minh Nguyen
>> Cc:
Hi Lennart,
Thanks for comments, there're out of date comments from rl1.
I also will update the patch to change "test ? x : y" to "if-else" after
receives comments from Praveen and Vu
Thanks,
Minh
On 11/02/16 00:17, Lennart Lund wrote:
> Hi Minh
>
> Ack with comments.
> Please see comments inli
L AMF Node Director is down,
> terminate this process
> Feb 10 17:21:10 PM_PL-3 amf_demo[29519]: exiting (caught term signal)
> Feb 10 17:21:10 PM_PL-3 osafclmna[29321]: AL AMF Node Director is down,
> terminat
Hi Praveen,
Please find my comments inline [Minh]
Thanks,
Minh
On 11/02/16 17:10, praveen malviya wrote:
> Hi Minh,
>
> I have marked some doubts with [Praveen]. Could you please answer
> them, it will helpful in understanding the changes in AMFD and AMFND.
>
> Thanks,
> Praveen
>
> On 20-Jan-1
> is not a case with one payload.
> This problem looks more like AMF than IMM limitation problem.
>
> Thanks,
> Zoran
>
> -Original Message-
> From: minh chau [mailto:minh.c...@dektech.com.au]
> Sent: Thursday, February 11, 2016 5:47 AM
> To: Nagendra Kumar; H
Hi Praveen,
Please find my comments inline [Minh]
Thanks,
Minh
On 12/02/16 22:10, praveen malviya wrote:
> Hi Minh,
>
> Please find some initial comments and questions marked with [Praveen].
>
> One question regarding the approach.
> In most of the changed APIs from saNtfInitialize() to
> saNtf
created in source code repo while compiling. I compiled again and they are
> the same. All the patches are applied.
> So, please check from your side and confirm me if I am making any mistake?
>
> Thanks
> -Nagu
>> -Original Message-
>> From: Gary Lee [mailto:gary..
Hi Nagu,
Thanks for your testing.
Below is our investigation from TC1 - TC31 which seem to be important,
plus some patches that we're trying to fix the issues
1. IMM one payload limitation (TC #1, #6, #7, #8, #9, #10, #11)
Discussion is on-going. When we hit the limitation, which causes
misma
Hi Nagu,
Attached patch is for TC 41, 42.
We have noticed one bug in sidep, will update it soon.
Thanks,
Minh
On 22/02/16 23:48, Hans Nordebäck wrote:
Hi,
please see enclosed patch for TC #1, #6, #7, #8, #9, #10 and
#11/Thanks HansN
On 02/19/2016 10:09 AM, minh chau wrote:
Hi Nagu
Hi Praveen,
We have been lost in emails of #1620, sorry for late reply.
V4 has been sent out though your comments here are still valid on V4.
So please find our comments inline with [Gary] and [Minh]
Thanks,
Gary/Minh
On 11/02/16 22:15, praveen malviya wrote:
> Hi Minh,
>
> Please find some init
Hi,
I made a mistake in rebase the patch, that I reverted fix of #1595 (the
last diff)
I'll remove that last diff in next version.
Thanks,
Minh
On 25/02/16 19:44, Minh Hon Chau wrote:
> osaf/services/saf/amf/amfd/cluster.cc| 48 +++-
> osaf/services/saf/amf/amfd/comp.cc
Hi Vu,
Please see comments in line with [Minh]
Thanks,
Minh
On 25/02/16 17:57, Vu Minh Nguyen wrote:
> Hi Minh,
>
> I have few comments below [Vu] and one question.
>
> I see, in some places, NTF APIs not always return TRY_AGAIN if both SCs
> down.
> I am not sure if I feel correctly or not.
>
Hi Praveen,
If node_up of amfnd comes after node sync timer expires, amfd will send
reboot message to that amfnd, regardless of susi states.
Sending reboot message in avd_comp_pres_state_set() if comp is
inst/term-failed has already been in code base of #1620.
The change in #1620 that marks *nod
Hi Praveen,
Please see comments in line [Minh]
Thanks,
Minh
On 02/03/16 18:12, praveen malviya wrote:
>
>
> On 02-Mar-16 12:26 PM, minh chau wrote:
>> Hi Praveen,
>>
>> If node_up of amfnd comes after node sync timer expires, amfd will send
>> reboot message
nks
>>> Gary
>>>
>>>
>>> Quoting Mathivanan Naickan Palanivelu :
>>>
>>>> Hi All,
>>>>
>>>> What is 'delayed failover'? That sounds against the principles of
>>>> 'software fault isolation&#
Hi Nagu, Praveen
From patch 09 to patch 14, they are fixes for bugs that you also need
on top of patches #4.
The problems you reported should not happen if you have them. They are
regardless whether we *reboot node if transient states* or *adjust
transient states* (delayed failover).
Patch 0
sient SUSI. The difference is decision to be made, one can reboot
the node, another can adjust the state. Though it seems rebooting node
will loose the availability?
Thanks,
Minh
On 03/03/16 11:32, minh chau wrote:
> Hi Nagu, Praveen
>
> From patch 09 to patch 14, they are fixes for bugs
e comments and other
> comments of v1 on amfd patch. Those are important comments and needs
> to be addressed.
[Minh] We have received 2 emails for comments on V2 so far and all of
those had been responded. In V4 we have corrected patches according to
some of your comments
Belows are da
Hi Nagu,
From your test description TC#1, it says SU2 hosted on SC-2. And after
SC-1 comes back, SU2 on PL-4 gets assignment.
This description is symptom of su mapping issue which is addressed in
patch 11_1.
But now looking at the trace file, SU2 is being hosted in PL-4 actually
(not as in de
and run the legacy tests in the
> non-resilience configuration and all tests PASS.
>
> Regards
> Lennart
>
>> -Original Message-
>> From: Minh Hon Chau [mailto:minh.c...@dektech.com.au]
>> Sent: den 1 mars 2016 08:30
>> To: Lennart Lund; praveen.
equire deducing the
>> SG FSM state at the time of controller down and resuming SG in the same
>> state.
>> 4)There are FIVE SG FSM states in our code out of which STABLE
>> state of SG is not applicable for transition state. So there are only
>> FOUR SG fsm st
>
>> -Original Message-
>> From: minh chau [mailto:minh.c...@dektech.com.au]
>> Sent: den 4 mars 2016 09:40
>> To: Lennart Lund; praveen.malv...@oracle.com; Vu Minh Nguyen
>> Cc: opensaf-devel@lists.sourceforge.net
>> Subject: Re: [PATCH 0 of 5] Revi
is issued, then faulty su happens during assignment. But after
headless, everything had already happened so how these fsm code will be
called in the right order (or running concurrently) on all entities
while sharing one fsm state.
Thanks,
Minh
On 10/03/16 16:13, minh chau wrote:
> Hi Prav
On 11/03/16 17:23, praveen malviya wrote:
>
>
> On 10-Mar-16 5:31 PM, minh chau wrote:
>> To clarify my doubts: These sg fsm code are working in non-headless in
>> the way it prevents user issue a new admin op while the previous admin
>> op has been in progress, beca
Hi Nagu, Praveen
Since #1-#4 have been acked, can you please push them?
#5 and #11_2 allows comp/su failover during headless, so we may have to
visit them later.
However, the patches: #9 #10 #11_1 #12 #13 are bug fixes that does not
relate to *delayed failover* and needed for #1-#4. Can you plea
t add even more thread related issues.
>
> Thanks
> Lennart
>
>> -Original Message-
>> From: Minh Hon Chau [mailto:minh.c...@dektech.com.au]
>> Sent: den 14 mars 2016 03:08
>> To: Lennart Lund; praveen.malv...@oracle.com; Vu Minh Nguyen; Minh
>> Chau
er_list declared in ntfa_cb_t structure seems
not being used at all. I think refactoring object orientation would give
a support to the idea of implementation of cb handler as above.
If this sounds right to you, there seems to be some things to do
>
> Thanks
> Lennart
>
>
t; -----Original Message-
>> From: Minh Chau H
>> Sent: den 16 mars 2016 15:58
>> To: Lennart Lund; praveen.malv...@oracle.com; Vu Minh Nguyen
>> Cc: opensaf-devel@lists.sourceforge.net; Anders Widell; Minh Chau H
>> Subject: Re: [PATCH 2 of 5] NTF: Add su
Hi Praveen, Vu
Any comment on V3?
Thanks,
Minh
On 18/03/16 19:01, Lennart Lund wrote:
> Hi Minh
>
> Ack, sorry for beeing a bit unclear
>
> Thanks
> Lennart
>
>> -Original Message-
>> From: minh chau [mailto:minh.c...@dektech.com.au]
>> Sent: den
Hi Nagu,
Please see my comment inline
Thanks,
Minh
On 21/03/16 20:48, Nagendra Kumar wrote:
>
> TC #9 and TC #10: Configuration is SC-1, PL-3 and PL-4. SU1(Act) on
> PL-3 and SU2(Std) on PL-4.
> Stop controller and then stop PL-3, start PL-3 and start controller.
> SU2 will be Act and SU1 will
Ack with minor comment:
In first page, do we need to update " Release 4.7 Programmer's Reference
October 2015"?
Thanks,
Minh
On 07/04/16 16:12, praveen malviya wrote:
> Hi All,
>
> Please find attached AMF PR doc updated for #1533.
> Only one minor change is done in section 2.2.10.1 Scope of Adm
Ack from me
Thanks,
Minh
On 07/04/16 13:53, Gary Lee wrote:
> osaf/services/saf/amf/amfnd/pg.cc | 18 ++
> 1 files changed, 18 insertions(+), 0 deletions(-)
>
>
> return TRY_AGAIN for saAmfProtectionGroupTrack and
> saAmfProtectionGroupTrackStop
> while headless, since protec
Hi Praveen,
I see the latest ntfa_api.c code does not reserve SA_AIS_ERR_UNAVAILABLE
when recovery client/reader/subscriber failed due to non-SA_AIS_OK rc in
returned msg. Can you check whether this V2 was pushed?
Thanks,
Minh
On 29/03/16 20:02, praveen.malv...@oracle.com wrote:
> osaf/libs/a
Hi,
Ack with comments:
- The statement of 5) seems to be included in 2), maybe can combine 2)
and 5)
- Since ERR_UNAVAILABLE could be returned in A.02.01, PR doc should
recommend what's client's behavior when receiving this error code, eg.
try API again since node has not joined cluster, or ...
Hi Praveen
Please see comments inline
Thanks,
Minh
On 11/04/16 16:13, praveen malviya wrote:
>
> On 07-Apr-16 7:17 PM, Minh Hon Chau wrote:
>> osaf/services/saf/amf/amfnd/su.cc | 5 -
>> 1 files changed, 0 insertions(+), 5 deletions(-)
>>
>>
>> Currently avnd_su_curr_info_del() is called
ld be executed as
instance of consumer (subscriber, reader) or producer (sender)/
How does this sound to you?
/
/Thanks,
Minh/
/
On 11/04/16 21:49, Lennart Lund wrote:
>
> Hi Minh
>
> I still have some comment. Please see attached document
>
> Thanks
>
> Lennart
>
&
Hi Praveen
NTF server also accepts initialize request (and here it comes from
reinitializeClient() after headless) if NTF server has not initialized
with CLM.
So after headless, this situation will most likely happen. The recovery
would succeeds, but after that what if NTF server notifies the a
On 12/04/16 21:49, praveen malviya wrote:
>
>
> On 12-Apr-16 3:56 PM, minh chau wrote:
>> Hi Praveen
>>
>> NTF server also accepts initialize request (and here it comes from
>> reinitializeClient() after headless) if NTF server has not initialized
>&g
On 13/04/16 15:43, praveen malviya wrote:
>
>
> On 12-Apr-16 10:24 PM, minh chau wrote:
>>
>>
>> On 12/04/16 21:49, praveen malviya wrote:
>>>
>>>
>>> On 12-Apr-16 3:56 PM, minh chau wrote:
>>>> Hi Praveen
>>&g
case, and that
should be documented.
Thanks,
Minh
On 14/04/16 07:01, minh chau wrote:
>
>
> On 13/04/16 15:43, praveen malviya wrote:
>>
>>
>> On 12-Apr-16 10:24 PM, minh chau wrote:
>>>
>>>
>>> On 12/04/16 21:49, praveen malviya wrote
y on CLM indication or b)when we have more
> clarity on CLM status of nodes during headless.
>
> Attached patch in on top of #1744 patch and it fixes ntfsubscribe also
> to call saNTfFinalise() and exit on receiving ERR_UNAVAILABLE.I would
> like to push 1744 before RC2.
>
&
Tested the patch, ack with minor comment, please see inline
Thanks,
Minh
On 22/04/16 19:36, praveen.malv...@oracle.com wrote:
> osaf/services/saf/amf/amfnd/clc.cc| 85
> ++-
> osaf/services/saf/amf/amfnd/include/avnd_su.h | 1 +
> osaf/services/saf/amf/a
e used in comp FSM as the current COMPCSI will be marked
> RESTARTING in comp_restart_init() very lately. At most for comp FSM ,
> the for loop in discussion can be moved in a function like
> all_csis_in_restarting_execpt_given(su, csi).
>
> Thanks,
> Praveen
>
> On 26-Apr-16 3
Ack from me
Thanks,
Minh
On 27/04/16 16:17, praveen.malv...@oracle.com wrote:
> osaf/services/saf/amf/amfnd/clc.cc| 73
> ++-
> osaf/services/saf/amf/amfnd/include/avnd_su.h | 2 +
> osaf/services/saf/amf/amfnd/susm.cc | 10 ++-
> 3 files cha
Hi,
#1719 set milestone for GA, can you please review it?
Thanks
Minh
On 16/04/16 22:01, opensaf-devel-requ...@lists.sourceforge.net wrote:
> Message: 8
> Date: Thu, 07 Apr 2016 11:35:50 +1000
> From: Minh Hon Chau
> Subject: [devel] [PATCH 1 of 1] AMFND: Resend pg information after
> head
Hi Praveen,
Yes this is problem that agent coming up during failover, the server
state then set as NTFA_NTFSV_NEW_ACTIVE. At this state, server state
will never set to NTFA_NTFSV_UP because the implementation treats
NTFA_NTFSV_NEW_ACTIVE as NTFA_NTFSV_UP, since at both of those states
NTF serv
Hi Lennart,
I don't know how to test this, probably repeatedly sending notification
during failover.
The code is quite clear to see the only place that server state changes
to NTFA_NTFS_NEW_ACTIVE is at switch-case of NTFA_NTFS_NONE.
Can you please help to push this? This bug makes agent bad sta
Hi Praveen,
Please see comments in line.
Thanks,
Minh
On 13/05/16 17:17, praveen malviya wrote:
> Hi Minh,
>
> I am trying to understand the problem.
>
> As per these ntfd traces, in the down event at below at 3) ntfd clears
> the client data so subsequent requests for Unsubscribe() and
> Fina
ack
On 19/05/16 13:47, Nhat Pham wrote:
> osaf/services/saf/ntfsv/ntfs/NtfLogger.cc | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>
> During testing SC failover, the following ER log sometimes happens.
>
> ER Failed to log an alarm or security alarm notification (6)
>
> The seve
Hi Praveen,
I have tested the patch, it fixes the reported issue.
The problem seems to be a data race condition between thread handling
clc fsm and timer expiry thread which reset all variables of a su while
these variables have being used elsewhere in clc fsm. This race
condition should cause
Hi,
This patch was aimed to fix the problem in test of running multiple api
life cycle parallel. But now I realise there is still same problem due to
mailbox priority at ntfd side. I will have to check and refloat another
patch
Thanks,
Minh
>
>
> On 16-May-16 7:04 AM, minh chau wro
Ack from me with a *missing place* to be updated
Thanks,
Minh
On 23/05/16 16:52, praveen malviya wrote:
> Hi All,
>
> I would like to push this patch today.
> Please provide feedback.
>
> Thanks,
> Praveen
>
> On 20-May-16 2:07 PM, praveen malviya wrote:
>>
>&
Hi Nagu,
Ack from me, not tested because I could not reproduce.
Thanks,
Minh
On 01/06/16 22:32, nagendr...@oracle.com wrote:
> osaf/services/saf/amf/amfnd/chc.cc | 10 ++
> 1 files changed, 10 insertions(+), 0 deletions(-)
>
>
> If the component is not in instantiated state, then hc
Hi Lennart,
I'm not sure what the comment "fixme?" intended to fix, but it seems not
giving any information about the bug to be fixed, so I remove it
Please help to push the attached patch.
Thanks,
Minh
On 03/06/16 23:53, Lennart Lund wrote:
Ack
Review only.
Comment: Is the "/* fixme? */" c
Hi Praveen,
saAmfSUHostedByNode should be cold synced after headless. The
avd_process_state_info_queue() is called before active amfd creates
Opensaf-2N assignment for SCs. The standby assignment for Opensaf-2N on
standby controller includes RDE csi which then set node role as standby,
thus th
Hi Nagu,
Patch looks good.
Can we think an alternative that condition of calling
avd_process_state_info_queue() by checking node_state as
AVD_AVND_STATE_ABSENT, so that we don't have to introduce new static var?
Thanks,
Minh
On 23/06/16 20:45, nagendr...@oracle.com wrote:
> osaf/services/saf
safest.
>
> Thanks
> -Nagu
>> -Original Message-
>> From: minh chau [mailto:minh.c...@dektech.com.au]
>> Sent: 27 June 2016 07:42
>> To: Nagendra Kumar; hans.nordeb...@ericsson.com; Praveen Malviya;
>> gary@dektech.com.au
>> Cc: opensaf-devel@lists.sou
Hi Praveen,
NoRed MW allows locking SU only, and not allow locking SI, which means
to me if NoRed MW SUs are unlocked it must provide its services (SMFND,
IMMND, CPND, CLMNA)
I'm not sure whether this is a must-have requirement or not, since this
behavior has existed for long.
Thanks,
Minh
On
On 08/07/16 16:05, praveen malviya wrote:
>
>
> On 07-Jul-16 6:31 PM, minh chau wrote:
>> Hi Praveen,
>>
>> NoRed MW allows locking SU only, and not allow locking SI, which means
>> to me if NoRed MW SUs are unlocked it must provide its services (SMFND,
>&
Hi,
I think Praveen's comment on #1812 was worrying about amfd hanging when
init with CLM, this patch does not change position of CLM initialization
and also it's done in thread so it will be ok?
Regarding Anders' comment: I did quick test, lock clm on standby
controller and reboot it, when it
re-initialize them. But there
>>> is also a small possibility that a bug causes the handle to simply not
>>> work. A "fresh", newly initialized handle would be safer than a
>>> one-year
>>> old handle.
>>>
>>> Do you think
Hi Vu,
The patch looks good. Can I test this patch after #1315 is pushed? I run
into osaf_abort() for now.
Thanks,
Minh
On 22/07/16 21:16, Vu Minh Nguyen wrote:
> osaf/services/saf/ntfsv/ntfs/NtfLogger.cc | 51
> +++---
> 1 files changed, 13 insertions(+), 38 deleti
I mean "... no objection ..."
Thanks,
Minh
On 25/07/16 10:53, minh chau wrote:
> Hi,
>
> I have tried to reproduce the problem in #1781, when amfd in
> non-member node gets assigned role, amfd initializes CLM successfully.
> Only sfmd, cpkt got UNAVAILABLE from saClmCl
Hi Mathi,
I noticed that #1781 has moved the CLM init before amfd get assigned
role. Would you be happy if I change amfd to make it does CLM init when
it actually gets active/standby role?
Thanks,
Minh
On 25/07/16 11:25, minh chau wrote:
> I mean "... no objection ..."
>
Hi Praveen,
One comment with [Minh] in line.
Thanks,
Minh
On 01/08/16 17:22, Gary Lee wrote:
> Hi Praveen
>
> On 1/08/2016 4:29 PM, praveen malviya wrote:
>> Hi Gary, Long,
>>
>> Some comments/observations:
>> -In AMFD saAisNameBorrow() is used in logging and AMFND uses
>> osaf_extended_name_bo
Hi Praveen,
There's a bug in V1 at AMFD side, so I floated V2.
The change is commented in V2:
"
This V2 avoid AMFD crash if scAbsence is not configured.
V2's diff (from V1) is at avd_process_state_info_queue()
"
So latest patches are below:
[PATCH 0 of 2] Review Request for AMF: Support admin
Hi Praveen,
This patch has also fixed the coredump in the other tests are failing in
test report of #1725 part 1, which are 14, 64, 68, 84, 124, 128
In the above test cases, still get "ER avd_sg_su_oper_list_del: su not
found".
Can we change ER to WA?
Ack from me with this minor comment.
Thank
Hi Nagu,
Have you enabled IMM schema changes and adding these new attributes
before upgrade?
This could be tested in the same way as previous additional attributes
were introduced as before.
Thanks,
Minh
On 10/08/16 21:10, Nagendra Kumar wrote:
> Hi Minh,
>
> I was doing upgrade and downgrade,
Hi Nagu, Praveen,
Can you please give me comments if you have any so far, that would help
me revise some codes first while you can continue reviewing?
There are some changes in SG codes, I hope it doesn't break the SG's
existing logic.
Thanks,
Minh
On 05/08/16 07:20, Minh Hon Chau wrote:
> Sum
Hi Nagu,
I got this.
CXX osafamfd-sg_2n_fsm.o
CXX osafamfd-sg_nored_fsm.o
sg_2n_fsm.cc: In member function ‘virtual SaAisErrorT
SG_2N::si_swap(AVD_SI*, SaInvocationT)’:
sg_2n_fsm.cc:775:6: error: ‘cb’ was not declared in this scope
((cb->node_id_avd_other != 0) && (cb->other
Thanks Hans, I will correct it before push.
On 10/08/16 22:15, Hans Nordebäck wrote:
> Ack, code review only. The ticket no is incorrect in the subject should be
> #1894/Thanks HansN
>
> -Original Message-
> From: Minh Hon Chau [mailto:minh.c...@dektech.com.au]
> Sent: den 29 juni 2016 02
Hi Nagu,
I think I can just replace "cb" by "avd_cb", and testing the patch. Then
you can correct it later.
Thanks,
Minh
On 17/08/16 12:50, minh chau wrote:
> Hi Nagu,
>
> I got this.
>
> CXX osafamfd-sg_2n_fsm.o
> CXX osafamfd-sg_nored_fs
Ack from me (code review only)
Thanks,
Minh
On 17/08/16 16:39, Nagendra Kumar wrote:
> Hi Minh,
> Please change cb to avd_cb and then test. Sorry for the typo.
>
> Thanks
> -Nagu
>
>> -Original Message-
>> From: minh chau [mailto:minh.c...@dekt
Hi Praveen,
I attached them to ticket.
Thanks,
Minh
On 19/08/16 21:08, praveen malviya wrote:
> Hi Minh,
> All patches are not received.
> Please attached them in the ticket.
>
> Thanks,
> Praveen
>
> On 18-Aug-16 5:45 AM, Minh Hon Chau wrote:
>> osaf/services/saf/amf/amfd/include/sg.h | 4 +-
Hi Long, Praveen,
Regarding this TODO
+ if(notification) {
+// TODO (minhchau): memleak if notification is an array
+osaf_extended_name_free(¬ification->member.compName);
free(notification);
+ }
Client currently uses saAmfProtectionGroupNotificationFree_4(handle,
buff->notificati
cumented.
>
>
> Thanks,
> Praveen
>
>
> On 20-Aug-16 2:22 PM, minh chau wrote:
>> Hi Long, Praveen,
>>
>> Regarding this TODO
>> + if(notification) {
>> +// TODO (minhchau): memleak if notification is an array
>> + osaf_extended_name_free(¬if
> Since B.04.01 APIs are not fully implemented, agent copies from old
> type of structure to new type in ava_cpy_protection_group_ntf().
>
>
> Thanks,
> Praveen
>
> On 22-Aug-16 10:51 AM, minh chau wrote:
>> Hi Praveen,
>>
>> The problem with B.04.0
Hi Vu,
Ack from me (tested)
Thanks,
Minh
On 16/08/16 13:30, Vu Minh Nguyen wrote:
> Hi all,
>
> Do you have any comments on the updated patch (update test code)? Thanks.
>
> Regards, Vu
>
>> -Original Message-
>> From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au]
>> Sent: Thursday,
Hi Praveen,
One comment in line with [Minh]
Thanks
Minh
On 20/07/16 18:57, praveen.malv...@oracle.com wrote:
> osaf/services/saf/amf/amfd/include/sg.h | 1 +
> osaf/services/saf/amf/amfd/nodegroup.cc | 4 +-
> osaf/services/saf/amf/amfd/sg_npm_fsm.cc | 62
> ++
ith [Praveen]
>
> Thanks,
> Praveen
>
>
>
> On 23-Aug-16 5:53 AM, minh chau wrote:
>> Hi Praveen,
>>
>> One comment in line with [Minh]
>>
>> Thanks
>> Minh
>>
>> On 20/07/16 18:57, praveen.malv...@oracle.com wrote:
>>> osaf/servic
em is coming.
> But still all longdn patches can be pushed and this discussion can
> continue.
>
> What do you think?
>
>
> Thanks,
> praveen
>
>
>
> On 22-Aug-16 12:08 PM, minh chau wrote:
>> Hi Praveen,
>>
>> The case you just mentioned is stil
Hi Nagu,
Please use the patches attached to ticket to test, there are many
changes from the version you are testing.
https://sourceforge.net/p/opensaf/tickets/_discuss/thread/7b203666/ad7f/attachment/1725_phase_1.tgz
It's a rebased longDN version, so you will not have to tested again
I just tes
Hi Praveen,
I will use them for test.
Thanks,
Minh
On 23/08/16 16:58, praveen malviya wrote:
> Hi Minh,
>
> I have attached patches for #1454 and #1608 in the ticket #1454.
> Please apply them in order.
>
> Thanks,
> Praveen
>
> On 23-Aug-16 11:56 AM, minh chau wrote:
Hi Nagu,
I see in the trace you provided, the SU2/SU3 become IN_SERVICE late. If
there's a delay in PL4 joining cluster after headless in your test then
you could also see it in the latest patches (longDN rebased version)
I'm looking in to this issue.
Thanks.
Minh
On 23/08/16 20:24, Nagendra K
arts some timer (larger value
among cluster timer and node sync timer) on receiving AMFD up and on
expiry of this timer sends the buffered assignment message.
Thanks,
Praveen
Thanks,
Praveen
On 23-Aug-16 4:33 PM, minh chau wrote:
Hi Nagu,
I see in the trace you provided, the SU2/SU3 become IN_SERV
etails of what you would like to log.
Thanks,
Praveen
-
On 23/08/16 21:03, minh chau wrote:
> Hi Nagu,
>
> I see in the trace you provided, the SU2/SU3 become IN_SERVICE late.
> If there's a delay in PL4 joining cluster after headless in your test
> then you could also see
inh,
>
> Please see responses with [Praveen].
>
>
> Thanks,
> Praveen
>
> On 23-Aug-16 7:18 PM, minh chau wrote:
>> Hi Praveen,
>>
>> Please let me copy your questions and answer here in email, so it's
>> easier we can add c
ent way. I think we
could also see this kind of problem in future.
Thanks,
Minh
On 23/08/16 16:58, praveen malviya wrote:
> Hi Minh,
>
> I have attached patches for #1454 and #1608 in the ticket #1454.
> Please apply them in order.
>
> Thanks,
> Praveen
>
> On 23-Au
Hi Nagu,
Can you please apply the below patch on top of
1725_02_V2_bugfix_resend_buffer_in_set_leds.diff?
In your test, PL3 get set_leds, but PL-4 has not, so SU2 can not respond
su_si msg.
@Praveen: Thanks for you help, I guess SU2 need to be ready to send
su_si msg at the same as SU1.
diff
Hi Nagu,
Second thought, Praveen's one is better I think. You can try with his patch.
Thanks
Minh
On 24/08/16 22:21, minh chau wrote:
> Hi Nagu,
>
> Can you please apply the below patch on top of
> 1725_02_V2_bugfix_resend_buffer_in_set_leds.diff?
> In your test, PL3 get se
Hi Vu,
Ack from me for PR doc.
I see this limitation still documented in README, but I think it's just
fine to be there (under 4.5). You can also make another paragraph to say
it's removed in 5.1.
I'm ok with both, since nothing is interesting in 5.1 to say.
Thanks,
Minh
On 25/08/16 12:39, Vu
Hi Praveen,
I think we need to come back a bit to non-headless feature.
The cluster init timer expiry ensures all nodes having MW SUs assigned
and node state are PRESENT. It's the unique entry point to non-ncs SU
assignment phase.
We also need to keep this principle in headless for #1725.
...
Hi,
The test failed because two reasons:
1. There are two places that nodegroup operation borrows 2N SG FSM, but
the AdminState of SG is not stored to IMM
saAmfSGAdminState = ng->saAmfNGAdminState;
...
su->sg_of_su->saAmfSGAdminState = SA_AMF_ADMIN_UNLOCKED;
This setting needs to
inalize() call to release all the resources.
>
> I think as of now please go ahead with your suggested solution. From
> finalize perspective this is a defect and applicable to all the
> branches. So please raise a ticket for that.
>
> Thanks,
> Praveen
>
>
> On 22
s,
> Praveen
>
>
>
> On 26-Aug-16 7:35 AM, minh chau wrote:
>> Hi Praveen,
>>
>> Just to confirm if I understand correctly the problem you mentioned in
>> saAmfFinalize(). As the specification says application should call
>> free()/Free_4() to release
s_su_si_response_for_ng() is for tracking the state of admin
> operation so that AMFD replies to IMM for admin operation and this is
> not required after headless state.
>
> I think problem is not that much complex as it is valid for only 2N
> models and only in case a).
>
>
Hi Nagu,
Thanks for your time to verify the patches.
Yes, versioning changes for AMFD-AMFD is not required, I will remove it
before push
Thanks,
Minh
On 26/08/16 22:13, Nagendra Kumar wrote:
> Hi Minh,
> Ack for patches (1725_01_V5_intro_new_rta_states_longDn.diff,
> 1725_02_V2_resend_su
1 - 100 of 470 matches
Mail list logo
