Hi Mahesh,
SaLogFilterSetCallbackT was already declared before . So we don't have to
add more one header file.
Regards
Canh
-Original Message-
From: Canh Truong [mailto:canh.v.tru...@dektech.com.au]
Sent: Tuesday, February 21, 2017 4:41 PM
To: 'A V Mahesh'; 'lennart.l...@ericsson.com
/ for version handling.
Regards
Canh
-Original Message-
From: A V Mahesh [mailto:mahesh.va...@oracle.com]
Sent: Tuesday, February 21, 2017 4:31 PM
To: Canh Truong; lennart.l...@ericsson.com; vu.m.ngu...@dektech.com.au
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH 0 of 3] Review
Hi Vu,
Please see some my comments with [Canh]
Regards
Canh
-Original Message-
From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au]
Sent: Thursday, February 16, 2017 5:30 PM
To: lennart.l...@ericsson.com; mahesh.va...@oracle.com;
canh.v.tru...@dektech.com.au
Cc:
Hi Mahesh,
The test case " logtest 1 10" and " logtest 1 11" are created for version
handling. In standby node, it has new code for log agent (with #2146), that
means that version handling in log agent have been added.
The log agent check if minor version bigger than the agent support, it will
Hi aMinh,
NTFS has already re-assigned length of buffer to MAX_ADDITIONAL_TEXT_LENGTH
if it is exceeds to MAX_ADDITIONAL_TEXT_LENGTH.
So we don't need to add any more for this check.
Regards
Canh
-Original Message-
From: minh chau [mailto:minh.c...@dektech.com.au]
Sent: Wednesday,
Hi Lennart,
Thanks for your comments.
As I understand you mean that the agent shall send to the server with the
minor version that is initialized with client [in minor version] , except if
minor = 0, it will be set to 1. But as section of 3.5.1 AIS document "
minorVersion = highest value of
Hi Mahesh,
Could you explain more clear about this?
The first ` if (*stream->p_fd == -1) {` is to avoid closing and rename log
file if file descriptor is -1.
The second is checked if open log if open log file fail.
Regards
Canh
-Original Message-
From: A V Mahesh
Hi Praveen,
When app do saNtfInitialize(), the ntfa will send initialized message with
normal priority (MDS_SEND_PRIORITY_MEDIUM = 2) to NTFS. NTFS pick this
message up in mds callback and put to mbx with same priority . if app is
dead suddenly after initializing, NTFS will receive both
Hi Lennart,
I already did the upgrade test as your below and it was passed from my side.
I will check and run all test again
Regards,
Canh
-Original Message-
From: Lennart Lund [mailto:lennart.l...@ericsson.com]
Sent: Tuesday, November 15, 2016 11:16 PM
To: Canh Van Truong; Vu Minh
Thanks Lennart,
I will check these functions and move some of them if needed.
Regards,
Canh
-Original Message-
From: Lennart Lund [mailto:lennart.l...@ericsson.com]
Sent: Thursday, October 13, 2016 5:38 PM
To: Canh Van Truong; mahesh.va...@oracle.com; Vu Minh Nguyen
Cc:
Thanks Lennart,
I will add this before pushing code.
Regards,
Canh.
-Original Message-
From: Lennart Lund [mailto:lennart.l...@ericsson.com]
Sent: Tuesday, October 11, 2016 8:51 PM
To: Canh Van Truong; Vu Minh Nguyen; mahesh.va...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Hi Praveen,
What I understand about deadlock as below:
When other API and saNtfFinalize() called in parallel, both take the
ntfhandle by ncshm_take_hdl(), the cell->use_ct increase
(and > 1). The saNtfFinalize() call ncshm_destroy_hdl() to destroy
ntfhandle, but ncshm_destroy_hdl() will check
Hi Praveen,
The problem is not always happen. After #1818 is fixed, it's still happen
sometimes. I cannot reproduce this problem, just have trace log (attached
here: https://sourceforge.net/p/opensaf/tickets/1895/).
The test case in this patch may not reproduce the problem. It just proves
that
Hi Mahesh,
I run cppcheck with latest version 1.75. I got from:
https://sourceforge.net/projects/cppcheck/files/cppcheck/1.75/
And build, then run with option --enable=performance.
Regards,
Canh.
-Original Message-
From: A V Mahesh [mailto:mahesh.va...@oracle.com]
Sent: Thursday,
Hi Mahesh,
Please see my comment inline.
Regards,
Canh.
-Original Message-
From: A V Mahesh [mailto:mahesh.va...@oracle.com]
Sent: Thursday, September 01, 2016 10:59 AM
To: Canh Van Truong; vu.m.ngu...@dektech.com.au; lennart.l...@ericsson.com
Cc: opensaf-devel@lists.sourceforge.net
opensaf-devel@lists.sourceforge.net
> Subject: Re: [PATCH 1 of 1] log: fix issue with priority of messages
> adding to mailbox in the server[1396]
>
> Hi Canh,
>
> It seems Lennart already provide comments please check.
>
> -AVM
>
>
> On 6/21/2016 12:07 PM,
]
Sent: Tuesday, June 21, 2016 11:47 AM
To: Canh Truong; vu.m.ngu...@dektech.com.au; lennart.l...@ericsson.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1 of 1] log: fix issue with priority of messages adding to
mailbox in the server[1396]
Hi Canh,
It will be good to send V2 patch
Hi Mahesh,
I have created new test case for multiple threads. Please help check new
patch in attachment.
Thanks,
Canh.
-Original Message-
From: A V Mahesh [mailto:mahesh.va...@oracle.com]
Sent: Tuesday, June 14, 2016 11:03 AM
To: Canh Van Truong; vu.m.ngu...@dektech.com.au;
n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
<>
changeset 7214b787efa1088e407c89b016d0d16f30254c1a
Author: Canh Truong <canh.v.tru...@dektech.com.au>
Date: Wed, 16 M
osaf/services/saf/logsv/lgs/lgs_evt.cc| 6 ++
osaf/services/saf/logsv/lgs/lgs_imm.cc| 7 ++-
osaf/services/saf/logsv/lgs/lgs_stream.cc | 12 +
osaf/services/saf/logsv/lgs/lgs_stream.h | 1 +
tests/logsv/tet_LogOiOps.c| 74 +++
Tests n
Other n
Comments (indicate scope for each "y" above):
-
<>
changeset ba42ccf646021ea8b705b451431999d6fe4d77d7
Author: Canh Truong <canh.v.tru...@dektech.com.au>
Date: Tue, 16 F
21 matches
Mail list logo
