Hi Gary
ACK (not tested)
Regards
Canh
-Original Message-
From: Gary Lee
Sent: Tuesday, July 9, 2019 1:21 PM
To: canh.v.tru...@dektech.com.au; minh.c...@dektech.com.au;
hans.nordeb...@ericsson.com
Cc: opensaf-devel@lists.sourceforge.net; Gary Lee
Subject: [PATCH 0/4] Review Request
Hi Gary
I have 2 comments bellow.
Regards
Canh
-Original Message-
From: Gary Lee
Sent: Wednesday, July 3, 2019 1:27 PM
To: hans.nordeb...@ericsson.com; minh.c...@dektech.com.au
Cc: opensaf-devel@lists.sourceforge.net
Subject: [devel] [PATCH 2/3] fmd: add active promotion
-type f -mmin -1 | egrep
'verRotatedFile.*\.[log$\|cfg$]' | wc -l | awk '{printf $1}')
Regards
Canh
From: Lennart Lund
Sent: Friday, June 28, 2019 10:26 PM
To: Canh Van Truong ; Vu Minh Nguyen
Cc: opensaf-devel@lists.sourceforge.net
Subject: Sv: [PATCH 0/1] Review Request for log: Update the
ERIES HERE ***
revision 9bcab8d44653a03463d9c32f3df20390709415aa
Author: Canh Van Truong
Date: Mon, 1 Jul 2019 16:36:49 +0700
log: Update the try again for admin operation [#3056]
The logtest 6 49 and logtest 6 50 failed because the admin
operation fail due to closing log file timeout.
Upd
The logtest 6 49 and logtest 6 50 failed because the admin
operation fail due to closing log file timeout.
Update to try again the command admin operation in test cases
---
src/log/apitest/tet_LogOiOps.c | 176 +++--
1 file changed, 101 insertions(+), 75
Hi Lennart
I will do it before pushing
Thanks
Canh
From: Lennart Lund
Sent: Thursday, June 27, 2019 6:50 PM
To: Canh Van Truong ; Vu Minh Nguyen
Cc: opensaf-devel@lists.sourceforge.net; Karin Holm
; Lennart Lund
Subject: RE: Review request log: document for ticket #3022 and #3046
ERIES HERE ***
revision 7659200d2bd20d96d0dbfff6f583be478f9a6429
Author: Canh Van Truong
Date: Thu, 27 Jun 2019 13:19:48 +0700
log: Update the try again for admin operation [#3056]
The logtest 6 49 and logtest 6 50 failed because the admin
operation fail due to closing log file timeout.
Upd
The logtest 6 49 and logtest 6 50 failed because the admin
operation fail due to closing log file timeout.
Update to try again the command admin operation in test cases
---
src/log/apitest/tet_LogOiOps.c | 54 ++
1 file changed, 34 insertions(+), 20
Thanks Lennart
Please see my reply as [xcantru].
Regards
Canh
From: Lennart Lund
Sent: Tuesday, June 25, 2019 9:53 PM
To: Canh Van Truong ; Vu Minh Nguyen
Cc: opensaf-devel@lists.sourceforge.net; Karin Holm
Subject: RE: Review request log: document for ticket #3022 and #3046
Hi Lennart
Sorry for missing information of document ticket number. I created the
ticket #3052 for this.
Thanks
Canh
From: Lennart Lund
Sent: Wednesday, June 19, 2019 8:15 PM
To: Canh Van Truong ; Vu Minh Nguyen
Cc: opensaf-devel@lists.sourceforge.net; Karin Holm
; Lennart Lund
Update the document because of the ticket #3022 and #3046
Document with recorded changes attached. Activate "Show Changes" to see
them [Edit/Track Changes/Show Changes]
The section is updated: 3.3.8 in PR document
Regards
Canh
OpenSAF_LOGSv_PR.odt
Description:
uot; above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision 6967d779c50c95324a32fa50790ddb44f944433f
Author: Canh Van Truong
Date: Fri, 14 Jun 2019 18:46:32 +0700
log: Delete the older file without closing current log file via admin operation
[#3046]
Improve the enhancement of ticket #3022
Thanks Lennart
Please see my reply comments and the updated patch in attachment
Thanks
Canh
From: Lennart Lund
Sent: Thursday, June 13, 2019 11:02 PM
To: Canh Van Truong ; Vu Minh Nguyen
Cc: opensaf-devel@lists.sourceforge.net
Subject: Sv: [PATCH 1/1] log: Delete the older file
Improve the enhancement of ticket #3022, the user can rotate (delete) older log
files without closing current log file.
LOG add new parameter (numberOfFilesToRemove) to admin op command with id = 2.
- If parameter exists, LOGD remove number of older file base on parameter value
- If parameter
uot; above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision de4381569c8155b30c095305a77c4360dd772557
Author: Canh Van Truong
Date: Thu, 13 Jun 2019 18:31:52 +0700
log: Delete the older file without closing current log file via admin operation
[#3046]
Improve the enhancement of ticket #3022
IN/COMMENT THE PATCH SERIES HERE ***
revision 811194853343b4ae7de9ae4f671849fdacc15abe
Author: Canh Van Truong
Date: Mon, 3 Jun 2019 17:48:45 +0700
log: Delete the older file without closing current log file [#3046]
Improve the enhancement of ticket #3022, the user can rotate (delete) older log
fil
Improve the enhancement of ticket #3022, the user can rotate (delete) older log
files without closing current log file.
LOG add new parameter(optional) to admin op command with id = 2.
- If parameter exists, LOGD rotates log file without closing current log file
- If parameter is omitted, LOGD
THE PATCH SERIES HERE ***
revision 2a9afe2cc3bc03fdb2b358fb795f16f2b8088a27
Author: Canh Van Truong
Date: Thu, 30 May 2019 11:18:18 +0700
log: fix to remove the cfg file when log file rotation [#3045]
If the date(include year, month and day) in oldest cfg file name and the
date of created oldes
If the date(include year, month and day) in oldest cfg file name and the
date of created oldest log file is different, logd cannot find out the
oldest cfg file. The oldest cfg file is never removed when log file rotation.
So number of cfg file is huge after time while the log file has already been
Sometimes etcd server take long time to handle the request and command "etcdctl
get"
will be timeout. Consensus understands that etcd may be downed and need to
self-fence event though etcd server is handling the request.
The "etcdctl get" command in "watch" should be do the retries and the dial
"y" above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision 53694b66ce17c25e55fe87bc5aace94794325744
Author: Canh Van Truong
Date: Fri, 24 May 2019 14:35:13 +0700
osaf: fix lost connectivity of consensus during "get" command t
uot; above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision 1c9e4d8aaabd4df6f3e00b9699a0362fda463ae7
Author: Canh Van Truong
Date: Tue, 16 Apr 2019 14:54:10 +0700
log: Log enhance to rotate log file via admin operation [#3022]
In some cases the Users want to rotat
In some cases the Users want to rotate log file at the time althouth
the file size hasn't been reached MAX FILE SIZE. Log service provides the
new feature that user can rotate log file via admin operation.
---
src/ais/include/saLog.h| 3 +-
src/log/apitest/tet_LogOiOps.c | 76
Thanks Lennart,
Please my comments.
Regards
Canh
From: Lennart Lund
Sent: Tuesday, March 26, 2019 3:41 PM
To: Canh Van Truong ; Vu Minh Nguyen
Cc: opensaf-devel@lists.sourceforge.net; Lennart Lund
Subject: RE: [PATCH 1/1] log: logd crash due to well known stream has
numOpeners = 0
oot" list does not have that stream. So
if my thinking is correct, that case won't cause the issue happen ?
There is already a log ER if ckpt fail "LOG_ER("%s: MBCSV send FAILED
rc=%u.", __FUNCTION__, rc);"
Thanks
Canh
From: Lennart Lund
Sent: Friday, March 22, 2019 7:40
ned. Standby node up to active will close that well known
stream 2 times with numOpeners = 2. Then numOpeners will be zero for the
well known stream.
I don't see any more hint that cause the issue happen.
Regards
Canh
From: Vu Minh Nguyen
Sent: Monday, March 18, 2019 2:14 PM
To:
When the stream is created, the numOpeners is not initialized and
may be started with unexpected value (e.g max value of unsigned int32).
It is not correct. That may cause when client close the well known stream
and numOpeners may be 0. The crash happens.
The "numOpeners" should be initialized
IN/COMMENT THE PATCH SERIES HERE ***
revision 47976ac471b11624b2c7e2a62dcd702baa21840a
Author: Canh Van Truong
Date: Thu, 14 Mar 2019 18:19:58 +0700
log: logd crash due to well known stream has numOpeners = 0 [#3018]
When the stream is created, the numOpeners is not initialized and
may
Hi Khanh,
Ack (review only)
Regards
Canh
-Original Message-
From: khanh.h.dang
Sent: Thursday, February 21, 2019 9:46 AM
To: canh.v.tru...@dektech.com.au
Cc: opensaf-devel@lists.sourceforge.net; khanh.h.dang
Subject: [PATCH 1/1] log: Allow hyphen character "-" in trace file name
During cluster start, one node (node 1) broadcast up msg to other node. The
remote node (node 2) get this msg and send the connection to node 1 (connect()).
Similarly node 1 send the connection to node 2 after node 2 broadcast up msg
to.
Beside of node 2 connect() to node 1, node 2 also add the
uot; above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision 8ce7c2e43ebebdf3adb2dcfd24ea2bd95c28cbc4
Author: Canh Van Truong
Date: Thu, 7 Mar 2019 17:33:51 +0700
dtm: Fix dtm close socket due to duplication of adding node IP info [#2984]
During cluster start, one node (node 1) broadcast up ms
will send the new after patch test ran.
Regards
Canh
-Original Message-
From: Gary Lee
Sent: Thursday, March 7, 2019 6:58 AM
To: Hans Nordebäck ; Canh Van Truong
; Anders Widell ;
Minh Hon Chau
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/1] dtm: Fix dtm close socket due
When using the command "immcfg logConfig=1,safApp=safLogService -a
logRecordDestinationConfiguration-="
If there is just one value in the multi attribute and we delete last one, the
value
will be deleted in imm database but it is not deleted in LGD.
The patch update the attribute
uot; above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision 1e3620686bcea3ade971a7577b8e9f004bc345d3
Author: Canh Van Truong
Date: Fri, 1 Mar 2019 16:55:59 +0700
log: Fix the last value of logRecordDestinationConfiguration is not deleted
[#3014]
When using the command "immcfg log
Add Minh and Ander
-Original Message-
From: khanh.h.dang
Sent: Thursday, February 21, 2019 9:46 AM
To: canh.v.tru...@dektech.com.au
Cc: opensaf-devel@lists.sourceforge.net; khanh.h.dang
Subject: [PATCH 1/1] log: Allow hyphen character "-" in trace file name
[#3009]
Allow hyphen
Hi aVu
Ack. Legacy test passed
Thanks
Canh
-Original Message-
From: Vu Minh Nguyen
Sent: Thursday, January 24, 2019 5:15 PM
To: lennart.l...@ericsson.com; canh.v.tru...@dektech.com.au
Cc: opensaf-devel@lists.sourceforge.net; Vu Minh Nguyen
Subject: [PATCH 1/1] log: fix coredump at
uot; above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision f6e0dcddacda062913b8856296e0bfb22240950d
Author: Canh Van Truong
Date: Thu, 24 Jan 2019 13:30:14 +0700
ntf: Fix to NTFD doesn't send the response if MDS_DEST of client is
disconnected [#2973]
When the sending notification re
When the sending notification request come to NTFD , they are put in the mbx
to wait for being processed. if client of these request is down (MDS_DEST of
this client
is disconnected), MDS thread receive the event down and also put to mbx. The
priority
of event down and send request are the same.
Thanks Lennart
I have updated your comments. If no more comments, the document will be
pushed.
Regards
Canh
From: Lennart Lund
Sent: Friday, January 18, 2019 3:32 PM
To: Canh Van Truong ; Minh Hon Chau
Cc: opensaf-devel@lists.sourceforge.net; Lennart Lund
Subject: RE: Review
Hi all
Please help look at this ticket.
Thanks
Canh
-Original Message-
From: Canh Van Truong
Sent: Tuesday, December 18, 2018 2:25 PM
To: anders.wid...@ericsson.com; hans.nordeb...@ericsson.com;
gary@dektech.com.au; minh.c...@dektech.com.au
Cc: opensaf-devel@lists.sourceforge.net
Hi aMinh
I have updated your comments. Please help check and push the document if
there are no more comments.
Thanks
Canh
From: Minh Hon Chau
Sent: Friday, January 18, 2019 7:25 AM
To: Lennart Lund ; Canh Van Truong
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: Review
Hi Lennart
Yes, I add new column for "Default value".
Regards
Canh
From: Lennart Lund
Sent: Friday, January 11, 2019 5:33 PM
To: Canh Van Truong ; Minh Hon Chau
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: Review request ntf: update document for limit of logger buf
Thanks Lennart,
I have updated with your comments.
Please give the comments if there is something need to be updated.
Regards
Canh
From: Lennart Lund
Sent: Thursday, January 10, 2019 9:07 PM
To: Canh Van Truong ; Minh Hon Chau
Cc: opensaf-devel@lists.sourceforge.net
Subject
Update the document because of the ticket #2961
ntf: Limit the logger buffer [#2961]
Document with recorded changes attached. Activate "Show Changes" to see
them [Edit/Track Changes/Show Changes]
Thanks
Canh
OpenSAF_NTFSv_PR.odt
Description:
: Lennart Lund
Sent: Wednesday, January 9, 2019 6:38 PM
To: Canh Van Truong ; Minh Hon Chau
Cc: opensaf-devel@lists.sourceforge.net
Subject: SV: [PATCH 1/2] ntf: Limit the logger buffer [#2961]
Hi Canh
Ack for "ntf: Limit the logger buffer" commit with some comments. See
[Lenn
ntfsend is blocked in case TRY_AGAIN error. It should do the retry in
limit time.
---
src/ntf/tools/ntfclient.c | 75 ---
src/ntf/tools/ntfsend.c | 240 +++---
2 files changed, 120 insertions(+), 195 deletions(-)
diff --git
revision 2d825d47b278c76fb010fec5380e99b2e6d5f875
Author: Canh Van Truong
Date: Wed, 9 Jan 2019 15:51:41 +0700
ntf: Update TRY_AGAIN error in ntfsend tool [#2961]
ntfsend is blocked in case TRY_AGAIN error. It should do the retry in
limit time.
revision 19ca9bcf42b68044dfabe1bde3a2a992c0e41d88
Author: Canh Van Truong
D
When writing the notificaion fail with TRY_AGAIN in callback, the notificaion
is pushed
again to the list. If this happens for long time, the list is going to be very
big.
This cause NTFD take time to process writing all the notification in the list
and
the request from NTFA come this time may
revision ee3a78c078ef68b428936d3daf5e4f990020a4b3
Author: Canh Van Truong
Date: Mon, 7 Jan 2019 14:12:37 +0700
ntf: Update TRY_AGAIN error in ntfsend tool [#2961]
ntfsend is blocked in case TRY_AGAIN error. It should do the retry in
limit time.
revision e4fb2e054b091fde815d448a674985efdaeb9840
Author: Canh Van Truong
D
When writing the notificaion fail with TRY_AGAIN in callback, the notificaion
is pushed
again to the list. If this happens for long time, the list is going to be very
big.
This cause NTFD take time to process writing all the notification in the list
and
the request from NTFA come this time may
ntfsend is blocked in case TRY_AGAIN error. It should do the retry in
limit time.
---
src/ntf/tools/ntfclient.c | 75 ---
src/ntf/tools/ntfsend.c | 240 +++---
2 files changed, 120 insertions(+), 195 deletions(-)
diff --git
revision 14d81a9e0644b49bbc03dcccd46b6ec9bce28011
Author: Canh Van Truong
Date: Thu, 27 Dec 2018 14:42:09 +0700
log: Update level of printout info in syslog from ER to WA [#2990]
Complete diffstat:
--
src/log/logd/lgs_evt.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Testin
---
src/log/logd/lgs_evt.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/log/logd/lgs_evt.cc b/src/log/logd/lgs_evt.cc
index 589cb262b..35d939a4b 100644
--- a/src/log/logd/lgs_evt.cc
+++ b/src/log/logd/lgs_evt.cc
@@ -1523,7 +1523,7 @@ static uint32_t
During cluster start, one node (node 1) broadcast up msg to other node. The
remote node (node 2) get this msg and send the connection to node 1 (connect()).
Similarly node 1 send the connection to node 2 after node 2 broadcast up msg
to.
Beside of node 2 connect() to node 1, node 2 also add the
uot; above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision 031c6cd11485c103c8faab901eff5f6f36b02c3f
Author: Canh Van Truong
Date: Tue, 18 Dec 2018 14:03:26 +0700
dtm: Fix dtm close socket due to duplication of adding node IP info [#2984]
During cluster start, one node (node 1) broadcast up ms
uot; above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision 1e17f7da43db9adc2368aae7ba88e734bc7ea4ec
Author: Canh Van Truong
Date: Tue, 18 Dec 2018 11:29:34 +0700
dtm: Fix dtm close socket due to duplication of adding node IP info [#2984]
During cluster start, one node (node 1) broadcast up ms
During cluster start, one node (node 1) broadcast up msg to other node. The
remote node (node 2) get this msg and send the connection to node 1 (connect()).
Similarly node 1 send the connection to node 2 after node 2 broadcast up msg
to.
Beside of node 2 connect() to node 1, node 2 also add the
uot; above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision 23cce2069f4c711ddbb004e2c0eb1c2aea33a89f
Author: Canh Van Truong
Date: Thu, 6 Dec 2018 14:55:03 +0700
ntf: fix to limit the retry when writing notificaion to log file fail with
TRY_AGAIN [#2961]
When writing the notifi
When writing the notificaion fail with TRY_AGAIN in callback, the notificaion
is pushed
again to the list. If this happens for long time, the list is going to be very
big.
This cause NTFD take time to process writing all the notification in the list
and
the request from NTFA come this time may
When the sending notification request come to NTFD , they are put in the mbx
to wait for being processed. if client of these request is down (MDS_DEST of
this client
is disconnected), MDS thread receive the event down and also put to mbx. The
priority
of event down and send request are the same.
uot; above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision 4dc49c58454828315de22e3203b230e97de3edc9
Author: Canh Van Truong
Date: Wed, 5 Dec 2018 12:05:37 +0700
ntf: Fix to NTFD doesn't send the response if MDS_DEST of client is
disconnected [#2973]
When the sending notification re
** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision c9c60b1fb8780e068645af71a73171c099eef86f
Author: Canh Van Truong
Date: Wed, 28 Nov 2018 10:12:34 +0700
ntf: Increase the priority when sending MDS_DOWN to NTFD maind thread [#2973]
When the sending notification request come to NTFD , th
When the sending notification request come to NTFD , they are put in the mbx
to wait for being processed. if client of these request is down, MDS thread
receive the event down and also put to mbx. The priority of event down and send
request are the same. So NTF will process the send request before
:39 AM
To: 'Canh Van Truong' ; 'Lennart Lund'
; 'Minh Hon Chau'
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [devel] [PATCH 1/1] ntf: Increase the priority when sending
MDS_DOWN to NTFD maind thread [#2973]
Hi Canh,
I just wonder if any notification miss cause by this change?
Example
To: Canh Van Truong ; Minh Hon Chau
Cc: opensaf-devel@lists.sourceforge.net; Canh Van Truong
; Lennart Lund
Subject: RE: [PATCH 1/1] ntf: Increase the priority when sending MDS_DOWN to
NTFD maind thread [#2973]
Hi Canh,
Ack, with comments see [Lennart] below. I have not tested
I cannot say
** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision 9842ae0795666b002697ab15c01866cabcf5da95
Author: Canh Van Truong
Date: Tue, 27 Nov 2018 18:53:38 +0700
ntf: Increase the priority when sending MDS_DOWN to NTFD maind thread [#2973]
When the sending notification request come to NTFD , th
Hi Gary,
Ack
Thanks
Canh
-Original Message-
From: Gary Lee
Sent: Tuesday, November 13, 2018 2:39 PM
To: canh.v.tru...@dektech.com.au; hans.nordeb...@ericsson.com;
nagen...@hasolutions.in
Cc: opensaf-devel@lists.sourceforge.net; Gary Lee
Subject: [PATCH 0/2] Review Request for osaf:
NtfReader filter with searchcriteria then create the cached list notification.
But the filter is not correct. The patch update the the filter of search
criteria
and the read next of notification.
---
src/ntf/apitest/ntf_search_criteria_test.sh | 26 +-
src/ntf/ntfd/NtfReader.cc
THE PATCH SERIES HERE ***
revision 144b28cfd987d88f21363c6d0632af10055534ba
Author: Canh Van Truong
Date: Tue, 18 Sep 2018 18:46:50 +0700
ntf: Fix NtfReader filter with searchcriteria is not correct [#2925]
NtfReader filter with searchcriteria then create the cached list notification.
But
revision a5c8a17672deedd5dea5566428576a20177bdeab
Author: Canh Van Truong
Date: Fri, 24 Aug 2018 15:41:43 +0700
log: fix timeout when deleting configuration stream [#2903]
During closing stream, log sevice does try again in 8s when renaming file.
the log server is hung in that time and cannot poll and process an
During closing stream, log sevice does try again in 8s when renaming file.
the log server is hung in that time and cannot poll and process any requests.
If the completed_callback come from imm in that time, the callback cannot be
processed in time (in 6s) and cause timeout issue happen.
The try
When NTFD is started, the NtfAdmin class object is defined and log client is
initialized in this object. The initialiation of client may be loop forever
if TRY_AGAIN error always return. Somehow log service has not been started on
time or log service is busy, NTFD is kept in the loop. And the AMF
THE PATCH SERIES HERE ***
revision 8147a578e31b09c5cc2439c10688e32c1153bd18
Author: Canh Van Truong
Date: Mon, 20 Aug 2018 18:04:37 +0700
ntf: Update timeout for initializing log client [#2878]
When NTFD is started, the NtfAdmin class object is defined and log client is
initialized in t
** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision 74cace7aa740ddaa90646ca1f826de37d4ae7056
Author: Canh Van Truong
Date: Mon, 20 Aug 2018 13:58:41 +0700
mbc: fix mbcsv loop forever while it is being dispatch ALL [#2899]
When processing "MBCSV_PEER_UP_MSG" msg in case dispatch all fr
When processing "MBCSV_PEER_UP_MSG" msg in case dispatch all from user,
the msg may be too old. The msg may be come from the node that already rebooted.
This reason cause mbcsv loop forever in WHILE loop, because the active node
cannot
find the adest of peer msg.
The solution is that find entity
PM
To: Minh Hon Chau ; Canh Van Truong
; Vu Minh Nguyen
Cc: opensaf-devel@lists.sourceforge.net; Lennart Lund
Subject: RE: [devel] [PATCH 1/1] ntf: Update timeout for initializing log
client [#2878]
Hi Canh,
I'm not sure if my comment still is unclear so I have written comments in
the code
revision e89d6b0fcd56f83e864d5036e1edd6de5edd639b
Author: Canh Van Truong
Date: Fri, 10 Aug 2018 14:16:02 +0700
log: fix logtest 4 58 fail [#2909]
Due to hard-disk problem, the log file has not been closed successful and
log file has not been renamed. When previous test case (4 48) closes log
Due to hard-disk problem, the log file has not been closed successful and
log file has not been renamed. When previous test case (4 48) closes log file
fail,
test case (4 58) also count the size of (4 48)'s log file. This cause the size
of
log file is not 0.
The patch update to check (grep) if
Hi Lennart,
The patch just want to clean up the client in agent in case BAD_HANDLE. I
attach the new update.
If you have any comments please let me know.
Thanks
Canh
-Original Message-
From: Lennart Lund
Sent: Tuesday, August 7, 2018 7:33 PM
To: Canh Van Truong ; Vu Minh Nguyen
Cc
Log agent get BAD_HANDLE in some API from log server. The client has already
gone away in log server, but it still in the list in agent (lib). it need to be
deallocated and removed from list in agent.
The patch updates to remove in log API finalize
---
src/log/agent/lga_agent.cc | 3 +++
1 file
-
From: Minh Hon Chau
Sent: Friday, August 3, 2018 2:32 PM
To: Canh Van Truong ; vu.m.ngu...@dektech.com.au
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/1] ntf: Update timeout for initializing log client [#2878]
Hi Canh,
This issue seems to be partially fixed, we now prioritize
Hi Lennart,
Please see my comment
Thanks
Canh
From: Lennart Lund
Sent: Thursday, August 2, 2018 7:32 PM
To: Canh Van Truong ; Vu Minh Nguyen
Cc: opensaf-devel@lists.sourceforge.net; Lennart Lund
Subject: RE: [PATCH 0/1] Review Request for log: fix logtest 6 42 fail
[#2903]
Hi
Hi Lennart
Please see my reply inline
Thanks
Canh
-Original Message-
From: Lennart Lund
Sent: Wednesday, August 1, 2018 9:20 PM
To: Canh Van Truong ; Vu Minh Nguyen
Cc: opensaf-devel@lists.sourceforge.net; Canh Van Truong
; Lennart Lund
Subject: RE: [PATCH 0/1] Review
ERIES HERE ***
revision 7489c44113ac179020ba554b0c76eaf9750ef75f
Author: Canh Van Truong
Date: Wed, 1 Aug 2018 10:02:21 +0700
log: fix logtest 6 42 fail [#2903]
Test case logtest 2 49 creates some cfg app to test the limitation, then
deleting these stream at the end. But the deleting fails due
Test case logtest 2 49 creates some cfg app to test the limitation, then
deleting these stream at the end. But the deleting fails due to timeout for
waiting the implementer. After that test case logtest 6 42 need to create
some cfg app and take the same stream name. That causes the creattion fail
When processing "MBCSV_PEER_UP_MSG" msg in case dispatch all from user,
the msg may be too old. The msg may be come from the node that already rebooted.
This reason cause mbcsv loop forever in WHILE loop, because the active node
cannot
find the adest of peer msg.
The solution is that find entity
** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision 1cb4daf9aa7544168e54563bae0c67f9593fac1f
Author: Canh Van Truong
Date: Mon, 30 Jul 2018 10:53:19 +0700
mbc: fix mbcsv loop forever while it is being dispatch ALL [#2899]
When processing "MBCSV_PEER_UP_MSG" msg in case dispatch al
Thanks Lennrt,
I will add this note information in the .h file before push patch.
Regards
Canh
-Original Message-
From: Lennart Lund
Sent: Monday, July 23, 2018 8:23 PM
To: Canh Van Truong ; Vu Minh Nguyen
Cc: opensaf-devel@lists.sourceforge.net; Canh Van Truong
Subject: RE: [PATCH
If saLogWriteLogAsync return BAD_HANDLE error, log client will never be
re-initialized again. The patch reset variable "log_client_initialized = false"
in case BAD_HANDLE and the client will be re-initialized later.
---
src/osaf/saflog/saflog.c | 75
revision 1432d769c26c0ecc1e321f628da6c04c1fb376b9
Author: Canh Van Truong
Date: Mon, 2 Jul 2018 17:05:04 +0700
osaf: update for saflog in case saLogWriteLogAsync with BAD_HANDLE [#2886]
If saLogWriteLogAsync return BAD_HANDLE error, log client will never be
re-initialized again. The patch rese
revision 49204a5b772bdf949b910212d89c52e048dee721
Author: Canh Van Truong
Date: Tue, 26 Jun 2018 13:15:37 +0700
ntf: Update timeout for initializing log client [#2878]
When NTFD is started, the NtfAdmin class object is defined and log client is
initialized in this object. The initialiation of client may be lo
When NTFD is started, the NtfAdmin class object is defined and log client is
initialized in this object. The initialiation of client may be loop forever
if TRY_AGAIN error always return. Somehow log service has not been started on
time or log service is busy, NTFD is kept in the loop. And the AMF
revision 86a719f65a401ab51b6b60e110dd97ea395080d8
Author: Canh Van Truong
Date: Wed, 13 Jun 2018 17:23:22 +0700
log: fix saLogFilterSetCallbackT_03 fails [#2875]
When using immadm command to change saLogStreamSeverityFilter attribute in
runtime object, the adminOperationCallback is called to update the attribute
va
When using immadm command to change saLogStreamSeverityFilter attribute in
runtime object, the adminOperationCallback is called to update the attribute
value to imm then send the filter callback to user. sometimes the return of
command immadm come before the filter callback. if user poll the
revision bceda86638e0075ac4147574efb43d9896dca8b0
Author: Canh Van Truong
Date: Thu, 7 Jun 2018 13:25:45 +0700
ntf: fix wrong AdminOwnerName notified by osafntfimcnd [#2869]
Update to use dynamic varibale for operation invoked name in each CCB,
instead of using one global name for all CCB
Complet
Update to use dynamic varibale for operation invoked name in each CCB,
instead of using one global name for all CCB
---
src/ntf/ntfimcnd/ntfimcn_imm.c | 67 ++
1 file changed, 29 insertions(+), 38 deletions(-)
diff --git a/src/ntf/ntfimcnd/ntfimcn_imm.c
So Ack.
But please look at the minor comments I had as well
Thanks
Lennart
> -Original Message-
> From: Canh Van Truong [mailto:canh.v.tru...@dektech.com.au]
> Sent: den 6 mars 2018 05:19
> To: Lennart Lund ; Vu Minh Nguyen
>
> Cc: opensaf-devel@lists.sourceforge.net
> Subje
Hi a.Vu,
>From coredump info (in attachment), There is no saLogWriteLogAsync/
saLogStreamClose() is called ??
Regards
Canh
-Original Message-
From: Vu Minh Nguyen
Sent: Friday, June 1, 2018 3:56 PM
To: lennart.l...@ericsson.com; canh.v.tru...@dektech.com.au
Cc:
revision ebe563fcea9d760754450d2f53d8c99d115b5b16
Author: Canh Van Truong
Date: Wed, 30 May 2018 15:49:01 +0700
ckpt: update return code in LOG_ER printout [#2864]
Complete diffstat:
--
src/ckpt/apitest/test_cpa_util.c | 30 +++---
src/ckpt/ckptd/cpd_proc.c| 18 +++--
---
src/ckpt/apitest/test_cpa_util.c | 30 +++---
src/ckpt/ckptd/cpd_proc.c| 18 +++---
2 files changed, 26 insertions(+), 22 deletions(-)
diff --git a/src/ckpt/apitest/test_cpa_util.c b/src/ckpt/apitest/test_cpa_util.c
index 9b765bbb7..bc52ff950
1 - 100 of 224 matches
Mail list logo
