Re: [devel] [PATCH 2/2] amfd: Remove assignment of NwayActive SU which is over assigned after split brain [#2926]

ack, code review only/Thanks HansN On 09/19/2018 12:50 AM, Minh Chau wrote: --- src/amf/amfd/sg_nwayact_fsm.cc | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/amf/amfd/sg_nwayact_fsm.cc b/src/amf/amfd/sg_nwayact_fsm.cc index f339026..bbd63c8 100644 ---

Re: [devel] [PATCH 1/2] amfd: Reboot the node that has SU over-assigned after split brain [#2926]

ack, code review only/Thanks HansN On 09/19/2018 12:50 AM, Minh Chau wrote: After split-brain, the assignments can go over the preferred number. Reboot the node once at time until the current active assignments is equal to preferred number. --- src/amf/amfd/sg_nwayact_fsm.cc | 20

Re: [devel] [PATCH 2/3] base: add config file reader [#2923]

ack, code review only. /Thanks HansN On 09/21/2018 08:55 AM, Gary Lee wrote: Some configuration attribute are read by OpenSAF daemons as environment variables. eg. export FMS_PROMOTE_ACTIVE_TIMER=0 There is no easy way to reload these values without a restart. ConfigFileReader will parse

Re: [devel] [PATCH 3/3] fmd: enable reload of configuration without restart [#2923]

ack, code review only. /Thanks HansN On 09/21/2018 08:55 AM, Gary Lee wrote: Only FMS_PROMOTE_ACTIVE_TIMER, FMS_NODE_ISOLATION_TIMEOUT and FMS_ACTIVATION_SUPERVISION_TIMER are currently supported. These values can be changed in fmd.conf and take effect by sending SIGHUP to fmd. ---

Re: [devel] [PATCH 1/3] base: remove use of SIGHUP to toggle INFO messages [#2923]

ack, code review only. /Thanks HansN On 09/21/2018 08:55 AM, Gary Lee wrote: We need to use SIGHUP for reload of configuration --- src/base/daemon.c| 5 +++-- src/base/logtrace.cc | 22 -- 2 files changed, 3 insertions(+), 24 deletions(-) diff --git

Re: [devel] [PATCH 3/3] fmd: enable reload of configuration without restart [#2923]

ack, review only. Minor comments below. /Thanks HansN On 09/19/2018 05:42 AM, Gary Lee wrote: Only FMS_PROMOTE_ACTIVE_TIMER, FMS_NODE_ISOLATION_TIMEOUT and FMS_ACTIVATION_SUPERVISION_TIMER are currently supported. These values can be changed in fmd.conf and take effect by sending SIGHUP to

Re: [devel] [PATCH 2/3] base: add config file reader [#2923]

ack, review only. Some comments below. /Thanks HansN On 09/19/2018 05:42 AM, Gary Lee wrote: Some configuration attribute are read by OpenSAF daemons as environment variables. eg. export FMS_PROMOTE_ACTIVE_TIMER=0 There is no easy way to reload these values without a restart.

Re: [devel] [PATCH 1/3] base: remove use of SIGHUP to toggle INFO messages [#2923]

ack, review only/Thanks HansN On 09/19/2018 05:42 AM, Gary Lee wrote: We need to use SIGHUP for reload of configuration --- src/base/daemon.c| 5 +++-- src/base/logtrace.cc | 22 -- 2 files changed, 3 insertions(+), 24 deletions(-) diff --git a/src/base/daemon.c

Re: [devel] [PATCH 1/1] clm: add new test cases of API saClmInitialize_4() of apitest [#2914]

ack, review only. Minor comment below. /Thanks HansN On 08/21/2018 03:20 PM, Richa Tiwari wrote: --- src/clm/apitest/tet_saClmInitialize.cc | 53 ++ 1 file changed, 53 insertions(+) diff --git a/src/clm/apitest/tet_saClmInitialize.cc

Re: [devel] [PATCH 1/1] osaf: make takeover request expiration time configurable [#2917]

Hi Gary, ack, code review only. /Thanks HansN On 08/22/2018 07:01 AM, Gary Lee wrote: --- src/fm/fmd/fmd.conf | 4 src/osaf/consensus/consensus.cc | 24 src/osaf/consensus/consensus.h | 4 ++-- 3 files changed, 22 insertions(+), 10

Re: [devel] [PATCH 1/1] amfd: reboot nodes that report conflicting 2N active assignments [#2920]

Hi, I think AMF should avoid getting into this state. Resolving this state may be difficult. AMF should not make any new assignments/failovers when the state of the failing node/component is not known, i.e. we should prefer consistency before availability. /Thanks HansN On 09/03/2018

Re: [devel] [PATCH 1/1] amfd: Set SA_AMF_READINESS_IN_SERVICE for qualified SU after cluster startup timeout [#2916]

ack, review only/Thanks HansN On 08/22/2018 12:23 PM, Minh Chau wrote: In the scenario of single step upgrade where the UNLOCK-IN/UNLOCK admin op are issued to a SU hosted on non-active node while cluster startup timer is active and not all ncs SU on that node are fully assigned. In such case,

Re: [devel] [PATCH 1/1] mbc: fix mbcsv loop forever while it is being dispatch ALL [#2899]

Hi Canh, ack, code review only. /Thanks HansN On 08/20/2018 10:48 AM, Canh Van Truong wrote: When processing "MBCSV_PEER_UP_MSG" msg in case dispatch all from user, the msg may be too old. The msg may be come from the node that already rebooted. This reason cause mbcsv loop forever in WHILE

Re: [devel] [PATCH 1/1] mbc: fix mbcsv loop forever while it is being dispatch ALL [#2899]

Hi Canh, ack, review only. One minor comment, instead of adding a similar function mbcsv_check_if_peer_node_id_exist reuse mbcsv_search_and_return_peer and add a new argument to this function (upper/lower/all part of archword) instead. It is not that many place that needs to be updated

Re: [devel] [PATCH 1/1] amf: remove assignment for NPI component with enable DisableRestart [#2879]

Hi Thang, yes, you copied it from above, it looks as it is misspelled, thus -> this at both comments?/Thanks HansN On 08/07/2018 10:49 AM, Thang Nguyen wrote: Hi Hans, Thanks for your review. But that comment has already existed. B.R /Thang -Original Message- From: Hans Nordeb

Re: [devel] [PATCH 1/1] amf: remove assignment for NPI component with enable DisableRestart [#2879]

Hi Thang, ack, code review only. Very minor comment below. /Thanks HansN On 06/27/2018 07:48 PM, thang.nguyen wrote: With NPI component configured with saAmfCtDefDisableRestart=1. Once invoking restart admin op, amfnd does not remove the assignment and cause the crash. Remove assignment

Re: [devel] [PATCH 2/2] rded: perform KV store operations outside main thread [#2905]

Hi Gary, ack, review only. Minor comments below. /Thanks HansN On 08/01/2018 06:49 AM, Gary Lee wrote: Sometimes the 'watch' command in the KV plugin will not return a takeover request, if the KV store does not respond in time. Then rded would try to read the takeover request in the main

Re: [devel] [PATCH 1/2] osaf: add function to read takeover requests [#2905]

Hi Gary, ack, review only. /Thanks HansN On 08/01/2018 06:49 AM, Gary Lee wrote: --- src/osaf/consensus/consensus.cc | 17 + src/osaf/consensus/consensus.h | 3 +++ 2 files changed, 20 insertions(+) diff --git a/src/osaf/consensus/consensus.cc

Re: [devel] [PATCH 1/1] imm: attrDefaultValue is set to NULL if no default value is given [#2901]

Hi Vu, ack, review only. Minor comment below./Thanks HansN On 07/30/2018 10:46 AM, Vu Minh Nguyen wrote: When explicitly having tag, but no value is given: , set NULL to attrDefaultValue. --- src/imm/immloadd/imm_loader.cc | 3 ++- src/imm/tools/imm_import.cc| 3 ++- 2 files changed,

Re: [devel] [PATCH 1/1] dtm: Add --extract-trace option to osaflog command V2 [#2894]

Hi Minh, ack, review only. Minor comment below. /Thanks HansN On 07/20/2018 05:33 AM, Minh Chau wrote: If a process produces a core dump file that has THREAD_TRACE_BUFFER enabled, this option reads the core dump file to extract the trace strings in all threads and writes them to the trace

Re: [devel] [PATCH 1/1] amfd: check for queued updates on attribute [#2884]

Hi Gary, a minor comment below. /Regards HansN On 07/06/2018 04:07 AM, Gary Lee wrote: If there is a queued update on a particular object's attribute, also queue further 'sync' updates so we don't end up with an inconsistent value. --- src/amf/amfd/imm.cc | 35

Re: [devel] [PATCH 1/1] amfd: Check IMM status before calling saImmOiDispatch [#2885]

Hi Minh, I noticed this ticket is set as fixed but one question. Looking at the backtrace in the ticket, it seems that the imma_cb struct cb_lock mutex is created in thread 5 (avd_imm_reinit_bg_thread) but in the main thread pthread_mutex_unlock intents to unlock the "old" cb_lock mutex

Re: [devel] [PATCH 1/1] imm: prioritize to elect IMMND on the active node [#2862]

Hi Vu, ack, review only. (The indentation is still not correct). /Thanks HansN On 06/20/2018 08:28 AM, Vu Minh Nguyen wrote: The coordinator IMMND on PL-3 was crashed, the active IMMD then elected the new coordinator on the standby node, SC-2, but failed because IMMND on the SC-2 was

Re: [devel] [PATCH 1/1] base: Support thread trace buffer [#456]

Hi Minh, ack, review only. Some comments below marked with [HansN]. (Perhaps TraceLogBuffer and TraceLogClient are better names?) /Thanks HansN On 06/11/2018 11:16 PM, Minh Chau wrote: This ticket support the tracing buffer per thread. If enabled, each thread has it own buffer which the

Re: [devel] [PATCH 1/1] imm: fix failure to import file containing existing long dn object [#2874]

Hi Vu, ack, code review only. Some comments, function createImmObject looks as a candidate for refactoring and struct ParserState perhaps can use std::string instead of char* for objectName? /Thanks HansN On 06/11/2018 11:50 AM, Vu Minh Nguyen wrote: We copied the original object name

Re: [devel] [PATCH 1/1] imm: prioritize to elect IMMND on the active node [#2862]

    immnd_info_node->isCoord = true; /Thanks HansN On 06/15/2018 03:43 PM, Hans Nordeback wrote: Hi Vu, a few comments, - the indentation is not correct after the first while stmt. - why adding a new similar while loop? Instead remove the newly added while loop and change the first while l

Re: [devel] [PATCH 1/1] imm: prioritize to elect IMMND on the active node [#2862]

Hi Vu, a few comments, - the indentation is not correct after the first while stmt. - why adding a new similar while loop? Instead remove the newly added while loop and change the first while loop to something like this (not tested though): } else{ /* Try to elect a new coord. */

Re: [devel] [PATCH 1/1] ckpt: update return code in LOG_ER printout [#2864]

Hi Canh, ack, code review only. /Thanks HansN On 05/30/2018 11:01 AM, Canh Van Truong wrote: --- src/ckpt/apitest/test_cpa_util.c | 30 +++--- src/ckpt/ckptd/cpd_proc.c| 18 +++--- 2 files changed, 26 insertions(+), 22 deletions(-) diff --git

Re: [devel] [PATCH 1/1] mds: release mds lock if mds_mdtm_init failed [#2873]

ack, code review only. /Thanks HansN On 06/11/2018 06:40 AM, Phat Do wrote: If a process failed to mds_mdtm_init(), then it exits and holds the mds lock forever. Any upcoming MDS init process got stuck at required lock. This patch will clean up and release mds lock if mds_mdtm_init failed.

Re: [devel] [PATCH 1/1] base: ensure _file is always initialised [#2872]

ack, review only/Thanks HansN On 06/08/2018 05:12 AM, Gary Lee wrote: If trace is enabled after the last TRACE() statement is run, but *before* ~Trace() is called, then _file is left as nullptr when logtrace_output() is called in ~Trace(). This will segfault. --- src/base/logtrace.h | 10

Re: [devel] [PATCH 1/1] base: Improve backtrace print in daemon.c [#2853]

ell; Gary Lee *Kopia:* opensaf-devel@lists.sourceforge.net *Ämne:* RE: [PATCH 1/1] base: Improve backtrace print in daemon.c [#2853] Hi Hans, Ack, code review only Regards, Ravi -Original Message- From: Hans Nordeback [mailto:hans.nordeb...@ericsson.com] Sent: Wednesday, May 16, 2018 12:

Re: [devel] [PATCH 1/1] mds: return success at failure in case of using broadcast send type [#2866]

wrote: Hi Hans, Ack with one question, started with [Vu]. Thanks! Regards, Vu -Original Message----- From: Hans Nordeback Sent: Monday, May 28, 2018 6:18 PM To: vu.m.ngu...@dektech.com.au Cc: opensaf-devel@lists.sourceforge.net; Hans Nordeback Subject: [PATCH 1/1] mds: return success

[devel] [PATCH 0/1] Review Request for mds: return success at failure in case of using broadcast send type [#2866]

** EXPLAIN/COMMENT THE PATCH SERIES HERE *** revision 45b986c5f3dc6a7ead53f3f4e913a19ca4b303c5 Author: Hans Nordeback <hans.nordeb...@ericsson.com> Date: Mon, 28 May 2018 13:06:26 +0200 mds: return success at failure in case of using broadcast send type [#2866] C

[devel] [PATCH 1/1] mds: return success at failure in case of using broadcast send type [#2866]

--- src/mds/apitest/mdstipc.h | 2 + src/mds/apitest/mdstipc_api.c | 130 ++ src/mds/mds_dt_tipc.c | 2 +- 3 files changed, 133 insertions(+), 1 deletion(-) diff --git a/src/mds/apitest/mdstipc.h b/src/mds/apitest/mdstipc.h index

Re: [devel] [PATCH 1/1] base: Place TraceLog instance on heap memory V3 [#2860]

Hi Minh, yes, std::call_once or pthread_once should work. /Thanks HansN On 05/28/2018 05:08 AM, Minh Hon Chau wrote: Hi Hans, I think it can happen e.g if the traces in agent are enabled for more than 1 services. Maybe std::call_once can do? Thanks Minh On 25/05/18 18:33, Hans Nordeback

Re: [devel] [PATCH 1/1] base: Place TraceLog instance on heap memory V3 [#2860]

Hi Minh, ack, with a comment/question, if logtrace_init can be called concurrently, the new calls are not thread safe. If so, (it is the same problem when e.g. making a singleton thread safe, where e.g. "double-checked locking" has been tried, but does not work). Using pthread_once here

Re: [devel] [PATCH 1/1] base: Destructor of TraceLog causes coredump V2 [#2860]

Thanks, Minh On 23/05/18 20:50, Hans Nordeback wrote: Change Mutex class to make it possible for caller to decide if abort --- src/base/logtrace_client.cc | 5 - src/base/mutex.cc | 2 +- src/base/mutex.h| 22 +- 3 files changed, 18 ins

[devel] [PATCH 0/1] Review Request for base: Destructor of TraceLog causes coredump V2 [#2860]

revision c8e1aced8519c4f77819b1dbc92bdedfcf4734ea Author: Hans Nordeback <hans.nordeb...@ericsson.com> Date: Wed, 23 May 2018 12:36:40 +0200 base: Destructor of TraceLog causes coredump V2 [#2860] Change Mutex class to make it possible for caller to decide if abort Complete diffstat:

[devel] [PATCH 1/1] base: Destructor of TraceLog causes coredump V2 [#2860]

Change Mutex class to make it possible for caller to decide if abort --- src/base/logtrace_client.cc | 5 - src/base/mutex.cc | 2 +- src/base/mutex.h| 22 +- 3 files changed, 18 insertions(+), 11 deletions(-) diff --git

Re: [devel] [PATCH 1/1] base: Disable TraceLog desctructor [#2860]

Hi Minh, I think the call to exit() should be made thread safe instead, removing the destructor may lead to other problems such as leakages. In the "daemonized" services _Exit() is called and no destructors are run, there were some problems earlier when some libraries called exit(), these

Re: [devel] [PATCH 1/1] rded: run controller promotion code in new thread [#2857]

Hi Gary, ack, code review only. /Thanks HansN On 05/18/2018 07:50 AM, Gary Lee wrote: Currently, the consensus code relating to node promotion is run from the main thread. We can improve rded's responsiveness by moving this code into another thread. --- src/rde/rded/rde_cb.h| 3 +-

[devel] [PATCH 1/1] base: Improve backtrace print in daemon.c [#2853]

--- src/base/daemon.c | 52 ++--- tools/cluster_sim_uml/build_uml | 1 + 2 files changed, 49 insertions(+), 4 deletions(-) diff --git a/src/base/daemon.c b/src/base/daemon.c index 361dd8dd6..2ad0dcd2d 100644 --- a/src/base/daemon.c +++

Re: [devel] [PATCH 1/1] nid: restart opensafd on failure when systemd enabled [#2839]

ed. If I set "Restart=on-failure" it works fine.     Can you test this in your setup to see if you see the same thing? Alex On 04/24/2018 05:04 AM, Hans Nordeback wrote: NOTICE: This

Re: [devel] [PATCH 1/1] nid: restart opensafd on failure when systemd enabled [#2839]

if dtmd or immnd crashes early in the startup process, the node doesn't reboot, and the executables are not restarted. If I set "Restart=on-failure" it works fine.     Can you test this in your setup to see if you see the same thing? Alex On

Re: [devel] [PATCH 1/1] nid: restart opensafd on failure when systemd enabled [#2839]

Hi Alex, please see comment below. /Thanks HansN On 04/23/2018 03:56 PM, Alex Jones wrote: Hi Hans,     I just did some tests. Maybe there is a bug in nid, but when I do not have "Restart=on-failure", the node does not reboot when I run the command "systemctl start opensafd; sleep 3;

Re: [devel] [PATCH 1/1] amfd: if rootCauseEntity is PLM entity don't engage lock/lock-in [#2835]

Hi Alex, please see below for some comments/questions. /Regards HansN On 04/18/2018 03:41 PM, Alex Jones wrote: When using PLM an AMF node mapped to a CLM node mapped to a PLM EE, can get stuck in locked state when rebooting, or going through a PLM EE lock/unlock. When amfd receives a START

Re: [devel] [PATCH 2/2] base: Example of OSAF_LOCAL_LOG_FILE environment variable in amfd.conf file [#2306]

Hi Minh, ack, review only. Minor suggestions below. /Thanks HansN On 04/12/2018 01:12 AM, Minh Chau wrote: This commit is only an example to show where OSAF_LOCAL_LOG_FILE is configured. This commit will not be pushed. The introduction of OSAF_LOCAL_LOG_FILE for all services will be in

Re: [devel] [PATCH 1/2] base: Add support to direct OpenSAF logging to local node file [#2306]

Hi Minh, ack, code review only. Some comments below. /Thanks HansN On 04/12/2018 01:12 AM, Minh Chau wrote: Unify TraceLog and MdsLog class to one class (TraceLog) so it can be used as a common log client. Add new instance TraceLog for OpenSAF logging to local file, which can be

[devel] [PATCH 0/1] Review Request for base: Check return code from unlink in nid_create_ipc [#2829]

** EXPLAIN/COMMENT THE PATCH SERIES HERE *** revision c388066bbafb0dce8b4efdfe09a65a90571e8d25 Author: Hans Nordeback <hans.nordeb...@ericsson.com> Date: Thu, 5 Apr 2018 10:45:04 +0200 base: Check return code from unlink in nid_create_ipc [#2829] Complete diffstat: -

[devel] [PATCH 1/1] base: Check return code from unlink in nid_create_ipc [#2829]

--- src/nid/agent/nid_ipc.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/nid/agent/nid_ipc.c b/src/nid/agent/nid_ipc.c index 4f43cd309..1a77fd8e2 100644 --- a/src/nid/agent/nid_ipc.c +++ b/src/nid/agent/nid_ipc.c @@ -28,6 +28,7 @@ #include #include

[devel] [PATCH 1/1] build: Add support for google gmock framework V2 [#2823]

--- 00-README.unittest | 24 ++-- src/ais/Makefile.am | 5 - src/amf/Makefile.am | 7 +-- src/base/Makefile.am| 21 + src/base/tests/mock_turtle.cc | 20

[devel] [PATCH 0/1] Review Request for build: Add support for google gmock framework V2 [#2823]

IN/COMMENT THE PATCH SERIES HERE *** revision 3a278a70fe455cde4cfc2c3d13f163a91f5ff2f7 Author: Hans Nordeback <hans.nordeb...@ericsson.com> Date: Tue, 3 Apr 2018 12:57:57 +0200 build: Add support for google gmock framework V2 [#2823] Added Files: src/base/tests/mock_turtle.cc

[devel] [PATCH 0/1] Review Request for build: Add support for google gmock framework [#2823]

THE PATCH SERIES HERE *** revision cdbf86c2db6865ff96268f99e125ee87af59162d Author: Hans Nordeback <hans.nordeb...@ericsson.com> Date: Tue, 3 Apr 2018 12:35:43 +0200 build: Add support for google gmock framework [#2823] Added Files: src/base/tests/mock_turtle.cc

[devel] [PATCH 1/1] build: Add support for google gmock framework [#2823]

--- 00-README.unittest | 24 ++-- src/ais/Makefile.am | 5 - src/amf/Makefile.am | 7 +-- src/base/Makefile.am| 21 + src/base/tests/mock_turtle.cc | 20

[devel] [PATCH 0/1] Review Request for tools: Fix trace2dot, it stopped working after ticket #2165 [#2668]

revision 0e9a107623599596462855ae5ddff45a83427039 Author: Hans Nordeback <hans.nordeb...@ericsson.com> Date: Fri, 9 Mar 2018 14:05:52 +0100 tools: Fix trace2dot, it stopped working after ticket #2165 [#2668] Complete diffstat: -- tools/devel/dot/trace2dot | 22 +++---

[devel] [PATCH 1/1] tools: Fix trace2dot, it stopped working after ticket #2165 [#2668]

--- tools/devel/dot/trace2dot | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/tools/devel/dot/trace2dot b/tools/devel/dot/trace2dot index 160617c7a..1977276ea 100755 --- a/tools/devel/dot/trace2dot +++ b/tools/devel/dot/trace2dot @@ -2,7 +2,7 @@ # #

[devel] [PATCH 0/1] Review Request for fmd: Wrong unit for FMS_NODE_ISOLATION_TIMEOUT in fmd.conf [#2761]

revision fbafa0b50ee506200b91311b4cc286d0dc46735a Author: Hans Nordeback <hans.nordeb...@ericsson.com> Date: Tue, 16 Jan 2018 12:44:46 +0100 fmd: Wrong unit for FMS_NODE_ISOLATION_TIMEOUT in fmd.conf [#2761] Complete diffstat: -- src/fm/fmd/fmd.conf | 2 +- 1 file changed, 1 insertio

[devel] [PATCH 1/1] fmd: Wrong unit for FMS_NODE_ISOLATION_TIMEOUT in fmd.conf [#2761]

--- src/fm/fmd/fmd.conf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/fm/fmd/fmd.conf b/src/fm/fmd/fmd.conf index 63950ef8e..4924abfd9 100644 --- a/src/fm/fmd/fmd.conf +++ b/src/fm/fmd/fmd.conf @@ -14,7 +14,7 @@ export FMS_HA_ENV_HEALTHCHECK_KEY="Default" export

[devel] [PATCH 0/1] Review Request for build: Add cpplint filter to allow unapproved C++11 header [#2760]

revision 9e9e55185aead198d18135711356647d20b97d0b Author: Hans Nordeback <hans.nordeb...@ericsson.com> Date: Mon, 15 Jan 2018 12:15:28 +0100 build: Add cpplint filter to allow unapproved C++11 header [#2760] Added Files: CPPLINT.cfg Complete diffstat: -- CPPLINT.c

[devel] [PATCH 1/1] build: Add cpplint filter to allow unapproved C++11 header [#2760]

--- CPPLINT.cfg | 1 + 1 file changed, 1 insertion(+) create mode 100644 CPPLINT.cfg diff --git a/CPPLINT.cfg b/CPPLINT.cfg new file mode 100644 index 0..532509cd0 --- /dev/null +++ b/CPPLINT.cfg @@ -0,0 +1 @@ +filter=-build/c++11 -- 2.15.1

[devel] [PATCH 0/1] Review Request for amfnd: Improve log message for amf_saImmOmAccessorGet_o2 [#2755]

uot; above): - *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** revision e0a73d77beea5dcf9a558074cfc03d1ea3d4dbd7 Author: Hans Nordeback <hans.nordeb...@ericsson.com> Date: Mon, 8 Jan 2018 14:37:18 +0100 amfnd: Improve log message for amf_saImmOmAccessorGet_o2 [#2755] Complete diffstat: -

[devel] [PATCH 1/1] amfnd: Improve log message for amf_saImmOmAccessorGet_o2 [#2755]

--- src/amf/amfnd/compdb.cc | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/amf/amfnd/compdb.cc b/src/amf/amfnd/compdb.cc index 1ecd1a1c9..962bbec7d 100644 --- a/src/amf/amfnd/compdb.cc +++ b/src/amf/amfnd/compdb.cc @@ -842,15 +842,16 @@ static

[devel] [PATCH 1/1] base: Fix opensaf_scale_out script to handle binary arguments [#2703]

--- scripts/opensaf_scale_out | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/opensaf_scale_out b/scripts/opensaf_scale_out index dadb270c3..f9f5cde7a 100644 --- a/scripts/opensaf_scale_out +++ b/scripts/opensaf_scale_out @@ -41,7 +41,7 @@ exit 0 # for node in

[devel] [PATCH 0/1] Review Request for base: Fix opensaf_scale_out script to handle binary arguments [#2703]

revision 51f95a1e226c1617b9de48b82b3a0242fb3b6f22 Author: Hans Nordeback <hans.nordeb...@ericsson.com> Date: Mon, 27 Nov 2017 16:24:05 +0100 base: Fix opensaf_scale_out script to handle binary arguments [#2703] Complete diffstat: -- scripts/opensaf_scale_out | 4 ++-- 1

[devel] [PATCH 1/1] base: Add KillMode=none to opensafd.service [#2706]

--- src/nid/opensafd.service.in | 1 + 1 file changed, 1 insertion(+) diff --git a/src/nid/opensafd.service.in b/src/nid/opensafd.service.in index b14890ac2..35f290d8d 100644 --- a/src/nid/opensafd.service.in +++ b/src/nid/opensafd.service.in @@ -10,6 +10,7 @@ Type=forking

[devel] [PATCH 0/1] Review Request for base: Add KillMode=none to opensafd.service [#2706]

revision fcecf7778f15826bf8ca6f14c3cfad4fa835fbc8 Author: Hans Nordeback <hans.nordeb...@ericsson.com> Date: Mon, 27 Nov 2017 08:51:48 +0100 base: Add KillMode=none to opensafd.service [#2706] Complete diffstat: -- src/nid/opensafd.service.in | 1 + 1 file changed, 1 insertion(+)

[devel] [PATCH 1/1] base: Improve logging at daemon exit [#2704]

--- src/base/daemon.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/src/base/daemon.c b/src/base/daemon.c index 27170d779..bfb605093 100644 --- a/src/base/daemon.c +++ b/src/base/daemon.c @@ -68,6 +68,9 @@ static unsigned int __tracemask; static

[devel] [PATCH 0/1] Review Request for base: Improve logging at daemon exit [#2704]

revision 87b7ed739d5ea61f24ecf10cfa2e7dc5b82e748f Author: Hans Nordeback <hans.nordeb...@ericsson.com> Date: Fri, 24 Nov 2017 15:23:52 +0100 base: Improve logging at daemon exit [#2704] Complete diffstat: -- src/base/daemon.c | 19 +++ 1 file changed, 15 insertions(+), 4 deleti

[devel] [PATCH 0/1] Review Request for base: Make pylint output format selectable V2 [#2686]

** EXPLAIN/COMMENT THE PATCH SERIES HERE *** revision 957601f5b8afb0d1dfc9b76cc58d692b7c1754d3 Author: Hans Nordeback <hans.nordeb...@ericsson.com> Date: Fri, 17 Nov 2017 12:32:05 +0100 base: Make pylint output format selectable V2 [#2686] The output format can now be given, e.g.: make

[devel] [PATCH 1/1] base: Make pylint output format selectable V2 [#2686]

The output format can now be given, e.g.: make pylint (defaults to text) make pylint FORMAT=html make pylint FORMAT=parseable make pylint FORMAT=json --- Makefile.am | 4 +++- python/README | 8 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am

[devel] [PATCH 1/1] base: Make pylint output format selectable [#2686]

The output format can now be given, e.g.: make pylint (defaults to text) make pylint FORMAT=html make pylint FORMAT=parseable make pylint FORMAT=json --- Makefile.am | 2 +- python/README | 8 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am

[devel] [PATCH 0/1] Review Request for base: Make pylint output format selectable [#2686]

** EXPLAIN/COMMENT THE PATCH SERIES HERE *** revision c3abd385a424fd586a011cbcbda22e2fb18aa78b Author: Hans Nordeback <hans.nordeb...@ericsson.com> Date: Fri, 17 Nov 2017 09:44:09 +0100 base: Make pylint output format selectable [#2686] The output format can now be given, e.g.: make

[devel] [PATCH 0/1] Review Request for clm: Fix clm_user_data to not truncate data V2 [#2684]

revision f24e9809ba4a95d00eb3bd55890d05a687e32c1b Author: Hans Nordeback <hans.nordeb...@ericsson.com> Date: Thu, 16 Nov 2017 15:38:49 +0100 clm: Fix clm_user_data to not truncate data V2 [#2684] Complete diffstat: -- scripts/opensaf_scale_out | 20 +++- src/clm/README

[devel] [PATCH 1/1] clm: Fix clm_user_data to not truncate data V2 [#2684]

--- scripts/opensaf_scale_out | 20 +++- src/clm/README| 2 +- src/clm/clmnd/main.c | 9 + 3 files changed, 17 insertions(+), 14 deletions(-) diff --git a/scripts/opensaf_scale_out b/scripts/opensaf_scale_out index c7e902553..714d0b8b4 100644 ---

[devel] [PATCH 0/1] Review Request for clm: Fix clm_user_data to not truncate data [#2684]

IN/COMMENT THE PATCH SERIES HERE *** revision dec6c1f850cd5f103d734db7ebabe875b4264b92 Author: Hans Nordeback <hans.nordeb...@ericsson.com> Date: Thu, 16 Nov 2017 15:23:18 +0100 clm: Fix clm_user_data to not truncate data [#2684] Complete diffstat: -- scripts/opensa

[devel] [PATCH 1/1] clm: Fix clm_user_data to not truncate data [#2684]

--- scripts/opensaf_scale_out | 20 +++- src/clm/README| 2 +- src/clm/clmnd/main.c | 7 +++ 3 files changed, 15 insertions(+), 14 deletions(-) diff --git a/scripts/opensaf_scale_out b/scripts/opensaf_scale_out index c7e902553..714d0b8b4 100644 ---

[devel] [PATCH 0/1] Review Request for base: Add TimeoutStartSec to opensafd.service [#2678]

revision 435db978f4f47b8f760847cca985aa89d9628dae Author: Hans Nordeback <hans.nordeb...@ericsson.com> Date: Fri, 10 Nov 2017 12:03:22 +0100 base: Add TimeoutStartSec to opensafd.service [#2678] Complete diffstat: -- src/nid/opensafd.service.in | 1 + 1 file changed, 1 insertion(+)

[devel] [PATCH 1/1] base: Add TimeoutStartSec to opensafd.service [#2678]

--- src/nid/opensafd.service.in | 1 + 1 file changed, 1 insertion(+) diff --git a/src/nid/opensafd.service.in b/src/nid/opensafd.service.in index 2698f796f..2dce10145 100644 --- a/src/nid/opensafd.service.in +++ b/src/nid/opensafd.service.in @@ -9,6 +9,7 @@ ExecStop=@initscriptdir@/opensafd

[devel] [PATCH 0/1] Review Request for clm: WA Two active controllers observed at cluster [#2677]

** EXPLAIN/COMMENT THE PATCH SERIES HERE *** revision c6fa67095dfcb65d8eb390f080e421e73100dfbf Author: Hans Nordeback <hans.nordeb...@ericsson.com> Date: Fri, 10 Nov 2017 09:21:36 +0100 clm: WA Two active controllers observed at cluster [#2677] With current #2542 solution there is a window in th

[devel] [PATCH 1/1] clm: WA Two active controllers observed at cluster [#2677]

With current #2542 solution there is a window in the nid phase when reboots are overlapped leading to two active controllers . This patch solves this problem. --- 00-README.conf | 11 ++- src/base/osaf_utility.c | 44

[devel] [PATCH 1/1] dtm: Fix segv in osafdtmd [#2669]

--- src/dtm/dtmnd/dtm_main.cc | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/dtm/dtmnd/dtm_main.cc b/src/dtm/dtmnd/dtm_main.cc index f8d7e531a..cf0b81f8a 100644 --- a/src/dtm/dtmnd/dtm_main.cc +++ b/src/dtm/dtmnd/dtm_main.cc @@ -282,21 +282,21 @@ int

[devel] [PATCH 0/1] Review Request for dtm: Fix segv in osafdtmd [#2669]

813 Author: Hans Nordeback <hans.nordeb...@ericsson.com> Date: Tue, 7 Nov 2017 13:39:31 +0100 dtm: Fix segv in osafdtmd [#2669] Complete diffstat: -- src/dtm/dtmnd/dtm_main.cc | 16 1 file changed, 8 insertions(+), 8 deletions(-)

[devel] [PATCH 0/1] Review Request for clm: Fix unexpected join response error when executing immadm -o 4, 5 commands [#2661]

TCH SERIES HERE *** revision 95fbfe4510da88f6424d2a2beb64a9576333f612 Author: Hans Nordeback <hans.nordeb...@ericsson.com> Date: Wed, 1 Nov 2017 16:16:10 +0100 clm: Fix unexpected join response error when executing immadm -o 4, 5 commands [#2661] Complete diffstat: -

[devel] [PATCH 1/1] clm: Fix unexpected join response error when executing immadm -o 4, 5 commands [#2661]

--- src/clm/clmnd/main.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/clm/clmnd/main.c b/src/clm/clmnd/main.c index 926c5b718..948703426 100644 --- a/src/clm/clmnd/main.c +++ b/src/clm/clmnd/main.c @@ -215,6 +215,13 @@ static uint32_t clmna_mds_dec_flat(struct

[devel] [PATCH 0/1] Review Request for amfnd: fix segv in ncs_tmr_stop V2 [#2658]

revision 553ce52d7f1026923a8b72a4cea4d8a13af70d94 Author: Hans Nordeback <hans.nordeb...@ericsson.com> Date: Mon, 30 Oct 2017 15:50:12 +0100 amfnd: fix segv in ncs_tmr_stop V2 [#2658] Complete diffstat: -- src/amf/amfnd/di.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[devel] [PATCH 1/1] amfnd: fix segv in ncs_tmr_stop V2 [#2658]

--- src/amf/amfnd/di.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/amf/amfnd/di.cc b/src/amf/amfnd/di.cc index 7aac34260..2043c6064 100644 --- a/src/amf/amfnd/di.cc +++ b/src/amf/amfnd/di.cc @@ -1300,13 +1300,14 @@ void avnd_di_msg_ack_process(AVND_CB *cb, uint32_t

[devel] [PATCH 0/1] Review Request for amfnd: fix segv in ncs_tmr_stop [#2658]

revision 2210f4fdaae570fb9f8e4ef6bd180fab9d11bc41 Author: Hans Nordeback <hans.nordeb...@ericsson.com> Date: Fri, 27 Oct 2017 17:30:26 +0200 amfnd: fix segv in ncs_tmr_stop [#2658] Complete diffstat: -- src/amf/amfnd/di.cc | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-)

[devel] [PATCH 1/1] amfnd: fix segv in ncs_tmr_stop [#2658]

--- src/amf/amfnd/di.cc | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/amf/amfnd/di.cc b/src/amf/amfnd/di.cc index 7aac34260..6e5aaf54b 100644 --- a/src/amf/amfnd/di.cc +++ b/src/amf/amfnd/di.cc @@ -1293,7 +1293,9 @@ uint32_t avnd_di_node_down_msg_send(AVND_CB *cb)

[devel] [PATCH 0/1] Review Request for pyosaf: Create a pylint makefile target for pyosaf V2 [#2636]

uot; above): - *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** revision bd05358407b2f11cfaeb76163993b9a1ba8fabe4 Author: Hans Nordeback <hans.nordeb...@ericsson.com> Date: Mon, 23 Oct 2017 14:07:09 +0200 pyosaf: Create a pylint makefile target for

[devel] [PATCH 1/1] pyosaf: Create a pylint makefile target for pyosaf V2 [#2636]

--- Makefile.am | 9 +- python/pylintrc | 381 2 files changed, 389 insertions(+), 1 deletion(-) create mode 100644 python/pylintrc diff --git a/Makefile.am b/Makefile.am index a7548d274..f9ba87b35 100644 --- a/Makefile.am +++

[devel] [PATCH 0/1] Review Request for base: Add IPv6 support to gcov collect [#2620]

IN/COMMENT THE PATCH SERIES HERE *** revision b3035d08020fc96af12578e732d7ed5fa91258e8 Author: Hans Nordeback <hans.nordeb...@ericsson.com> Date: Fri, 6 Oct 2017 16:03:24 +0200 base: Add IPv6 support to gcov collect [#2620] Added Files: src/base/osaf_gcov.c src/base/osaf_g

[devel] [PATCH 1/1] base: Add IPv6 support to gcov collect [#2620]

--- 00-README.conf| 3 + src/base/Makefile.am | 1 + src/base/daemon.c | 87 + src/base/osaf_gcov.c | 199 ++ src/base/osaf_gcov.h | 40

[devel] [PATCH 0/1] Review Request for clm: Add user data in CLMSV_CLUSTER_JOIN_REQ message V2 [#2590]

uot; above): - *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** revision 4a03d2278aed4f5477bdd10ea77e17bf38136ede Author: Hans Nordeback <hans.nordeb...@ericsson.com> Date: Fri, 6 Oct 2017 10:56:27 +0200 clm: Add user data in CLMSV_CLUSTER_JOIN_REQ message V2 [#2590] Complete diffstat: ---

[devel] [PATCH 1/1] clm: Add user data in CLMSV_CLUSTER_JOIN_REQ message V2 [#2590]

--- scripts/opensaf_scale_out | 14 +- src/clm/README | 17 src/clm/clmd/clms_cb.h | 2 ++ src/clm/clmd/clms_evt.c| 32 ++- src/clm/clmd/clms_mds.c| 21 +++ src/clm/clmnd/cb.h | 2 ++ src/clm/clmnd/clmna.conf

[devel] [PATCH 1/1] clm: Make the cluster reset admin op safe V3 [#2451]

--- 00-README.conf | 10 +- src/base/osaf_utility.c | 44 src/base/osaf_utility.h | 5 + src/clm/clmnd/main.c| 1 + src/nid/nodeinit.cc | 2 ++ 5 files changed, 61 insertions(+), 1 deletion(-) diff --git

[devel] [PATCH 0/1] Review Request for clm: Make the cluster reset admin op safe V3 [#2451]

IN/COMMENT THE PATCH SERIES HERE *** revision d71eddab22f5e48ad9a354aee6ebc71ab68a174e Author: Hans Nordeback <hans.nordeb...@ericsson.com> Date: Wed, 27 Sep 2017 13:08:03 +0200 clm: Make the cluster reset admin op safe V3 [#2451] Complete diffstat: -- 00-README.co

[devel] [PATCH 1/1] clm: Add user data in CLMSV_CLUSTER_JOIN_REQ message [#2590]

--- src/clm/README | 8 +--- src/clm/clmd/clms_evt.c| 11 +-- src/clm/clmd/clms_mds.c| 11 +++ src/clm/clmnd/cb.h | 1 + src/clm/clmnd/main.c | 28 +++- src/clm/common/clmsv_msg.h | 1 + 6 files changed, 54

[devel] [PATCH 0/1] Review Request for osaf: Add gcov support [#2589]

uot; above): - *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** revision d72a6fbc6e6526f1cbf4433432856f314608e315 Author: Hans Nordeback <hans.nordeb...@ericsson.com> Date: Thu, 21 Sep 2017 16:10:22 +0200 osaf: Add gcov support [#2589] Added Files: tools/devel/gcov_collect/

[devel] [PATCH 1/1] osaf: Add gcov support [#2589]

--- 00-README.conf| 13 - Makefile.am | 8 ++- README| 1 + configure.ac | 18 ++ src/base/daemon.c | 96 +--

[devel] [PATCH 1/1] clm: Make the cluster reset admin op safe V2 [#2451]

The active node reboots all nodes in the cluster excepts itself, the active node. When the peer CLMS node has been rebooted and is in a "well defined" state it sends a peer up message to the active CLMS node. If a cluster reboot is ongoing, the active CLM node will be rebooted as the last step

  1   2   3   4   5   >