[devel] [PATCH 0 of 1] Review Request for smfd: Merge rolling to singlestep procedures for several nodes [#1685]

2016-09-01 Thread Rafael Odzakow 
Summary: Merge rolling to singlestep procedures for several nodes
Review request for Trac Ticket(s): #1685
Peer Reviewer(s): lennart, reddy
Pull request to: <>
Affected branch(es): <>
Development branch: <>


Impacted area   Impact y/n

 Docsn
 Build systemn
 RPM/packaging   n
 Configuration files n
 Startup scripts n
 SAF servicesy
 OpenSAF servicesn
 Core libraries  n
 Samples n
 Tests   n
 Other   n


Comments (indicate scope for each "y" above):
-
 Added SI-Swap to this feature. There are two main function calls independent
 of each other when doing si-swap. The class seemed redundant so it got 
refactored
 out. Missing is the protection for openSafSmfExecControl attribute in 
SmfConfig.

changeset 931d77e6c9bc04dc4e55f6264e2fcde4070e8203
Author: Rafael Odzakow 
Date:   Thu, 01 Sep 2016 10:46:53 +0200

smfd: Merge rolling to singlestep procedures for several nodes [#1685]

Enables the balanced mode feature. This mode changes the execution
of rolling procedures to be merged into one or several single steps that are
spread out across the cluster nodes. This feature is used to give a faster
upgrade time compared to rolling one node at a time, possibly several times
for each node. By splittting the procedures it into several single steps
across the nodes a total service outage can be avoided.


Added Files:

 osaf/services/saf/smfsv/smfd/SmfExecControl.cc
 osaf/services/saf/smfsv/smfd/SmfExecControl.h


Complete diffstat:
--
 osaf/services/saf/smfsv/config/smfsv_classes.xml|   13 +
 osaf/services/saf/smfsv/smfd/Makefile.am|6 +-
 osaf/services/saf/smfsv/smfd/SmfCampState.cc|  126 
+-
 osaf/services/saf/smfsv/smfd/SmfCampaign.cc |   77 
+++-
 osaf/services/saf/smfsv/smfd/SmfCampaign.hh |1 +
 osaf/services/saf/smfsv/smfd/SmfExecControl.cc  |  410 
+++
 osaf/services/saf/smfsv/smfd/SmfExecControl.h   |   59 
+
 osaf/services/saf/smfsv/smfd/SmfProcState.cc|   28 +++-
 osaf/services/saf/smfsv/smfd/SmfUpgradeCampaign.cc  |   32 +
 osaf/services/saf/smfsv/smfd/SmfUpgradeCampaign.hh  |   24 --
 osaf/services/saf/smfsv/smfd/SmfUpgradeProcedure.cc |   27 ---
 osaf/services/saf/smfsv/smfd/SmfUpgradeProcedure.hh |   18 ++-
 osaf/services/saf/smfsv/smfd/SmfUpgradeStep.hh  |   13 ++---
 osaf/services/saf/smfsv/smfd/smfd.h |2 +-
 14 files changed, 653 insertions(+), 183 deletions(-)


Testing Commands:
-
 Campaign with rolling procedures is attached to the ticket. Run a campaign
 with rolling procedures on payloads and enable the balanced mode. Example
 configuration for balanced mode:

 immcfg -c OpenSafSmfExecControl -a procExecMode=2 
openSafSmfExecControl=MergeCampToSS2o
 immcfg -a numberOfSingleSteps=2 -a nodesForSingleStep=PL-3 -a 
nodesForSingleStep=PL-4 openSafSmfExecControl=MergeCampToSS2
 immcfg -a openSafSmfExecControl=openSafSmfExecControl=MergeCampToSS2 
smfConfig=1,safApp=safSmfService

 In this configuration we can expect to run one single step procedures on each 
of the payloads specified

Testing, Expected Results:
--
  campaign should have executed all rolling steps as groups of single steps.

Conditions of Submission:
-
 <>


Arch  Built StartedLinux distro
---
mipsn  n
mips64  n  n
x86 n  n
x86_64  n  n
powerpc n  n
powerpc64   n  n


Reviewer Checklist:
---
[Submitters: make sure that your review doesn't trigger any checkmarks!]


Your checkin has not passed review because (see checked entries):

___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.

___ You have failed to nominate the proper persons for review and push.

___ Your patches do not have proper short+long header

___ You have grammar/spelling in your header that is unacceptable.

___ You have exceeded a sensible line length in your headers/comments/text.

___ You have failed to put in a proper Trac Ticket # into your commits.

___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)

___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or

[devel] [PATCH 0 of 1] Review Request for smfd: Merge rolling to singlestep procedures for several nodes [#1685]

2016-08-27 Thread Rafael Odzakow 
Summary: smfd: Merge rolling to singlestep procedures for several nodes
Review request for Trac Ticket(s): #1685
Peer Reviewer(s): lennart, reddy
Pull request to: <>
Affected branch(es): <>
Development branch: <>


Impacted area   Impact y/n

 Docsn
 Build systemn
 RPM/packaging   n
 Configuration files n
 Startup scripts n
 SAF servicesy
 OpenSAF servicesn
 Core libraries  n
 Samples n
 Tests   n
 Other   n


Comments (indicate scope for each "y" above):
-
 Missing the si-swap implementation and OI for some extra checks.

changeset a383f0ebdb5602d9799ee69f3bdf59e479413fb9
Author: Rafael Odzakow 
Date:   Tue, 23 Aug 2016 10:02:51 +0200

smfd: Merge rolling to singlestep procedures for several nodes [#1685]

Enables the balanced mode feature. This mode changes the execution
of rolling procedures to be merged into one or several single steps that are
spread out across the cluster nodes. This feature is used to give a faster
upgrade time compared to rolling one node at a time, possibly several times
for each node. By splittting the procedures it into several single steps
across the nodes a total service outage can be avoided.

Added Files:

 osaf/services/saf/smfsv/smfd/SmfExecControl.cc
 osaf/services/saf/smfsv/smfd/SmfExecControl.h


Complete diffstat:
--
 osaf/services/saf/smfsv/config/smfsv_classes.xml|   13 +
 osaf/services/saf/smfsv/smfd/Makefile.am|6 +-
 osaf/services/saf/smfsv/smfd/SmfCampState.cc|  126 
--
 osaf/services/saf/smfsv/smfd/SmfCampaign.cc |   78 
++
 osaf/services/saf/smfsv/smfd/SmfCampaign.hh |1 +
 osaf/services/saf/smfsv/smfd/SmfExecControl.cc  |  423 
+++
 osaf/services/saf/smfsv/smfd/SmfExecControl.h   |   64 
+
 osaf/services/saf/smfsv/smfd/SmfProcState.cc|7 ++-
 osaf/services/saf/smfsv/smfd/SmfUpgradeCampaign.cc  |   32 +++-
 osaf/services/saf/smfsv/smfd/SmfUpgradeCampaign.hh  |   24 -
 osaf/services/saf/smfsv/smfd/SmfUpgradeProcedure.cc |   14 +++--
 osaf/services/saf/smfsv/smfd/SmfUpgradeProcedure.hh |   20 ++-
 osaf/services/saf/smfsv/smfd/SmfUpgradeStep.hh  |   13 ++--
 osaf/services/saf/smfsv/smfd/smfd.h |2 +-
 14 files changed, 638 insertions(+), 185 deletions(-)


Testing Commands:
-
 Campaign with rolling procedures is attached to the ticket. Run a campaign
 with rolling procedures on payloads and enable the balanced mode. Example
 configuration for balanced mode:

 immcfg -c OpenSafSmfExecControl -a procExecMode=2 
openSafSmfExecControl=MergeCampToSS2o
 immcfg -a numberOfSingleSteps=2 -a nodesForSingleStep=PL-3 -a 
nodesForSingleStep=PL-4 openSafSmfExecControl=MergeCampToSS2
 immcfg -a openSafSmfExecControl=openSafSmfExecControl=MergeCampToSS2 
smfConfig=1,safApp=safSmfService

 In this configuration we can expect to run one single step procedures on each 
of the payloads specified


Testing, Expected Results:
--
 campaign should have executed all steps.


Conditions of Submission:
-
 <>


Arch  Built StartedLinux distro
---
mipsn  n
mips64  n  n
x86 n  n
x86_64  n  n
powerpc n  n
powerpc64   n  n


Reviewer Checklist:
---
[Submitters: make sure that your review doesn't trigger any checkmarks!]


Your checkin has not passed review because (see checked entries):

___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.

___ You have failed to nominate the proper persons for review and push.

___ Your patches do not have proper short+long header

___ You have grammar/spelling in your header that is unacceptable.

___ You have exceeded a sensible line length in your headers/comments/text.

___ You have failed to put in a proper Trac Ticket # into your commits.

___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)

___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.

___ You have ^M present in some of your files. These have to be removed.

___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.

___ You have mixed real

[devel] [PATCH 0 of 1] Review Request for smfd: Merge rolling to singlestep procedures for several nodes [#1685]

2016-08-23 Thread Rafael Odzakow 
Summary: smfd: Merge rolling to singlestep procedures for several nodes
Review request for Trac Ticket(s): #1685
Peer Reviewer(s): lennart, reddy
Pull request to: <>
Affected branch(es): <>
Development branch: <>


Impacted area   Impact y/n

 Docsn
 Build systemn
 RPM/packaging   n
 Configuration files n
 Startup scripts n
 SAF servicesy
 OpenSAF servicesn
 Core libraries  n
 Samples n
 Tests   n
 Other   n


Comments (indicate scope for each "y" above):
-
 Still missing: 
   si-swap handling to be added
   oi for openSafSmfExecControl to be added

changeset 95f9f432c9d79c29a2ba971add5ad490f28ca0a3
Author: Rafael Odzakow 
Date:   Tue, 23 Aug 2016 10:02:51 +0200

smfd: Merge rolling to singlestep procedures for several nodes [#1685]

This commit enables the balanced mode feature. This mode changes the execution
of rolling procedures to be merged into one or several single steps that are
spread out across the cluster nodes. This feature is used to give a faster
upgrade time compared to rolling procedures upgrading one node at a time,
possibly several times for each node. By splittting the procedures it into
several single steps across the nodes a total service outage can be avoided.


Added Files:

 osaf/services/saf/smfsv/smfd/SmfExecControl.cc
 osaf/services/saf/smfsv/smfd/SmfExecControl.h


Complete diffstat:
--
 osaf/services/saf/smfsv/config/smfsv_classes.xml|   13 +
 osaf/services/saf/smfsv/smfd/Makefile.am|6 +-
 osaf/services/saf/smfsv/smfd/SmfCampState.cc|  125 
---
 osaf/services/saf/smfsv/smfd/SmfCampaign.cc |   78 
--
 osaf/services/saf/smfsv/smfd/SmfCampaign.hh |1 +
 osaf/services/saf/smfsv/smfd/SmfExecControl.cc  |  399 
+++
 osaf/services/saf/smfsv/smfd/SmfExecControl.h   |   56 
+
 osaf/services/saf/smfsv/smfd/SmfProcState.cc|7 ++-
 osaf/services/saf/smfsv/smfd/SmfUpgradeCampaign.cc  |   32 --
 osaf/services/saf/smfsv/smfd/SmfUpgradeCampaign.hh  |   24 --
 osaf/services/saf/smfsv/smfd/SmfUpgradeProcedure.cc |   14 --
 osaf/services/saf/smfsv/smfd/SmfUpgradeProcedure.hh |   20 +++-
 osaf/services/saf/smfsv/smfd/SmfUpgradeStep.hh  |   13 ++---
 osaf/services/saf/smfsv/smfd/smfd.h |2 +-
 14 files changed, 605 insertions(+), 185 deletions(-)


Testing Commands:
-
Campaign with rolling procedures is attached to the ticket. Run a campaign with
rolling procedures on payloads and enable the balanced mode:

 immcfg -c OpenSafSmfExecControl -a procExecMode=2 
openSafSmfExecControl=MergeCampToSS2
 immcfg -a numberOfSingleSteps=2 -a nodesForSingleStep=PL-3 -a 
nodesForSingleStep=PL-4 openSafSmfExecControl=MergeCampToSS2
 immcfg -a openSafSmfExecControl=openSafSmfExecControl=MergeCampToSS2 
smfConfig=1,safApp=safSmfService

 In this configuration we can expect to run one single step procedures on each 
of the payloads specified.



Testing, Expected Results:
--
 campaign should have executed all steps according to configuration


Conditions of Submission:
-
 <>


Arch  Built StartedLinux distro
---
mipsn  n
mips64  n  n
x86 n  n
x86_64  n  n
powerpc n  n
powerpc64   n  n


Reviewer Checklist:
---
[Submitters: make sure that your review doesn't trigger any checkmarks!]


Your checkin has not passed review because (see checked entries):

___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.

___ You have failed to nominate the proper persons for review and push.

___ Your patches do not have proper short+long header

___ You have grammar/spelling in your header that is unacceptable.

___ You have exceeded a sensible line length in your headers/comments/text.

___ You have failed to put in a proper Trac Ticket # into your commits.

___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)

___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.

___ You have ^M present in some of your files. These have to be removed.

___ You have needlessly changed whitespace or added whitespace crimes
like