Re: [devel] [PATCH 0 of 3] Review Request for log: implement SaLogFilterSetCallbackT and version handling V4 [#2146]

[Vu Minh Nguyen]

Ack

Regards, Vu

> -Original Message-
> From: Canh Van Truong [mailto:canh.v.tru...@dektech.com.au]
> Sent: Thursday, February 16, 2017 1:49 PM
> To: lennart.l...@ericsson.com; vu.m.ngu...@dektech.com.au;
> mahesh.va...@oracle.com
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: [PATCH 0 of 3] Review Request for log: implement
> SaLogFilterSetCallbackT and version handling V4 [#2146]
> 
> Summary: log: implement SaLogFilterSetCallbackT and version handling V4
> [#2146]
> Review request for Trac Ticket(s): #2146
> Peer Reviewer(s): Lennart, Vu, Mahesh
> Pull request to: Vu
> Affected branch(es): default
> Development branch: default
> 
> 
> Impacted area   Impact y/n
> 
>  Docsn
>  Build systemn
>  RPM/packaging   n
>  Configuration files n
>  Startup scripts n
>  SAF servicesn
>  OpenSAF servicesy
>  Core libraries  n
>  Samples n
>  Tests   n
>  Other   n
> 
> 
> Comments (indicate scope for each "y" above):
> -
>  <>
> 
> changeset 05726400fc1a27cf50255b70bb7f952156cbe68f
> Author:   Canh Van Truong 
> Date: Mon, 21 Nov 2016 17:19:56 +0700
> 
>   log: implement SaLogFilterSetCallbackT [#2146]
> 
>   Implement SaLogFilterSetCallbackT which is mentioned at section
> 3.6.5
>   SaLogFilterSetCallbackT @ AIS LOG document.
> 
>   LGS:
>- Whenever severity filter is changed for app and systerm
streams,
> lgs will
>   find which clients that associate with the stream. Then lgs sends
> message
>   callback to clients.
>- Encoding callback message for severity filter callback
> 
>   LGA:
>- Decoding callback message for severity callback from lgs and
> send the
>   message to the client which setting filter callback.
>- Dispatching severity filter callback
> 
>   - Encrease version of log service to A.02.03
> 
> changeset 8d41edf85334f1b14d858e2ad2f705aecf6b9a68
> Author:   Canh Van Truong 
> Date: Tue, 17 Jan 2017 14:24:33 +0700
> 
>   log: Add minor version checking in log server [#2146]
> 
>   Checking minor version and return version error if major/minor
> version is
>   higher than supported major/minor
> 
>   Add client_version to log_client_t and checkpoint struct in lgs
> 
>   Increase checkpoint version and checkpoint client_ver to stand by
> 
>   Only send filter callback to client that initialized with minor
version >
> 3
> 
> changeset ff130149eb45136a50563878431a92b52e024997
> Author:   Canh Van Truong 
> Date: Tue, 17 Jan 2017 15:42:40 +0700
> 
>   log: fix checking version in log agent [#2146]
> 
>   Fix checking version in log agent
> 
>   The agent report highest supported version except getting
> ERR_VERSION from
>   server. if agent get ERR_VERSION, it will set supported version to
> A.02.03
> 
> 
> Added Files:
> 
>  src/log/logd/lgs_mbcsv_v6.cc
>  src/log/logd/lgs_mbcsv_v6.h
> 
> 
> Complete diffstat:
> --
>  src/log/Makefile.am   |3 +
>  src/log/agent/lga.h   |4 +
>  src/log/agent/lga_api.c   |   58 +++--
>  src/log/agent/lga_mds.c   |   71
++
>  src/log/agent/lga_util.c  |   64 +++-
>  src/log/apitest/logtest.c |3 +-
>  src/log/apitest/logtestfr.c   |3 +-
>  src/log/apitest/saflogtest.c  |3 +-
>  src/log/apitest/tet_LogOiOps.c|   72
++
>  src/log/apitest/tet_log_longDN.c  |3 +-
>  src/log/apitest/tet_saLogFilterSetCallbackT.c |  418
> ++
> ++
> -
>  src/log/apitest/tet_saLogInitialize.c |   24 +++
>  src/log/apitest/tet_saLogStreamOpen_2.c   |3 +-
>  src/log/common/lgsv_defs.h|7 +-
>  src/log/common/lgsv_msg.h |8 ++
>  src/log/logd/lgs_cb.h |2 +
>  src/log/logd/lgs_evt.cc   |   93
++---
>  src/log/logd/lgs_imm.cc   |8 ++
>  src/log/logd/lgs_mbcsv.cc |  181
> 
>  src/log/logd/lgs_mbcsv.h  |9 ++-
>  src/log/logd/lgs_mbcsv_v6.cc  |  169
> +
>  src/log/logd/lgs_mbcsv_v6.h   |   56 +
>  src/log/logd/lgs_mds.cc   |   58 

Re: [devel] [PATCH 0 of 3] Review Request for log: implement SaLogFilterSetCallbackT and version handling V4 [#2146]

[A V Mahesh]

Hi Canh,

I got it, i got confused because of  increased version to A.02.03 ,
I went through version handling given by Lennart

I just ACKed it.

-AVM

On 2/21/2017 3:29 PM, Canh Truong wrote:
> Hi Mahesh,
>
> SaLogFilterSetCallbackT was already declared before  . So we don't have to
> add more one header file.
>
> Regards
> Canh
>
> -Original Message-
> From: Canh Truong [mailto:canh.v.tru...@dektech.com.au]
> Sent: Tuesday, February 21, 2017 4:41 PM
> To: 'A V Mahesh'; 'lennart.l...@ericsson.com'; 'vu.m.ngu...@dektech.com.au'
> Cc: 'opensaf-devel@lists.sourceforge.net'
> Subject: RE: [devel] [PATCH 0 of 3] Review Request for log: implement
> SaLogFilterSetCallbackT and version handling V4 [#2146]
>
> Hi Mahesh,
>
> The saLogFilterSetCallback is already existing in spec. But it has not
> implemented yet. The patch implemented to received filter callback from log
> server. So we increase version to A.02.03.
> You can refer at Lennart's comments in
> https://sourceforge.net/p/opensaf/tickets/2146/ for version handling.
>
> Regards
> Canh
>
> -Original Message-
> From: A V Mahesh [mailto:mahesh.va...@oracle.com]
> Sent: Tuesday, February 21, 2017 4:31 PM
> To: Canh Truong; lennart.l...@ericsson.com; vu.m.ngu...@dektech.com.au
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: Re: [devel] [PATCH 0 of 3] Review Request for log: implement
> SaLogFilterSetCallbackT and version handling V4 [#2146]
>
> Hi Canh,
>
> I am sorry saLogFilterSetCallback is existing call back in specification and
> it seem we increased initialized  version jut to support  agent version is
> that right ?
>
> -AVM
>
> On 2/21/2017 2:51 PM, A V Mahesh wrote:
>> Hi Canh,
>>
>> The  general practice of implementing  any upcoming functionality of
>> SAF specification we do define in relevant structures
>> `src//saf/` file for example
>> `src/ckpt/saf/saCkpt_B_02_03.h` in addition to
>> `src/ckpt/saf/saCkpt.h`, so that user will include that new .h file
>> for new definitions
>>
>> Is their any reson  `SaLogFilterSetCallbackT` didn't followed this ?
>> How application will include this  `SaLogFilterSetCallbackT` ?
>>
>> -AVM
>>
>> On 2/21/2017 2:07 PM, A V Mahesh wrote:
>>> Hi Canh,
>>>
>>> I can see that you are passing NULL callbacks as `` for
>>> "logtest 1 10" and " logtest 1 11" by seeing
>>>
>>> -AVM
>>>
>>>
>>> On 2/21/2017 1:02 PM, Canh Truong wrote:
 Hi Mahesh,

 The test case " logtest 1 10" and " logtest 1 11"  are created for
 version handling. In standby node, it has new code for log agent
 (with #2146), that means that version handling in log agent have been
> added.
 The log agent check if minor version bigger than the agent support,
 it will return ERROR_VERSION.  The test case is successful.

 In test case 11, log agent reassign for version of client is A.02.01
 before sending to the initialized request to log server. So the test
 case is successful.

 The test cases for filter callback is in test suite 17. (logtest 17)

 Regards
 Canh


 -Original Message-
 From: A V Mahesh [mailto:mahesh.va...@oracle.com]
 Sent: Tuesday, February 21, 2017 2:10 PM
 To: Canh Van Truong; lennart.l...@ericsson.com;
 vu.m.ngu...@dektech.com.au
 Cc: opensaf-devel@lists.sourceforge.net
 Subject: Re: [PATCH 0 of 3] Review Request for log: implement
 SaLogFilterSetCallbackT and version handling V4 [#2146]

 Hi  Canh,

 I was jut testing Agent in-service upgrade , so I have following
 setup and run the New FilterSetCallback test case and i was
 expecting case should receive fail/not-supported , but they are getting
> succeed how ?

 -SC-2  ACTIVE  Old Node ( LOG is old code with out #2146 patch )
 -SC-1  STANDBY  New Node ( LOG is new code with #2146 patch )

 SC-1# /usr/bin/logtest 1 10

 Suite 1: Library Life Cycle
 10  PASSED   saLogInitialize() with minor version is set bigger
> than
 supported version;

 
 
 =

 Test Result:
Total:  1
Passed: 1
Failed: 0

 SC-1# /usr/bin/logtest 1 11

 Suite 1: Library Life Cycle
 11  PASSED   saLogInitialize() with minor version is not set;

 
 
 =

 Test Result:
Total:  1
Passed: 1
Failed: 0

 -AVM

 On 2/16/2017 12:18 PM, Canh Van Truong wrote:
> Summary: log: implement SaLogFilterSetCallbackT and version
> handling
> V4 [#2146] Review request for Trac Ticket(s): #2146 Peer Reviewer(s):
> Lennart, Vu, Mahesh Pull request to: Vu Affected branch(es):
> default Development branch: default
>
> 

Re: [devel] [PATCH 0 of 3] Review Request for log: implement SaLogFilterSetCallbackT and version handling V4 [#2146]

[Canh Truong]

Hi Mahesh,

SaLogFilterSetCallbackT was already declared before  . So we don't have to
add more one header file. 

Regards
Canh

-Original Message-
From: Canh Truong [mailto:canh.v.tru...@dektech.com.au] 
Sent: Tuesday, February 21, 2017 4:41 PM
To: 'A V Mahesh'; 'lennart.l...@ericsson.com'; 'vu.m.ngu...@dektech.com.au'
Cc: 'opensaf-devel@lists.sourceforge.net'
Subject: RE: [devel] [PATCH 0 of 3] Review Request for log: implement
SaLogFilterSetCallbackT and version handling V4 [#2146]

Hi Mahesh,

The saLogFilterSetCallback is already existing in spec. But it has not
implemented yet. The patch implemented to received filter callback from log
server. So we increase version to A.02.03.
You can refer at Lennart's comments in
https://sourceforge.net/p/opensaf/tickets/2146/ for version handling.

Regards
Canh

-Original Message-
From: A V Mahesh [mailto:mahesh.va...@oracle.com]
Sent: Tuesday, February 21, 2017 4:31 PM
To: Canh Truong; lennart.l...@ericsson.com; vu.m.ngu...@dektech.com.au
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH 0 of 3] Review Request for log: implement
SaLogFilterSetCallbackT and version handling V4 [#2146]

Hi Canh,

I am sorry saLogFilterSetCallback is existing call back in specification and
it seem we increased initialized  version jut to support  agent version is
that right ?

-AVM

On 2/21/2017 2:51 PM, A V Mahesh wrote:
> Hi Canh,
>
> The  general practice of implementing  any upcoming functionality of 
> SAF specification we do define in relevant structures 
> `src//saf/` file for example 
> `src/ckpt/saf/saCkpt_B_02_03.h` in addition to 
> `src/ckpt/saf/saCkpt.h`, so that user will include that new .h file 
> for new definitions
>
> Is their any reson  `SaLogFilterSetCallbackT` didn't followed this ?
> How application will include this  `SaLogFilterSetCallbackT` ?
>
> -AVM
>
> On 2/21/2017 2:07 PM, A V Mahesh wrote:
>> Hi Canh,
>>
>> I can see that you are passing NULL callbacks as `` for 
>> "logtest 1 10" and " logtest 1 11" by seeing
>>
>> -AVM
>>
>>
>> On 2/21/2017 1:02 PM, Canh Truong wrote:
>>> Hi Mahesh,
>>>
>>> The test case " logtest 1 10" and " logtest 1 11"  are created for 
>>> version handling. In standby node, it has new code for log agent 
>>> (with #2146), that means that version handling in log agent have been
added.
>>> The log agent check if minor version bigger than the agent support, 
>>> it will return ERROR_VERSION.  The test case is successful.
>>>
>>> In test case 11, log agent reassign for version of client is A.02.01 
>>> before sending to the initialized request to log server. So the test 
>>> case is successful.
>>>
>>> The test cases for filter callback is in test suite 17. (logtest 17)
>>>
>>> Regards
>>> Canh
>>>
>>>
>>> -Original Message-
>>> From: A V Mahesh [mailto:mahesh.va...@oracle.com]
>>> Sent: Tuesday, February 21, 2017 2:10 PM
>>> To: Canh Van Truong; lennart.l...@ericsson.com; 
>>> vu.m.ngu...@dektech.com.au
>>> Cc: opensaf-devel@lists.sourceforge.net
>>> Subject: Re: [PATCH 0 of 3] Review Request for log: implement 
>>> SaLogFilterSetCallbackT and version handling V4 [#2146]
>>>
>>> Hi  Canh,
>>>
>>> I was jut testing Agent in-service upgrade , so I have following 
>>> setup and run the New FilterSetCallback test case and i was 
>>> expecting case should receive fail/not-supported , but they are getting
succeed how ?
>>>
>>>
>>> -SC-2  ACTIVE  Old Node ( LOG is old code with out #2146 patch )
>>> -SC-1  STANDBY  New Node ( LOG is new code with #2146 patch )
>>>
>>> SC-1# /usr/bin/logtest 1 10
>>>
>>> Suite 1: Library Life Cycle
>>>10  PASSED   saLogInitialize() with minor version is set bigger
than
>>> supported version;
>>>
>>> 
>>> 
>>> =
>>>
>>>Test Result:
>>>   Total:  1
>>>   Passed: 1
>>>   Failed: 0
>>>
>>> SC-1# /usr/bin/logtest 1 11
>>>
>>> Suite 1: Library Life Cycle
>>>11  PASSED   saLogInitialize() with minor version is not set;
>>>
>>> 
>>> 
>>> =
>>>
>>>Test Result:
>>>   Total:  1
>>>   Passed: 1
>>>   Failed: 0
>>>
>>> -AVM
>>>
>>> On 2/16/2017 12:18 PM, Canh Van Truong wrote:
 Summary: log: implement SaLogFilterSetCallbackT and version 
 handling
 V4 [#2146] Review request for Trac Ticket(s): #2146 Peer Reviewer(s):
 Lennart, Vu, Mahesh Pull request to: Vu Affected branch(es): 
 default Development branch: default

 
 Impacted area   Impact y/n
 
  Docsn
  Build systemn
  RPM/packaging   n
  Configuration files n
  Startup scripts n
  SAF servicesn
  OpenSAF servicesy
  Core libraries  n

Re: [devel] [PATCH 0 of 3] Review Request for log: implement SaLogFilterSetCallbackT and version handling V4 [#2146]

[A V Mahesh]

Hi Canh,

ACK tested ( including agent upgrade )

-AVM

On 2/21/2017 3:11 PM, Canh Truong wrote:
> Hi Mahesh,
>
> The saLogFilterSetCallback is already existing in spec. But it has not
> implemented yet. The patch implemented to received filter callback from log
> server. So we increase version to A.02.03.
> You can refer at Lennart's comments in
> https://sourceforge.net/p/opensaf/tickets/2146/ for version handling.
>
> Regards
> Canh
>
> -Original Message-
> From: A V Mahesh [mailto:mahesh.va...@oracle.com]
> Sent: Tuesday, February 21, 2017 4:31 PM
> To: Canh Truong; lennart.l...@ericsson.com; vu.m.ngu...@dektech.com.au
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: Re: [devel] [PATCH 0 of 3] Review Request for log: implement
> SaLogFilterSetCallbackT and version handling V4 [#2146]
>
> Hi Canh,
>
> I am sorry saLogFilterSetCallback is existing call back in specification and
> it seem we increased initialized  version jut to support  agent version is
> that right ?
>
> -AVM
>
> On 2/21/2017 2:51 PM, A V Mahesh wrote:
>> Hi Canh,
>>
>> The  general practice of implementing  any upcoming functionality of
>> SAF specification we do define in relevant structures
>> `src//saf/` file for example
>> `src/ckpt/saf/saCkpt_B_02_03.h` in addition to
>> `src/ckpt/saf/saCkpt.h`, so that user will include that new .h file
>> for new definitions
>>
>> Is their any reson  `SaLogFilterSetCallbackT` didn't followed this ?
>> How application will include this  `SaLogFilterSetCallbackT` ?
>>
>> -AVM
>>
>> On 2/21/2017 2:07 PM, A V Mahesh wrote:
>>> Hi Canh,
>>>
>>> I can see that you are passing NULL callbacks as `` for
>>> "logtest 1 10" and " logtest 1 11" by seeing
>>>
>>> -AVM
>>>
>>>
>>> On 2/21/2017 1:02 PM, Canh Truong wrote:
 Hi Mahesh,

 The test case " logtest 1 10" and " logtest 1 11"  are created for
 version handling. In standby node, it has new code for log agent
 (with #2146), that means that version handling in log agent have been
> added.
 The log agent check if minor version bigger than the agent support,
 it will return ERROR_VERSION.  The test case is successful.

 In test case 11, log agent reassign for version of client is A.02.01
 before sending to the initialized request to log server. So the test
 case is successful.

 The test cases for filter callback is in test suite 17. (logtest 17)

 Regards
 Canh


 -Original Message-
 From: A V Mahesh [mailto:mahesh.va...@oracle.com]
 Sent: Tuesday, February 21, 2017 2:10 PM
 To: Canh Van Truong; lennart.l...@ericsson.com;
 vu.m.ngu...@dektech.com.au
 Cc: opensaf-devel@lists.sourceforge.net
 Subject: Re: [PATCH 0 of 3] Review Request for log: implement
 SaLogFilterSetCallbackT and version handling V4 [#2146]

 Hi  Canh,

 I was jut testing Agent in-service upgrade , so I have following
 setup and run the New FilterSetCallback test case and i was
 expecting case should receive fail/not-supported , but they are getting
> succeed how ?

 -SC-2  ACTIVE  Old Node ( LOG is old code with out #2146 patch )
 -SC-1  STANDBY  New Node ( LOG is new code with #2146 patch )

 SC-1# /usr/bin/logtest 1 10

 Suite 1: Library Life Cycle
 10  PASSED   saLogInitialize() with minor version is set bigger
> than
 supported version;

 
 
 =

 Test Result:
Total:  1
Passed: 1
Failed: 0

 SC-1# /usr/bin/logtest 1 11

 Suite 1: Library Life Cycle
 11  PASSED   saLogInitialize() with minor version is not set;

 
 
 =

 Test Result:
Total:  1
Passed: 1
Failed: 0

 -AVM

 On 2/16/2017 12:18 PM, Canh Van Truong wrote:
> Summary: log: implement SaLogFilterSetCallbackT and version
> handling
> V4 [#2146] Review request for Trac Ticket(s): #2146 Peer Reviewer(s):
> Lennart, Vu, Mahesh Pull request to: Vu Affected branch(es):
> default Development branch: default
>
> 
> Impacted area   Impact y/n
> 
>   Docsn
>   Build systemn
>   RPM/packaging   n
>   Configuration files n
>   Startup scripts n
>   SAF servicesn
>   OpenSAF servicesy
>   Core libraries  n
>   Samples n
>   Tests   n
>   Other   n
>
>
> Comments (indicate scope for each "y" above):
> -
>   

Re: [devel] [PATCH 0 of 3] Review Request for log: implement SaLogFilterSetCallbackT and version handling V4 [#2146]

[Canh Truong]

Hi Mahesh,

The saLogFilterSetCallback is already existing in spec. But it has not
implemented yet. The patch implemented to received filter callback from log
server. So we increase version to A.02.03.
You can refer at Lennart's comments in
https://sourceforge.net/p/opensaf/tickets/2146/ for version handling.

Regards
Canh

-Original Message-
From: A V Mahesh [mailto:mahesh.va...@oracle.com] 
Sent: Tuesday, February 21, 2017 4:31 PM
To: Canh Truong; lennart.l...@ericsson.com; vu.m.ngu...@dektech.com.au
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH 0 of 3] Review Request for log: implement
SaLogFilterSetCallbackT and version handling V4 [#2146]

Hi Canh,

I am sorry saLogFilterSetCallback is existing call back in specification and
it seem we increased initialized  version jut to support  agent version is
that right ?

-AVM

On 2/21/2017 2:51 PM, A V Mahesh wrote:
> Hi Canh,
>
> The  general practice of implementing  any upcoming functionality of 
> SAF specification we do define in relevant structures 
> `src//saf/` file for example 
> `src/ckpt/saf/saCkpt_B_02_03.h` in addition to 
> `src/ckpt/saf/saCkpt.h`, so that user will include that new .h file 
> for new definitions
>
> Is their any reson  `SaLogFilterSetCallbackT` didn't followed this ?
> How application will include this  `SaLogFilterSetCallbackT` ?
>
> -AVM
>
> On 2/21/2017 2:07 PM, A V Mahesh wrote:
>> Hi Canh,
>>
>> I can see that you are passing NULL callbacks as `` for 
>> "logtest 1 10" and " logtest 1 11" by seeing
>>
>> -AVM
>>
>>
>> On 2/21/2017 1:02 PM, Canh Truong wrote:
>>> Hi Mahesh,
>>>
>>> The test case " logtest 1 10" and " logtest 1 11"  are created for 
>>> version handling. In standby node, it has new code for log agent 
>>> (with #2146), that means that version handling in log agent have been
added.
>>> The log agent check if minor version bigger than the agent support, 
>>> it will return ERROR_VERSION.  The test case is successful.
>>>
>>> In test case 11, log agent reassign for version of client is A.02.01 
>>> before sending to the initialized request to log server. So the test 
>>> case is successful.
>>>
>>> The test cases for filter callback is in test suite 17. (logtest 17)
>>>
>>> Regards
>>> Canh
>>>
>>>
>>> -Original Message-
>>> From: A V Mahesh [mailto:mahesh.va...@oracle.com]
>>> Sent: Tuesday, February 21, 2017 2:10 PM
>>> To: Canh Van Truong; lennart.l...@ericsson.com; 
>>> vu.m.ngu...@dektech.com.au
>>> Cc: opensaf-devel@lists.sourceforge.net
>>> Subject: Re: [PATCH 0 of 3] Review Request for log: implement 
>>> SaLogFilterSetCallbackT and version handling V4 [#2146]
>>>
>>> Hi  Canh,
>>>
>>> I was jut testing Agent in-service upgrade , so I have following 
>>> setup and run the New FilterSetCallback test case and i was 
>>> expecting case should receive fail/not-supported , but they are getting
succeed how ?
>>>
>>>
>>> -SC-2  ACTIVE  Old Node ( LOG is old code with out #2146 patch )
>>> -SC-1  STANDBY  New Node ( LOG is new code with #2146 patch )
>>>
>>> SC-1# /usr/bin/logtest 1 10
>>>
>>> Suite 1: Library Life Cycle
>>>10  PASSED   saLogInitialize() with minor version is set bigger
than
>>> supported version;
>>>
>>> 
>>> 
>>> =
>>>
>>>Test Result:
>>>   Total:  1
>>>   Passed: 1
>>>   Failed: 0
>>>
>>> SC-1# /usr/bin/logtest 1 11
>>>
>>> Suite 1: Library Life Cycle
>>>11  PASSED   saLogInitialize() with minor version is not set;
>>>
>>> 
>>> 
>>> =
>>>
>>>Test Result:
>>>   Total:  1
>>>   Passed: 1
>>>   Failed: 0
>>>
>>> -AVM
>>>
>>> On 2/16/2017 12:18 PM, Canh Van Truong wrote:
 Summary: log: implement SaLogFilterSetCallbackT and version 
 handling
 V4 [#2146] Review request for Trac Ticket(s): #2146 Peer Reviewer(s):
 Lennart, Vu, Mahesh Pull request to: Vu Affected branch(es): 
 default Development branch: default

 
 Impacted area   Impact y/n
 
  Docsn
  Build systemn
  RPM/packaging   n
  Configuration files n
  Startup scripts n
  SAF servicesn
  OpenSAF servicesy
  Core libraries  n
  Samples n
  Tests   n
  Other   n


 Comments (indicate scope for each "y" above):
 -
  <>

 changeset 05726400fc1a27cf50255b70bb7f952156cbe68f
 Author:Canh Van Truong 
 Date:  Mon, 21 Nov 2016 17:19:56 +0700

log: implement SaLogFilterSetCallbackT [#2146]

Implement 

Re: [devel] [PATCH 0 of 3] Review Request for log: implement SaLogFilterSetCallbackT and version handling V4 [#2146]

[A V Mahesh]

Hi Canh,

I am sorry saLogFilterSetCallback is existing call back in specification
and it seem we increased initialized  version jut to support  agent 
version is that right ?

-AVM

On 2/21/2017 2:51 PM, A V Mahesh wrote:
> Hi Canh,
>
> The  general practice of implementing  any upcoming functionality of SAF
> specification we do define in relevant structures
> `src//saf/` file
> for example `src/ckpt/saf/saCkpt_B_02_03.h` in addition to
> `src/ckpt/saf/saCkpt.h`, so that user will include that new .h file for
> new definitions
>
> Is their any reson  `SaLogFilterSetCallbackT` didn't followed this ?
> How application will include this  `SaLogFilterSetCallbackT` ?
>
> -AVM
>
> On 2/21/2017 2:07 PM, A V Mahesh wrote:
>> Hi Canh,
>>
>> I can see that you are passing NULL callbacks as `` for
>> "logtest 1 10" and " logtest 1 11" by seeing
>>
>> -AVM
>>
>>
>> On 2/21/2017 1:02 PM, Canh Truong wrote:
>>> Hi Mahesh,
>>>
>>> The test case " logtest 1 10" and " logtest 1 11"  are created for version
>>> handling. In standby node, it has new code for log agent (with #2146), that
>>> means that version handling in log agent have been added.
>>> The log agent check if minor version bigger than the agent support, it will
>>> return ERROR_VERSION.  The test case is successful.
>>>
>>> In test case 11, log agent reassign for version of client is A.02.01 before
>>> sending to the initialized request to log server. So the test case is
>>> successful.
>>>
>>> The test cases for filter callback is in test suite 17. (logtest 17)
>>>
>>> Regards
>>> Canh
>>>
>>>
>>> -Original Message-
>>> From: A V Mahesh [mailto:mahesh.va...@oracle.com]
>>> Sent: Tuesday, February 21, 2017 2:10 PM
>>> To: Canh Van Truong; lennart.l...@ericsson.com; vu.m.ngu...@dektech.com.au
>>> Cc: opensaf-devel@lists.sourceforge.net
>>> Subject: Re: [PATCH 0 of 3] Review Request for log: implement
>>> SaLogFilterSetCallbackT and version handling V4 [#2146]
>>>
>>> Hi  Canh,
>>>
>>> I was jut testing Agent in-service upgrade , so I have following setup and
>>> run the New FilterSetCallback test case and i was expecting case should
>>> receive fail/not-supported , but they are getting succeed how ?
>>>
>>>
>>> -SC-2  ACTIVE  Old Node ( LOG is old code with out #2146 patch )
>>> -SC-1  STANDBY  New Node ( LOG is new code with #2146 patch )
>>>
>>> SC-1# /usr/bin/logtest 1 10
>>>
>>> Suite 1: Library Life Cycle
>>>10  PASSED   saLogInitialize() with minor version is set bigger than
>>> supported version;
>>>
>>> 
>>> =
>>>
>>>Test Result:
>>>   Total:  1
>>>   Passed: 1
>>>   Failed: 0
>>>
>>> SC-1# /usr/bin/logtest 1 11
>>>
>>> Suite 1: Library Life Cycle
>>>11  PASSED   saLogInitialize() with minor version is not set;
>>>
>>> 
>>> =
>>>
>>>Test Result:
>>>   Total:  1
>>>   Passed: 1
>>>   Failed: 0
>>>
>>> -AVM
>>>
>>> On 2/16/2017 12:18 PM, Canh Van Truong wrote:
 Summary: log: implement SaLogFilterSetCallbackT and version handling
 V4 [#2146] Review request for Trac Ticket(s): #2146 Peer Reviewer(s):
 Lennart, Vu, Mahesh Pull request to: Vu Affected branch(es): default
 Development branch: default

 
 Impacted area   Impact y/n
 
  Docsn
  Build systemn
  RPM/packaging   n
  Configuration files n
  Startup scripts n
  SAF servicesn
  OpenSAF servicesy
  Core libraries  n
  Samples n
  Tests   n
  Other   n


 Comments (indicate scope for each "y" above):
 -
  <>

 changeset 05726400fc1a27cf50255b70bb7f952156cbe68f
 Author:Canh Van Truong 
 Date:  Mon, 21 Nov 2016 17:19:56 +0700

log: implement SaLogFilterSetCallbackT [#2146]

Implement SaLogFilterSetCallbackT which is mentioned at section
>>> 3.6.5
SaLogFilterSetCallbackT @ AIS LOG document.

LGS:
 - Whenever severity filter is changed for app and systerm
>>> streams, lgs will
find which clients that associate with the stream. Then lgs sends
>>> message
callback to clients.
 - Encoding callback message for severity filter callback

LGA:
 - Decoding callback message for severity callback from lgs and
>>> send the
message to the client which setting filter callback.
 - Dispatching severity filter callback

- Encrease version of log service to A.02.03

 changeset 

Re: [devel] [PATCH 0 of 3] Review Request for log: implement SaLogFilterSetCallbackT and version handling V4 [#2146]

[A V Mahesh]

Hi Canh,

The  general practice of implementing  any upcoming functionality of SAF 
specification we do define in relevant structures 
`src//saf/` file
for example `src/ckpt/saf/saCkpt_B_02_03.h` in addition to 
`src/ckpt/saf/saCkpt.h`, so that user will include that new .h file for 
new definitions

Is their any reson  `SaLogFilterSetCallbackT` didn't followed this ?
How application will include this  `SaLogFilterSetCallbackT` ?

-AVM

On 2/21/2017 2:07 PM, A V Mahesh wrote:
> Hi Canh,
>
> I can see that you are passing NULL callbacks as `` for
> "logtest 1 10" and " logtest 1 11" by seeing
>
> -AVM
>
>
> On 2/21/2017 1:02 PM, Canh Truong wrote:
>> Hi Mahesh,
>>
>> The test case " logtest 1 10" and " logtest 1 11"  are created for version
>> handling. In standby node, it has new code for log agent (with #2146), that
>> means that version handling in log agent have been added.
>> The log agent check if minor version bigger than the agent support, it will
>> return ERROR_VERSION.  The test case is successful.
>>
>> In test case 11, log agent reassign for version of client is A.02.01 before
>> sending to the initialized request to log server. So the test case is
>> successful.
>>
>> The test cases for filter callback is in test suite 17. (logtest 17)
>>
>> Regards
>> Canh
>>
>>
>> -Original Message-
>> From: A V Mahesh [mailto:mahesh.va...@oracle.com]
>> Sent: Tuesday, February 21, 2017 2:10 PM
>> To: Canh Van Truong; lennart.l...@ericsson.com; vu.m.ngu...@dektech.com.au
>> Cc: opensaf-devel@lists.sourceforge.net
>> Subject: Re: [PATCH 0 of 3] Review Request for log: implement
>> SaLogFilterSetCallbackT and version handling V4 [#2146]
>>
>> Hi  Canh,
>>
>> I was jut testing Agent in-service upgrade , so I have following setup and
>> run the New FilterSetCallback test case and i was expecting case should
>> receive fail/not-supported , but they are getting succeed how ?
>>
>>
>> -SC-2  ACTIVE  Old Node ( LOG is old code with out #2146 patch )
>> -SC-1  STANDBY  New Node ( LOG is new code with #2146 patch )
>>
>> SC-1# /usr/bin/logtest 1 10
>>
>> Suite 1: Library Life Cycle
>>   10  PASSED   saLogInitialize() with minor version is set bigger than
>> supported version;
>>
>> 
>> =
>>
>>   Test Result:
>>  Total:  1
>>  Passed: 1
>>  Failed: 0
>>
>> SC-1# /usr/bin/logtest 1 11
>>
>> Suite 1: Library Life Cycle
>>   11  PASSED   saLogInitialize() with minor version is not set;
>>
>> 
>> =
>>
>>   Test Result:
>>  Total:  1
>>  Passed: 1
>>  Failed: 0
>>
>> -AVM
>>
>> On 2/16/2017 12:18 PM, Canh Van Truong wrote:
>>> Summary: log: implement SaLogFilterSetCallbackT and version handling
>>> V4 [#2146] Review request for Trac Ticket(s): #2146 Peer Reviewer(s):
>>> Lennart, Vu, Mahesh Pull request to: Vu Affected branch(es): default
>>> Development branch: default
>>>
>>> 
>>> Impacted area   Impact y/n
>>> 
>>> Docsn
>>> Build systemn
>>> RPM/packaging   n
>>> Configuration files n
>>> Startup scripts n
>>> SAF servicesn
>>> OpenSAF servicesy
>>> Core libraries  n
>>> Samples n
>>> Tests   n
>>> Other   n
>>>
>>>
>>> Comments (indicate scope for each "y" above):
>>> -
>>> <>
>>>
>>> changeset 05726400fc1a27cf50255b70bb7f952156cbe68f
>>> Author: Canh Van Truong 
>>> Date:   Mon, 21 Nov 2016 17:19:56 +0700
>>>
>>> log: implement SaLogFilterSetCallbackT [#2146]
>>>
>>> Implement SaLogFilterSetCallbackT which is mentioned at section
>> 3.6.5
>>> SaLogFilterSetCallbackT @ AIS LOG document.
>>>
>>> LGS:
>>>  - Whenever severity filter is changed for app and systerm
>> streams, lgs will
>>> find which clients that associate with the stream. Then lgs sends
>> message
>>> callback to clients.
>>>  - Encoding callback message for severity filter callback
>>>
>>> LGA:
>>>  - Decoding callback message for severity callback from lgs and
>> send the
>>> message to the client which setting filter callback.
>>>  - Dispatching severity filter callback
>>>
>>> - Encrease version of log service to A.02.03
>>>
>>> changeset 8d41edf85334f1b14d858e2ad2f705aecf6b9a68
>>> Author: Canh Van Truong 
>>> Date:   Tue, 17 Jan 2017 14:24:33 +0700
>>>
>>> log: Add minor version checking in log server [#2146]
>>>
>>> Checking minor version and return version error if major/minor
>> version is
>>> higher than supported major/minor
>>>
>>> Add client_version to log_client_t 

Re: [devel] [PATCH 0 of 3] Review Request for log: implement SaLogFilterSetCallbackT and version handling V4 [#2146]

[A V Mahesh]

Hi Canh,

I can see that you are passing NULL callbacks as `` for 
"logtest 1 10" and " logtest 1 11" by seeing

-AVM


On 2/21/2017 1:02 PM, Canh Truong wrote:
> Hi Mahesh,
>
> The test case " logtest 1 10" and " logtest 1 11"  are created for version
> handling. In standby node, it has new code for log agent (with #2146), that
> means that version handling in log agent have been added.
> The log agent check if minor version bigger than the agent support, it will
> return ERROR_VERSION.  The test case is successful.
>
> In test case 11, log agent reassign for version of client is A.02.01 before
> sending to the initialized request to log server. So the test case is
> successful.
>
> The test cases for filter callback is in test suite 17. (logtest 17)
>
> Regards
> Canh
>
>
> -Original Message-
> From: A V Mahesh [mailto:mahesh.va...@oracle.com]
> Sent: Tuesday, February 21, 2017 2:10 PM
> To: Canh Van Truong; lennart.l...@ericsson.com; vu.m.ngu...@dektech.com.au
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: Re: [PATCH 0 of 3] Review Request for log: implement
> SaLogFilterSetCallbackT and version handling V4 [#2146]
>
> Hi  Canh,
>
> I was jut testing Agent in-service upgrade , so I have following setup and
> run the New FilterSetCallback test case and i was expecting case should
> receive fail/not-supported , but they are getting succeed how ?
>
>
> -SC-2  ACTIVE  Old Node ( LOG is old code with out #2146 patch )
> -SC-1  STANDBY  New Node ( LOG is new code with #2146 patch )
>
> SC-1# /usr/bin/logtest 1 10
>
> Suite 1: Library Life Cycle
>  10  PASSED   saLogInitialize() with minor version is set bigger than
> supported version;
>
> 
> =
>
>  Test Result:
> Total:  1
> Passed: 1
> Failed: 0
>
> SC-1# /usr/bin/logtest 1 11
>
> Suite 1: Library Life Cycle
>  11  PASSED   saLogInitialize() with minor version is not set;
>
> 
> =
>
>  Test Result:
> Total:  1
> Passed: 1
> Failed: 0
>
> -AVM
>
> On 2/16/2017 12:18 PM, Canh Van Truong wrote:
>> Summary: log: implement SaLogFilterSetCallbackT and version handling
>> V4 [#2146] Review request for Trac Ticket(s): #2146 Peer Reviewer(s):
>> Lennart, Vu, Mahesh Pull request to: Vu Affected branch(es): default
>> Development branch: default
>>
>> 
>> Impacted area   Impact y/n
>> 
>>Docsn
>>Build systemn
>>RPM/packaging   n
>>Configuration files n
>>Startup scripts n
>>SAF servicesn
>>OpenSAF servicesy
>>Core libraries  n
>>Samples n
>>Tests   n
>>Other   n
>>
>>
>> Comments (indicate scope for each "y" above):
>> -
>><>
>>
>> changeset 05726400fc1a27cf50255b70bb7f952156cbe68f
>> Author:  Canh Van Truong 
>> Date:Mon, 21 Nov 2016 17:19:56 +0700
>>
>>  log: implement SaLogFilterSetCallbackT [#2146]
>>
>>  Implement SaLogFilterSetCallbackT which is mentioned at section
> 3.6.5
>>  SaLogFilterSetCallbackT @ AIS LOG document.
>>
>>  LGS:
>>   - Whenever severity filter is changed for app and systerm
> streams, lgs will
>>  find which clients that associate with the stream. Then lgs sends
> message
>>  callback to clients.
>>   - Encoding callback message for severity filter callback
>>
>>  LGA:
>>   - Decoding callback message for severity callback from lgs and
> send the
>>  message to the client which setting filter callback.
>>   - Dispatching severity filter callback
>>
>>  - Encrease version of log service to A.02.03
>>
>> changeset 8d41edf85334f1b14d858e2ad2f705aecf6b9a68
>> Author:  Canh Van Truong 
>> Date:Tue, 17 Jan 2017 14:24:33 +0700
>>
>>  log: Add minor version checking in log server [#2146]
>>
>>  Checking minor version and return version error if major/minor
> version is
>>  higher than supported major/minor
>>
>>  Add client_version to log_client_t and checkpoint struct in lgs
>>
>>  Increase checkpoint version and checkpoint client_ver to stand by
>>
>>  Only send filter callback to client that initialized with minor
>> version > 3
>>
>> changeset ff130149eb45136a50563878431a92b52e024997
>> Author:  Canh Van Truong 
>> Date:Tue, 17 Jan 2017 15:42:40 +0700
>>
>>  log: fix checking version in log agent [#2146]
>>
>>  Fix checking version in log agent
>>
>>  The agent report highest supported version except getting
> ERR_VERSION from
>>  server. if agent get ERR_VERSION, it will set supported 

Re: [devel] [PATCH 0 of 3] Review Request for log: implement SaLogFilterSetCallbackT and version handling V4 [#2146]

[Canh Truong]

Hi Mahesh,

The test case " logtest 1 10" and " logtest 1 11"  are created for version
handling. In standby node, it has new code for log agent (with #2146), that
means that version handling in log agent have been added.  
The log agent check if minor version bigger than the agent support, it will
return ERROR_VERSION.  The test case is successful.

In test case 11, log agent reassign for version of client is A.02.01 before
sending to the initialized request to log server. So the test case is
successful.

The test cases for filter callback is in test suite 17. (logtest 17)

Regards
Canh


-Original Message-
From: A V Mahesh [mailto:mahesh.va...@oracle.com] 
Sent: Tuesday, February 21, 2017 2:10 PM
To: Canh Van Truong; lennart.l...@ericsson.com; vu.m.ngu...@dektech.com.au
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 0 of 3] Review Request for log: implement
SaLogFilterSetCallbackT and version handling V4 [#2146]

Hi  Canh,

I was jut testing Agent in-service upgrade , so I have following setup and
run the New FilterSetCallback test case and i was expecting case should
receive fail/not-supported , but they are getting succeed how ?


-SC-2  ACTIVE  Old Node ( LOG is old code with out #2146 patch )
-SC-1  STANDBY  New Node ( LOG is new code with #2146 patch )

SC-1# /usr/bin/logtest 1 10

Suite 1: Library Life Cycle
10  PASSED   saLogInitialize() with minor version is set bigger than 
supported version;


=

Test Result:
   Total:  1
   Passed: 1
   Failed: 0

SC-1# /usr/bin/logtest 1 11

Suite 1: Library Life Cycle
11  PASSED   saLogInitialize() with minor version is not set;


=

Test Result:
   Total:  1
   Passed: 1
   Failed: 0

-AVM

On 2/16/2017 12:18 PM, Canh Van Truong wrote:
> Summary: log: implement SaLogFilterSetCallbackT and version handling 
> V4 [#2146] Review request for Trac Ticket(s): #2146 Peer Reviewer(s): 
> Lennart, Vu, Mahesh Pull request to: Vu Affected branch(es): default 
> Development branch: default
>
> 
> Impacted area   Impact y/n
> 
>   Docsn
>   Build systemn
>   RPM/packaging   n
>   Configuration files n
>   Startup scripts n
>   SAF servicesn
>   OpenSAF servicesy
>   Core libraries  n
>   Samples n
>   Tests   n
>   Other   n
>
>
> Comments (indicate scope for each "y" above):
> -
>   <>
>
> changeset 05726400fc1a27cf50255b70bb7f952156cbe68f
> Author:   Canh Van Truong 
> Date: Mon, 21 Nov 2016 17:19:56 +0700
>
>   log: implement SaLogFilterSetCallbackT [#2146]
>
>   Implement SaLogFilterSetCallbackT which is mentioned at section
3.6.5
>   SaLogFilterSetCallbackT @ AIS LOG document.
>
>   LGS:
>- Whenever severity filter is changed for app and systerm
streams, lgs will
>   find which clients that associate with the stream. Then lgs sends
message
>   callback to clients.
>- Encoding callback message for severity filter callback
>
>   LGA:
>- Decoding callback message for severity callback from lgs and
send the
>   message to the client which setting filter callback.
>- Dispatching severity filter callback
>
>   - Encrease version of log service to A.02.03
>
> changeset 8d41edf85334f1b14d858e2ad2f705aecf6b9a68
> Author:   Canh Van Truong 
> Date: Tue, 17 Jan 2017 14:24:33 +0700
>
>   log: Add minor version checking in log server [#2146]
>
>   Checking minor version and return version error if major/minor
version is
>   higher than supported major/minor
>
>   Add client_version to log_client_t and checkpoint struct in lgs
>
>   Increase checkpoint version and checkpoint client_ver to stand by
>
>   Only send filter callback to client that initialized with minor 
> version > 3
>
> changeset ff130149eb45136a50563878431a92b52e024997
> Author:   Canh Van Truong 
> Date: Tue, 17 Jan 2017 15:42:40 +0700
>
>   log: fix checking version in log agent [#2146]
>
>   Fix checking version in log agent
>
>   The agent report highest supported version except getting
ERR_VERSION from
>   server. if agent get ERR_VERSION, it will set supported version to 
> A.02.03
>
>
> Added Files:
> 
>   src/log/logd/lgs_mbcsv_v6.cc
>   src/log/logd/lgs_mbcsv_v6.h
>
>
> Complete diffstat:
> --
>   src/log/Makefile.am   |3 +
>   src/log/agent/lga.h   |4 +
>   src/log/agent/lga_api.c   |   58 +++--
>   

Re: [devel] [PATCH 0 of 3] Review Request for log: implement SaLogFilterSetCallbackT and version handling V4 [#2146]

[A V Mahesh]

Hi  Canh,

I was jut testing Agent in-service upgrade , so I have following setup 
and run the New FilterSetCallback test case
and i was expecting case should receive fail/not-supported , but they 
are getting succeed how ?


-SC-2  ACTIVE  Old Node ( LOG is old code with out #2146 patch )
-SC-1  STANDBY  New Node ( LOG is new code with #2146 patch )

SC-1# /usr/bin/logtest 1 10

Suite 1: Library Life Cycle
10  PASSED   saLogInitialize() with minor version is set bigger than 
supported version;

=

Test Result:
   Total:  1
   Passed: 1
   Failed: 0

SC-1# /usr/bin/logtest 1 11

Suite 1: Library Life Cycle
11  PASSED   saLogInitialize() with minor version is not set;

=

Test Result:
   Total:  1
   Passed: 1
   Failed: 0

-AVM

On 2/16/2017 12:18 PM, Canh Van Truong wrote:
> Summary: log: implement SaLogFilterSetCallbackT and version handling V4 
> [#2146]
> Review request for Trac Ticket(s): #2146
> Peer Reviewer(s): Lennart, Vu, Mahesh
> Pull request to: Vu
> Affected branch(es): default
> Development branch: default
>
> 
> Impacted area   Impact y/n
> 
>   Docsn
>   Build systemn
>   RPM/packaging   n
>   Configuration files n
>   Startup scripts n
>   SAF servicesn
>   OpenSAF servicesy
>   Core libraries  n
>   Samples n
>   Tests   n
>   Other   n
>
>
> Comments (indicate scope for each "y" above):
> -
>   <>
>
> changeset 05726400fc1a27cf50255b70bb7f952156cbe68f
> Author:   Canh Van Truong 
> Date: Mon, 21 Nov 2016 17:19:56 +0700
>
>   log: implement SaLogFilterSetCallbackT [#2146]
>
>   Implement SaLogFilterSetCallbackT which is mentioned at section 3.6.5
>   SaLogFilterSetCallbackT @ AIS LOG document.
>
>   LGS:
>- Whenever severity filter is changed for app and systerm streams, 
> lgs will
>   find which clients that associate with the stream. Then lgs sends 
> message
>   callback to clients.
>- Encoding callback message for severity filter callback
>
>   LGA:
>- Decoding callback message for severity callback from lgs and 
> send the
>   message to the client which setting filter callback.
>- Dispatching severity filter callback
>
>   - Encrease version of log service to A.02.03
>
> changeset 8d41edf85334f1b14d858e2ad2f705aecf6b9a68
> Author:   Canh Van Truong 
> Date: Tue, 17 Jan 2017 14:24:33 +0700
>
>   log: Add minor version checking in log server [#2146]
>
>   Checking minor version and return version error if major/minor version 
> is
>   higher than supported major/minor
>
>   Add client_version to log_client_t and checkpoint struct in lgs
>
>   Increase checkpoint version and checkpoint client_ver to stand by
>
>   Only send filter callback to client that initialized with minor version 
> > 3
>
> changeset ff130149eb45136a50563878431a92b52e024997
> Author:   Canh Van Truong 
> Date: Tue, 17 Jan 2017 15:42:40 +0700
>
>   log: fix checking version in log agent [#2146]
>
>   Fix checking version in log agent
>
>   The agent report highest supported version except getting ERR_VERSION 
> from
>   server. if agent get ERR_VERSION, it will set supported version to 
> A.02.03
>
>
> Added Files:
> 
>   src/log/logd/lgs_mbcsv_v6.cc
>   src/log/logd/lgs_mbcsv_v6.h
>
>
> Complete diffstat:
> --
>   src/log/Makefile.am   |3 +
>   src/log/agent/lga.h   |4 +
>   src/log/agent/lga_api.c   |   58 +++--
>   src/log/agent/lga_mds.c   |   71 ++
>   src/log/agent/lga_util.c  |   64 +++-
>   src/log/apitest/logtest.c |3 +-
>   src/log/apitest/logtestfr.c   |3 +-
>   src/log/apitest/saflogtest.c  |3 +-
>   src/log/apitest/tet_LogOiOps.c|   72 ++
>   src/log/apitest/tet_log_longDN.c  |3 +-
>   src/log/apitest/tet_saLogFilterSetCallbackT.c |  418 
> -
>   src/log/apitest/tet_saLogInitialize.c |   24 +++
>   src/log/apitest/tet_saLogStreamOpen_2.c   |3 +-
>   src/log/common/lgsv_defs.h|7 +-
>   src/log/common/lgsv_msg.h |8 ++
>   src/log/logd/lgs_cb.h 

[devel] [PATCH 0 of 3] Review Request for log: implement SaLogFilterSetCallbackT and version handling V4 [#2146]

[Canh Van Truong]

Summary: log: implement SaLogFilterSetCallbackT and version handling V4 [#2146]
Review request for Trac Ticket(s): #2146
Peer Reviewer(s): Lennart, Vu, Mahesh
Pull request to: Vu
Affected branch(es): default
Development branch: default


Impacted area   Impact y/n

 Docsn
 Build systemn
 RPM/packaging   n
 Configuration files n
 Startup scripts n
 SAF servicesn
 OpenSAF servicesy
 Core libraries  n
 Samples n
 Tests   n
 Other   n


Comments (indicate scope for each "y" above):
-
 <>

changeset 05726400fc1a27cf50255b70bb7f952156cbe68f
Author: Canh Van Truong 
Date:   Mon, 21 Nov 2016 17:19:56 +0700

log: implement SaLogFilterSetCallbackT [#2146]

Implement SaLogFilterSetCallbackT which is mentioned at section 3.6.5
SaLogFilterSetCallbackT @ AIS LOG document.

LGS:
 - Whenever severity filter is changed for app and systerm streams, 
lgs will
find which clients that associate with the stream. Then lgs sends 
message
callback to clients.
 - Encoding callback message for severity filter callback

LGA:
 - Decoding callback message for severity callback from lgs and 
send the
message to the client which setting filter callback.
 - Dispatching severity filter callback

- Encrease version of log service to A.02.03

changeset 8d41edf85334f1b14d858e2ad2f705aecf6b9a68
Author: Canh Van Truong 
Date:   Tue, 17 Jan 2017 14:24:33 +0700

log: Add minor version checking in log server [#2146]

Checking minor version and return version error if major/minor version 
is
higher than supported major/minor

Add client_version to log_client_t and checkpoint struct in lgs

Increase checkpoint version and checkpoint client_ver to stand by

Only send filter callback to client that initialized with minor version 
> 3

changeset ff130149eb45136a50563878431a92b52e024997
Author: Canh Van Truong 
Date:   Tue, 17 Jan 2017 15:42:40 +0700

log: fix checking version in log agent [#2146]

Fix checking version in log agent

The agent report highest supported version except getting ERR_VERSION 
from
server. if agent get ERR_VERSION, it will set supported version to 
A.02.03


Added Files:

 src/log/logd/lgs_mbcsv_v6.cc
 src/log/logd/lgs_mbcsv_v6.h


Complete diffstat:
--
 src/log/Makefile.am   |3 +
 src/log/agent/lga.h   |4 +
 src/log/agent/lga_api.c   |   58 +++--
 src/log/agent/lga_mds.c   |   71 ++
 src/log/agent/lga_util.c  |   64 +++-
 src/log/apitest/logtest.c |3 +-
 src/log/apitest/logtestfr.c   |3 +-
 src/log/apitest/saflogtest.c  |3 +-
 src/log/apitest/tet_LogOiOps.c|   72 ++
 src/log/apitest/tet_log_longDN.c  |3 +-
 src/log/apitest/tet_saLogFilterSetCallbackT.c |  418 
-
 src/log/apitest/tet_saLogInitialize.c |   24 +++
 src/log/apitest/tet_saLogStreamOpen_2.c   |3 +-
 src/log/common/lgsv_defs.h|7 +-
 src/log/common/lgsv_msg.h |8 ++
 src/log/logd/lgs_cb.h |2 +
 src/log/logd/lgs_evt.cc   |   93 
++---
 src/log/logd/lgs_imm.cc   |8 ++
 src/log/logd/lgs_mbcsv.cc |  181 

 src/log/logd/lgs_mbcsv.h  |9 ++-
 src/log/logd/lgs_mbcsv_v6.cc  |  169 
+
 src/log/logd/lgs_mbcsv_v6.h   |   56 +
 src/log/logd/lgs_mds.cc   |   58 --
 src/log/logd/lgs_util.cc  |   96 
++
 src/log/logd/lgs_util.h   |3 +
 src/log/tools/saf_logger.c|3 +-
 src/osaf/saflog/saflog.c  |5 +-
 27 files changed, 1308 insertions(+), 119 deletions(-)


Testing Commands:
-
Create test cases:
logtest 1 10
logtest 1 11
logtest 4 58
logtest 17


Testing, Expected Results:
--
All test cases pass


Conditions of Submission:
-
Ack from reviewers


Arch  Built