Re: [devel] [PATCH 2/5] rded: add split brain prevention support [#64]

2018-01-24 Thread Anders Widell
See comment below, marked AndersW2>. I also have one more comment on the Consensus class: I noticed that it is defined in a file called service.h. Could you rename the file to consensus.h, so that the file name reflects the name of the class defined in it? Also, the file keyvalue.h should be

Re: [devel] [PATCH 2/5] rded: add split brain prevention support [#64]

2018-01-23 Thread Gary Lee
Hi Anders Will change according to your comments, one comment below: On 24/01/18 01:53, Anders Widell wrote: Ack for this patch with comments, marked AndersW> regards, Anders Widell +   case RDE_MSG_NEW_ACTIVE_CALLBACK: +  { +    const std::string my_node = base::Conf::NodeName();

Re: [devel] [PATCH 2/5] rded: add split brain prevention support [#64]

2018-01-23 Thread Anders Widell
Ack for this patch with comments, marked AndersW> regards, Anders Widell On 01/23/2018 09:06 AM, Gary Lee wrote: * consult with consensus service before promoting node to active * add watch thread and self-fence if it detects active controller has been changed (if remote fencing is

[devel] [PATCH 2/5] rded: add split brain prevention support [#64]

2018-01-23 Thread Gary Lee
* consult with consensus service before promoting node to active * add watch thread and self-fence if it detects active controller has been changed (if remote fencing is disabled) --- src/rde/Makefile.am | 3 ++- src/rde/rded/osaf-rded.in | 4 src/rde/rded/rde_cb.h | 4 +++-

[devel] [PATCH 2/5] rded: add split brain prevention support [#64]

2018-01-19 Thread Gary Lee
* consult with consensus service before promoting node to active * add watch thread and self-fence if it detects active controller has been changed (if remote fencing is disabled) --- src/rde/Makefile.am | 3 ++- src/rde/rded/osaf-rded.in | 4 src/rde/rded/rde_cb.h | 3 ++-

[devel] [PATCH 2/5] rded: add split brain prevention support [#64]

2018-01-09 Thread Gary Lee
* consult with consensus service before promoting node to active * add watch thread and self-fence if it detects active controller has been changed --- src/rde/Makefile.am | 3 ++- src/rde/rded/osaf-rded.in | 4 src/rde/rded/rde_cb.h | 3 ++- src/rde/rded/rde_main.cc | 32