[devel] [PATCH 0 of 1] Review Request for amfd: Remove asserts from validation routines [#849]

Summary: amfd: Remove asserts from validation routines [#849] Review request for Trac Ticket(s): 849 Peer Reviewer(s): Hans F, Hans N, Nagendra, Praveen Pull request to: Affected branch(es): all Development branch: default Impacted area Impact y/n

[devel] [PATCH 1 of 1] amfd: Remove asserts from validation routines [#849]

osaf/services/saf/amf/amfd/app.cc| 18 +++--- osaf/services/saf/amf/amfd/comp.cc | 5 +++-- osaf/services/saf/amf/amfd/compcstype.cc | 5 +++-- osaf/services/saf/amf/amfd/hlt.cc| 10 ++ osaf/services/saf/amf/amfd/sg.cc | 9 +

Re: [devel] [PATCH 0 of 1] Review Request for imm: Allow admin-operations directly targeting an implementer/applier [#799]

Will push this tomorrow if there are no objections. /AndersBj -Original Message- From: Anders Bjornerstedt [mailto:anders.bjornerst...@ericsson.com] Sent: den 29 april 2014 16:37 To: reddy.neelaka...@oracle.com; Zoran Milinkovic Cc: opensaf-devel@lists.sourceforge.net Subject: [devel]

[devel] [PATCH 1 of 3] imm: add support for configurable OI callback timeout [#16]

osaf/libs/common/immsv/immsv_evt.c | 56 ++- osaf/libs/common/immsv/include/immsv_evt.h | 4 + osaf/libs/common/immsv/include/immsv_evt_model.h | 1 + osaf/services/saf/immsv/immd/immd_evt.c | 9 ++- osaf/services/saf/immsv/immnd/ImmModel.cc

[devel] [PATCH 3 of 3] immtests: add test cases for OI callback timeout [#16]

tests/immsv/implementer/test_cleanup.c |1 + tests/immsv/implementer/test_saImmOiImplementerSet.c | 287 +++ 2 files changed, 288 insertions(+), 0 deletions(-) Test cases cover OI callback timeout and timeout on searching for an object with RTA diff --git

[devel] [PATCH 2 of 3] imm: use IMMA_OI_CALLBACK_TIMEOUT for setting OI callback timeout [#16]

osaf/libs/agents/saf/imma/imma_cb.h | 1 + osaf/libs/agents/saf/imma/imma_def.h| 1 + osaf/libs/agents/saf/imma/imma_oi_api.c | 23 ++- 3 files changed, 24 insertions(+), 1 deletions(-) IMMA uses IMMA_OI_CALLBACK_TIMEOUT for sending OI timeout to IMM service

[devel] Default value of saAmfSGAutoRepair in opensaf models

Should we change value for saAmfSGAutoRepair (in osaf/services/saf/amf/config/amf_objects.xml) to have the value True since we now actually support this? Thanks, Hans -- Is your legacy SCM system holding you back? Join

[devel] AMF: remove support for MDS_CALLBACK_COPY?

According to MDS documentation COPY support is needed when sending messages to the same MDS core which I interpret as the same linux process. Since AMF does not do that (correct me if I am wrong) this code can/should be removed. I added an assert in the COPY callback and nothing happens...

[devel] [PATCH 1 of 1] osaf: Fix compilation errors when building with GCC 4.9.0 [#883]

osaf/libs/core/common/ncs_main_pub.c | 2 +- osaf/libs/core/common/ncs_sprr.c | 2 +- osaf/libs/core/include/ncssysf_def.h | 4 ++-- osaf/libs/core/leap/hj_dec.c | 4 ++-- osaf/libs/core/leap/hj_enc.c | 8

Re: [devel] [PATCH 1 of 1] osaf: Fix compilation errors when building with GCC 4.9.0 [#883]

Yes that should ALSO be done. :-) There are probably several more places where we have printf. This patch just fixes the missing parentheses. I could fix the printf too, while touching that line. / Anders Widell On 05/08/2014 03:33 PM, Hans Feldt wrote: Why not just replace with trace?

Re: [devel] [PATCH 0 of 3] Review Request for imm: add support for configurable OI callback timeout [#16]

Ack on these patches with the following comments: --- 1) In the imma client you have added: +#define IMMSV_OI_CALLBACK_WAIT_TIME 6 /* Default wait time for OI callback to reply in seconds = 6 sec*/ This default timeout is set in the client if the client has not explicitly

[devel] [PATCH 1 of 1] imm: update immsv/README for IMMA_OI_CALLBACK_TIMEOUT [#16]

osaf/services/saf/immsv/README | 22 ++ 1 files changed, 22 insertions(+), 0 deletions(-) See osaf/services/saf/immsv/README for details on IMMA_OI_CALLBACK_TIMEOUT. diff --git a/osaf/services/saf/immsv/README b/osaf/services/saf/immsv/README ---