[devel] [PATCH 0 of 3] Review Request for leap : now leap library ensure shm availability before writing [#2202]

2016-11-29 Thread mahesh . valla
Summary:leap : now leap library ensure shm availability before writing [#2202] Review request for Trac Ticket(s): #2202 Peer Reviewer(s): Hoang / Ramesh Pull request to: <> Affected branch(es): <> Development branch: <> Impacted area Impact y/n

[devel] [PATCH 1 of 3] leap : now leap library ensure shm availability before writing [#2202]

2016-11-29 Thread mahesh . valla
osaf/libs/core/leap/os_defs.c | 20 ++-- 1 files changed, 18 insertions(+), 2 deletions(-) Issue : If OSAF_CKPT_SHM_ALLOC_GUARANTEE is NOT set and SHM is 100% used in system , pnd Segmentation fault (core dumped) at LEAP memcpy(). Fix : Now LEAP library ensures shm free

Re: [devel] [PATCH 1 of 1] amfnd: return SA_AIS_ERR_NO_OP for error clear api [#245]

2016-11-29 Thread Nagendra Kumar
Thanks Hans. Please specify err parms ? This is the case when there is no error as Oper state is enable. Thanks -Nagu > -Original Message- > From: Hans Nordeback [mailto:hans.nordeb...@ericsson.com] > Sent: 29 November 2016 12:55 > To: Nagendra Kumar; Praveen Malviya;

[devel] [PATCH 0 of 1] Review Request for amfd: finalize imm handle before init in thread[#2188] V3

2016-11-29 Thread praveen . malviya
Summary: amfd: finalize imm handle before init in thread[#2188] V3 Review request for Trac Ticket(s): #2188 Peer Reviewer(s): AMF devs Pull request to: <> Affected branch(es): ALl Development branch: <> Impacted area Impact y/n

[devel] [PATCH 1 of 1] amfd: finalize imm handle before init in thread[#2188] V3

2016-11-29 Thread praveen . malviya
osaf/services/saf/amf/amfd/imm.cc | 4 osaf/services/saf/amf/amfd/main.cc | 2 +- 2 files changed, 5 insertions(+), 1 deletions(-) V3:incoporates suggestions given by Minh and Gary. When AMFD receives BAD_HANDLE from IMM, it calls avd_imm_reinit_bg() to init with IMM in a separate

[devel] [PATCH 1 of 1] cpnd: fix error handling while section_hdr_update_fail [#2207]

2016-11-29 Thread Hoang Vo
osaf/libs/common/cpsv/include/cpnd_sec.h | 2 +- osaf/services/saf/cpsv/cpnd/cpnd_db.c| 5 - osaf/services/saf/cpsv/cpnd/cpnd_evt.c | 8 osaf/services/saf/cpsv/cpnd/cpnd_proc.c | 2 +- osaf/services/saf/cpsv/cpnd/cpnd_sec.cc | 25 ++--- 5 files

[devel] [PATCH 0 of 1] Review Request for cpnd: fix error handling while section_hdr_update_fail [#2207] V2

2016-11-29 Thread Hoang Vo
Summary: cpnd: fix error handling while section_hdr_update_fail [#2207] V2 Review request for Trac Ticket(s): #2207 Peer Reviewer(s): mahesh.va...@oracle.com; anders.wid...@ericsson.com Pull request to: mahesh.va...@oracle.com Affected branch(es): default Development branch: default

[devel] [PATCH 2 of 3] cpsv : update cpsv error handing based on leap changes [#2202]

2016-11-29 Thread mahesh . valla
osaf/libs/common/cpsv/include/cpnd_cb.h | 4 +- osaf/libs/common/cpsv/include/cpnd_init.h | 8 +- osaf/libs/common/cpsv/include/cpnd_sec.h | 2 +- osaf/libs/core/include/ncs_osprm.h| 2 +- osaf/services/saf/cpsv/cpnd/cpnd_db.c | 12 ++--

[devel] [PATCH 3 of 3] mqsv : update mqsv error handing based on leap changes [#2202]

2016-11-29 Thread mahesh . valla
osaf/services/saf/glsv/glnd/glnd_shm.c | 2 +- osaf/services/saf/mqsv/mqnd/mqnd_shm.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/osaf/services/saf/glsv/glnd/glnd_shm.c b/osaf/services/saf/glsv/glnd/glnd_shm.c --- a/osaf/services/saf/glsv/glnd/glnd_shm.c +++

Re: [devel] [PATCH 1 of 1] amfnd: add logs for HC start failures [#340]

2016-11-29 Thread Nagendra Kumar
Thanks Minh, I will add. -Nagu > -Original Message- > From: minh chau [mailto:minh.c...@dektech.com.au] > Sent: 29 November 2016 14:01 > To: Nagendra Kumar; hans.nordeb...@ericsson.com; Praveen Malviya; > gary@dektech.com.au > Cc: opensaf-devel@lists.sourceforge.net > Subject: Re:

Re: [devel] [PATCH 1 of 1] ntfd: process NTFA down event with high priority[#2206]

2016-11-29 Thread Canh Truong
Hi Praveen, When app do saNtfInitialize(), the ntfa will send initialized message with normal priority (MDS_SEND_PRIORITY_MEDIUM = 2) to NTFS. NTFS pick this message up in mds callback and put to mbx with same priority . if app is dead suddenly after initializing, NTFS will receive both

Re: [devel] [PATCH 1 of 1] amfnd: return SA_AIS_ERR_NO_OP for error clear api [#245]

2016-11-29 Thread Nagendra Kumar
Hi Hans, This piece of code needn't run as there were no error before as comp is healthy also no need to call clear_error_report_alarm. Thanks -Nagu > -Original Message- > From: Hans Nordeback [mailto:hans.nordeb...@ericsson.com] > Sent: 29 November 2016 14:32 > To: Nagendra

Re: [devel] [PATCH 1 of 1] amfnd: return SA_AIS_ERR_NO_OP for error clear api [#245]

2016-11-29 Thread Hans Nordeback
Hi Nagu, The question was that this code is not run after SA_AIS_ERR_NO_OP is handled, is this correct? : if ((SA_AIS_OK == amf_rc) && (NCSCC_RC_SUCCESS == rc)) { /*** clear the err params ***/ err_info = >err_info; err_info->src = static_cast(0);

Re: [devel] [PATCH 1 of 1] amfnd: return SA_AIS_ERR_NO_OP for error clear api [#245]

2016-11-29 Thread Hans Nordeback
Hi Nagu, thanks, ack. /Regards HansN On 11/29/2016 10:12 AM, Nagendra Kumar wrote: > Hi Hans, > This piece of code needn't run as there were no error before as comp is > healthy also no need to call clear_error_report_alarm. > > Thanks > -Nagu > >> -Original Message- >> From:

Re: [devel] [PATCH 0 of 1] Review Request for imm: Correct nodeId assertion in ImmModel::ccbAbort() [#2205]

2016-11-29 Thread Neelakanta Reddy
Hi Hung, Reviewed and tested the patch. Ack. /Neel. On 2016/11/25 01:04 PM, Hung Nguyen wrote: > Summary: imm: Correct nodeId assertion in ImmModel::ccbAbort() [#2205] > Review request for Trac Ticket(s): 2205 > Peer Reviewer(s): Zoran, Neel > Pull request to: > Affected branch(es): 5.0, 5.1,

Re: [devel] [PATCH 1 of 3] leap : now leap library ensure shm availability before writing [#2202]

2016-11-29 Thread ramesh betham
Hi Mahesh, Please see my comments with [Ramesh] inline. Thanks, Ramesh. On 11/29/2016 4:07 PM, mahesh.va...@oracle.com wrote: > osaf/libs/core/leap/os_defs.c | 20 ++-- > 1 files changed, 18 insertions(+), 2 deletions(-) > > > Issue : > > If OSAF_CKPT_SHM_ALLOC_GUARANTEE is

Re: [devel] [PATCH 0 of 3] Review Request for leap : now leap library ensure shm availability before writing [#2202]

2016-11-29 Thread A V Mahesh
Hi Hoang, Thansk for the test . Then it looks issue is not related to SHM deficiency ( 100 % used by other application ) can you please re-test with below changes and that will confirm us it is completely not related to SHM free size. replacing: `if (req->info.write.i_write_size >

Re: [devel] [PATCH 0 of 3] Review Request for leap : now leap library ensure shm availability before writing [#2202]

2016-11-29 Thread A V Mahesh
Hi Hoang, We have no option that , why because reproducible steps are not easy . Please find the additional `2202_addtional.patch` patch on top of published patch this will confirm us it is completely not related to SHM free size. -AVM On 11/30/2016 12:10 PM, Vo Minh Hoang wrote: Dear

Re: [devel] [PATCH 1 of 1] AMFD: Do not let non-active AMFD receives CLM track callback [#2141]

2016-11-29 Thread minh chau
Hi Praveen, I have seen a limitation of using the same job queue now, that it will increase the possibility of loss of IMM update job which is causing incorrect headless recovery. The timer is one alternative. We had spawned a thread to deal with TRY_AGAIN/TIMEOUT in case of start cluster

[devel] [PATCH 0 of 1] Review Request for imm:allow augumentCcbInit with ROF as false in completed callback[#1956] V2

2016-11-29 Thread reddy . neelakanta
Summary: imm:allow augumentCcbInit with ROF as false in completed callback[#1956] V2 Review request for Trac Ticket(s): 1956 Peer Reviewer(s): Hung, Zoran Affected branch(es): 5.0.x, 5.1.x, default Development branch: default Impacted area Impact y/n

[devel] [PATCH 1 of 1] imm:allow augumentCcbInit with ROF as false in completed callback[#1956] V2

2016-11-29 Thread reddy . neelakanta
osaf/libs/agents/saf/imma/imma_cb.h | 5 + osaf/libs/agents/saf/imma/imma_db.c | 99 + osaf/libs/agents/saf/imma/imma_oi_api.c | 60 +++ osaf/libs/agents/saf/imma/imma_proc.c | 64 ++--- 4 files changed, 133

Re: [devel] [PATCH 0 of 3] Review Request for leap : now leap library ensure shm availability before writing [#2202]

2016-11-29 Thread Vo Minh Hoang
Dear Mahesh, Unfortunately, I have just receive information that the same core dump still occur after applying patch. Here is dump information in short, please tell me if I can do anything in support: Program terminated with signal SIGSEGV, Segmentation fault. #0 0x7fe314aa0109 in

Re: [devel] [PATCH 1 of 1] cpnd: fix error handling while section_hdr_update_fail [#2207]

2016-11-29 Thread A V Mahesh
HI All, Validation of this patch dependent on #2202 , so please find the attached re-based patch of this (#2207) ticket. Hoang will re-publish the V3 patch once he is in office. -AVM On 11/29/2016 4:23 PM, Hoang Vo wrote: osaf/libs/common/cpsv/include/cpnd_sec.h | 2 +-

[devel] [PATCH 0 of 1] Review Request for amf: Spare controller did not get rebooted when amfd is killed on spare controller with headless [#1857]

2016-11-29 Thread Hans Nordeback
Summary: amf: spare controller did not get rebooted when amfd is killed on spare controller with headless Review request for Trac Ticket(s): #1857 Peer Reviewer(s): Nagu, Praveen, Gary Pull request to: Affected branch(es): default Development branch: default

[devel] [PATCH 0 of 1] Review Request for smf: Avoid unconditional sleep when calling adminoperation[#2211]

2016-11-29 Thread reddy . neelakanta
Summary: smf: Avoid uncditional sleep when calling adminoperation[#2211] Review request for Trac Ticket(s): 2211 Peer Reviewer(s): Rafael, Lennart, Tai Affected branch(es): 5.0.x, 5.1.x, default Development branch: default Impacted area Impact y/n