[devel] [PATCH 1/1] amfnd: Buffered not-ack susi assignment response after both SC go down [#2105]

2017-05-15 Thread Minh Chau
When amfnd-payload responds susi assignment response just before both SC go down, and that response message does not come to director. Therefore, the status of that assignment could be seen as "modifying" in IMM. When SC comes back, active amfd will be waiting for that response forever. Patch

[devel] [PATCH 0/1] Review Request for amfnd: Buffered not-ack susi assignment response after both SC go down [#2105]

2017-05-15 Thread Minh Chau
Summary: amfnd: Buffered not-ack susi assignment response after both SC go down [#2105] Review request for Ticket(s): 2105 Peer Reviewer(s): AMF maintainers Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop, release Development branch: ticket-2105 Base

[devel] [PATCH 0/1] Review Request for log: refactor log agent - 2nd increment [#2412] V4

2017-05-15 Thread Vu Minh Nguyen
Summary: log: refactor log agent - 2nd increment [#2412] Review request for Ticket(s): 2412 Peer Reviewer(s): LOG Devs Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2412 Base revision: 8c09ce778f01cd0b202a2b7b9fd51dbc14648674

[devel] [PATCH 0/1] Review Request for osaf: Support DESTDIR when installing OpenSAF samples [#2460]

2017-05-15 Thread Anders Widell
Summary: osaf: Support DESTDIR when installing OpenSAF samples [#2460] Review request for Ticket(s): 2460 Peer Reviewer(s): Ramesh Pull request to: Affected branch(es): develop Development branch: ticket-2460 Base revision: 8c09ce778f01cd0b202a2b7b9fd51dbc14648674 Personal repository:

[devel] [PATCH 1/1] osaf: Support DESTDIR when installing OpenSAF samples [#2460]

2017-05-15 Thread Anders Widell
Add support for using DESTDIR to point to the installation root directory when installing the OpenSAF sample programs. --- samples/amf/proxy/Makefile.am| 6 +++--- samples/amf/sa_aware/Makefile.am | 8 samples/amf/wrapper/Makefile.am | 4 ++-- 3 files changed, 9 insertions(+), 9

Re: [devel] [PATCH 1/1] clm: add tool commands clm-adm, clm-state, clm-find [#2394]

2017-05-15 Thread Anders Widell
Ack with one comment: --admin_op should be renamed to --admin-op (dash instead of underscore as word separator). regards, Anders Widell On 05/12/2017 11:54 AM, Praveen wrote: > This is V2 which incorporates comments given on V1. > > clm-adm: for performing CLM admin operations on CLM node and

[devel] [PATCH 1/1] base: Improve state report for opensafd [#2459]

2017-05-15 Thread Rafael Odzakow
Internally opensafd creates a lock file during start/stop to avoid parallel execution. To allow others to query the state this ticket will use the opensafd lockfile to report the status of start/stop when requested with "opensafd status" --- src/nid/opensafd.in | 19 ++- 1 file

[devel] [PATCH 0/1] Review Request for base: Improve state report for opensafd [#2459]

2017-05-15 Thread Rafael Odzakow
Summary: base: Improve state report for opensafd [#2459] Review request for Ticket(s): 2459 Peer Reviewer(s): anders/hans Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2459 Base revision:

Re: [devel] [PATCH 1/1] amfnd: Buffered not-ack susi assignment response after both SC go down [#2105]

2017-05-15 Thread praveen malviya
Hi Minh, I am reviewing this patch. Thanks, Praveen On 15-May-17 1:06 PM, Minh Chau wrote: > When amfnd-payload responds susi assignment response just before both SC > go down, and that response message does not come to director. Therefore, > the status of that assignment could be seen as

Re: [devel] [PATCH 1/1] amf: send oper_state when NCS SUs already instantiated [#2443]

2017-05-15 Thread praveen malviya
Hi Long, This check is very generic. During su restart cases, a PI SU having NPI components will send unnecessary enabled events to AMFD. When AMFD will receive this events it will try to assign this SU and can lead to assignments in other than 2N red models cases. I think check should be