Hi Vu,
Maybe it's better if you push additional patch in #2771. You don't next to send
the patch for the review (it's already commented and agreed 😊 )
It will be more visible where the change is done, then pushing the change in
the next commit.
BR,
Zoran
-Original Message-
From: Vu Min
Summary: pyosaf: refactor IMM samples to use new pyosaf utils [#2681]
Review request for Ticket(s): 2681
Peer Reviewer(s): Hans Nordeback, Srinivas Mangipudy, Quyen Dao
Pull request to: Hans Nordeback
Affected branch(es): develop
Development branch: ticket-2681
Base revision: 3587648509bf14d692852d
---
python/samples/caps | 69 +
python/samples/caps-inheritance-impl | 78 ++
python/samples/imm-listener | 130 +---
python/samples/imm-listener-inheritance-impl | 172 ++
pytho
Ack with comment: I think the file should be called README.etcd instead
of etcd.readme. Shouldn't it be added to the Makefile as well?
regards,
Anders Widell
On 03/07/2018 04:42 AM, Gary Lee wrote:
---
src/osaf/consensus/plugins/etcd.readme | 32
1 file ch
Ack with minor comment: explain in the (long) commit message why this
change was needed, i.e. since etcdctl otherwise could otherwise try to
contact unavailable etcd servers which would cause delays.
regards,
Anders Widell
On 03/07/2018 05:37 AM, Gary Lee wrote:
---
src/osaf/consensus/plu
Summary: log: IMM OI BAD HANDLE incorrectly propagated to log client [#2799]
Review request for Ticket(s): 2799
Peer Reviewer(s): vu.m.ngu...@dektech.com.au, canh.v.tru...@dektech.com.au
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development branch:
Fix incorrect check of bad OI handle in log server event handler
procdure for open an application stream.
---
src/log/logd/lgs_evt.cc| 17 +++--
src/log/logd/lgs_imm.cc| 2 ++
src/log/logd/lgs_mbcsv.cc | 2 +-
src/log/logd/lgs_stream.cc | 24 +---
src/log
Summary: plmd: enable dynamic tracing [#2796]
Review request for Ticket(s): 2796
Peer Reviewer(s): Ravi
Pull request to:
Affected branch(es): develop
Development branch: ticket-2796
Base revision: 3587648509bf14d692852d0ce4882377bc0831b5
Personal repository: git://git.code.sf.net/u/trguitar/review
Dynamic tracing does not work with plmd.
plmd overrides the USR2 signal with its own dump routine.
Remove the signal hander code for USR2 in plmd.
---
src/plm/plmd/plms_main.c | 20
1 file changed, 20 deletions(-)
diff --git a/src/plm/plmd/plms_main.c b/src/plm/plmd/plms_ma
Hi Dheeraj, Gary and Anders,
Thanks a lot for the quick response! With your help, I was able to solve
the original issue of locating the share libraries. The current issue I am
facing now is with immxml-configure, which failed in File "./immxml-merge",
line 370, in save_result
self.i
Yes. Actually the whole plugins directory should be added to
src/osaf/Makefile.am
I will add this in the push.
+EXTRA_DIST += \
+Â Â src/osaf/consensus/plugins/etcd.plugin \
+Â Â src/osaf/consensus/plugins/sample.plugin \
+Â Â src/osaf/consensus/plugins/README.etcd
+
On 08/03/18 02:0
Hi Alex,
Ack for the patch, but have one comment
I understand using SIGUSR2 for Control Block dumping is not the generic way as
we are using USR2 signal for dynamically enabling Traces. we added this
because at times Traces are not enough for debugging and dump routine dumps the
complete Con
12 matches
Mail list logo
