[devel] [PATCH 1/1] imm: coredump during scale-in on large configuration [#2794]

When IMMND restarts (e.g: OUT OF ORDER detection), it may get message from active IMMD which is originated from just-dead IMMND process. In such case, we are in confused situation - messages come from local IMMND, but not me (reply_dest != cb->immnd_mdest_id)! This patch discards such messages, no

[devel] [PATCH 0/1] Review Request for imm: coredump during scale-in on large configuration [#2794]

Summary: imm: coredump during scale-in on large configuration [#2794] Review request for Ticket(s): 2794 Peer Reviewer(s): Ravi, Hans, Anders, Lennart Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2794 Base revision: 0983225ed

Re: [devel] [PATCH 0/1] Review Request for log: Fix cyclic crash when starting standby and OI is not active [#2711]

Hi Lennart, Ack Thanks Canh -Original Message- From: Lennart Lund [mailto:lennart.l...@ericsson.com] Sent: Friday, March 9, 2018 9:50 PM To: vu.m.ngu...@dektech.com.au; canh.v.tru...@dektech.com.au Cc: opensaf-devel@lists.sourceforge.net; Lennart Lund Subject: [PATCH 0/1] Review Reques

Re: [devel] [PATCH 0/1] Review Request for log: Fix cyclic crash when starting standby and OI is not active [#2711]

Hi Vu, Can you please also check that your comments are fixed/answered and Ack if ok. Note that I have chosen to not remove the isRtStream variable Thanks Lennart > -Original Message- > From: Canh Van Truong [mailto:canh.v.tru...@dektech.com.au] > Sent: den 12 mars 2018 11:39 > To: Lenn

[devel] [PATCH 0/1] Review Request for build: Fix false checkpatch warning about struct should normally be const [#2807]

Summary: build: Fix false checkpatch warning about struct should normally be const [#2807] Review request for Ticket(s): 2807 Peer Reviewer(s): Hans Pull request to: Affected branch(es): develop Development branch: ticket-2807 Base revision: d19d3988fd70e3f50e91402b243b2cc8c9a91d3a Personal repos

[devel] [PATCH 1/1] build: Fix false checkpatch warning about struct should normally be const [#2807]

Fix the following false warning produced by "make checkpatch": WARNING: struct should normally be const --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 8f2687314..b3d6553c1 100644 --- a/Makefile.am +++ b/Makefile.am @@ -431,7 +4

Re: [devel] [PATCH 1/1] rde: avoid SIGPIPE in send functions [#2800]

Ack with minor comment: Return type from strlen() is size_t, and return type from send() is ssize_t. So a more type-correct way to implement this is outlined in my inlined comments in the code below. regards, Anders Widell On 03/09/2018 02:44 AM, Gary Lee wrote: --- src/rde/agent/rda_papi

Re: [devel] [PATCH 1/1] build: Fix false checkpatch warning about struct should normally be const [#2807]

ack, review only/Thanks HansN On 03/12/2018 03:17 PM, Anders Widell wrote: Fix the following false warning produced by "make checkpatch": WARNING: struct should normally be const --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am i

Re: [devel] [PATCH 1/1] rde: avoid SIGPIPE in send functions [#2800]

Thanks for the pickup. My bad. I got preoccupied looking at the partial write and possible issues with recv(). The code seems to assume the entire message is received with each recv(). I guess it's mostly true, because the messages are so small. On 13/03/18 01:30, Anders Widell wrote: Ack wit

Re: [devel] [PATCH 0/1] Review Request for log: Fix cyclic crash when starting standby and OI is not active [#2711]

Hi Lennart, Ack from me. Thanks. Regards, Vu > -Original Message- > From: Lennart Lund [mailto:lennart.l...@ericsson.com] > Sent: Monday, March 12, 2018 7:01 PM > To: Canh Van Truong ; Vu Minh Nguyen > > Cc: opensaf-devel@lists.sourceforge.net; Lennart Lund > > Subject: RE: [PATCH 0/1]