Re: [devel] [PATCH 1/1] imm: fix unknown event type in imma_proc_free_pointers [#2779]

2018-03-14 Thread Vu Minh Nguyen 
Hi Hans,

See my response inline.

Regards, Vu

> -Original Message-
> From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com]
> Sent: Wednesday, March 14, 2018 9:14 PM
> To: Vu Minh Nguyen ;
> ravisekhar.ko...@oracle.com; zoran.milinko...@ericsson.com;
> anders.wid...@ericsson.com; lennart.l...@ericsson.com
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: Re: [PATCH 1/1] imm: fix unknown event type in
> imma_proc_free_pointers [#2779]
> 
> ack, review only. One question below.
> 
> /Thanks HansN
> 
> 
> On 03/13/2018 08:19 AM, Vu Minh Nguyen wrote:
> > The message type IMMA_EVT_ND2A_PROC_STALE_CLIENTS was introduced
> in IMM,
> > but missed mention it in `void imma_proc_free_pointers()`.
> > ---
> >   src/imm/agent/imma_proc.cc | 3 +++
> >   1 file changed, 3 insertions(+)
> >
> > diff --git a/src/imm/agent/imma_proc.cc b/src/imm/agent/imma_proc.cc
> > index 886b50c..ec62b98 100644
> > --- a/src/imm/agent/imma_proc.cc
> > +++ b/src/imm/agent/imma_proc.cc
> > @@ -1401,6 +1401,9 @@ void imma_proc_free_pointers(IMMA_CB *cb,
> IMMA_EVT *evt) {
> >   case IMMA_EVT_ND2A_OI_CCB_ABORT_UC:
> > break;
> >
> > +case IMMA_EVT_ND2A_PROC_STALE_CLIENTS:
> [HansN] why isn't this case stmt added to the case stmt's before, such as:
> 
> case IMMA_EVT_ND2A_OI_CCB_COMPLETED_UC:
> case IMMA_EVT_ND2A_OI_CCB_APPLY_UC:
> case IMMA_EVT_ND2A_OI_CCB_ABORT_UC:
> case IMMA_EVT_ND2A_PROC_STALE_CLIENTS:
[Vu] XXX_OI_CCB_XXX message types belongs to CCB up call category/group while 
XXX_PROC_STALE_XXX doesn't. 
So, separate them to different code blocks may be better, I think.

>break;
> > +  break;
> > +
> >   default:
> > TRACE_4("Unknown event type %u", evt->type);
> > break;



--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Re: [devel] [PATCH 1/1] imm: fix unknown event type in imma_proc_free_pointers [#2779]

2018-03-14 Thread Hans Nordebäck 

ack, review only. One question below.

/Thanks HansN


On 03/13/2018 08:19 AM, Vu Minh Nguyen wrote:

The message type IMMA_EVT_ND2A_PROC_STALE_CLIENTS was introduced in IMM,
but missed mention it in `void imma_proc_free_pointers()`.
---
  src/imm/agent/imma_proc.cc | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/src/imm/agent/imma_proc.cc b/src/imm/agent/imma_proc.cc
index 886b50c..ec62b98 100644
--- a/src/imm/agent/imma_proc.cc
+++ b/src/imm/agent/imma_proc.cc
@@ -1401,6 +1401,9 @@ void imma_proc_free_pointers(IMMA_CB *cb, IMMA_EVT *evt) {
  case IMMA_EVT_ND2A_OI_CCB_ABORT_UC:
break;
  
+case IMMA_EVT_ND2A_PROC_STALE_CLIENTS:

[HansN] why isn't this case stmt added to the case stmt's before, such as:

case IMMA_EVT_ND2A_OI_CCB_COMPLETED_UC:
case IMMA_EVT_ND2A_OI_CCB_APPLY_UC:
case IMMA_EVT_ND2A_OI_CCB_ABORT_UC:
case IMMA_EVT_ND2A_PROC_STALE_CLIENTS:
  break;

+  break;
+
  default:
TRACE_4("Unknown event type %u", evt->type);
break;



--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Re: [devel] [PATCH 1/1] imm: fix unknown event type in imma_proc_free_pointers [#2779]

2018-03-13 Thread Ravi Sekhar Reddy Konda 
Hi Vu,

Ack, code review only

Regards,
Ravi

-Original Message-
From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] 
Sent: Tuesday, March 13, 2018 12:50 PM
To: ravisekhar.ko...@oracle.com; hans.nordeb...@ericsson.com; 
zoran.milinko...@ericsson.com; anders.wid...@ericsson.com; 
lennart.l...@ericsson.com
Cc: opensaf-devel@lists.sourceforge.net; Vu Minh Nguyen 

Subject: [PATCH 1/1] imm: fix unknown event type in imma_proc_free_pointers 
[#2779]

The message type IMMA_EVT_ND2A_PROC_STALE_CLIENTS was introduced in IMM, but 
missed mention it in `void imma_proc_free_pointers()`.
---
 src/imm/agent/imma_proc.cc | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/imm/agent/imma_proc.cc b/src/imm/agent/imma_proc.cc index 
886b50c..ec62b98 100644
--- a/src/imm/agent/imma_proc.cc
+++ b/src/imm/agent/imma_proc.cc
@@ -1401,6 +1401,9 @@ void imma_proc_free_pointers(IMMA_CB *cb, IMMA_EVT *evt) {
 case IMMA_EVT_ND2A_OI_CCB_ABORT_UC:
   break;
 
+case IMMA_EVT_ND2A_PROC_STALE_CLIENTS:
+  break;
+
 default:
   TRACE_4("Unknown event type %u", evt->type);
   break;
--
1.9.1

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

[devel] [PATCH 1/1] imm: fix unknown event type in imma_proc_free_pointers [#2779]

2018-03-13 Thread Vu Minh Nguyen 
The message type IMMA_EVT_ND2A_PROC_STALE_CLIENTS was introduced in IMM,
but missed mention it in `void imma_proc_free_pointers()`.
---
 src/imm/agent/imma_proc.cc | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/imm/agent/imma_proc.cc b/src/imm/agent/imma_proc.cc
index 886b50c..ec62b98 100644
--- a/src/imm/agent/imma_proc.cc
+++ b/src/imm/agent/imma_proc.cc
@@ -1401,6 +1401,9 @@ void imma_proc_free_pointers(IMMA_CB *cb, IMMA_EVT *evt) {
 case IMMA_EVT_ND2A_OI_CCB_ABORT_UC:
   break;
 
+case IMMA_EVT_ND2A_PROC_STALE_CLIENTS:
+  break;
+
 default:
   TRACE_4("Unknown event type %u", evt->type);
   break;
-- 
1.9.1


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel