Re: [devel] [PATCH 1/1] osaf: add example config for etcd [#2784]

2018-03-11 Thread Ravi Sekhar Reddy Konda
Hi Gary, Ack, with some comments 1) The current example that you have given is for static etcd cluster configuration In the Cloud environment, the Cluster will be growing and shrinking dynamically, accordingly we might need to add or remove new nodes to the etcd cluster It will be

Re: [devel] [PATCH 1/1] osaf: add example config for etcd [#2784]

2018-03-07 Thread Gary Lee
Yes. Actually the whole plugins directory should be added to src/osaf/Makefile.am I will add this in the push. +EXTRA_DIST += \ +   src/osaf/consensus/plugins/etcd.plugin \ +   src/osaf/consensus/plugins/sample.plugin \ +   src/osaf/consensus/plugins/README.etcd + On 08/03/18

Re: [devel] [PATCH 1/1] osaf: add example config for etcd [#2784]

2018-03-07 Thread Anders Widell
Ack with comment: I think the file should be called README.etcd instead of etcd.readme. Shouldn't it be added to the Makefile as well? regards, Anders Widell On 03/07/2018 04:42 AM, Gary Lee wrote: --- src/osaf/consensus/plugins/etcd.readme | 32 1 file