Re: [devel] [PATCH 1 of 1] amfd: do not notify admin state of SG for same state transtion[#1990]

2016-09-15 Thread minh chau
On 15/09/16 21:03, praveen malviya wrote: > > > On 15-Sep-16 4:10 PM, minh chau wrote: >> Hi Praveen, >> >> ack with minor comment. >> 1-I think 2 places: avd_sg_admin_state_set() and >> AVD_SG::set_admin_state(), to be changed? > I did not know that there are two function doing same thing. > Do

Re: [devel] [PATCH 1 of 1] amfd: do not notify admin state of SG for same state transtion[#1990]

2016-09-15 Thread praveen malviya
On 15-Sep-16 4:10 PM, minh chau wrote: > Hi Praveen, > > ack with minor comment. > 1-I think 2 places: avd_sg_admin_state_set() and > AVD_SG::set_admin_state(), to be changed? I did not know that there are two function doing same thing. Do you know the reason, Why there were not merged or new one

Re: [devel] [PATCH 1 of 1] amfd: do not notify admin state of SG for same state transtion[#1990]

2016-09-15 Thread minh chau
Hi Praveen, ack with minor comment. 1-I think 2 places: avd_sg_admin_state_set() and AVD_SG::set_admin_state(), to be changed? 2-Those functions exit with TRACE_LEAVE() Thanks, Minh On 15/09/16 19:58, praveen.malv...@oracle.com wrote: > osaf/services/saf/amf/amfd/sg.cc | 2 ++ > 1 files chan