Re: [opensc-devel] Proposed cardmod patch

2011-01-25 Thread Martin Paljak
Hello, On Jan 24, 2011, at 10:11 PM, Douglas E. Engert wrote: > On 1/24/2011 12:54 PM, Brian Thomas wrote: >> Hello, >> >> I strongly urge the OpenSC team to make this change to fix mini-driver >> compatibility. Yes, my company "needs this because we just do", however >> by implementing this fix

Re: [opensc-devel] Proposed cardmod patch

2011-01-24 Thread Brian Thomas
sage- > From: Martin Paljak [mailto:mar...@martinpaljak.net] > Sent: Saturday, January 22, 2011 7:27 AM > To: Douglas E. Engert > Cc: opensc-devel@lists.opensc-project.org; Brian Thomas > Subject: Re: [opensc-devel] Proposed cardmod patch > > Hello, > > On Jan 21, 2011, at 9:45

Re: [opensc-devel] Proposed cardmod patch

2011-01-24 Thread Douglas E. Engert
Martin Paljak [mailto:mar...@martinpaljak.net] > Sent: Saturday, January 22, 2011 7:27 AM > To: Douglas E. Engert > Cc: opensc-devel@lists.opensc-project.org; Brian Thomas > Subject: Re: [opensc-devel] Proposed cardmod patch > > Hello, > > On Jan 21, 2011, at 9:45 PM, Dougl

Re: [opensc-devel] Proposed cardmod patch

2011-01-24 Thread Brian Thomas
e. Thanks, Brian Thomas -Original Message- From: Martin Paljak [mailto:mar...@martinpaljak.net] Sent: Saturday, January 22, 2011 7:27 AM To: Douglas E. Engert Cc: opensc-devel@lists.opensc-project.org; Brian Thomas Subject: Re: [opensc-devel] Proposed cardmod patch Hello, On Jan 21, 201

Re: [opensc-devel] Proposed cardmod patch

2011-01-22 Thread Martin Paljak
Hello, On Jan 21, 2011, at 9:45 PM, Douglas E. Engert wrote: > Attached is the patch to just do (2) below. I believe that this > is the part that Brian wants to not call sc_ctx_detect_readers > Martin you had said you want to do this differently so I will > leave this up to you as to weither this

Re: [opensc-devel] Proposed cardmod patch

2011-01-21 Thread Brian Thomas
: [opensc-devel] Proposed cardmod patch Attached is the patch to just do (2) below. I believe that this is the part that Brian wants to not call sc_ctx_detect_readers Martin you had said you want to do this differently so I will leave this up to you as to weither this is commited or not. On 1/19

Re: [opensc-devel] Proposed cardmod patch

2011-01-21 Thread Douglas E. Engert
Attached is the patch to just do (2) below. I believe that this is the part that Brian wants to not call sc_ctx_detect_readers Martin you had said you want to do this differently so I will leave this up to you as to weither this is commited or not. On 1/19/2011 5:46 PM, Douglas E. Engert wrote:

Re: [opensc-devel] Proposed cardmod patch

2011-01-21 Thread Douglas E. Engert
On 1/21/2011 12:28 AM, Jean-Michel Pouré - GOOZE wrote: > Le jeudi 20 janvier 2011 à 15:44 -0600, Douglas E. Engert a écrit : >> I have gotten further today. > > Dear Douglas, > > You may look at MySmartLogon source code: > http://www.mysmartlogon.com/products/eidauthenticate.html > Thanks, I se

Re: [opensc-devel] Proposed cardmod patch

2011-01-21 Thread Brian Thomas
Doug, Our implementation does not use any of the cardmod code. The modifications we require are: -The Flag needs to be added -Not detecting the readers if the flag is set Thanks, Brian Thomas -Original Message- From: Douglas E. Engert [mailto:deeng...@anl.gov] Sent: Thursday, January

Re: [opensc-devel] Proposed cardmod patch

2011-01-20 Thread Jean-Michel Pouré - GOOZE
Le jeudi 20 janvier 2011 à 15:44 -0600, Douglas E. Engert a écrit : > I have gotten further today. Dear Douglas, You may look at MySmartLogon source code: http://www.mysmartlogon.com/products/eidauthenticate.html If the certs are valid, smartcard logon can be enabled. This tool can be used to ch

Re: [opensc-devel] Proposed cardmod patch

2011-01-20 Thread Douglas E. Engert
Brian, You still have not told us how you mini driver loads any of the OpenSC code. Does it use any of the cardmod code? I ask because the patch you need may be only part of what I proposed basicaly (2). I would like to ask Martin, as he had comments on the patch. On 1/20/2011 3:00 PM, Brian Thom

Re: [opensc-devel] Proposed cardmod patch

2011-01-20 Thread Douglas E. Engert
On 1/20/2011 11:32 AM, Jean-Michel Pouré - GOOZE wrote: > >> Windows uses a container name derived from the serial number, >> and the keyid, (and maybe the type of card), and stored these in the >> certificate store. >> The current cardmod driver is using a constant serial number, >> 0,1,2,3,4,5,

Re: [opensc-devel] Proposed cardmod patch

2011-01-20 Thread Brian Thomas
Hello, We have confirmed this patch works for us. Good job! Question: what would it take to get this patch committed to trunk and released officially? Perhaps an OpenSC version 12.01? We are in dire need of this. Thanks, Brian Thomas -Original Message- From: Douglas E. Engert [mailt

Re: [opensc-devel] Proposed cardmod patch

2011-01-20 Thread Viktor TARASOV
Thank you very much for this answer. On 20.01.2011 17:51, Douglas E. Engert wrote: > On 1/20/2011 4:53 AM, Viktor TARASOV wrote: >> Hello, >> >> sorry for the question out of the subject, but >> >> When using OpenSC minidriver (or any other), >> does there any existing (or that could be implemente

Re: [opensc-devel] Proposed cardmod patch

2011-01-20 Thread Jean-Michel Pouré - GOOZE
> Windows uses a container name derived from the serial number, > and the keyid, (and maybe the type of card), and stored these in the > certificate store. > The current cardmod driver is using a constant serial number, > 0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15 which will work for a single > smartca

Re: [opensc-devel] Proposed cardmod patch

2011-01-20 Thread Douglas E. Engert
On 1/20/2011 4:53 AM, Viktor TARASOV wrote: > Hello, > > sorry for the question out of the subject, but > > When using OpenSC minidriver (or any other), > does there any existing (or that could be implemented) > possibility to re-actualize the card content and to propagate the > eventual changes

Re: [opensc-devel] Proposed cardmod patch

2011-01-20 Thread Douglas E. Engert
On 1/20/2011 3:43 AM, Martin Paljak wrote: > Hello, > > On Jan 20, 2011, at 1:46 AM, Douglas E. Engert wrote: > >> Attached is a patch to the cardmod code to do the following: >> >> (1) Fix an uninitialized stricture by by using calloc >> in stead of malloc. With out this it was having probl

Re: [opensc-devel] Proposed cardmod patch

2011-01-20 Thread francois . leblanc
Martin Paljak a écrit sur 20/01/2011 13:40:02 : > [image supprimée] > > Re: [opensc-devel] Proposed cardmod patch > > Martin Paljak > > A : > > francois.leblanc > > 20/01/2011 13:42 > > Cc : > > "Douglas E. Engert", OpenSC-devel,

Re: [opensc-devel] Proposed cardmod patch

2011-01-20 Thread Martin Paljak
Hello, On Jan 20, 2011, at 11:28 AM, francois.lebl...@cev-sa.com wrote: > "Douglas E. Engert" a écrit sur 20/01/2011 00:46:51 : > > It's close to the first release I've develop see the start > > http://www.opensc-project.org/pipermail/opensc-devel/2009-October/012610.html > > but Martin at th

Re: [opensc-devel] Proposed cardmod patch

2011-01-20 Thread Viktor TARASOV
Hello, sorry for the question out of the subject, but When using OpenSC minidriver (or any other), does there any existing (or that could be implemented) possibility to re-actualize the card content and to propagate the eventual changes to the Windows key stores without re-inserting the card? I

Re: [opensc-devel] Proposed cardmod patch

2011-01-20 Thread Martin Paljak
Hello, On Jan 20, 2011, at 1:46 AM, Douglas E. Engert wrote: > Attached is a patch to the cardmod code to do the following: > > (1) Fix an uninitialized stricture by by using calloc >in stead of malloc. With out this it was having problems >with checking the status on the reader. malloc

Re: [opensc-devel] Proposed cardmod patch

2011-01-20 Thread francois . leblanc
"Douglas E. Engert" a écrit sur 20/01/2011 00:46:51 : > [image supprimée] > > Proposed cardmod patch > > Douglas E. Engert > > A : > > OpenSC-devel > > 20/01/2011 00:49 > > Cc : > > Brian Thomas, François Leblanc > > Attached is a patch to the cardmod code to do the following: >

[opensc-devel] Proposed cardmod patch

2011-01-19 Thread Douglas E. Engert
Attached is a patch to the cardmod code to do the following: (1) Fix an uninitialized stricture by by using calloc in stead of malloc. With out this it was having problems with checking the status on the reader. (2) Implement a change that this should work for Brian Thomas that allo