[opensc-devel] Request for comment: bringing warnings down to a dull roar

2012-09-20 Thread B. Scott Michel
I'm debating whether to submit a pull request on github with patches to reduce gcc's warnings to a minimum (actually, completely eliminated.) However, the patches violate the coding rules by marking unused parameters in static functions -- the "marking" is very explicit and very visible. I also to

Re: [opensc-devel] Request for comment: bringing warnings down to a dull roar

2012-09-21 Thread B. Scott Michel
On 9/21/2012 12:40 AM, Ludovic Rousseau wrote: > Hello, > > 2012/9/20 B. Scott Michel : >> I'm debating whether to submit a pull request on github with patches to >> reduce gcc's warnings to a minimum (actually, completely eliminated.) >> However, the patche

Re: [opensc-devel] Request for comment: bringing warnings down to a dull roar

2012-09-26 Thread B. Scott Michel
On 9/22/2012 12:04 AM, Andreas Jellinghaus wrote: > > > Do not "fix" unused param warnings. The correct way to fix them is to > > remove the parameter. > > Well, with c style object orientation we have interfaces that all card > drivers must implement, even if they don't use all function parameter

Re: [opensc-devel] Need help building Mac OS X packages

2012-10-15 Thread B. Scott Michel
On 10/14/2012 5:27 AM, Ludovic Rousseau wrote: > 2012/10/2 Jean-Michel Pouré - GOOZE : >> Hello, >> >> I have some problems building Mac OS X packages on the farm. >> This is Mac OS X 10.6 (SnowLeopard) and OpenSC git. >> >> Can you help? > On my Snow Leopard system with up to date version of OpenS

Re: [opensc-devel] SC_MAX_CARD_DRIVERS and OpenSC 0.13

2012-10-31 Thread B. Scott Michel
Could solve the problem two ways: #define SC_MAX_CARD_DRIVERS (sizeof(internal_card_drivers)/sizeof(internal_card_drivers[0])) or detect the end of the array by the null card driver name pointer. Either way, you don't need a magic constant for the size of the array, which is also fairly dangerous