Re: [opensource-dev] Review Request: STORM-987 : llimage_libtest : create an independent executable to exercise llimage outside the viewer

2011-03-10 Thread Merov Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/195/ --- (Updated March 10, 2011, 10:15 p.m.) Review request for Viewer. Changes -

[opensource-dev] Daily Scrum Summary - Thursday, March 10

2011-03-10 Thread Anya Kanevsky
Sprint 12, ends 03.21.11 Thursday, March 10 General Notes -- - MMOTD: Merov - 2.5.2 is in the works to fix a bunch of crashes. Team Status -- Merov Linden -- *PAST* - MM : pulled 3 issues in, code rev

[opensource-dev] Review Request: (STORM-250) Unexpected "More" text appears in the About Landmark panel after minimizing the floater

2011-03-10 Thread Seth ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/198/ --- Review request for Viewer. Summary --- Fixed "More" link being toggled

Re: [opensource-dev] Review Request: Add optional range ring to the mini-map -- one centered on you with a radius of 20m to show local chat range

2011-03-10 Thread Ibrew Meads
Would'nt it be better to put the color and alpha in a debug value? On Mar 10, 2011 2:29 PM, "Jonathan Yap" wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/197/ > --

Re: [opensource-dev] Review Request: STORM-971 'Stop Tracking' menu item is still enabled in Mini-map floater after you stopped tracking in Nearby mini-map

2011-03-10 Thread Twisted Laws
> On March 10, 2011, 2:57 p.m., Jonathan Yap wrote: > > indra/newview/llnetmap.cpp, line 514 > > > > > > Why is a 0 (or in some other places of the code, a NULL) being passed > > here? It seems the definition of isTrac

Re: [opensource-dev] Review Request: STORM-971 'Stop Tracking' menu item is still enabled in Mini-map floater after you stopped tracking in Nearby mini-map

2011-03-10 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/133/#review442 --- indra/newview/llnetmap.cpp

[opensource-dev] Review Request: Add optional range ring to the mini-map -- one centered on you with a radius of 20m to show local chat range

2011-03-10 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/197/ --- Review request for Viewer. Summary --- Add optional range ring to the

[opensource-dev] Review Request: Corrected a call to the Mac-specific command "Rez" that had the wrong case.

2011-03-10 Thread Cron Stardust
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/196/ --- Review request for Viewer. Summary --- Simple change from a lower-case

[opensource-dev] VWR-25120 - viewer_manifest.py has incorrect case for "Rez" command on case-sensitive Macs

2011-03-10 Thread Ricky
As I've again found a few more moments to try compiling the viewer again, this time on my Mac, I ran across an issue that was trivial to take care of: incorrect command name case on the Apple-specific command "Rez". Here's the link: https://jira.secondlife.com/browse/VWR-25120 Ricky Cron Stardust

Re: [opensource-dev] Review Request: STORM-1018 Improve error messaging for External Editor feature

2011-03-10 Thread Vadim ProductEngine
> On March 7, 2011, 10:31 p.m., Merov Linden wrote: > > I like the intent. In the code though, I don't really understand why the > > EC_NOT_SPECIFIED case is treated differently than other error messages. I > > fail to understand why this needs a "custom" message (in the panel xml > > instead

[opensource-dev] Daily Scrum Summary - Wednesday, March 9

2011-03-10 Thread Anya Kanevsky
Sprint 12, ends 03.21.11 Wednesday, March 9 General Notes -- - MMOTD: Merov Team Status -- Merov Linden -- *PAST* - MM : pulled 8 issues in - Attended Viewer triage - Hosted "Viewer Coding and Desi

[opensource-dev] Range ring on mini-map -- VWR-25117

2011-03-10 Thread Jonathan Welch
Hi, Having a range ring on the mini-map came up at a Linden User Group meeting this week so I wrote up VWR-25117 and did a bit of coding. Right now there is only 1 ring with a radius of 20m. If you are on more or less the same level as the green/yel