[Bug 2849] OpenSSH 7.7p1 uses login_name value instead of user@hostname
https://bugzilla.mindrot.org/show_bug.cgi?id=2849 --- Comment #11 from Johannes Schindelin --- > Close RESOLVED bugs with the release of openssh-8.0 Surely you meant openssh-7.9? And I have to say that I am sad with the way this ticket was handled. It is still a very counterintuitive change that was introduced, without prior warning, and the behavior is still very much against pretty much all other command-line software. Just making sure you know that not everybody agrees with your decision. -- You are receiving this mail because: You are watching the assignee of the bug. You are watching someone on the CC list of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 2849] OpenSSH 7.7p1 uses login_name value instead of user@hostname
https://bugzilla.mindrot.org/show_bug.cgi?id=2849 Damien Miller changed: What|Removed |Added Status|RESOLVED|CLOSED --- Comment #10 from Damien Miller --- Close RESOLVED bugs with the release of openssh-8.0 -- You are receiving this mail because: You are watching the assignee of the bug. You are watching someone on the CC list of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 2849] OpenSSH 7.7p1 uses login_name value instead of user@hostname
https://bugzilla.mindrot.org/show_bug.cgi?id=2849 Mark E Waite changed: What|Removed |Added OS|Windows 10 |All Version|7.6p1 |7.7p1 Hardware|amd64 |All -- You are receiving this mail because: You are watching someone on the CC list of the bug. You are watching the assignee of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 2849] OpenSSH 7.7p1 uses login_name value instead of user@hostname
https://bugzilla.mindrot.org/show_bug.cgi?id=2849 --- Comment #9 from James Cloos --- I should have noted: It is perfectly OK to say that command line wins over config files. That is of course normal and expected. But /within/ the command line last has to win over earlier. -- You are receiving this mail because: You are watching the assignee of the bug. You are watching someone on the CC list of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 2849] OpenSSH 7.7p1 uses login_name value instead of user@hostname
https://bugzilla.mindrot.org/show_bug.cgi?id=2849 James Cloos changed: What|Removed |Added CC||cl...@jhcloos.com --- Comment #8 from James Cloos --- I have to join the choir against this change. The change is in direct opposition to posix. All command line parsing must be last wins. Shell aliases, functions and scripts all require that. Last wins is also easier to program. This change means you have to check each option as to whether it already has been specified; last wins means that is not needed. It may be that last wins came into being because the early coders didn't think of the possibility of specifying an option more than once. But even if so it is not standard and How Things Are Done™. The distributions will all have to patch around this brokenness anyway. -- You are receiving this mail because: You are watching the assignee of the bug. You are watching someone on the CC list of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 2849] OpenSSH 7.7p1 uses login_name value instead of user@hostname
https://bugzilla.mindrot.org/show_bug.cgi?id=2849 --- Comment #7 from Mark E Waite --- Thanks for your comments. While I disagree with the choice, I wholeheartedly support your right and responsibility to make that choice. I'll adapt the Jenkins git plugin to the new behavior of OpenSSH 7.7 and add tests to assure I detect it if the change is reverted in the future. I believe you'll hear the same report from other users in the future, but those hypothetical future reports don't help my persuasion efforts now. I suspect you're confident that either they won't arrive, or if they arrive they will be resolved as "WONTFIX". Thanks again for your work on OpenSSH. It is amazing software! -- You are receiving this mail because: You are watching the assignee of the bug. You are watching someone on the CC list of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 2849] OpenSSH 7.7p1 uses login_name value instead of user@hostname
https://bugzilla.mindrot.org/show_bug.cgi?id=2849 Damien Miller changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #6 from Damien Miller --- (In reply to Johannes Schindelin from comment #5) > Damien, are you sure you want to promote this behavior? Literally > *all* other command-line programs let command-line options be > overridden. We've been promoting this behaviour for almost 20 years - configuration has long been documented to be first-match-wins (see ssh_config(5)). That "user@" was being treated differently was a bug. > And even if this were not so, are you not even acknowledging that > this is a backwards-incompatible behavior that was not announced, > and that we already demonstrated to break existing setups? Yes, it's backwards incompatible. I'm sorry I neglected to mention it in the release notes, but the correction of the behaviour was absolutely intentional. > And even if you are reluctant to see it this way, how would you > suggest Jenkins to do things when the URI is *a user-specified* > value that may, or may not have a user name, and `jenkins` should be > used as user name if the URI does not have one? Should Jenkins now > scan the URI themselves? I'm not sure I follow. OpenSSH < 7.7 didn't support URIs on the command-line. If you're talking about "user@host" (which isn't a URI and is trivial to parse anyway) then yeah, if your software is specifying a fallback username then it's pretty fundamental that it should check that one hasn't already been specified elsewhere. -- You are receiving this mail because: You are watching someone on the CC list of the bug. You are watching the assignee of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 2849] OpenSSH 7.7p1 uses login_name value instead of user@hostname
https://bugzilla.mindrot.org/show_bug.cgi?id=2849 Johannes Schindelin changed: What|Removed |Added CC||johannes.schinde...@gmx.de --- Comment #5 from Johannes Schindelin --- Damien, are you sure you want to promote this behavior? Literally *all* other command-line programs let command-line options be overridden. Just a few examples: ls --color --color=never rm --interactive=never --interactive=always git status --color --no-color and the list goes on and on and on and on and on. And for a good reason. Aliases are such an example, as I already mentioned in the Pull Request. Besides, in English, and on the command-line, we read from left to right. So if you read --color=always --color=never, it is pretty obvious what the reader understands, no? She would read "use color, always, oh wait, nevermind, never, ever use color". And that's been the case for a long, long time. And even if this were not so, are you not even acknowledging that this is a backwards-incompatible behavior that was not announced, and that we already demonstrated to break existing setups? And even if you are reluctant to see it this way, how would you suggest Jenkins to do things when the URI is *a user-specified* value that may, or may not have a user name, and `jenkins` should be used as user name if the URI does not have one? Should Jenkins now scan the URI themselves? I was quite a bit shocked to read what you had to say, to say the least. -- You are receiving this mail because: You are watching someone on the CC list of the bug. You are watching the assignee of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 2849] OpenSSH 7.7p1 uses login_name value instead of user@hostname
https://bugzilla.mindrot.org/show_bug.cgi?id=2849 --- Comment #4 from Mark E Waite --- Sorry, I should have referenced OpenSSH bug 2385 in my previous comment, not OpenSSH bug 2348. OpenSSH bug 2348 is unrelated to this bug. -- You are receiving this mail because: You are watching someone on the CC list of the bug. You are watching the assignee of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 2849] OpenSSH 7.7p1 uses login_name value instead of user@hostname
https://bugzilla.mindrot.org/show_bug.cgi?id=2849 --- Comment #3 from Mark E Waite --- I agree that the Jenkins behavior is incorrect. It should use the correct login_name. However, please consider the other example cited by Johannes Schindelin in https://github.com/openssh/openssh-portable/pull/91 before you decide to retain the new OpenSSH 7.7p1 command line argument precedence behavior. He notes in the pull request that the new behavior now takes the first argument value even if later arguments provide a replacement value. He describes how that will harm existing uses of shell aliases that provide a default value for login_name while still allowing the default value to be overridden. With OpenSSH 7.7p1, the override will be ignored. The OpenSSH 7.6p1 command line argument behavior is describing clearly and accurately in OpenSSH bug 2348. The patch from OpenSSH bug 2348 has not been included in the documentation, but it accurately describes the behavior before OpenSSH 7.7. I think it is a mistake to change the behavior in OpenSSH 7.7 in this way. It will break other users, not just the Jenkins git plugin. -- You are receiving this mail because: You are watching someone on the CC list of the bug. You are watching the assignee of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 2849] OpenSSH 7.7p1 uses login_name value instead of user@hostname
https://bugzilla.mindrot.org/show_bug.cgi?id=2849 Damien Miller changed: What|Removed |Added CC||d...@mindrot.org --- Comment #2 from Damien Miller --- OpenSSH 7.7 makes it first-match-wins, which is how all other command-line and configuration file options are processed. The previous behaviour was at best undefined and certainly inconsistent with everything else. Why is jenkins specifying contradictory username options? That seems like a more obvious bug. -- You are receiving this mail because: You are watching someone on the CC list of the bug. You are watching the assignee of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 2849] OpenSSH 7.7p1 uses login_name value instead of user@hostname
https://bugzilla.mindrot.org/show_bug.cgi?id=2849 --- Comment #1 from Mark E Waite --- See proposed patch from Johannes Schindelin at https://github.com/openssh/openssh-portable/pull/91 -- You are receiving this mail because: You are watching the assignee of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
