Re: [openssl-dev] OpenSSL 1.1.0-pre4 change in SSL_get_version() return value

2016-03-19 Thread Viktor Dukhovni
On Thu, Mar 17, 2016 at 12:37:41AM +0200, Jouni Malinen wrote: > Was the SSL_get_version() behavior changed on purpose in the Beta 1 > release? This function used to return "TLSv1" when TLS v1.0 was used > while it is now in Beta 1 returning "TLSv1.0" for that case. I missed this change in the re

Re: [openssl-dev] OpenSSL 1.1.0-pre4 change in SSL_get_version() return value

2016-03-19 Thread Viktor Dukhovni
> On Mar 18, 2016, at 4:40 PM, Richard Moore wrote: > > I think it is reasonable to preserve the backwards compatible "TLSv1" > > for the string protocol version, but do we also need to preserve the > > "TLSv1.0" in ciphers(1) output? If so, the code needs an exception > > that can otherwise b

Re: [openssl-dev] OpenSSL 1.1.0-pre4 change in SSL_get_version() return value

2016-03-19 Thread Viktor Dukhovni
> On Mar 16, 2016, at 6:44 PM, Viktor Dukhovni > wrote: > >> Was the SSL_get_version() behavior changed on purpose in the Beta 1 >> release? This function used to return "TLSv1" when TLS v1.0 was used >> while it is now in Beta 1 returning "TLSv1.0" for that case. > > I missed this change in t

[openssl-dev] OpenSSL 1.1.0-pre4 change in SSL_get_version() return value

2016-03-18 Thread Jouni Malinen
Was the SSL_get_version() behavior changed on purpose in the Beta 1 release? This function used to return "TLSv1" when TLS v1.0 was used while it is now in Beta 1 returning "TLSv1.0" for that case. This type of unexpected change in the API can break existing users of the function. As an example, wp

Re: [openssl-dev] OpenSSL 1.1.0-pre4 change in SSL_get_version() return value

2016-03-18 Thread Richard Moore
On 18 March 2016 at 16:20, Hubert Kario wrote: > On Wednesday 16 March 2016 20:40:42 Viktor Dukhovni wrote: > > > On Mar 16, 2016, at 6:44 PM, Viktor Dukhovni us...@dukhovni.org> wrote: > > >> Was the SSL_get_version() behavior changed on purpose in the Beta 1 > > >> release? This function used

Re: [openssl-dev] OpenSSL 1.1.0-pre4 change in SSL_get_version() return value

2016-03-18 Thread Viktor Dukhovni
> On Mar 16, 2016, at 6:44 PM, Viktor Dukhovni > wrote: > >> Was the SSL_get_version() behavior changed on purpose in the Beta 1 >> release? This function used to return "TLSv1" when TLS v1.0 was used >> while it is now in Beta 1 returning "TLSv1.0" for that case. > > I missed this change in t

Re: [openssl-dev] OpenSSL 1.1.0-pre4 change in SSL_get_version() return value

2016-03-18 Thread Hubert Kario
On Wednesday 16 March 2016 20:40:42 Viktor Dukhovni wrote: > > On Mar 16, 2016, at 6:44 PM, Viktor Dukhovni wrote: > >> Was the SSL_get_version() behavior changed on purpose in the Beta 1 > >> release? This function used to return "TLSv1" when TLS v1.0 was > >> used > >> while it is now in Beta 1