Re: [CVS] OpenSSL: openssl/crypto/x509/ x509_att.c

Dr. Stephen Henson wrote: - if (len == -1) + if ((len == -1) !(attrtype MBSTRING_FLAG)) I do wish you wouldn't use these extra brackets around comparison operators. if (len == -1 !(attrtype MBSTRING_FLAG)) works just fine and is consistent with most of the rest of the

Re: [CVS] OpenSSL: openssl/crypto/x509/ x509_att.c

On Friday 30 May 2008 09:52:40 Ben Laurie wrote: Dr. Stephen Henson wrote: - if (len == -1) + if ((len == -1) !(attrtype MBSTRING_FLAG)) I do wish you wouldn't use these extra brackets around comparison operators. if (len == -1 !(attrtype MBSTRING_FLAG)) works just fine

Re: [CVS] OpenSSL: openssl/crypto/x509/ x509_att.c

Geoff Thorpe wrote: On Friday 30 May 2008 09:52:40 Ben Laurie wrote: Dr. Stephen Henson wrote: I do wish you wouldn't use these extra brackets around comparison operators. if (len == -1 !(attrtype MBSTRING_FLAG)) works just fine and is consistent with most of the rest of the