Re: Bug in CRYPTO_get_new_dynlockid()

2002-12-13 Thread Bertie
At 06:34 PM 12/12/02 +0100, Richard Levitte - VMS Whacker wrote: In message [EMAIL PROTECTED] on Wed, 11 Dec 2002 08:24:47 +, Bertie [EMAIL PROTECTED] said: bertie In view of the fact that the chil engine code is only bertie threadsafe if the dynlock callbacks are implemented, and that bertie

Re: Bug in CRYPTO_get_new_dynlockid()

2002-12-13 Thread Richard Levitte - VMS Whacker
In message [EMAIL PROTECTED] on Fri, 13 Dec 2002 08:54:50 +, Bertie [EMAIL PROTECTED] said: bertie Your changes aren't in the latest snapshot, bertie openssl-0.9.7-stable-SNAP-20021212.tar.gz. Is there some other bertie way that I can test them ? You can rsync our repository, and check out

Re: Bug in CRYPTO_get_new_dynlockid()

2002-12-13 Thread Bertie
At 10:02 AM 12/13/02 +0100, Richard Levitte - VMS Whacker wrote: In message [EMAIL PROTECTED] on Fri, 13 Dec 2002 08:54:50 +, Bertie [EMAIL PROTECTED] said: bertie Your changes aren't in the latest snapshot, bertie openssl-0.9.7-stable-SNAP-20021212.tar.gz. Is there some other bertie way that

Re: Bug in CRYPTO_get_new_dynlockid()

2002-12-13 Thread Bertie
At 12:22 PM 12/13/02 +, Bertie wrote: At 10:02 AM 12/13/02 +0100, Richard Levitte - VMS Whacker wrote: In message [EMAIL PROTECTED] on Fri, 13 Dec 2002 08:54:50 +, Bertie [EMAIL PROTECTED] said: bertie Your changes aren't in the latest snapshot, bertie

Re: Bug in CRYPTO_get_new_dynlockid()

2002-12-13 Thread Richard Levitte - VMS Whacker
In message [EMAIL PROTECTED] on Fri, 13 Dec 2002 12:49:02 +, Bertie [EMAIL PROTECTED] said: bertie Have rsync'd the latest and eyeballed your changes. They look bertie fine to me, I like the way you have left the error in if bertie dynlocks not supported this is visible from e.g. openssl

Re: Bug in CRYPTO_get_new_dynlockid()

2002-12-12 Thread Bertie
At 11:29 AM 12/11/02 -0500, Geoff Thorpe wrote: Hi there, * Bertie ([EMAIL PROTECTED]) wrote: At 10:00 AM 12/11/02 +0100, Richard Levitte - VMS Whacker wrote: bertie Yep, this solution works if you are an application developer bertie wanting to use chil engine. This is not much help if you are

Re: Bug in CRYPTO_get_new_dynlockid()

2002-12-12 Thread Richard Levitte - VMS Whacker
I've been thinking about the whole static vs. dynamic lock situation, and I must say I have some difficulty seeing a good way out of it. The two variants serve similar purposes, but have one crucial difference, and it's that the static ones are pre-initialised. If everything was converted to use

Re: Bug in CRYPTO_get_new_dynlockid()

2002-12-12 Thread Bertie
If everything was converted to use dynamic locks, I wonder where those locks would be created and initialised? Shall we have yet another startup function, say OpenSSL_init(), that does this (BTW, we really should have that anyway, so we have something that does all those startup things that

Re: Bug in CRYPTO_get_new_dynlockid()

2002-12-11 Thread Bertie
bertie BTW: You never replied to the mail with subject Requiring bertie multithreaded apps to provide dynamic locking upcalls was bertie this because you agreed with it :-) Not really. It's more like haven't quite had the time to really read it, have marked it for later processing... I will

Re: Bug in CRYPTO_get_new_dynlockid()

2002-12-11 Thread Richard Levitte - VMS Whacker
In message [EMAIL PROTECTED] on Wed, 11 Dec 2002 08:24:47 +, Bertie [EMAIL PROTECTED] said: bertie In view of the fact that the chil engine code is only bertie threadsafe if the dynlock callbacks are implemented, and that bertie it is unlikely that openssl application developers will get

Re: Bug in CRYPTO_get_new_dynlockid()

2002-12-11 Thread Bertie
At 09:36 AM 12/11/02 +0100, Richard Levitte - VMS Whacker wrote: In message [EMAIL PROTECTED] on Wed, 11 Dec 2002 08:24:47 +, Bertie [EMAIL PROTECTED] said: bertie In view of the fact that the chil engine code is only bertie threadsafe if the dynlock callbacks are implemented, and that bertie

Re: Bug in CRYPTO_get_new_dynlockid()

2002-12-11 Thread Richard Levitte - VMS Whacker
In message [EMAIL PROTECTED] on Wed, 11 Dec 2002 08:56:19 +, Bertie [EMAIL PROTECTED] said: bertie Yep, this solution works if you are an application developer bertie wanting to use chil engine. This is not much help if you are bertie say an Apache user who wanted to use an nCipher HSM to

Re: Bug in CRYPTO_get_new_dynlockid()

2002-12-11 Thread Bertie
At 10:00 AM 12/11/02 +0100, Richard Levitte - VMS Whacker wrote: In message [EMAIL PROTECTED] on Wed, 11 Dec 2002 08:56:19 +, Bertie [EMAIL PROTECTED] said: bertie Yep, this solution works if you are an application developer bertie wanting to use chil engine. This is not much help if you are

Re: Bug in CRYPTO_get_new_dynlockid()

2002-12-11 Thread Richard Levitte - VMS Whacker
I'll ponder and get back to you later today. -- Richard Levitte \ Spannvägen 38, II \ [EMAIL PROTECTED] Redakteur@Stacken \ S-168 35 BROMMA \ T: +46-8-26 52 47 \ SWEDEN \ or +46-708-26 53 44 Procurator Odiosus Ex Infernis-- [EMAIL PROTECTED]

Re: Bug in CRYPTO_get_new_dynlockid()

2002-12-11 Thread Bertie
At 10:16 AM 12/11/02 +0100, Richard Levitte - VMS Whacker wrote: I'll ponder and get back to you later today. Thanks, Bertie __ OpenSSL Project http://www.openssl.org Development Mailing List

Re: Bug in CRYPTO_get_new_dynlockid()

2002-12-11 Thread Geoff Thorpe
Hi there, * Bertie ([EMAIL PROTECTED]) wrote: At 10:00 AM 12/11/02 +0100, Richard Levitte - VMS Whacker wrote: bertie Yep, this solution works if you are an application developer bertie wanting to use chil engine. This is not much help if you are bertie say an Apache user who wanted to use an

Re: Bug in CRYPTO_get_new_dynlockid()

2002-12-11 Thread Richard Levitte - VMS Whacker
In message 20021211162914.GA1042@debbie on Wed, 11 Dec 2002 11:29:14 -0500, Geoff Thorpe [EMAIL PROTECTED] said: geoff Just catching up on all this, but something seems a bit strange to me geoff about the fundamental reliance on OpenSSL-sponsored dynamic locks. The geoff point is this: ENGINE is

Re: Bug in CRYPTO_get_new_dynlockid()

2002-12-11 Thread Geoff Thorpe
Hi, * Richard Levitte - VMS Whacker ([EMAIL PROTECTED]) wrote: The CHIL interface was once meant as some kind of general purpose library to access certain functions in a cipher box or smart card. For that reason, it asks for mutex callbacks exactly like OpenSSL does (and probably for the same

Re: Bug in CRYPTO_get_new_dynlockid()

2002-12-10 Thread Richard Levitte - VMS Whacker
In message [EMAIL PROTECTED] on Mon, 09 Dec 2002 11:17:07 +, Bertie [EMAIL PROTECTED] said: bertie The patch fixed the CRYPTO_get_new_dynlockid() bug. Maybe bertie CRYPTO_lock could also be made safer when called with an bertie invalid lockid, do you think it should assert rather silently

Re: Bug in CRYPTO_get_new_dynlockid()

2002-12-09 Thread Bertie
At 01:28 AM 12/7/02 +0100, Richard Levitte - VMS Whacker wrote: In message [EMAIL PROTECTED] on Fri, 06 Dec 2002 16:51:37 +, Bertie [EMAIL PROTECTED] said: bertie There is a bug in CRYPTO_get_new_dynlockid(), since the first bertie time it gets called it returns -2 (not -1 as I expected

Bug in CRYPTO_get_new_dynlockid()

2002-12-06 Thread Bertie
Apologies for the previous mail, missed off [EMAIL PROTECTED] I have added dynamic locking support to apache2 and have been testing with openssl-0.9.7-beta4 and engine chil. There is a bug in CRYPTO_get_new_dynlockid(), since the first time it gets called it returns -2 (not -1 as I expected

Re: Bug in CRYPTO_get_new_dynlockid()

2002-12-06 Thread Richard Levitte - VMS Whacker
In message [EMAIL PROTECTED] on Fri, 06 Dec 2002 16:51:37 +, Bertie [EMAIL PROTECTED] said: bertie There is a bug in CRYPTO_get_new_dynlockid(), since the first bertie time it gets called it returns -2 (not -1 as I expected) and bertie when you call CRYPTO_lock (mode, -2, , ) it silently