Re: [openssl-project] Style guide updates

2018-01-26 Thread Andy Polyakov
> What else needs to be updated? Relax requirement that argument names in function definition has to match function declaration to permit adding 'unused_' prefix prior unused arguments. ___ openssl-project mailing list openssl-project@openssl.org

Re: [openssl-project] Style guide updates

2018-01-26 Thread Andy Polyakov
> - Don't use else after return? I'd argue against making it an absolute requirement. To give an example. You don't a problem with returns in switch, so why should it be a problem with returns from switch-like if-elseif chain? ___ openssl-project

Re: [openssl-project] Fwd: [openssl-commits] Broken: openssl/openssl#15866 (master - cf8e923)

2018-01-26 Thread Richard Levitte
I think I said it earlier, that prefixing the output with '#' is a TAP compatible way to fix this. One way is to pipe the execution of the program through a "sed -e 's|^|# |'", except that it's not exactly portable... Another way *might* be to open("program |") and handle the output in

Re: [openssl-project] Style guide updates

2018-01-26 Thread Matt Caswell
On 26/01/18 17:03, Richard Levitte wrote: > In message on Fri, 26 Jan > 2018 14:06:27 +, Matt Caswell said: > > matt> - Use size_t for sizes of things > > ... and, it seems, as array index. > Yes - because an array