Re: [openssl-project] constification on already released branches

2018-03-25 Thread Richard Levitte
In message on Mon, 26 Mar 2018 08:36:17 +1000, Tim Hudson said: tjh> https://github.com/openssl/openssl/pull/2181 tjh> and tjh> https://github.com/openssl/openssl/pull/1603#issuecomment-248649700 tjh> tjh> One thing that should be noted is that if you are building with tjh> -Wall -Werror (whic

[openssl-project] cppflags, cflags and ldflags

2018-03-25 Thread Richard Levitte
Note: this mail follows the discussion on github started here: https://github.com/openssl/openssl/pull/5742#discussion_r176919954 That discussion started as a simple side note, but I should probably have known better... it ends up derailing a PR that shouldn't really be affected, so I'm bringing t

[openssl-project] rule-based building attributes (Re: cppflags, cflags and ldflags)

2018-03-25 Thread Richard Levitte
Branching a specific thread around these ideas. In message on Sun, 25 Mar 2018 18:45:40 +0200, Andy Polyakov said: appro> > Another side thing that I've been thinking of for quite a while, and I appro> > think you may have argued for even though I feel a bit unsure, and appro> > that's to supp

Re: [openssl-project] cppflags, cflags and ldflags

2018-03-25 Thread Richard Levitte
In message <7e8cc500-3739-e32a-e036-4c3eb8f28...@openssl.org> on Sun, 25 Mar 2018 15:20:54 +0200, Andy Polyakov said: appro> > My spin on it goes in a different direction. It's true that we appro> > *currently* pass cflags to all stages. I would argue, though, that appro> > this is mostly beca

Re: [openssl-project] cppflags, cflags and ldflags

2018-03-25 Thread Andy Polyakov
>> Note: this mail follows the discussion on github started here: >> https://github.com/openssl/openssl/pull/5742#discussion_r176919954 In the light of the new evidence presented in https://github.com/openssl/openssl/pull/5745 one can argue in favour of splitting -pthread flag to cppflags and ldfl

Re: [openssl-project] cppflags, cflags and ldflags

2018-03-25 Thread Andy Polyakov
> appro> We already touched this in Windows context, one option (more suitable > in > appro> my mind) is toolchain-specific *rules*. I.e. instead of trying to fit > appro> cube into circular hole, just make square hole on the side. For example > appro> *if* target has ldonly attribute, just emit l

Re: [openssl-project] cppflags, cflags and ldflags

2018-03-25 Thread Andy Polyakov
> Note: this mail follows the discussion on github started here: > https://github.com/openssl/openssl/pull/5742#discussion_r176919954 > That discussion started as a simple side note, but I should probably > have known better... it ends up derailing a PR that shouldn't really > be affected, so I'm

[openssl-project] constification on already released branches

2018-03-25 Thread Tim Hudson
https://github.com/openssl/openssl/pull/2181 and https://github.com/openssl/openssl/pull/1603#issuecomment-248649700 One thing that should be noted is that if you are building with -Wall -Werror (which many projects do) and you are using OpenSSL and things change from a const perspective builds br