Re: [Openstack] Discussion / proposal: deleted column marker

2012-10-02 Thread Johannes Erdfelt
On Tue, Oct 02, 2012, Pitucha, Stanislaw Izaak stanislaw.pitu...@hp.com wrote: I'd like to open a discussion on a topic that's been bugging me for a number of reasons - soft deletes (by that I mean marking rows with deleted=1 in the db) and related - actions audit. This is a subject I'm

Re: [Openstack] Discussion / proposal: deleted column marker

2012-10-02 Thread Johannes Erdfelt
On Tue, Oct 02, 2012, Pitucha, Stanislaw Izaak stanislaw.pitu...@hp.com wrote: Does anyone know why soft-delete is still in place? Are there any reasons it can't / shouldn't be removed at this time? If it's possible to remove it, would you miss it? I'm certainly not a fan of the database

Re: [Openstack] Default reply to behavior for mailing list

2012-07-31 Thread Johannes Erdfelt
On Tue, Jul 31, 2012, Bhuvaneswaran A bhu...@apache.org wrote: If a subscriber reply to a mailing list message, it's sent to the author only. Each subscriber should use Reply to All every time, to post a reply to mailing list. Can you please configure the mailing list and set reply-to header

Re: [Openstack] [nova] Proposal for Sean Dague to join nova-core

2012-07-23 Thread Johannes Erdfelt
On Fri, Jul 20, 2012, Vishvananda Ishaya vishvana...@gmail.com wrote: When I was going through the list of reviewers to see who would be good for nova-core a few days ago, I left one out. Sean has been doing a lot of reviews lately[1] and did the refactor and cleanup of the driver loading

Re: [Openstack] [nova] Proposal to add Padraig Brady to nova-core

2012-07-19 Thread Johannes Erdfelt
On Wed, Jul 18, 2012, Vishvananda Ishaya vishvana...@gmail.com wrote: Padraig has been contributing a lot of code to all parts of nova, and has been contributing a lot to reviews[1]. I think he would make a great addition to nova-core. +1! JE ___

Re: [Openstack] [nova] Proposal to add Yun Mao to nova-core

2012-07-19 Thread Johannes Erdfelt
On Wed, Jul 18, 2012, Vishvananda Ishaya vishvana...@gmail.com wrote: Yun has been putting a lot of effort into cleaning up our state management, and has been contributing a lot to reviews[1]. I think he would make a great addition to nova-core. +1! JE

Re: [Openstack] [nova] Proposal to add Michael Still to nova-core

2012-07-19 Thread Johannes Erdfelt
On Wed, Jul 18, 2012, Vishvananda Ishaya vishvana...@gmail.com wrote: Michael wrote the image cache management code, did all of the remaining conversions of instance_id - instance_uuid, and has been contributing a lot to reviews[1]. I think he would make a great addition to nova-core. +1! JE

Re: [Openstack] How do I stop image-create from using /tmp?

2012-07-03 Thread Johannes Erdfelt
On Tue, Jul 03, 2012, Daniel P. Berrange berra...@redhat.com wrote: It seems to me that we're just as likely to have a review slip through that uses /tmp insecurely as a review slipping through that uses /tmp at all. We already run a bunch of PEP8 checks across the code on every commit.

Re: [Openstack] How do I stop image-create from using /tmp?

2012-07-02 Thread Johannes Erdfelt
On Mon, Jul 02, 2012, Daniel P. Berrange berra...@redhat.com wrote: In Fedora 18, /tmp is going to be a RAM filesystem, so we absolutely must not create any sizeable files on /tmp. In addition from a security POV, we must aim to *never* use /tmp for anything at all

Re: [Openstack] How do I stop image-create from using /tmp?

2012-07-02 Thread Johannes Erdfelt
On Mon, Jul 02, 2012, Daniel P. Berrange berra...@redhat.com wrote: On Mon, Jul 02, 2012 at 08:17:08AM -0700, Johannes Erdfelt wrote: Not using /tmp for large files is a good reason for practical reasons (distributions moving to ramfs for /tmp). But please don't start throwing around

Re: [Openstack] help me with the xenapi test

2012-07-02 Thread Johannes Erdfelt
On Mon, Jul 02, 2012, Salvatore Orlando sorla...@nicira.com wrote: I do not see any obvious reason for these failures, especially as they appear to occur when the vdi is created. If I recall it correctly, that code is stubbed out for unit tests, and it does not seem your patch un-stubs it.

Re: [Openstack] RFC: Thoughts on improving OpenStack GIT commit practice/history

2012-06-28 Thread Johannes Erdfelt
First off, I wanted to say I think these are a great set of recommendations. On Wed, Jun 27, 2012, Daniel P. Berrange berra...@redhat.com wrote: Fixes: bug #1003373 Implements: blueprint libvirt-xml-cpu-model Change-Id: I4946a16d27f712ae2adf8441ce78e6c0bb0bb657 Signed-off-by:

Re: [Openstack] Openstack special sauce checking tool??

2012-06-28 Thread Johannes Erdfelt
On Thu, Jun 28, 2012, Joshua Harlow harlo...@yahoo-inc.com wrote: I remember hearing once that someone had a openstack import/hacking style checking tool. I was wondering if such a thing existed to verify same the openstack way of doing imports and other special checks to match the openstack

Re: [Openstack] RFC: Thoughts on improving OpenStack GIT commit practice/history

2012-06-28 Thread Johannes Erdfelt
On Thu, Jun 28, 2012, Daniel P. Berrange berra...@redhat.com wrote: On Thu, Jun 28, 2012 at 09:21:20AM -0700, Johannes Erdfelt wrote: What is the Signed-off-by tag used for? Your examples have yourself, but isn't that kind of implied by submitting the patch for review in the first place

Re: [Openstack] RPC Semantics

2012-06-12 Thread Johannes Erdfelt
On Tue, Jun 12, 2012, Eric Windisch e...@cloudscaling.com wrote: We actually do have ACKs in ZeroMQ, as far as I understand how they work in AMQP, but they're really simple. The send() method is actually synchronous with the message being received on the other end. However, we don't wait for

Re: [Openstack] RPC Semantics

2012-06-12 Thread Johannes Erdfelt
On Tue, Jun 12, 2012, Eric Windisch e...@cloudscaling.com wrote: For instance, an instance migration can take a while since we need to copy many gigabytes of disks to another host. If we want to do a software upgrade, we either need to wait a long time for the migration to finish, or we

Re: [Openstack] Comparing roles - case (in)sensitivity

2012-06-08 Thread Johannes Erdfelt
On Fri, Jun 08, 2012, Brian Waldon brian.wal...@rackspace.com wrote: Can you explain why? Not to speak for Kiall, but I'll make the argument that there is no value in treating admin, Admin, and admIn separately. It can only lead to confusion and frustration of the people who use OpenStack.

Re: [Openstack] How to let nova use localtime rather than UTC time?

2012-06-06 Thread Johannes Erdfelt
On Wed, Jun 06, 2012, livemoon mwjpi...@gmail.com wrote: I found nova use utcnow to get time and write it to db. So the create_time of vm also show utc time rather than localtime. You really don't want to do this. For instance, the database won't store the timezone, so in places where there is

[Openstack] Jenkins Changes

2012-06-06 Thread Johannes Erdfelt
There appears to have been some changes to Jenkins recently. Jobs do not appear to be associated with Gerrit changes anymore. https://jenkins.openstack.org/job/gate-nova-python27/ You can see jobs 335 and older have a link to Gerrit, but new jobs don't have any. This makes it harder to see what

Re: [Openstack] Parallel execution of Jenkins gate jobs

2012-06-06 Thread Johannes Erdfelt
On Tue, Jun 05, 2012, James E. Blair cor...@inaugust.com wrote: One important difference is that the new system does not have retrigger buttons in Jenkins. If the gate tests fail with a false negative, you'll need to leave another Approved vote in Gerrit. This part of your post didn't

Re: [Openstack] How to let nova use localtime rather than UTC time?

2012-06-06 Thread Johannes Erdfelt
On Wed, Jun 06, 2012, Gabriel Hurley gabriel.hur...@nebula.com wrote: Stored timestamps should always be in UTC, however efforts should be made to support local timezones as a user-configurable option. Horizon will be working towards this goal since Django has good timezone support, I'd

Re: [Openstack] Lossage in nova test suite?

2012-06-04 Thread Johannes Erdfelt
On Mon, Jun 04, 2012, James E. Blair cor...@inaugust.com wrote: On 06/04/2012 05:47 PM, Gabe Westmaas wrote: Should we revert this change till we get it cleared up? Here's a proposal to do that: https://review.openstack.org/#/c/8166/ I approved it because of how bad Jenkins is right

Re: [Openstack] cfg usage - option registration, global objects

2012-05-31 Thread Johannes Erdfelt
On Thu, May 31, 2012, Mark Washenberger mark.washenber...@rackspace.com wrote: * not be tied up with eventlet on the consumer side Yes! * let the consumer code decide when to ack a message (although maybe the concept of acking doesn't exist for all implementations?) My XenAPI

Re: [Openstack] cfg usage - option registration, global objects

2012-05-31 Thread Johannes Erdfelt
On Thu, May 31, 2012, Mark McLoughlin mar...@redhat.com wrote: On Thu, 2012-05-31 at 08:58 -0700, Johannes Erdfelt wrote: My XenAPI idempotency branch delays ACKs until after it's done processing the message to ensure we get the message again after restart. https://review.openstack.org

Re: [Openstack] [Netstack] About python versions that we are planning to support

2012-05-09 Thread Johannes Erdfelt
On Wed, May 09, 2012, Robert Kukura rkuk...@redhat.com wrote: I'm very concerned about the potential of this XenServer/XCP requirement to interfere with making the various Quantum agents first-class OpenStack services by utilizing current and future openstack-common facilities for

Re: [Openstack] database migration cleanup

2012-04-30 Thread Johannes Erdfelt
On Mon, Apr 30, 2012, Dan Prince dpri...@redhat.com wrote: The primary benefit here is it is simply less code to maintain: The old migrations scripts for Essex are around 6200 lines of code. The new compacted migration for Essex is around 950 lines of code. It seems like you're counting

Re: [Openstack] database migration cleanup

2012-04-27 Thread Johannes Erdfelt
On Fri, Apr 27, 2012, Dan Prince dpri...@redhat.com wrote: Mirations don't appear to be particularly slow right now, and it doesn't appear that merging migrations will make them significantly faster. What exactly is the benefit of doing this? Speed wasn't the primary motivation here

Re: [Openstack] database migration cleanup

2012-04-27 Thread Johannes Erdfelt
On Fri, Apr 27, 2012, Monsyne Dragon mdra...@rackspace.com wrote: Even better, what would it take to try using Alembic? (http://alembic.readthedocs.org/en/latest/front.html#project-homepage) It's a big improvement over sqlalchemy. Amongst other things, migrations are not numbered, they are

Re: [Openstack] Caching strategies in Nova ...

2012-03-23 Thread Johannes Erdfelt
On Fri, Mar 23, 2012, Kevin L. Mitchell kevin.mitch...@rackspace.com wrote: On Fri, 2012-03-23 at 13:43 +, Gabe Westmaas wrote: However, I kind of expect that many users will still poll even if they know they won't get new data until X time. I wish there was some kind of way for us

Re: [Openstack] Caching strategies in Nova ...

2012-03-23 Thread Johannes Erdfelt
On Fri, Mar 23, 2012, Debo Dutta (dedutta) dedu...@cisco.com wrote: +1 to DBs being slow. But what if we used a combo of memcache and db. Or use couch/mongo. Comparision: http://kkovacs.eu/cassandra-vs-mongodb-vs-couchdb-vs-redis Anyone has experience on large deployments to see the

[Openstack-poc] [Bug 951197] Re: openstack namespace does not play nicely with checkedout repos

2012-03-23 Thread Johannes Erdfelt
The change doesn't handle the case where cfg.py imports other modules from openstack/common which aren't installed yet either. This is the case with the new iniparser.py module that I recently got merged. As a workaround so I can get my changes into nova, I hacked update.py to use this code:

[Openstack-poc] [Bug 963509] [NEW] update.py doesn't handle dependencies of configured modules

2012-03-23 Thread Johannes Erdfelt
Public bug reported: cfg.py now depends on iniparser.py, but update.py didn't automatically copy it. The dependencies can be figured out automatically and update.py could be friendlier and help out us poor developers. ** Affects: openstack-common Importance: Undecided Status: New

Re: [Openstack] Being pedantic about pedanticism: HACKING styleguide

2012-03-22 Thread Johannes Erdfelt
On Thu, Mar 22, 2012, Andrew Bogott abog...@wikimedia.org wrote: I propose that this unified style guide be copied into each of the above projects, with a mandate to maintain consistency henceforth. Any objections? I recently saw a suggestion to put it into openstack-common, but I don't

Re: [Openstack] Being pedantic about pedanticism: HACKING styleguide

2012-03-22 Thread Johannes Erdfelt
On Thu, Mar 22, 2012, Kevin L. Mitchell kevin.mitch...@rackspace.com wrote: On Thu, 2012-03-22 at 11:22 -0500, Andrew Bogott wrote: Nova, this: A docstring ends with an empty line before the closing quotations. Huh? I thought I removed that... You did:

Re: [Openstack] [NOVA] Snapshotting may require significant disk space (in /tmp). How to properly solve disk space issues?

2012-03-16 Thread Johannes Erdfelt
On Fri, Mar 16, 2012, Vishvananda Ishaya vishvana...@gmail.com wrote: Now that we have the temdir context manager I was thinking something like: diff --git a/nova/utils.py b/nova/utils.py index e375f11..a3ac896 100644 --- a/nova/utils.py +++ b/nova/utils.py @@ -61,9 +61,11 @@

[Openstack-poc] [Bug 955308] [NEW] MultiStrOpt doesn't always accept multiple strings

2012-03-14 Thread Johannes Erdfelt
Public bug reported: It appears to work for CLI options but not when using config files. Looking at the tests, this appears to be a known bug since the assertion in test_conf_file_multistr_values_append has been commented out with a FIXME. ** Affects: openstack-common Importance: Undecided

Re: [Openstack] Gerrit minimum review time frame

2012-03-13 Thread Johannes Erdfelt
On Tue, Mar 13, 2012, Lorin Hochstein lo...@nimbisservices.com wrote: As long as we're talking about review issues, I'd really like to have a set of reviewing guidelines. Even better would be to have them in checklist form to make sure we don't miss things as we do reviews (checklists are

Re: [Openstack] Notifiers

2012-03-12 Thread Johannes Erdfelt
is already working on this. If not, let me know if this makes sense and I can start by creating a blueprint. Also, is there any preference to use object oriented (or not)? It is a surprise that the code is different for event notifications between Nova and Glance. I believe the same developer (Johannes

Re: [Openstack] db notification support for API extension?

2012-03-08 Thread Johannes Erdfelt
On Thu, Mar 08, 2012, Andrew Bogott abog...@wikimedia.org wrote: 1) DB support I need a database table to keep track of some filesystem metadata. My current implementation adds the table via nova/db/sqlalchemy/migrate_repo... but is it really necessary to coordinate this table with

Re: [Openstack] Memory leaks from greenthreads

2012-03-05 Thread Johannes Erdfelt
On Mon, Mar 05, 2012, Pádraig Brady p...@draigbrady.com wrote: File /usr/lib64/python2.7/threading.py, line 446, in __init__ self.__daemonic = self._set_daemon() File /usr/lib64/python2.7/threading.py, line 470, in _set_daemon return current_thread().daemon AttributeError:

Re: [Openstack] eventlet weirdness

2012-03-02 Thread Johannes Erdfelt
On Fri, Mar 02, 2012, Armando Migliaccio armando.migliac...@eu.citrix.com wrote: I agree, but then the whole assumption of adopting eventlet to simplify the programming model is hindered by the fact that one has to think harder to what is doing...Nova could've kept Twisted for that matter.

Re: [Openstack] eventlet weirdness

2012-02-29 Thread Johannes Erdfelt
On Wed, Feb 29, 2012, Yun Mao yun...@gmail.com wrote: we sometimes notice this error message which prevent us from starting nova services occasionally. We are using a somewhat modified diablo stable release on Ubuntu 11.10. It may very well be the problem from our patches but I'm wondering if

Re: [Openstack] Memory leaks from greenthreads

2012-02-29 Thread Johannes Erdfelt
On Wed, Feb 29, 2012, Joshua Harlow harlo...@yahoo-inc.com wrote: Just a thought I was having, that others might want to chime in on. Has there been any thinking around only using eventlet/greenlet for webserver endpoints and using something like multiprocessing for everything else? I

Re: [Openstack] Devstack (sh) and tmux

2012-02-08 Thread Johannes Erdfelt
On Wed, Feb 08, 2012, Dugger, Donald D donald.d.dug...@intel.com wrote: Unless they've changed things (I've worked on so many versions of Linux/Unix I do get confused :) but `stdio' is supposed to check and, if the output is a file then it's buffered and, if it's a terminal, then it's

Re: [Openstack] Openstack + XCP (both on SID): XenAPI python script failing

2011-12-30 Thread Johannes Erdfelt
On Sat, Dec 31, 2011, Thomas Goirand tho...@goirand.fr wrote: Here's the output (reformatted by hand to fit in this mail): root@GPLHost:os_ # glance index ID Name Disk Format Size uuid1 lucid_ami ami 524288000 uuid2 kernelaki 4099360 uuid3 ramdisk ari

Re: [Openstack] CRITICAL XENAPI_MISSING_PLUGIN xenhost

2011-12-28 Thread Johannes Erdfelt
On Thu, Dec 29, 2011, Thomas Goirand tho...@goirand.fr wrote: What am I doing wrong? What's that plugin thing about? Note that I've put stuff in /etc/xapi.d, like the xenhost python script, but it doesn't seem that's enough. Did you place it in /etc/xapi.d or /etc/xapi.d/plugins? The latter is

Re: [Openstack] using objects returned from DB layer

2011-12-15 Thread Johannes Erdfelt
On Thu, Dec 15, 2011, Kevin L. Mitchell kevin.mitch...@rackspace.com wrote: 2. However, I violently disagree with the idea that the DB layer must return dicts. It does not, even if you start talking about allowing use of other kinds of databases. We can, and should,

Re: [Openstack] using objects returned from DB layer

2011-12-15 Thread Johannes Erdfelt
On Thu, Dec 15, 2011, Mark Washenberger mark.washenber...@rackspace.com wrote: 1. regular objects (which is what I thought Kevin was talking about. . . maybe?) I think this has been poorly defined so far. I've seen some quick proposals that include moving instance actions to an Instance class,

Re: [Openstack] Current rev of lp:nova

2011-09-23 Thread Johannes Erdfelt
On Fri, Sep 23, 2011, Salvatore Orlando salvatore.orla...@eu.citrix.com wrote: This appears to have been fixed now. It's been mostly fixed. However, it appears that the last commit to lp:nova (which was a branch of mine) has been lost in the move to github. It's not in the git tree and it's not

Re: [Openstack] A possible alternative to Gerrit ...

2011-09-07 Thread Johannes Erdfelt
On Wed, Sep 07, 2011, Jay Pipes jaypi...@gmail.com wrote: On Wed, Sep 7, 2011 at 11:34 AM, Sandy Walsh sandy.wa...@rackspace.com wrote: But yes, there is a risk that a core member could just hit merge and close and break trunk. That's perhaps the only real con I can think of. That's the

Re: [Openstack] A possible alternative to Gerrit ...

2011-09-07 Thread Johannes Erdfelt
On Wed, Sep 07, 2011, Jay Pipes jaypi...@gmail.com wrote: On Wed, Sep 7, 2011 at 12:24 PM, Johannes Erdfelt johan...@erdfelt.com wrote: Why do core members have that merge and close option? Wouldn't it make more sense to restrict that to the Jenkins account? I still think you can do

Re: [Openstack] A possible alternative to Gerrit ...

2011-09-07 Thread Johannes Erdfelt
On Wed, Sep 07, 2011, Jay Pipes jaypi...@gmail.com wrote: The problem is that instead of spending time coding on features and bugs for Nova, Glance, Swift and Keystone, a bunch of devs are instead spending time working on an alternate solution to what has already been decided by the PPB,

Re: [Openstack] A possible alternative to Gerrit ...

2011-09-07 Thread Johannes Erdfelt
On Wed, Sep 07, 2011, Monty Taylor mord...@inaugust.com wrote: Part of this also comes from a semantic difference in how github and gerrit view the world. On github, you develop on your personal fork, and then you submit one of the branches in your fork to be pulled - so the unit of review is

Re: [Openstack] A possible alternative to Gerrit ...

2011-09-07 Thread Johannes Erdfelt
On Wed, Sep 07, 2011, Sandy Walsh sandy.wa...@rackspace.com wrote: ... and that's only from my first few days using Gerrit. I'd also like to add that the when merges fail, it's not easy to figure out why. I had a proposed branch the was approved and then failed to merge. I received a handful

Re: [Openstack] Why are we using github again?

2011-08-27 Thread Johannes Erdfelt
On Fri, Aug 26, 2011, Jesse Andrews anotherje...@gmail.com wrote: I disagree. I find lots of valuable in github even if trunk merges require gerrit. Teams can (and IMHO should) use pull requests to improve the quality before it is proposed to trunk. Pull requests to branches can be made

Re: [Openstack] Git/Gerrit workflow changes for Glance/Keystone

2011-08-26 Thread Johannes Erdfelt
On Mon, Aug 22, 2011, James E. Blair cor...@inaugust.com wrote: If you have any problems or questions, feel free to respond here, talk to mtaylor or jeblair on IRC, file a bug at URL:https://launchpad.net/openstack-ci, or submit a patch to URL:https://github.com/openstack/openstack-ci. In my

[Openstack] Why are we using github again?

2011-08-26 Thread Johannes Erdfelt
I'm struggling to find a reason why the Openstack project is using github. The use of Gerrit and other tools has reduced github to being just a pretty way to view a git repository. We can't use the github workflow of forking the repository, since that confuses the tools for Gerrit. There's

Re: [Openstack] Unable to publish an image on debian 6

2011-08-16 Thread Johannes Erdfelt
On Mon, Aug 15, 2011, Vishvananda Ishaya vishvana...@gmail.com wrote: I pushed a new version of that branch with the suggested change. The recent change to our db library to make it use eventlet is stealing the stack trace, so we can't reraise the same exception. The branch now logs the