Russell,
FYI, with the flags patch, it is no longer possible to set rpc-implementation
dependent flags in fake_flags.
Even Rabbit has a flag in there (fake_rabbit), but Rabbit flags are currently
global, so it works. That won't be true for long… We're going to have to fix
this.
One option is
I added a flag in my branch which uses a flag defined in the ZeroMQ driver.
This was fine before, but is a problem now, because tests/__init__.py doesn't
do rpc.register_opts. Instead, it does FLAGS.register_opts(rpc.rpc_opts), which
only loads the common RPC flags.
Of course, the flags file
On 05/04/2012 12:08 PM, Russell Bryant wrote:
On 05/04/2012 11:53 AM, Eric Windisch wrote:
Russell,
FYI, with the flags patch, it is no longer possible to set
rpc-implementation dependent flags in fake_flags.
Even Rabbit has a flag in there (fake_rabbit), but Rabbit flags are
currently
On 05/04/2012 12:16 PM, Eric Windisch wrote:
I added a flag in my branch which uses a flag defined in the ZeroMQ driver.
This was fine before, but is a problem now, because tests/__init__.py
doesn't do rpc.register_opts. Instead, it does
FLAGS.register_opts(rpc.rpc_opts), which only loads
I guess another question is, why do you need to set ZeroMQ related flags
in fake_flags? I think those should only be settings that apply for
*all* unit tests. I would just register your flags in your unit tests.
https://github.com/openstack/nova/blob/master/nova/tests/rpc/test_qpid.py#L69
On 05/04/2012 12:45 PM, Eric Windisch wrote:
I guess another question is, why do you need to set ZeroMQ related flags
in fake_flags? I think those should only be settings that apply for
*all* unit tests. I would just register your flags in your unit tests.
6 matches
Mail list logo
