Re: [openstack-dev] [Nova][libvirt] Understand why we lookup libvirt domains by instance name

2015-05-22 Thread Andrew Laski
On 05/22/15 at 10:16am, Deepak Shetty wrote: On Fri, May 22, 2015 at 5:19 AM, Mathieu Gagné mga...@iweb.com wrote: On 2015-05-21 4:18 PM, Chris Friesen wrote: I guess it's for the reason I mentioned above: To not break all OpenStack installations on Earth running with default config

Re: [openstack-dev] [Nova][libvirt] Understand why we lookup libvirt domains by instance name

2015-05-21 Thread Xav Paice
On 21/05/15 21:23, Daniel P. Berrange wrote: On Wed, May 20, 2015 at 03:01:50PM -0700, Michael Still wrote: I note that we use instance.name to lookup the libvirt domain a bunch in the driver. I'm wondering why we don't just use instance.uuid all the time -- the code for that already exists.

Re: [openstack-dev] [Nova][libvirt] Understand why we lookup libvirt domains by instance name

2015-05-21 Thread Daniel P. Berrange
On Wed, May 20, 2015 at 03:01:50PM -0700, Michael Still wrote: I note that we use instance.name to lookup the libvirt domain a bunch in the driver. I'm wondering why we don't just use instance.uuid all the time -- the code for that already exists. Is there a good reason to not move to always

Re: [openstack-dev] [Nova][libvirt] Understand why we lookup libvirt domains by instance name

2015-05-21 Thread Daniel P. Berrange
On Thu, May 21, 2015 at 09:34:20PM +1200, Xav Paice wrote: On 21/05/15 21:23, Daniel P. Berrange wrote: On Wed, May 20, 2015 at 03:01:50PM -0700, Michael Still wrote: I note that we use instance.name to lookup the libvirt domain a bunch in the driver. I'm wondering why we don't just use

Re: [openstack-dev] [Nova][libvirt] Understand why we lookup libvirt domains by instance name

2015-05-21 Thread Sahid Orentino Ferdjaoui
On Thu, May 21, 2015 at 10:23:35AM +0100, Daniel P. Berrange wrote: On Wed, May 20, 2015 at 03:01:50PM -0700, Michael Still wrote: I note that we use instance.name to lookup the libvirt domain a bunch in the driver. I'm wondering why we don't just use instance.uuid all the time -- the code

Re: [openstack-dev] [Nova][libvirt] Understand why we lookup libvirt domains by instance name

2015-05-21 Thread Mathieu Gagné
On 2015-05-21 3:13 AM, Daniel P. Berrange wrote: On Thu, May 21, 2015 at 09:34:20PM +1200, Xav Paice wrote: On 21/05/15 21:23, Daniel P. Berrange wrote: On Wed, May 20, 2015 at 03:01:50PM -0700, Michael Still wrote: I note that we use instance.name to lookup the libvirt domain a bunch in the

Re: [openstack-dev] [Nova][libvirt] Understand why we lookup libvirt domains by instance name

2015-05-21 Thread Chris Friesen
On 05/21/2015 03:20 PM, Mathieu Gagné wrote: On 2015-05-21 3:13 AM, Daniel P. Berrange wrote: On Thu, May 21, 2015 at 09:34:20PM +1200, Xav Paice wrote: On 21/05/15 21:23, Daniel P. Berrange wrote: On Wed, May 20, 2015 at 03:01:50PM -0700, Michael Still wrote: I note that we use

Re: [openstack-dev] [Nova][libvirt] Understand why we lookup libvirt domains by instance name

2015-05-21 Thread Mathieu Gagné
On 2015-05-21 3:38 PM, Chris Friesen wrote: On 05/21/2015 03:20 PM, Mathieu Gagné wrote: On 2015-05-21 3:13 AM, Daniel P. Berrange wrote: On Thu, May 21, 2015 at 09:34:20PM +1200, Xav Paice wrote: On 21/05/15 21:23, Daniel P. Berrange wrote: On Wed, May 20, 2015 at 03:01:50PM -0700, Michael

Re: [openstack-dev] [Nova][libvirt] Understand why we lookup libvirt domains by instance name

2015-05-21 Thread Fox, Kevin M
] Understand why we lookup libvirt domains by instance name On 05/21/2015 03:42 PM, Mathieu Gagné wrote: On 2015-05-21 3:38 PM, Chris Friesen wrote: On 05/21/2015 03:20 PM, Mathieu Gagné wrote: On 2015-05-21 3:13 AM, Daniel P. Berrange wrote: You do know you can configure the instance name used

Re: [openstack-dev] [Nova][libvirt] Understand why we lookup libvirt domains by instance name

2015-05-21 Thread Chris Friesen
On 05/21/2015 03:42 PM, Mathieu Gagné wrote: On 2015-05-21 3:38 PM, Chris Friesen wrote: On 05/21/2015 03:20 PM, Mathieu Gagné wrote: On 2015-05-21 3:13 AM, Daniel P. Berrange wrote: You do know you can configure the instance name used... eg in nova.conf

Re: [openstack-dev] [Nova][libvirt] Understand why we lookup libvirt domains by instance name

2015-05-21 Thread Mathieu Gagné
On 2015-05-21 4:18 PM, Chris Friesen wrote: I guess it's for the reason I mentioned above: To not break all OpenStack installations on Earth running with default config values. So that's not breaking *upgrades* of all OpenStack installations with default config values, which is a

Re: [openstack-dev] [Nova][libvirt] Understand why we lookup libvirt domains by instance name

2015-05-21 Thread Deepak Shetty
On Fri, May 22, 2015 at 5:19 AM, Mathieu Gagné mga...@iweb.com wrote: On 2015-05-21 4:18 PM, Chris Friesen wrote: I guess it's for the reason I mentioned above: To not break all OpenStack installations on Earth running with default config values. So that's not breaking

Re: [openstack-dev] [Nova][libvirt] Understand why we lookup libvirt domains by instance name

2015-05-21 Thread Michael Still
On Thu, May 21, 2015 at 7:49 AM, Sahid Orentino Ferdjaoui sahid.ferdja...@redhat.com wrote: On Thu, May 21, 2015 at 10:23:35AM +0100, Daniel P. Berrange wrote: On Wed, May 20, 2015 at 03:01:50PM -0700, Michael Still wrote: I note that we use instance.name to lookup the libvirt domain a bunch

Re: [openstack-dev] [Nova][libvirt] Understand why we lookup libvirt domains by instance name

2015-05-21 Thread Sahid Orentino Ferdjaoui
On Thu, May 21, 2015 at 09:11:57AM -0700, Michael Still wrote: On Thu, May 21, 2015 at 7:49 AM, Sahid Orentino Ferdjaoui sahid.ferdja...@redhat.com wrote: On Thu, May 21, 2015 at 10:23:35AM +0100, Daniel P. Berrange wrote: On Wed, May 20, 2015 at 03:01:50PM -0700, Michael Still wrote: I

[openstack-dev] [Nova][libvirt] Understand why we lookup libvirt domains by instance name

2015-05-20 Thread Michael Still
I note that we use instance.name to lookup the libvirt domain a bunch in the driver. I'm wondering why we don't just use instance.uuid all the time -- the code for that already exists. Is there a good reason to not move to always using the uuid? I ask because instance.name is not guaranteed to be

Re: [openstack-dev] [Nova][libvirt] Understand why we lookup libvirt domains by instance name

2015-05-20 Thread Robert Collins
On 21 May 2015 at 10:01, Michael Still mi...@stillhq.com wrote: I note that we use instance.name to lookup the libvirt domain a bunch in the driver. I'm wondering why we don't just use instance.uuid all the time -- the code for that already exists. Is there a good reason to not move to always