Re: [openstack-dev] [all][clients] Enable hacking in python-*clients

2016-01-25 Thread Kirill Zaitsev
ge questions) > Subject: Re: [openstack-dev] [all][clients] Enable hacking in python-*clients > > On 2016-01-19 10:44, Abhishek Kekane wrote: >>> Hi Abishek, >> >>> In my understanding, hacking check is enabled for most (or all) of >> >>> python-

Re: [openstack-dev] [all][clients] Enable hacking in python-*clients

2016-01-19 Thread Kekane, Abhishek
bhishek.kek...@nttdata.com] Sent: 19 January 2016 10:49 To: OpenStack Development Mailing List (openstack-dev@lists.openstack.org) Subject: [openstack-dev] [all][clients] Enable hacking in python-*clients Hi Devs, As of now all OpenStack projects has hacking checks which take cares about OpenStac

Re: [openstack-dev] [all][clients] Enable hacking in python-*clients

2016-01-19 Thread Andreas Jaeger
On 2016-01-19 10:44, Abhishek Kekane wrote: Hi Abishek, In my understanding, hacking check is enabled for most (or all) of python-*client. For example, flake8 is run for each neutronclient review [1]. test-requirements installs hacking, so I believe hacking check is enabled.

Re: [openstack-dev] [all][clients] Enable hacking in python-*clients

2016-01-19 Thread Kekane, Abhishek
-Original Message- From: Andreas Jaeger [mailto:a...@suse.com] Sent: 19 January 2016 15:19 To: OpenStack Development Mailing List (not for usage questions) Subject: Re: [openstack-dev] [all][clients] Enable hacking in python-*clients On 2016-01-19 10:44, Abhishek Kekane wrote: >&

Re: [openstack-dev] [all][clients] Enable hacking in python-*clients

2016-01-19 Thread Akihiro Motoki
2016-01-19 18:58 GMT+09:00 Kekane, Abhishek <abhishek.kek...@nttdata.com>: > > > -Original Message- > From: Andreas Jaeger [mailto:a...@suse.com] > Sent: 19 January 2016 15:19 > To: OpenStack Development Mailing List (not for usage questions) > Subject: Re: [o

[openstack-dev] [all][clients] Enable hacking in python-*clients

2016-01-18 Thread Kekane, Abhishek
Hi Devs, As of now all OpenStack projects has hacking checks which take cares about OpenStack guidelines issues are caught while running PEP8 checks using tox. There are no such checks in any of the python-*client. IMO its worth to enable hacking checks in python-*clients as well which will

Re: [openstack-dev] [all][clients] Enable hacking in python-*clients

2016-01-18 Thread Akihiro Motoki
Hi Abishek, In my understanding, hacking check is enabled for most (or all) of python-*client. For example, flake8 is run for each neutronclient review [1]. test-requirements installs hacking, so I believe hacking check is enabled. openstackclient and novaclient do the same [2] [3]. Am I missing