Re: [openstack-dev] [diskimage-builder] Tracing levels for scripts (119023)

2014-12-04 Thread Ian Wienand
On 12/04/2014 05:41 AM, Clint Byrum wrote: What if the patch is reworked to leave the current trace-all-the-time mode in place, and we iterate on each script to make tracing conditional as we add proper logging? I have run [1] over patchset 15 to keep whatever was originally using -x tracing it

Re: [openstack-dev] [diskimage-builder] Tracing levels for scripts (119023)

2014-12-03 Thread Chris Jones
Hi > On 3 Dec 2014, at 18:41, Clint Byrum wrote: > > What if the patch is reworked to leave the current trace-all-the-time > mode in place, and we iterate on each script to make tracing conditional > as we add proper logging? +1 Cheers, -- Chris Jones _

Re: [openstack-dev] [diskimage-builder] Tracing levels for scripts (119023)

2014-12-03 Thread Clint Byrum
Excerpts from Chris Jones's message of 2014-12-03 02:47:30 -0800: > Hi > > I am very sympathetic to this view. We have a patch in hand that improves the > situation. We also have disagreement about the ideal situation. > > I +2'd Ian's patch because it makes things work better than they do now.

Re: [openstack-dev] [diskimage-builder] Tracing levels for scripts (119023)

2014-12-03 Thread Chris Jones
Hi I am very sympathetic to this view. We have a patch in hand that improves the situation. We also have disagreement about the ideal situation. I +2'd Ian's patch because it makes things work better than they do now. If we can arrive at an ideal solution later, great, but the more I think abou

Re: [openstack-dev] [diskimage-builder] Tracing levels for scripts (119023)

2014-12-02 Thread Ian Wienand
On 12/03/2014 09:30 AM, Clint Byrum wrote: I for one find the idea of printing every cp, cat, echo and ls command out rather frustratingly verbose when scanning logs from a normal run. I for one find this ongoing discussion over a flag whose own help says "-x -- turn on tracing" not doing the b

Re: [openstack-dev] [diskimage-builder] Tracing levels for scripts (119023)

2014-12-02 Thread Clint Byrum
Excerpts from Ian Wienand's message of 2014-12-02 11:22:31 -0800: > On 12/02/2014 03:46 PM, Clint Byrum wrote: > > 1) Conform all o-r-c scripts to the logging standards we have in > > OpenStack, or write new standards for diskimage-builder and conform > > them to those standards. Abolish non-condit

Re: [openstack-dev] [diskimage-builder] Tracing levels for scripts (119023)

2014-12-02 Thread Ian Wienand
On 12/02/2014 03:46 PM, Clint Byrum wrote: 1) Conform all o-r-c scripts to the logging standards we have in OpenStack, or write new standards for diskimage-builder and conform them to those standards. Abolish non-conditional xtrace in any script conforming to the standards. Honestly in the list

Re: [openstack-dev] [diskimage-builder] Tracing levels for scripts (119023)

2014-12-01 Thread Clint Byrum
gt; To: OpenStack Development Mailing List (not for usage questions) > >> Subject: Re: [openstack-dev] [diskimage-builder] Tracing levels for > >> scripts (119023) > >> > >> On 11/25/2014 10:58 PM, Ian Wienand wrote: > >> > Hi, > >> > >

Re: [openstack-dev] [diskimage-builder] Tracing levels for scripts (119023)

2014-12-01 Thread Steve Kowalik
On 02/12/14 12:27, Ian Wienand wrote: > - pretty sure SHELLOPTS doesn't survive sudo, which might add another > layer of complication for users sudo is well-known to strip out all but a well-defined list of environment variables when you use it. sudo -E turns that off, but the configuration can

Re: [openstack-dev] [diskimage-builder] Tracing levels for scripts (119023)

2014-12-01 Thread Ian Wienand
On 12/02/2014 04:25 AM, Ben Nemec wrote: 1) A specific reason SHELLOPTS can't be used. IMO leave this alone as it changes global behaviour at a low-level and that is a vector for unintended side-effects. Some thoughts: - We don't want tracing output of various well-known scripts that might

Re: [openstack-dev] [diskimage-builder] Tracing levels for scripts (119023)

2014-12-01 Thread Ben Nemec
thing to do. As yet I'm not convinced. -Ben On 11/27/2014 12:29 PM, Sullivan, Jon Paul wrote: >> -Original Message- >> From: Ben Nemec [mailto:openst...@nemebean.com] >> Sent: 26 November 2014 17:03 >> To: OpenStack Development Mailing List (not for usa

Re: [openstack-dev] [diskimage-builder] Tracing levels for scripts (119023)

2014-11-28 Thread James Slagle
nstack-dev] [diskimage-builder] Tracing levels for >> scripts (119023) >> >> On 11/25/2014 10:58 PM, Ian Wienand wrote: >> > Hi, >> > >> > My change [1] to enable a consistent tracing mechanism for the many >> > scripts diskimage-builder runs during

Re: [openstack-dev] [diskimage-builder] Tracing levels for scripts (119023)

2014-11-27 Thread Sullivan, Jon Paul
> -Original Message- > From: Ben Nemec [mailto:openst...@nemebean.com] > Sent: 26 November 2014 17:03 > To: OpenStack Development Mailing List (not for usage questions) > Subject: Re: [openstack-dev] [diskimage-builder] Tracing levels for > scripts (119023) > > On

Re: [openstack-dev] [diskimage-builder] Tracing levels for scripts (119023)

2014-11-26 Thread Ben Nemec
On 11/25/2014 10:58 PM, Ian Wienand wrote: > Hi, > > My change [1] to enable a consistent tracing mechanism for the many > scripts diskimage-builder runs during its build seems to have hit a > stalemate. > > I hope we can agree that the current situation is not good. When > trying to develop wit

[openstack-dev] [diskimage-builder] Tracing levels for scripts (119023)

2014-11-25 Thread Ian Wienand
Hi, My change [1] to enable a consistent tracing mechanism for the many scripts diskimage-builder runs during its build seems to have hit a stalemate. I hope we can agree that the current situation is not good. When trying to develop with diskimage-builder, I find myself constantly going and fi