Re: [openstack-dev] [neutron][neutron-*aas] Is lockutils-wrapper needed for tox.ini commands?

2015-02-17 Thread Paul Michali
Thanks for the insight into lockutils-wrapper usage Ihar. I had worked on getting the coverage target for VPNaaS repo working, and then have been working on a coverage target for functional testing. As part of that, I pulled the use of lockutils-wrapper. If you can review it, I'd appreciate it

Re: [openstack-dev] [neutron][neutron-*aas] Is lockutils-wrapper needed for tox.ini commands?

2015-02-16 Thread Ihar Hrachyshka
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/13/2015 11:13 PM, Paul Michali wrote: I see that in tox.ini, several commands have lockutils-wrapper prefix on them in the neutron-vpnaas repo. Seems like this was added as part of commit 88e2d801 for Migration to oslo.concurrency. Those

Re: [openstack-dev] [neutron][neutron-*aas] Is lockutils-wrapper needed for tox.ini commands?

2015-02-13 Thread Ben Nemec
All it does is create a temporary lock directory and then set an env var to that path so external locks work properly in tests. If you don't have any external locks or you use https://github.com/openstack/oslo.concurrency/blob/master/oslo_concurrency/fixture/lockutils.py#L55 for any tests that do

[openstack-dev] [neutron][neutron-*aas] Is lockutils-wrapper needed for tox.ini commands?

2015-02-13 Thread Paul Michali
I see that in tox.ini, several commands have lockutils-wrapper prefix on them in the neutron-vpnaas repo. Seems like this was added as part of commit 88e2d801 for Migration to oslo.concurrency. Is this needed on the functional, cover, and dsvm-functional targets? I don't see it in the neutron