Excerpts from Robert Collins's message of 2018-02-20 22:58:59 +1300:
> On 20 February 2018 at 04:39, Andrey Kurilin wrote:
> > Can someone explain me the reason for including "tests" module into
> > packages?
>
> Namespacing the tests makes the test ids unique which is very helpful
> for aggregat
On 20 February 2018 at 04:39, Andrey Kurilin wrote:
> Can someone explain me the reason for including "tests" module into
> packages?
Namespacing the tests makes the test ids unique which is very helpful
for aggregating test data as we do. Including that in the tar.gz that
is uploaded to PyPI is
On Mon, Feb 19, 2018 at 10:00:59AM -0500, Michael Bayer wrote:
> Hi list -
>
> Apparently Cinder was misled by my deprecations within the
> oslo_db.sqlalchemy.test_base package of DbFixture and DbTestCase, and
> in https://review.openstack.org/#/c/522290/ the assumption was made
> that these shoul
Summarizing all the reviews:
Doug's proposed check in oslo_db.tests: https://review.openstack.org/#/c/545859/
Mark oslo_db internal fixtures private: https://review.openstack.org/545862
Cinder: https://review.openstack.org/545860
Neutron: https://review.openstack.org/545868
Ironic: https://revie
Excerpts from Michael Bayer's message of 2018-02-19 10:55:52 -0500:
> wow that's heavy-handed. should that be in an oslo utility package of
> some kind ?
I thought about that, but figured we should wait and see whether we
actually want to take the approach before polishing it. If we do we can
add
On Mon, Feb 19, 2018 at 10:57 AM, Andrey Kurilin wrote:
> As for downstream you can do whatever you want, but it looks like this issue
> should be solved in upstream. I mean if "tests" directory is located at the
> top level of the repo, no one will use it.
again, the search at
http://codesearch.
Imo, it creates more problems than profits. If someone wants to change the
code and run tests -> use git repositories. Prepared python package is not
about this.
2018-02-19 17:57 GMT+02:00 Doug Hellmann :
> IIRC we started doing that so that consumers building their own packages
> can run the tes
As for downstream you can do whatever you want, but it looks like this
issue should be solved in upstream. I mean if "tests" directory is located
at the top level of the repo, no one will use it.
Also, setuptools supports `exclude` option which should solve the issue as
well.
2018-02-19 17:41 GM
IIRC we started doing that so that consumers building their own packages
can run the tests for the packages easily. I don't know how many people
are doing that, and apparently at least some downstream consumers aren't
packaging everything anyway so they couldn't run those tests.
Excerpts from Andr
wow that's heavy-handed. should that be in an oslo utility package of
some kind ?
On Mon, Feb 19, 2018 at 10:52 AM, Doug Hellmann wrote:
> Excerpts from Doug Hellmann's message of 2018-02-19 10:15:34 -0500:
>> Excerpts from Michael Bayer's message of 2018-02-19 10:00:59 -0500:
>> > Hi list -
>>
Excerpts from Doug Hellmann's message of 2018-02-19 10:15:34 -0500:
> Excerpts from Michael Bayer's message of 2018-02-19 10:00:59 -0500:
> > Hi list -
> >
> > Apparently Cinder was misled by my deprecations within the
> > oslo_db.sqlalchemy.test_base package of DbFixture and DbTestCase, and
> > i
On Mon, Feb 19, 2018 at 10:39 AM, Andrey Kurilin wrote:
> Can someone explain me the reason for including "tests" module into
> packages?
the "tests" module should not be inside packages. Downstream we have
CI running Cinder's test suite against packaged dependencies, which
fails because we don
On Mon, Feb 19, 2018 at 10:15 AM, Doug Hellmann wrote:
> Excerpts from Michael Bayer's message of 2018-02-19 10:00:59 -0500:
>> Hi list -
>>
>> Apparently Cinder was misled by my deprecations within the
>> oslo_db.sqlalchemy.test_base package of DbFixture and DbTestCase, and
>> in https://review.o
Can someone explain me the reason for including "tests" module into
packages?
2018-02-19 17:00 GMT+02:00 Michael Bayer :
> Hi list -
>
> Apparently Cinder was misled by my deprecations within the
> oslo_db.sqlalchemy.test_base package of DbFixture and DbTestCase, and
> in https://review.openstac
On Mon, Feb 19, 2018 at 04:13:04PM +0100, Andreas Jaeger wrote:
> On 2018-02-19 16:00, Michael Bayer wrote:
> > Hi list -
> >
> > Apparently Cinder was misled by my deprecations within the
> > oslo_db.sqlalchemy.test_base package of DbFixture and DbTestCase, and
> > in https://review.openstack.org
Excerpts from Michael Bayer's message of 2018-02-19 10:00:59 -0500:
> Hi list -
>
> Apparently Cinder was misled by my deprecations within the
> oslo_db.sqlalchemy.test_base package of DbFixture and DbTestCase, and
> in https://review.openstack.org/#/c/522290/ the assumption was made
> that these
On 2018-02-19 16:00, Michael Bayer wrote:
> Hi list -
>
> Apparently Cinder was misled by my deprecations within the
> oslo_db.sqlalchemy.test_base package of DbFixture and DbTestCase, and
> in https://review.openstack.org/#/c/522290/ the assumption was made
> that these should be imported from os
Hi list -
Apparently Cinder was misled by my deprecations within the
oslo_db.sqlalchemy.test_base package of DbFixture and DbTestCase, and
in https://review.openstack.org/#/c/522290/ the assumption was made
that these should be imported from oslo_db.tests.sqlalchemy.This
is an immense mistake
18 matches
Mail list logo
