Re: [openstack-dev] [oslo.db] Proposal: Get rid of deleted column

2013-08-20 Thread Jay Pipes
*sigh* I wish I'd been aware of these conversations and been in the Grizzly summit session on soft delete... What specific unique constraint was needed that changing the deleted column to use the id value solved? -jay On 08/19/2013 03:56 AM, Chris Behrens wrote: 'deleted' is used so that

Re: [openstack-dev] [oslo.db] Proposal: Get rid of deleted column

2013-08-20 Thread Boris Pavlovic
Jay, Don't worry I investigate this question very well. There are actually two approaches: 1) Use deleted_at to create Unique Constraints. But then we are not able to store in deleted_at NONE value, because it won't work e.g. We have table for Users (user_name, deleted_at, deleted), and we

Re: [openstack-dev] [oslo.db] Proposal: Get rid of deleted column

2013-08-20 Thread Ed Leafe
On Aug 20, 2013, at 2:33 PM, Chris Behrens cbehr...@codestud.com wrote: For instances table, we want to make sure 'uuid' is unique. But we can't put a unique constraint on that alone. If that instance gets deleted.. we should be able to create another entry with the same uuid without a

Re: [openstack-dev] [oslo.db] Proposal: Get rid of deleted column

2013-08-20 Thread Jay Pipes
I see the following use case: 1) Create something with a unique name within your tenant 2) Delete that 3) Create something with the same unique name immediately after As a pointless and silly use case that we should not cater to. It's made the database schema needlessly complex IMO and added

Re: [openstack-dev] [oslo.db] Proposal: Get rid of deleted column

2013-08-20 Thread Chris Behrens
On Aug 20, 2013, at 12:51 PM, Ed Leafe e...@openstack.org wrote: On Aug 20, 2013, at 2:33 PM, Chris Behrens cbehr...@codestud.com wrote: For instances table, we want to make sure 'uuid' is unique. But we can't put a unique constraint on that alone. If that instance gets deleted.. we

Re: [openstack-dev] [oslo.db] Proposal: Get rid of deleted column

2013-08-20 Thread Chris Behrens
On Aug 20, 2013, at 1:05 PM, Jay Pipes jaypi...@gmail.com wrote: I see the following use case: 1) Create something with a unique name within your tenant 2) Delete that 3) Create something with the same unique name immediately after As a pointless and silly use case that we should not

Re: [openstack-dev] [oslo.db] Proposal: Get rid of deleted column

2013-08-20 Thread Mike Perez
On Tue, Aug 20, 2013 at 1:59 PM, Jay Pipes jaypi...@gmail.com wrote: We should take a look at look at the various entities in the various database schemata and ask the following questions: 1) Do we care about archival of the entity? 2) Do we care about audit history of changes to the

Re: [openstack-dev] [oslo.db] Proposal: Get rid of deleted column

2013-08-20 Thread Jay Pipes
On 08/20/2013 05:52 PM, Vishvananda Ishaya wrote: On Aug 20, 2013, at 2:44 PM, Mike Perez thin...@gmail.com mailto:thin...@gmail.com wrote: On Tue, Aug 20, 2013 at 1:59 PM, Jay Pipes jaypi...@gmail.com mailto:jaypi...@gmail.com wrote: We should take a look at look at the various

Re: [openstack-dev] [oslo.db] Proposal: Get rid of deleted column

2013-08-20 Thread Jay Pipes
On 08/20/2013 05:52 PM, Vishvananda Ishaya wrote: On Aug 20, 2013, at 2:44 PM, Mike Perez thin...@gmail.com mailto:thin...@gmail.com wrote: On Tue, Aug 20, 2013 at 1:59 PM, Jay Pipes jaypi...@gmail.com mailto:jaypi...@gmail.com wrote: We should take a look at look at the various

Re: [openstack-dev] [oslo.db] Proposal: Get rid of deleted column

2013-08-20 Thread Vishvananda Ishaya
On Aug 20, 2013, at 3:16 PM, Jay Pipes jaypi...@gmail.com wrote: On 08/20/2013 05:52 PM, Vishvananda Ishaya wrote: On Aug 20, 2013, at 2:44 PM, Mike Perez thin...@gmail.com mailto:thin...@gmail.com wrote: On Tue, Aug 20, 2013 at 1:59 PM, Jay Pipes jaypi...@gmail.com

Re: [openstack-dev] [oslo.db] Proposal: Get rid of deleted column

2013-08-20 Thread Mike Perez
On Tue, Aug 20, 2013 at 2:52 PM, Vishvananda Ishaya vishvana...@gmail.comwrote: On Aug 20, 2013, at 2:44 PM, Mike Perez thin...@gmail.com wrote: For #1 and #2, really this sounds like another thing doing this along with Ceilometer. I would really like to leave this in Ceilometer and not have

Re: [openstack-dev] [oslo.db] Proposal: Get rid of deleted column

2013-08-20 Thread Chris Behrens
On Aug 20, 2013, at 3:29 PM, Vishvananda Ishaya vishvana...@gmail.com wrote: c) is going ot take a while. There are still quite a few places in nova, for example, that depend on accessing deleted records. Do you have a list of these places? No. I believe Joe Gordon did an initial look

Re: [openstack-dev] [oslo.db] Proposal: Get rid of deleted column

2013-08-20 Thread Vishvananda Ishaya
On Aug 20, 2013, at 4:15 PM, Mike Perez thin...@gmail.com wrote: On Tue, Aug 20, 2013 at 2:52 PM, Vishvananda Ishaya vishvana...@gmail.com wrote: On Aug 20, 2013, at 2:44 PM, Mike Perez thin...@gmail.com wrote: For #1 and #2, really this sounds like another thing doing this along with

[openstack-dev] [oslo.db] Proposal: Get rid of deleted column

2013-08-19 Thread Jay Pipes
I'm throwing this up here to get some feedback on something that's always bugged me about the model base used in many of the projects. There's a mixin class that looks like so: class SoftDeleteMixin(object): deleted_at = Column(DateTime) deleted = Column(Integer, default=0) def

Re: [openstack-dev] [oslo.db] Proposal: Get rid of deleted column

2013-08-19 Thread Boris Pavlovic
Hi Jay, When I started working around unique keys, I tried to use deleted_at column. so answer about why we don't use deleted_at column you could read in Devananda's comment on my patch https://review.openstack.org/#/c/16162/ . Also I should mention that this is really huge change and it will