Re: [openstack-dev] Usage of mox through out the Openstack project.

2013-08-03 Thread Alessandro Pilotti
Based on an intial run of the Hyper-V Nova tests with pymox (https://github.com/emonty/pymox), only 2 of the tests required some minor adjustements while the rest was running perfectly fine by just replacing the mox import line. If we plan to support pymox in Havana, I'd be happy to send a patc

Re: [openstack-dev] Usage of mox through out the Openstack project.

2013-07-26 Thread Joe Gordon
On Jul 26, 2013 5:53 AM, "Russell Bryant" wrote: > > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 07/26/2013 05:35 AM, Roman Bogorodskiy wrote: > > Alex Meade wrote: > > > >> +1 to everything Russell just said and of course Blueprints for > >> this. One for #3 (changing from mox -> Mock)

Re: [openstack-dev] Usage of mox through out the Openstack project.

2013-07-26 Thread Russell Bryant
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/26/2013 05:35 AM, Roman Bogorodskiy wrote: > Alex Meade wrote: > >> +1 to everything Russell just said and of course Blueprints for >> this. One for #3 (changing from mox -> Mock) would be good so >> that anyone who is bored or finds this urgent

Re: [openstack-dev] Usage of mox through out the Openstack project.

2013-07-26 Thread Roman Bogorodskiy
July 24, 2013 2:45pm > To: openstack-dev@lists.openstack.org > Subject: Re: [openstack-dev] Usage of mox through out the Openstack project. > > On 07/24/2013 02:32 PM, Kevin L. Mitchell wrote: > > On Wed, 2013-07-24 at 14:12 -0400, Chuck Short wrote: > >> 1. Change mox usage t

Re: [openstack-dev] Usage of mox through out the Openstack project.

2013-07-25 Thread Julien Danjou
On Thu, Jul 25 2013, Mark McClain wrote: > The Neutron project has been enforcing this approach for about a year now. > We're down to 8 files that still rely on Mox. Awesome, we'll have to bring Python 3 badges at the next summit for Neutron devs. ;) -- Julien Danjou /* Free Software hacker * f

Re: [openstack-dev] Usage of mox through out the Openstack project.

2013-07-25 Thread Mark McClain
On Jul 25, 2013, at 4:01 AM, Julien Danjou wrote: > On Wed, Jul 24 2013, Russell Bryant wrote: > >> A practical approach would probably be: >> >> 1) Prefer mock for new tests. >> >> 2) Use suggestion #2 above to mitigate the Python 3 concern. >> >> 3) Convert tests to mock over time, opportu

Re: [openstack-dev] Usage of mox through out the Openstack project.

2013-07-25 Thread Julien Danjou
On Wed, Jul 24 2013, Russell Bryant wrote: > A practical approach would probably be: > > 1) Prefer mock for new tests. > > 2) Use suggestion #2 above to mitigate the Python 3 concern. > > 3) Convert tests to mock over time, opportunistically, as tests are > being updated anyway. (Or if someone *r

Re: [openstack-dev] Usage of mox through out the Openstack project.

2013-07-24 Thread Anita Kuno
We had this discussion in Ironic a while back, and part of the use of mox going forward was familiarity amongst most of the coders currently submitting patches thus enhancing speed of development, a situation that falls under your observations, Chuck. Would it be possible to create a wiki page

Re: [openstack-dev] Usage of mox through out the Openstack project.

2013-07-24 Thread Alex Meade
nal Message- From: "Russell Bryant" Sent: Wednesday, July 24, 2013 2:45pm To: openstack-dev@lists.openstack.org Subject: Re: [openstack-dev] Usage of mox through out the Openstack project. On 07/24/2013 02:32 PM, Kevin L. Mitchell wrote: > On Wed, 2013-07-24 at 14:12 -0400, Chuck S

Re: [openstack-dev] Usage of mox through out the Openstack project.

2013-07-24 Thread Russell Bryant
On 07/24/2013 02:32 PM, Kevin L. Mitchell wrote: > On Wed, 2013-07-24 at 14:12 -0400, Chuck Short wrote: >> 1. Change mox usage to more python3 friendly such as mock. >> (https://pypi.python.org/pypi/mock/1.0.1). However this will cause >> alot of code churn in the projects as we move away from mox

Re: [openstack-dev] Usage of mox through out the Openstack project.

2013-07-24 Thread Brian Curtin
On Jul 24, 2013, at 1:12 PM, Chuck Short mailto:chuck.sh...@canonical.com>> wrote: Hi, The use of mox (https://pypi.python.org/pypi/mox/0.5.3) across the test suites in the Openstack project is quite extensive. This is probably due to the fact that it is the most familiar mocking object fram

Re: [openstack-dev] Usage of mox through out the Openstack project.

2013-07-24 Thread Alex Meade
bject: Re: [openstack-dev] Usage of mox through out the Openstack project. On 07/24/2013 02:19 PM, Alex Gaynor wrote: > I think moving towards mock is a better long term strategy: > > a) I don't you're correct that it's the most familiar for most python > developers. By Py

Re: [openstack-dev] Usage of mox through out the Openstack project.

2013-07-24 Thread Kevin L. Mitchell
On Wed, 2013-07-24 at 14:12 -0400, Chuck Short wrote: > 1. Change mox usage to more python3 friendly such as mock. > (https://pypi.python.org/pypi/mock/1.0.1). However this will cause > alot of code churn in the projects as we move away from mox to mock. > > > 2. Use the python3 fork called pymox

Re: [openstack-dev] Usage of mox through out the Openstack project.

2013-07-24 Thread Jay Pipes
On 07/24/2013 02:19 PM, Alex Gaynor wrote: I think moving towards mock is a better long term strategy: a) I don't you're correct that it's the most familiar for most python developers. By PyPi installs (A TERRIBLE METRIC, but it's all we have). Mock has 24k in the last week, mox has 3.5k b) mock

Re: [openstack-dev] Usage of mox through out the Openstack project.

2013-07-24 Thread Alex Gaynor
I think moving towards mock is a better long term strategy: a) I don't you're correct that it's the most familiar for most python developers. By PyPi installs (A TERRIBLE METRIC, but it's all we have). Mock has 24k in the last week, mox has 3.5k b) mock is a part of the standard library starting w