Re: [openstack-dev] [nova] NUMA Cells
On 12/04/2014 04:46 AM, Daniel P. Berrange wrote: On Thu, Dec 04, 2014 at 09:25:00AM +0100, Nikola Đipanov wrote: On 12/04/2014 05:30 AM, Michael Still wrote: Hi, so just having read a bunch of the libvirt driver numa code, I have a concern. At first I thought it was a little thing, but I am starting to think its more of a big deal... We use the term cells to describe numa cells. However, that term has a specific meaning in nova, and I worry that overloading the term is confusing. (Yes, I know the numa people had it first, but hey). So, what do people think about trying to move the numa code to use something like numa cell or numacell based on context? Seeing that node is also not exactly unambiguous in this space - I am fine with both with either numanode or numacell with a slight preference for numacell. A small issue will be renaming it in objects though - as this will require adding a new field for use in Kilo while still remaining backwards compatible with Juno, resulting in even more compatibility code (we already added some for the slightly different data format). The whole name is quite in context there, but we would use it like: for cell in numa_topology.cells: # awesome algo here with cell :( but if we were to rename it just in places where it's used to: for numacell in numa_topology.cells: # awesome algo here with numacell :) I think renaming local variables like this is really a solution in search of a problem. It is pretty blindingly obvious the 'cell' variable refers to a NUMA cell here, without having to spell it out as 'numacell'. Likewise I think the object property name is just fine as 'cell' because the context again makes it obvious what it is referring to +1 I don't think this is a problem in the current code. -jay ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Nova] Spring cleaning nova-core
On 12/04/2014 04:05 PM, Michael Still wrote: One of the things that happens over time is that some of our core reviewers move on to other projects. This is a normal and healthy thing, especially as nova continues to spin out projects into other parts of OpenStack. However, it is important that our core reviewers be active, as it keeps them up to date with the current ways we approach development in Nova. I am therefore removing some no longer sufficiently active cores from the nova-core group. I’d like to thank the following people for their contributions over the years: * cbehrens: Chris Behrens * vishvananda: Vishvananda Ishaya * dan-prince: Dan Prince * belliott: Brian Elliott * p-draigbrady: Padraig Brady +1 on Chris, Dan, Vish and Brian, who I believe have all moved on to new adventures. -1 on pixelbeat, since he's been active in reviews on various things AFAICT in the last 60-90 days and seems to be still a considerate reviewer in various areas. Best, -jay ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] [stable] Re: Stable check of openstack/cinder failed
2014-12-06 7:14 GMT+01:00 A mailing list for the OpenStack Stable Branch test reports. openstack-stable-ma...@lists.openstack.org: Build failed. - periodic-cinder-python26-icehouse http://logs.openstack.org/periodic-stable/periodic-cinder-python26-icehouse/d19db38 : FAILURE in 6m 50s - periodic-cinder-python27-icehouse http://logs.openstack.org/periodic-stable/periodic-cinder-python27-icehouse/eeb5864 : FAILURE in 5m 48s Fixed by https://review.openstack.org/139791 - please review/approve. Cheers, Alan ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] [qa] How to delete a VM which is in ERROR state?
Hi, I have a VM which is in ERROR state. +--+--+++-++ | ID | Name | Status | Task State | Power State | Networks | +--+--+++-++ | 1cb5bf96-619c-4174-baae-dd0d8c3d40c5 | cirros--1cb5bf96-619c-4174-baae-dd0d8c3d40c5 | ERROR | - | NOSTATE || I tried in both CLI “nova delete” and Horizon “terminate instance”. Both accepted the delete command without any error. However, the VM never got deleted. Is there a way to remove the VM? Thanks, Danny ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [qa] How to delete a VM which is in ERROR state?
Try nova reset-state --active uuid. On Saturday, December 6, 2014, Danny Choi (dannchoi) dannc...@cisco.com wrote: Hi, I have a VM which is in ERROR state. +--+--+++-++ | ID | Name | Status | Task State | Power State | Networks | +--+--+++-++ | 1cb5bf96-619c-4174-baae-dd0d8c3d40c5 | cirros--1cb5bf96-619c-4174-baae-dd0d8c3d40c5 | ERROR | - | NOSTATE || I tried in both CLI “nova delete” and Horizon “terminate instance”. Both accepted the delete command without any error. However, the VM never got deleted. Is there a way to remove the VM? Thanks, Danny ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
