Re: [openstack-dev] [Horizon] Javascript linting and documentation

2016-03-19 Thread Richard Jones
On 11 March 2016 at 04:37, Michael Krotscheck wrote: > On Wed, Mar 9, 2016 at 12:45 PM Tripp, Travis S > wrote: > >> The problem is that the warnings are so great that is really hard to read. >> > > If all the warnings were fixed - I know Matt

Re: [openstack-dev] [Horizon] Javascript linting and documentation

2016-03-10 Thread Michael Krotscheck
On Wed, Mar 9, 2016 at 4:15 PM Richard Jones wrote: > > We already have a "lintq" npm task that does this, which most of us use. > The problem is that we then ignore all the legitimate code linting warnings. > I think we both agree that some form of jsdoc linting is

Re: [openstack-dev] [Horizon] Javascript linting and documentation

2016-03-10 Thread Michael Krotscheck
On Wed, Mar 9, 2016 at 12:45 PM Tripp, Travis S wrote: > The problem is that the warnings are so great that is really hard to read. > If all the warnings were fixed - I know Matt Borland's working on that - would we be having this conversation? Michael

Re: [openstack-dev] [Horizon] Javascript linting and documentation

2016-03-09 Thread Richard Jones
On 10 March 2016 at 06:49, Michael Krotscheck wrote: > I guess I don't see what problems is being solved by turning the rule off, > and I also don't see the harm in having more check. It does generate a lot > of warnings, but invoking `npm run lint -- --quiet` gets rid of

Re: [openstack-dev] [Horizon] Javascript linting and documentation

2016-03-09 Thread Tripp, Travis S
>> Date: Wednesday, March 9, 2016 at 12:49 PM To: OpenStack List <openstack-dev@lists.openstack.org<mailto:openstack-dev@lists.openstack.org>> Subject: Re: [openstack-dev] [Horizon] Javascript linting and documentation +1 to what Rob said. I guess I don't see what problems is

Re: [openstack-dev] [Horizon] Javascript linting and documentation

2016-03-09 Thread Michael Krotscheck
+1 to what Rob said. I guess I don't see what problems is being solved by turning the rule off, and I also don't see the harm in having more check. It does generate a lot of warnings, but invoking `npm run lint -- --quiet` gets rid of those. Also, from my experience, sphinx-based doc builds are

Re: [openstack-dev] [Horizon] Javascript linting and documentation

2016-03-09 Thread Rob Cresswell (rcresswe)
If possible, I’d really prefer we left linting work to Newton. It’ll be good to get it to a more usable state again, but we ought to be focusing on thoroughly checking the new Launch Instance for bugs and edge usage cases, as well as the outstanding bugs and blueprints targeted at RC1