Re: [openstack-dev] [Neutron] Call for review focus

[Carl Baldwin]

On Mon, Dec 14, 2015 at 12:41 PM, Rossella Sblendido
 wrote:
> On 11/25/2015 11:05 PM, Assaf Muller wrote:
>> We could then consider running the script automatically on a daily
>> basis and publishing the
>> resulting URL in a nice bookmarkable place.
>
> An update on this. The easiest bookmarkable place that I found it's my blog
> [1]. I have a script that updates the url every day, I can do that more
> often. I'd love to have the url on the wiki but I think it requires to
> create a patch every day and approve it...not nice at all. Any suggestion?
>
> [1] http://rossella-sblendido.net/2015/12/14/gerrit-url-neutron-reviews/

I bet we could find a permanent url to give us a nice "307 Temporary
Redirect" so that we could bookmark the page and still have the URL
updated daily from the script.  With such a redirect, the bookmark
should always go to the fresh dashboard through it.  I wonder if infra
has any ideas on where this could be hosted.

Carl

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [Neutron] Call for review focus

[Rossella Sblendido]

On 11/25/2015 11:05 PM, Assaf Muller wrote:

We could then consider running the script automatically on a daily
basis and publishing the
resulting URL in a nice bookmarkable place.


An update on this. The easiest bookmarkable place that I found it's my 
blog [1]. I have a script that updates the url every day, I can do that 
more often. I'd love to have the url on the wiki but I think it requires 
to create a patch every day and approve it...not nice at all. Any 
suggestion?


cheers,

Rossella

[1] http://rossella-sblendido.net/2015/12/14/gerrit-url-neutron-reviews/

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [Neutron] Call for review focus

[Carl Baldwin]

++

On Wed, Nov 25, 2015 at 3:05 PM, Assaf Muller  wrote:
> On Mon, Nov 23, 2015 at 7:02 AM, Rossella Sblendido  
> wrote:
>>
>>
>> On 11/20/2015 03:54 AM, Armando M. wrote:
>>>
>>>
>>>
>>> On 19 November 2015 at 18:26, Assaf Muller >> > wrote:
>>>
>>> On Wed, Nov 18, 2015 at 9:14 PM, Armando M. >> > wrote:
>>> > Hi Neutrites,
>>> >
>>> > We are nearly two weeks away from the end of Mitaka 1.
>>> >
>>> > I am writing this email to invite you to be mindful to what you
>>> review,
>>> > especially in the next couple of weeks. Whenever you have the time
>>> to review
>>> > code, please consider giving priority to the following:
>>> >
>>> > Patches that target blueprints targeted for Mitaka;
>>> > Patches that target bugs that are either critical or high;
>>> > Patches that target rfe-approved 'bugs';
>>> > Patches that target specs that have followed the most current
>>> submission
>>> > process;
>>>
>>> Is it possible to create Gerrit dashboards for patches that answer
>>> these
>>> criteria, and then persist the links in Neutron's dashboards devref
>>> page?
>>> http://docs.openstack.org/developer/neutron/dashboards/index.html
>>> That'd be super useful.
>>>
>>>
>>> We should look into that, but to be perfectly honest I am not sure how
>>> easy it would be, since we'd need to cross-reference content that lives
>>> into gerrit as well as launchpad. Would that even be possible?
>>
>>
>> To cross-reference we can use the bug ID or the blueprint name.
>>
>> I created a script that queries launchpad to get:
>> 1) Bug number of the bugs tagged with approved-rfe
>> 2) Bug number of the critical/high bugs
>> 3) list of blueprints targeted for the current milestone (mitaka-1)
>>
>> With this info the script builds a .dash file that can be used by
>> gerrit-dash-creator [2] to produce a dashboard url .
>>
>> The script prints also the queries that can be used in gerrit UI directly,
>> e.g.:
>> Critical/High Bugs
>> (topic:bug/1399249 OR topic:bug/1399280 OR topic:bug/1443421 OR
>> topic:bug/1453350 OR topic:bug/1462154 OR topic:bug/1478100 OR
>> topic:bug/1490051 OR topic:bug/1491131 OR topic:bug/1498790 OR
>> topic:bug/1505575 OR topic:bug/1505843 OR topic:bug/1513678 OR
>> topic:bug/1513765 OR topic:bug/1514810)
>>
>>
>> This is the dashboard I get right now [3]
>>
>> I tried in many ways to get Gerrit to filter patches if the commit message
>> contains a bug ID. Something like:
>>
>> (message:"#1399249" OR message:"#1399280" OR message:"#1443421" OR
>> message:"#1453350" OR message:"#1462154" OR message:"#1478100" OR
>> message:"#1490051" OR message:"#1491131" OR message:"#1498790" OR
>> message:"#1505575" OR message:"#1505843" OR message:"#1513678" OR
>> message:"#1513765" OR message:"#1514810")
>>
>> but it doesn't work well, the result of the filter contains patches that
>> have nothing to do with the bugs queried.
>> That's why I had to filter using the topic.
>>
>> CAVEAT: To make the dashboard work, bug fixes must use the topic "bug/ID"
>> and patches implementing a blueprint the topic "bp/name". If a patch is not
>> following this convention it won't be showed in the dashboard, since the
>> topic is used as filter. Most of us use this convention already anyway so I
>> hope it's not too much of a burden.
>>
>> Feedback is appreciated :)
>
> Rossella this is exactly what I wanted :) Let's iterate on the patch
> and merge it.
> We could then consider running the script automatically on a daily
> basis and publishing the
> resulting URL in a nice bookmarkable place.
>
>>
>> [1] https://review.openstack.org/248645
>> [2] https://github.com/openstack/gerrit-dash-creator
>> [3] https://goo.gl/sglSbp
>>
>>>
>>> Btw, I was looking at the current blueprint assignments [1] for Mitaka:
>>> there are some blueprints that still need assignee, approver and
>>> drafter; we should close the gap. If there are volunteers, please reach
>>> out to me.
>>>
>>> Thanks,
>>> Armando
>>>
>>> [1] https://blueprints.launchpad.net/neutron/mitaka/+assignments
>>>
>>>
>>> >
>>> > Everything else should come later, no matter how easy or interesting
>>> it is
>>> > to review; remember that as a community we have the collective duty
>>> to work
>>> > towards a common (set of) target(s), as being planned in
>>> collaboration with
>>> > the Neutron Drivers team and the larger core team.
>>> >
>>> > I would invite submitters to ensure that the Launchpad resources
>>> > (blueprints, and bug report) capture the most updated view in terms
>>> of
>>> > patches etc. Work with your approver to help him/her be focussed
>>> where it
>>> > matters most.
>>> >
>>> > Finally, we had plenty of discussions at the design summit, and some
>>> of
>>> > those discussions will have to be followed 

Re: [openstack-dev] [Neutron] Call for review focus

[Carl Baldwin]

On Tue, Nov 24, 2015 at 4:47 AM, Rossella Sblendido  wrote:
>> I looked for the address scopes blueprint [1] which is targeted for
>> Mitaka-1 [2] and there are 6 (or 5, one is in the gate) patches on the
>> bp/address-scopes topic [3].  It isn't obvious to me yet why it didn't
>> get picked up on the dashboard.  I've only started to look in to this
>> and may not have much time right now.  I wondered if you could easily
>> tell why it didn't get picked up.
>>
>> Isn't it missing bp/ ? From the URL I can only see topic:address-scope,
>> which isn't the right one.
>
>
> Yes Armando is right. I fixed that. Another reason is that I am filtering
> out patches that are WIP or that failed Jenkins tests. This can be changed
> anyway. This is what I get now (after fixing the missing 'bp/') [1]

I tend to think that eliminating patches that are failing tests may
not be a good thing to do in general.  I think it makes the dashboard
too dynamic in the face of all of the unreliable tests that we see
come and go.  It would go dark when we see those check queue bombs
that fail all of the patches.  This is just my opinion and I could
probably adjust the end result to suit my tastes.

I do filter patch sets with failing tests in some of my own personal queries.

Carl

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [Neutron] Call for review focus

[Miguel Angel Ajo]

Assaf Muller wrote:

On Mon, Nov 23, 2015 at 7:02 AM, Rossella Sblendido  wrote:

On 11/20/2015 03:54 AM, Armando M. wrote:


On 19 November 2015 at 18:26, Assaf Muller>  wrote:

 On Wed, Nov 18, 2015 at 9:14 PM, Armando M.>  wrote:
 >  Hi Neutrites,
 >
 >  We are nearly two weeks away from the end of Mitaka 1.
 >
 >  I am writing this email to invite you to be mindful to what you
review,
 >  especially in the next couple of weeks. Whenever you have the time
to review
 >  code, please consider giving priority to the following:
 >
 >  Patches that target blueprints targeted for Mitaka;
 >  Patches that target bugs that are either critical or high;
 >  Patches that target rfe-approved 'bugs';
 >  Patches that target specs that have followed the most current
submission
 >  process;

 Is it possible to create Gerrit dashboards for patches that answer
these
 criteria, and then persist the links in Neutron's dashboards devref
 page?
 http://docs.openstack.org/developer/neutron/dashboards/index.html
 That'd be super useful.


We should look into that, but to be perfectly honest I am not sure how
easy it would be, since we'd need to cross-reference content that lives
into gerrit as well as launchpad. Would that even be possible?

To cross-reference we can use the bug ID or the blueprint name.

I created a script that queries launchpad to get:
1) Bug number of the bugs tagged with approved-rfe
2) Bug number of the critical/high bugs
3) list of blueprints targeted for the current milestone (mitaka-1)

With this info the script builds a .dash file that can be used by
gerrit-dash-creator [2] to produce a dashboard url .

The script prints also the queries that can be used in gerrit UI directly,
e.g.:
Critical/High Bugs
(topic:bug/1399249 OR topic:bug/1399280 OR topic:bug/1443421 OR
topic:bug/1453350 OR topic:bug/1462154 OR topic:bug/1478100 OR
topic:bug/1490051 OR topic:bug/1491131 OR topic:bug/1498790 OR
topic:bug/1505575 OR topic:bug/1505843 OR topic:bug/1513678 OR
topic:bug/1513765 OR topic:bug/1514810)


This is the dashboard I get right now [3]

I tried in many ways to get Gerrit to filter patches if the commit message
contains a bug ID. Something like:

(message:"#1399249" OR message:"#1399280" OR message:"#1443421" OR
message:"#1453350" OR message:"#1462154" OR message:"#1478100" OR
message:"#1490051" OR message:"#1491131" OR message:"#1498790" OR
message:"#1505575" OR message:"#1505843" OR message:"#1513678" OR
message:"#1513765" OR message:"#1514810")

but it doesn't work well, the result of the filter contains patches that
have nothing to do with the bugs queried.
That's why I had to filter using the topic.

CAVEAT: To make the dashboard work, bug fixes must use the topic "bug/ID"
and patches implementing a blueprint the topic "bp/name". If a patch is not
following this convention it won't be showed in the dashboard, since the
topic is used as filter. Most of us use this convention already anyway so I
hope it's not too much of a burden.

Feedback is appreciated :)


Rossella this is exactly what I wanted :) Let's iterate on the patch
and merge it.
We could then consider running the script automatically on a daily
basis and publishing the resulting URL in a nice bookmarkable place.


Just the thought I had. The dashboard generator is being very helpful to 
me :), but it's

something that could be automated.




[1] https://review.openstack.org/248645
[2] https://github.com/openstack/gerrit-dash-creator
[3] https://goo.gl/sglSbp


Btw, I was looking at the current blueprint assignments [1] for Mitaka:
there are some blueprints that still need assignee, approver and
drafter; we should close the gap. If there are volunteers, please reach
out to me.

Thanks,
Armando

[1] https://blueprints.launchpad.net/neutron/mitaka/+assignments


 >
 >  Everything else should come later, no matter how easy or interesting
it is
 >  to review; remember that as a community we have the collective duty
to work
 >  towards a common (set of) target(s), as being planned in
collaboration with
 >  the Neutron Drivers team and the larger core team.
 >
 >  I would invite submitters to ensure that the Launchpad resources
 >  (blueprints, and bug report) capture the most updated view in terms
of
 >  patches etc. Work with your approver to help him/her be focussed
where it
 >  matters most.
 >
 >  Finally, we had plenty of discussions at the design summit, and some
of
 >  those discussions will have to be followed up with actions (aka code
in
 >  OpenStack lingo). Even though, we no longer have deadlines for
feature
 >  submission, I strongly advise you not to leave it last minute. We
can only
 >  handle so much work for any given release, and past experience tells
us that
 >  we 

Re: [openstack-dev] [Neutron] Call for review focus

[Armando M.]

On 25 November 2015 at 03:09, Rossella Sblendido 
wrote:

>
>
> On 11/24/2015 06:53 PM, Armando M. wrote:
>
>>
>>
>> On 24 November 2015 at 04:13, Rossella Sblendido > > wrote:
>>
>>
>>
>> On 11/23/2015 06:38 PM, Armando M. wrote:
>>
>>
>>
>> On 23 November 2015 at 04:02, Rossella Sblendido
>> 
>> >> wrote:
>>
>>
>>
>>  On 11/20/2015 03:54 AM, Armando M. wrote:
>>
>>
>>
>>  On 19 November 2015 at 18:26, Assaf Muller
>> 
>>  >
>>  
>> >
>>   On Wed, Nov 18, 2015 at 9:14 PM, Armando M.
>>  
>> >
>>   >  > >   > Hi Neutrites,
>>   >
>>   > We are nearly two weeks away from the end of
>> Mitaka 1.
>>   >
>>   > I am writing this email to invite you to be
>> mindful to
>>  what you review,
>>   > especially in the next couple of weeks. Whenever
>> you have
>>  the time to review
>>   > code, please consider giving priority to the
>> following:
>>   >
>>   > Patches that target blueprints targeted for
>> Mitaka;
>>   > Patches that target bugs that are either
>> critical or high;
>>   > Patches that target rfe-approved 'bugs';
>>   > Patches that target specs that have followed the
>> most
>>  current submission
>>   > process;
>>
>>   Is it possible to create Gerrit dashboards for
>> patches that
>>  answer these
>>   criteria, and then persist the links in Neutron's
>>  dashboards devref
>>   page?
>> http://docs.openstack.org/developer/neutron/dashboards/index.html
>>   That'd be super useful.
>>
>>
>>  We should look into that, but to be perfectly honest I
>> am not
>>  sure how
>>  easy it would be, since we'd need to cross-reference
>> content
>>  that lives
>>  into gerrit as well as launchpad. Would that even be
>> possible?
>>
>>
>>  To cross-reference we can use the bug ID or the blueprint
>> name.
>>
>>  I created a script that queries launchpad to get:
>>  1) Bug number of the bugs tagged with approved-rfe
>>  2) Bug number of the critical/high bugs
>>  3) list of blueprints targeted for the current milestone
>> (mitaka-1)
>>
>>  With this info the script builds a .dash file that can be
>> used by
>>  gerrit-dash-creator [2] to produce a dashboard url .
>>
>>  The script prints also the queries that can be used in
>> gerrit UI
>>  directly, e.g.:
>>  Critical/High Bugs
>>  (topic:bug/1399249 OR topic:bug/1399280 OR topic:bug/1443421
>> OR
>>  topic:bug/1453350 OR topic:bug/1462154 OR topic:bug/1478100
>> OR
>>  topic:bug/1490051 OR topic:bug/1491131 OR topic:bug/1498790
>> OR
>>  topic:bug/1505575 OR topic:bug/1505843 OR topic:bug/1513678
>> OR
>>  topic:bug/1513765 OR topic:bug/1514810)
>>
>>
>>  This is the dashboard I get right now [3]
>>
>>  I tried in many ways to get Gerrit to filter patches if the
>> commit
>>  message contains a bug ID. Something like:
>>
>>  (message:"#1399249" OR message:"#1399280" OR
>> message:"#1443421" OR
>>  message:"#1453350" OR message:"#1462154" OR
>> message:"#1478100" OR
>>  message:"#1490051" OR message:"#1491131" OR
>> message:"#1498790" OR
>>  message:"#1505575" OR message:"#1505843" OR
>> message:"#1513678" OR
>>  message:"#1513765" OR message:"#1514810")
>>
>>  but it doesn't work well, the result of the filter contains
>> patches
>>  that have nothing to do with the bugs queried.
>>
>>
>> Try to drop the # and quote the bug 

Re: [openstack-dev] [Neutron] Call for review focus

[Assaf Muller]

On Mon, Nov 23, 2015 at 7:02 AM, Rossella Sblendido  wrote:
>
>
> On 11/20/2015 03:54 AM, Armando M. wrote:
>>
>>
>>
>> On 19 November 2015 at 18:26, Assaf Muller > > wrote:
>>
>> On Wed, Nov 18, 2015 at 9:14 PM, Armando M. > > wrote:
>> > Hi Neutrites,
>> >
>> > We are nearly two weeks away from the end of Mitaka 1.
>> >
>> > I am writing this email to invite you to be mindful to what you
>> review,
>> > especially in the next couple of weeks. Whenever you have the time
>> to review
>> > code, please consider giving priority to the following:
>> >
>> > Patches that target blueprints targeted for Mitaka;
>> > Patches that target bugs that are either critical or high;
>> > Patches that target rfe-approved 'bugs';
>> > Patches that target specs that have followed the most current
>> submission
>> > process;
>>
>> Is it possible to create Gerrit dashboards for patches that answer
>> these
>> criteria, and then persist the links in Neutron's dashboards devref
>> page?
>> http://docs.openstack.org/developer/neutron/dashboards/index.html
>> That'd be super useful.
>>
>>
>> We should look into that, but to be perfectly honest I am not sure how
>> easy it would be, since we'd need to cross-reference content that lives
>> into gerrit as well as launchpad. Would that even be possible?
>
>
> To cross-reference we can use the bug ID or the blueprint name.
>
> I created a script that queries launchpad to get:
> 1) Bug number of the bugs tagged with approved-rfe
> 2) Bug number of the critical/high bugs
> 3) list of blueprints targeted for the current milestone (mitaka-1)
>
> With this info the script builds a .dash file that can be used by
> gerrit-dash-creator [2] to produce a dashboard url .
>
> The script prints also the queries that can be used in gerrit UI directly,
> e.g.:
> Critical/High Bugs
> (topic:bug/1399249 OR topic:bug/1399280 OR topic:bug/1443421 OR
> topic:bug/1453350 OR topic:bug/1462154 OR topic:bug/1478100 OR
> topic:bug/1490051 OR topic:bug/1491131 OR topic:bug/1498790 OR
> topic:bug/1505575 OR topic:bug/1505843 OR topic:bug/1513678 OR
> topic:bug/1513765 OR topic:bug/1514810)
>
>
> This is the dashboard I get right now [3]
>
> I tried in many ways to get Gerrit to filter patches if the commit message
> contains a bug ID. Something like:
>
> (message:"#1399249" OR message:"#1399280" OR message:"#1443421" OR
> message:"#1453350" OR message:"#1462154" OR message:"#1478100" OR
> message:"#1490051" OR message:"#1491131" OR message:"#1498790" OR
> message:"#1505575" OR message:"#1505843" OR message:"#1513678" OR
> message:"#1513765" OR message:"#1514810")
>
> but it doesn't work well, the result of the filter contains patches that
> have nothing to do with the bugs queried.
> That's why I had to filter using the topic.
>
> CAVEAT: To make the dashboard work, bug fixes must use the topic "bug/ID"
> and patches implementing a blueprint the topic "bp/name". If a patch is not
> following this convention it won't be showed in the dashboard, since the
> topic is used as filter. Most of us use this convention already anyway so I
> hope it's not too much of a burden.
>
> Feedback is appreciated :)

Rossella this is exactly what I wanted :) Let's iterate on the patch
and merge it.
We could then consider running the script automatically on a daily
basis and publishing the
resulting URL in a nice bookmarkable place.

>
> [1] https://review.openstack.org/248645
> [2] https://github.com/openstack/gerrit-dash-creator
> [3] https://goo.gl/sglSbp
>
>>
>> Btw, I was looking at the current blueprint assignments [1] for Mitaka:
>> there are some blueprints that still need assignee, approver and
>> drafter; we should close the gap. If there are volunteers, please reach
>> out to me.
>>
>> Thanks,
>> Armando
>>
>> [1] https://blueprints.launchpad.net/neutron/mitaka/+assignments
>>
>>
>> >
>> > Everything else should come later, no matter how easy or interesting
>> it is
>> > to review; remember that as a community we have the collective duty
>> to work
>> > towards a common (set of) target(s), as being planned in
>> collaboration with
>> > the Neutron Drivers team and the larger core team.
>> >
>> > I would invite submitters to ensure that the Launchpad resources
>> > (blueprints, and bug report) capture the most updated view in terms
>> of
>> > patches etc. Work with your approver to help him/her be focussed
>> where it
>> > matters most.
>> >
>> > Finally, we had plenty of discussions at the design summit, and some
>> of
>> > those discussions will have to be followed up with actions (aka code
>> in
>> > OpenStack lingo). Even though, we no longer have deadlines for
>> feature
>> > submission, I strongly advise you not to leave it last minute. We
>> can only
>> > 

Re: [openstack-dev] [Neutron] Call for review focus

[Rossella Sblendido]

On 11/24/2015 06:53 PM, Armando M. wrote:



On 24 November 2015 at 04:13, Rossella Sblendido > wrote:



On 11/23/2015 06:38 PM, Armando M. wrote:



On 23 November 2015 at 04:02, Rossella Sblendido

>> wrote:



 On 11/20/2015 03:54 AM, Armando M. wrote:



 On 19 November 2015 at 18:26, Assaf Muller

 >
 

>
    Hi Neutrites,
  >
  > We are nearly two weeks away from the end of
Mitaka 1.
  >
  > I am writing this email to invite you to be
mindful to
 what you review,
  > especially in the next couple of weeks. Whenever
you have
 the time to review
  > code, please consider giving priority to the
following:
  >
  > Patches that target blueprints targeted for Mitaka;
  > Patches that target bugs that are either
critical or high;
  > Patches that target rfe-approved 'bugs';
  > Patches that target specs that have followed the
most
 current submission
  > process;

  Is it possible to create Gerrit dashboards for
patches that
 answer these
  criteria, and then persist the links in Neutron's
 dashboards devref
  page?
http://docs.openstack.org/developer/neutron/dashboards/index.html
  That'd be super useful.


 We should look into that, but to be perfectly honest I
am not
 sure how
 easy it would be, since we'd need to cross-reference
content
 that lives
 into gerrit as well as launchpad. Would that even be
possible?


 To cross-reference we can use the bug ID or the blueprint name.

 I created a script that queries launchpad to get:
 1) Bug number of the bugs tagged with approved-rfe
 2) Bug number of the critical/high bugs
 3) list of blueprints targeted for the current milestone
(mitaka-1)

 With this info the script builds a .dash file that can be
used by
 gerrit-dash-creator [2] to produce a dashboard url .

 The script prints also the queries that can be used in
gerrit UI
 directly, e.g.:
 Critical/High Bugs
 (topic:bug/1399249 OR topic:bug/1399280 OR topic:bug/1443421 OR
 topic:bug/1453350 OR topic:bug/1462154 OR topic:bug/1478100 OR
 topic:bug/1490051 OR topic:bug/1491131 OR topic:bug/1498790 OR
 topic:bug/1505575 OR topic:bug/1505843 OR topic:bug/1513678 OR
 topic:bug/1513765 OR topic:bug/1514810)


 This is the dashboard I get right now [3]

 I tried in many ways to get Gerrit to filter patches if the
commit
 message contains a bug ID. Something like:

 (message:"#1399249" OR message:"#1399280" OR
message:"#1443421" OR
 message:"#1453350" OR message:"#1462154" OR
message:"#1478100" OR
 message:"#1490051" OR message:"#1491131" OR
message:"#1498790" OR
 message:"#1505575" OR message:"#1505843" OR
message:"#1513678" OR
 message:"#1513765" OR message:"#1514810")

 but it doesn't work well, the result of the filter contains
patches
 that have nothing to do with the bugs queried.


Try to drop the # and quote the bug number like this:

message:"'1399280'"

Otherwise I believe gerrit looks for substring matches.


That was my first attempt, it doesn't work unfortunately.


That's weird. It works for me:

https://review.openstack.org/#/q/message:%22'1399280'%22,n,z


With one bug it works but if you have many and you use OR, it doesn't. 
You get spurious stuff. It must be related to how Gerrit implements the 
query for 

Re: [openstack-dev] [Neutron] Call for review focus

[Armando M.]

On 24 November 2015 at 04:13, Rossella Sblendido 
wrote:

>
>
> On 11/23/2015 06:38 PM, Armando M. wrote:
>
>>
>>
>> On 23 November 2015 at 04:02, Rossella Sblendido > > wrote:
>>
>>
>>
>> On 11/20/2015 03:54 AM, Armando M. wrote:
>>
>>
>>
>> On 19 November 2015 at 18:26, Assaf Muller > 
>> >> wrote:
>>
>>  On Wed, Nov 18, 2015 at 9:14 PM, Armando M.
>> 
>>  >>
>> wrote:
>>  > Hi Neutrites,
>>  >
>>  > We are nearly two weeks away from the end of Mitaka 1.
>>  >
>>  > I am writing this email to invite you to be mindful to
>> what you review,
>>  > especially in the next couple of weeks. Whenever you have
>> the time to review
>>  > code, please consider giving priority to the following:
>>  >
>>  > Patches that target blueprints targeted for Mitaka;
>>  > Patches that target bugs that are either critical or high;
>>  > Patches that target rfe-approved 'bugs';
>>  > Patches that target specs that have followed the most
>> current submission
>>  > process;
>>
>>  Is it possible to create Gerrit dashboards for patches that
>> answer these
>>  criteria, and then persist the links in Neutron's
>> dashboards devref
>>  page?
>> http://docs.openstack.org/developer/neutron/dashboards/index.html
>>  That'd be super useful.
>>
>>
>> We should look into that, but to be perfectly honest I am not
>> sure how
>> easy it would be, since we'd need to cross-reference content
>> that lives
>> into gerrit as well as launchpad. Would that even be possible?
>>
>>
>> To cross-reference we can use the bug ID or the blueprint name.
>>
>> I created a script that queries launchpad to get:
>> 1) Bug number of the bugs tagged with approved-rfe
>> 2) Bug number of the critical/high bugs
>> 3) list of blueprints targeted for the current milestone (mitaka-1)
>>
>> With this info the script builds a .dash file that can be used by
>> gerrit-dash-creator [2] to produce a dashboard url .
>>
>> The script prints also the queries that can be used in gerrit UI
>> directly, e.g.:
>> Critical/High Bugs
>> (topic:bug/1399249 OR topic:bug/1399280 OR topic:bug/1443421 OR
>> topic:bug/1453350 OR topic:bug/1462154 OR topic:bug/1478100 OR
>> topic:bug/1490051 OR topic:bug/1491131 OR topic:bug/1498790 OR
>> topic:bug/1505575 OR topic:bug/1505843 OR topic:bug/1513678 OR
>> topic:bug/1513765 OR topic:bug/1514810)
>>
>>
>> This is the dashboard I get right now [3]
>>
>> I tried in many ways to get Gerrit to filter patches if the commit
>> message contains a bug ID. Something like:
>>
>> (message:"#1399249" OR message:"#1399280" OR message:"#1443421" OR
>> message:"#1453350" OR message:"#1462154" OR message:"#1478100" OR
>> message:"#1490051" OR message:"#1491131" OR message:"#1498790" OR
>> message:"#1505575" OR message:"#1505843" OR message:"#1513678" OR
>> message:"#1513765" OR message:"#1514810")
>>
>> but it doesn't work well, the result of the filter contains patches
>> that have nothing to do with the bugs queried.
>>
>>
>> Try to drop the # and quote the bug number like this:
>>
>> message:"'1399280'"
>>
>> Otherwise I believe gerrit looks for substring matches.
>>
>
> That was my first attempt, it doesn't work unfortunately.
>

That's weird. It works for me:

https://review.openstack.org/#/q/message:%22'1399280'%22,n,z


>
> thanks,
>
> Rossella
>
>
>
>>
>> That's why I had to filter using the topic.
>>
>> CAVEAT: To make the dashboard work, bug fixes must use the topic
>> "bug/ID" and patches implementing a blueprint the topic "bp/name".
>> If a patch is not following this convention it won't be showed in
>> the dashboard, since the topic is used as filter. Most of us use
>> this convention already anyway so I hope it's not too much of a
>> burden.
>>
>> Feedback is appreciated :)
>>
>>
>> Nice one, I'll provide feedback on [1].
>>
>>
>> [1] https://review.openstack.org/248645
>> [2] https://github.com/openstack/gerrit-dash-creator
>> [3] https://goo.gl/sglSbp
>>
>>
>> Btw, I was looking at the current blueprint assignments [1] for
>> Mitaka:
>> there are some blueprints that still need assignee, approver and
>> drafter; we should close the gap. If there are volunteers,
>> please reach
>> out to me.
>>
>> Thanks,
>> Armando
>>
>>   

Re: [openstack-dev] [Neutron] Call for review focus

[Rossella Sblendido]

On 11/23/2015 06:42 PM, Armando M. wrote:



On 23 November 2015 at 09:22, Carl Baldwin > wrote:

On Mon, Nov 23, 2015 at 5:02 AM, Rossella Sblendido
> wrote:
> To cross-reference we can use the bug ID or the blueprint name.
>
> I created a script that queries launchpad to get:
> 1) Bug number of the bugs tagged with approved-rfe
> 2) Bug number of the critical/high bugs
> 3) list of blueprints targeted for the current milestone (mitaka-1)

Rossella, this is a great start!  In principle, I have wanted
something like this for a long time now.  The process of scraping
launchpad and gerrit manually for the most important stuff to review
is labor intensive and sometimes I just want to take a little bit of
extra time and review something.  It is very tempting to go straight
to gerrit and pick something.  I think it is very important for us to
finally crack this nut and have a dashboard which can help us easily
find the most important reviews.  I think your time on this is very
well spent and will positively affect the whole team.


Thanks a lot Carl! I really hope it will be useful :)



 > With this info the script builds a .dash file that can be used by
 > gerrit-dash-creator [2] to produce a dashboard url .
 >
 > The script prints also the queries that can be used in gerrit UI
directly,
 > e.g.:
 > Critical/High Bugs
 > (topic:bug/1399249 OR topic:bug/1399280 OR topic:bug/1443421 OR
 > topic:bug/1453350 OR topic:bug/1462154 OR topic:bug/1478100 OR
 > topic:bug/1490051 OR topic:bug/1491131 OR topic:bug/1498790 OR
 > topic:bug/1505575 OR topic:bug/1505843 OR topic:bug/1513678 OR
 > topic:bug/1513765 OR topic:bug/1514810)
 >
 > This is the dashboard I get right now [3]
 >
 > I tried in many ways to get Gerrit to filter patches if the
commit message
 > contains a bug ID. Something like:
 >
 > (message:"#1399249" OR message:"#1399280" OR message:"#1443421" OR
 > message:"#1453350" OR message:"#1462154" OR message:"#1478100" OR
 > message:"#1490051" OR message:"#1491131" OR message:"#1498790" OR
 > message:"#1505575" OR message:"#1505843" OR message:"#1513678" OR
 > message:"#1513765" OR message:"#1514810")
 >
 > but it doesn't work well, the result of the filter contains
patches that
 > have nothing to do with the bugs queried.
 > That's why I had to filter using the topic.
 >
 > CAVEAT: To make the dashboard work, bug fixes must use the topic
"bug/ID"
 > and patches implementing a blueprint the topic "bp/name". If a
patch is not
 > following this convention it won't be showed in the dashboard,
since the
 > topic is used as filter. Most of us use this convention already
anyway so I
 > hope it's not too much of a burden.
 >
 > Feedback is appreciated :)

I looked for the address scopes blueprint [1] which is targeted for
Mitaka-1 [2] and there are 6 (or 5, one is in the gate) patches on the
bp/address-scopes topic [3].  It isn't obvious to me yet why it didn't
get picked up on the dashboard.  I've only started to look in to this
and may not have much time right now.  I wondered if you could easily
tell why it didn't get picked up.


Isn't it missing bp/ ? From the URL I can only see topic:address-scope,
which isn't the right one.


Yes Armando is right. I fixed that. Another reason is that I am 
filtering out patches that are WIP or that failed Jenkins tests. This 
can be changed anyway. This is what I get now (after fixing the missing 
'bp/') [1]


cheers,

Rossella

[1] goo.gl/C7UjdD




Given that I only see one review in
the blueprints section, I suspect there are other blueprints which are
in the same situation.



[1] https://blueprints.launchpad.net/neutron/+spec/address-scopes
[2] https://launchpad.net/neutron/+milestone/mitaka-1
[3]
https://review.openstack.org/#/q/status:open+topic:bp/address-scopes,n,z

Thanks!
Carl

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe:
openstack-dev-requ...@lists.openstack.org?subject:unsubscribe

http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev




__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev



__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: 

Re: [openstack-dev] [Neutron] Call for review focus

[Rossella Sblendido]

On 11/23/2015 06:38 PM, Armando M. wrote:



On 23 November 2015 at 04:02, Rossella Sblendido > wrote:



On 11/20/2015 03:54 AM, Armando M. wrote:



On 19 November 2015 at 18:26, Assaf Muller 
>> wrote:

 On Wed, Nov 18, 2015 at 9:14 PM, Armando M.

 >> wrote:
 > Hi Neutrites,
 >
 > We are nearly two weeks away from the end of Mitaka 1.
 >
 > I am writing this email to invite you to be mindful to
what you review,
 > especially in the next couple of weeks. Whenever you have
the time to review
 > code, please consider giving priority to the following:
 >
 > Patches that target blueprints targeted for Mitaka;
 > Patches that target bugs that are either critical or high;
 > Patches that target rfe-approved 'bugs';
 > Patches that target specs that have followed the most
current submission
 > process;

 Is it possible to create Gerrit dashboards for patches that
answer these
 criteria, and then persist the links in Neutron's
dashboards devref
 page?
http://docs.openstack.org/developer/neutron/dashboards/index.html
 That'd be super useful.


We should look into that, but to be perfectly honest I am not
sure how
easy it would be, since we'd need to cross-reference content
that lives
into gerrit as well as launchpad. Would that even be possible?


To cross-reference we can use the bug ID or the blueprint name.

I created a script that queries launchpad to get:
1) Bug number of the bugs tagged with approved-rfe
2) Bug number of the critical/high bugs
3) list of blueprints targeted for the current milestone (mitaka-1)

With this info the script builds a .dash file that can be used by
gerrit-dash-creator [2] to produce a dashboard url .

The script prints also the queries that can be used in gerrit UI
directly, e.g.:
Critical/High Bugs
(topic:bug/1399249 OR topic:bug/1399280 OR topic:bug/1443421 OR
topic:bug/1453350 OR topic:bug/1462154 OR topic:bug/1478100 OR
topic:bug/1490051 OR topic:bug/1491131 OR topic:bug/1498790 OR
topic:bug/1505575 OR topic:bug/1505843 OR topic:bug/1513678 OR
topic:bug/1513765 OR topic:bug/1514810)


This is the dashboard I get right now [3]

I tried in many ways to get Gerrit to filter patches if the commit
message contains a bug ID. Something like:

(message:"#1399249" OR message:"#1399280" OR message:"#1443421" OR
message:"#1453350" OR message:"#1462154" OR message:"#1478100" OR
message:"#1490051" OR message:"#1491131" OR message:"#1498790" OR
message:"#1505575" OR message:"#1505843" OR message:"#1513678" OR
message:"#1513765" OR message:"#1514810")

but it doesn't work well, the result of the filter contains patches
that have nothing to do with the bugs queried.


Try to drop the # and quote the bug number like this:

message:"'1399280'"

Otherwise I believe gerrit looks for substring matches.


That was my first attempt, it doesn't work unfortunately.

thanks,

Rossella




That's why I had to filter using the topic.

CAVEAT: To make the dashboard work, bug fixes must use the topic
"bug/ID" and patches implementing a blueprint the topic "bp/name".
If a patch is not following this convention it won't be showed in
the dashboard, since the topic is used as filter. Most of us use
this convention already anyway so I hope it's not too much of a burden.

Feedback is appreciated :)


Nice one, I'll provide feedback on [1].


[1] https://review.openstack.org/248645
[2] https://github.com/openstack/gerrit-dash-creator
[3] https://goo.gl/sglSbp


Btw, I was looking at the current blueprint assignments [1] for
Mitaka:
there are some blueprints that still need assignee, approver and
drafter; we should close the gap. If there are volunteers,
please reach
out to me.

Thanks,
Armando

[1] https://blueprints.launchpad.net/neutron/mitaka/+assignments


 >
 > Everything else should come later, no matter how easy or
interesting it is
 > to review; remember that as a community we have the
collective duty to work
 > towards a common (set of) target(s), as being planned in
collaboration with
 > the Neutron Drivers team and the larger core team.
 >
 > I would invite submitters to ensure that the 

Re: [openstack-dev] [Neutron] Call for review focus

[Rossella Sblendido]

On 11/20/2015 03:54 AM, Armando M. wrote:



On 19 November 2015 at 18:26, Assaf Muller > wrote:

On Wed, Nov 18, 2015 at 9:14 PM, Armando M. > wrote:
> Hi Neutrites,
>
> We are nearly two weeks away from the end of Mitaka 1.
>
> I am writing this email to invite you to be mindful to what you review,
> especially in the next couple of weeks. Whenever you have the time to 
review
> code, please consider giving priority to the following:
>
> Patches that target blueprints targeted for Mitaka;
> Patches that target bugs that are either critical or high;
> Patches that target rfe-approved 'bugs';
> Patches that target specs that have followed the most current submission
> process;

Is it possible to create Gerrit dashboards for patches that answer these
criteria, and then persist the links in Neutron's dashboards devref
page?
http://docs.openstack.org/developer/neutron/dashboards/index.html
That'd be super useful.


We should look into that, but to be perfectly honest I am not sure how
easy it would be, since we'd need to cross-reference content that lives
into gerrit as well as launchpad. Would that even be possible?


To cross-reference we can use the bug ID or the blueprint name.

I created a script that queries launchpad to get:
1) Bug number of the bugs tagged with approved-rfe
2) Bug number of the critical/high bugs
3) list of blueprints targeted for the current milestone (mitaka-1)

With this info the script builds a .dash file that can be used by 
gerrit-dash-creator [2] to produce a dashboard url .


The script prints also the queries that can be used in gerrit UI 
directly, e.g.:

Critical/High Bugs
(topic:bug/1399249 OR topic:bug/1399280 OR topic:bug/1443421 OR 
topic:bug/1453350 OR topic:bug/1462154 OR topic:bug/1478100 OR 
topic:bug/1490051 OR topic:bug/1491131 OR topic:bug/1498790 OR 
topic:bug/1505575 OR topic:bug/1505843 OR topic:bug/1513678 OR 
topic:bug/1513765 OR topic:bug/1514810)



This is the dashboard I get right now [3]

I tried in many ways to get Gerrit to filter patches if the commit 
message contains a bug ID. Something like:


(message:"#1399249" OR message:"#1399280" OR message:"#1443421" OR 
message:"#1453350" OR message:"#1462154" OR message:"#1478100" OR 
message:"#1490051" OR message:"#1491131" OR message:"#1498790" OR 
message:"#1505575" OR message:"#1505843" OR message:"#1513678" OR 
message:"#1513765" OR message:"#1514810")


but it doesn't work well, the result of the filter contains patches that 
have nothing to do with the bugs queried.

That's why I had to filter using the topic.

CAVEAT: To make the dashboard work, bug fixes must use the topic 
"bug/ID" and patches implementing a blueprint the topic "bp/name". If a 
patch is not following this convention it won't be showed in the 
dashboard, since the topic is used as filter. Most of us use this 
convention already anyway so I hope it's not too much of a burden.


Feedback is appreciated :)

[1] https://review.openstack.org/248645
[2] https://github.com/openstack/gerrit-dash-creator
[3] https://goo.gl/sglSbp



Btw, I was looking at the current blueprint assignments [1] for Mitaka:
there are some blueprints that still need assignee, approver and
drafter; we should close the gap. If there are volunteers, please reach
out to me.

Thanks,
Armando

[1] https://blueprints.launchpad.net/neutron/mitaka/+assignments


>
> Everything else should come later, no matter how easy or interesting it is
> to review; remember that as a community we have the collective duty to 
work
> towards a common (set of) target(s), as being planned in collaboration 
with
> the Neutron Drivers team and the larger core team.
>
> I would invite submitters to ensure that the Launchpad resources
> (blueprints, and bug report) capture the most updated view in terms of
> patches etc. Work with your approver to help him/her be focussed where it
> matters most.
>
> Finally, we had plenty of discussions at the design summit, and some of
> those discussions will have to be followed up with actions (aka code in
> OpenStack lingo). Even though, we no longer have deadlines for feature
> submission, I strongly advise you not to leave it last minute. We can only
> handle so much work for any given release, and past experience tells us 
that
> we can easily hit a breaking point at around the ~30 blueprint mark.
>
> Once we reached it, it's likely we'll have to start pushing back work for
> Mitaka and allow us some slack; things are fluid as we all know, and the
> random gate breakage is always lurking round the corner! :)
>
> Happy hacking,
> Armando
>
 >
__
 > OpenStack Development Mailing List (not for usage 

Re: [openstack-dev] [Neutron] Call for review focus

[Carl Baldwin]

On Mon, Nov 23, 2015 at 5:02 AM, Rossella Sblendido  wrote:
> To cross-reference we can use the bug ID or the blueprint name.
>
> I created a script that queries launchpad to get:
> 1) Bug number of the bugs tagged with approved-rfe
> 2) Bug number of the critical/high bugs
> 3) list of blueprints targeted for the current milestone (mitaka-1)

Rossella, this is a great start!  In principle, I have wanted
something like this for a long time now.  The process of scraping
launchpad and gerrit manually for the most important stuff to review
is labor intensive and sometimes I just want to take a little bit of
extra time and review something.  It is very tempting to go straight
to gerrit and pick something.  I think it is very important for us to
finally crack this nut and have a dashboard which can help us easily
find the most important reviews.  I think your time on this is very
well spent and will positively affect the whole team.

> With this info the script builds a .dash file that can be used by
> gerrit-dash-creator [2] to produce a dashboard url .
>
> The script prints also the queries that can be used in gerrit UI directly,
> e.g.:
> Critical/High Bugs
> (topic:bug/1399249 OR topic:bug/1399280 OR topic:bug/1443421 OR
> topic:bug/1453350 OR topic:bug/1462154 OR topic:bug/1478100 OR
> topic:bug/1490051 OR topic:bug/1491131 OR topic:bug/1498790 OR
> topic:bug/1505575 OR topic:bug/1505843 OR topic:bug/1513678 OR
> topic:bug/1513765 OR topic:bug/1514810)
>
> This is the dashboard I get right now [3]
>
> I tried in many ways to get Gerrit to filter patches if the commit message
> contains a bug ID. Something like:
>
> (message:"#1399249" OR message:"#1399280" OR message:"#1443421" OR
> message:"#1453350" OR message:"#1462154" OR message:"#1478100" OR
> message:"#1490051" OR message:"#1491131" OR message:"#1498790" OR
> message:"#1505575" OR message:"#1505843" OR message:"#1513678" OR
> message:"#1513765" OR message:"#1514810")
>
> but it doesn't work well, the result of the filter contains patches that
> have nothing to do with the bugs queried.
> That's why I had to filter using the topic.
>
> CAVEAT: To make the dashboard work, bug fixes must use the topic "bug/ID"
> and patches implementing a blueprint the topic "bp/name". If a patch is not
> following this convention it won't be showed in the dashboard, since the
> topic is used as filter. Most of us use this convention already anyway so I
> hope it's not too much of a burden.
>
> Feedback is appreciated :)

I looked for the address scopes blueprint [1] which is targeted for
Mitaka-1 [2] and there are 6 (or 5, one is in the gate) patches on the
bp/address-scopes topic [3].  It isn't obvious to me yet why it didn't
get picked up on the dashboard.  I've only started to look in to this
and may not have much time right now.  I wondered if you could easily
tell why it didn't get picked up.  Given that I only see one review in
the blueprints section, I suspect there are other blueprints which are
in the same situation.

[1] https://blueprints.launchpad.net/neutron/+spec/address-scopes
[2] https://launchpad.net/neutron/+milestone/mitaka-1
[3] https://review.openstack.org/#/q/status:open+topic:bp/address-scopes,n,z

Thanks!
Carl

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [Neutron] Call for review focus

[Armando M.]

On 23 November 2015 at 09:22, Carl Baldwin  wrote:

> On Mon, Nov 23, 2015 at 5:02 AM, Rossella Sblendido 
> wrote:
> > To cross-reference we can use the bug ID or the blueprint name.
> >
> > I created a script that queries launchpad to get:
> > 1) Bug number of the bugs tagged with approved-rfe
> > 2) Bug number of the critical/high bugs
> > 3) list of blueprints targeted for the current milestone (mitaka-1)
>
> Rossella, this is a great start!  In principle, I have wanted
> something like this for a long time now.  The process of scraping
> launchpad and gerrit manually for the most important stuff to review
> is labor intensive and sometimes I just want to take a little bit of
> extra time and review something.  It is very tempting to go straight
> to gerrit and pick something.  I think it is very important for us to
> finally crack this nut and have a dashboard which can help us easily
> find the most important reviews.  I think your time on this is very
> well spent and will positively affect the whole team.
>
> > With this info the script builds a .dash file that can be used by
> > gerrit-dash-creator [2] to produce a dashboard url .
> >
> > The script prints also the queries that can be used in gerrit UI
> directly,
> > e.g.:
> > Critical/High Bugs
> > (topic:bug/1399249 OR topic:bug/1399280 OR topic:bug/1443421 OR
> > topic:bug/1453350 OR topic:bug/1462154 OR topic:bug/1478100 OR
> > topic:bug/1490051 OR topic:bug/1491131 OR topic:bug/1498790 OR
> > topic:bug/1505575 OR topic:bug/1505843 OR topic:bug/1513678 OR
> > topic:bug/1513765 OR topic:bug/1514810)
> >
> > This is the dashboard I get right now [3]
> >
> > I tried in many ways to get Gerrit to filter patches if the commit
> message
> > contains a bug ID. Something like:
> >
> > (message:"#1399249" OR message:"#1399280" OR message:"#1443421" OR
> > message:"#1453350" OR message:"#1462154" OR message:"#1478100" OR
> > message:"#1490051" OR message:"#1491131" OR message:"#1498790" OR
> > message:"#1505575" OR message:"#1505843" OR message:"#1513678" OR
> > message:"#1513765" OR message:"#1514810")
> >
> > but it doesn't work well, the result of the filter contains patches that
> > have nothing to do with the bugs queried.
> > That's why I had to filter using the topic.
> >
> > CAVEAT: To make the dashboard work, bug fixes must use the topic "bug/ID"
> > and patches implementing a blueprint the topic "bp/name". If a patch is
> not
> > following this convention it won't be showed in the dashboard, since the
> > topic is used as filter. Most of us use this convention already anyway
> so I
> > hope it's not too much of a burden.
> >
> > Feedback is appreciated :)
>
> I looked for the address scopes blueprint [1] which is targeted for
> Mitaka-1 [2] and there are 6 (or 5, one is in the gate) patches on the
> bp/address-scopes topic [3].  It isn't obvious to me yet why it didn't
> get picked up on the dashboard.  I've only started to look in to this
> and may not have much time right now.  I wondered if you could easily
> tell why it didn't get picked up.


Isn't it missing bp/ ? From the URL I can only see topic:address-scope,
which isn't the right one.


> Given that I only see one review in
> the blueprints section, I suspect there are other blueprints which are
> in the same situation.
>



>
> [1] https://blueprints.launchpad.net/neutron/+spec/address-scopes
> [2] https://launchpad.net/neutron/+milestone/mitaka-1
> [3]
> https://review.openstack.org/#/q/status:open+topic:bp/address-scopes,n,z
>
> Thanks!
> Carl
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [Neutron] Call for review focus

[Armando M.]

On 23 November 2015 at 04:02, Rossella Sblendido 
wrote:

>
>
> On 11/20/2015 03:54 AM, Armando M. wrote:
>
>>
>>
>> On 19 November 2015 at 18:26, Assaf Muller > > wrote:
>>
>> On Wed, Nov 18, 2015 at 9:14 PM, Armando M. > > wrote:
>> > Hi Neutrites,
>> >
>> > We are nearly two weeks away from the end of Mitaka 1.
>> >
>> > I am writing this email to invite you to be mindful to what you
>> review,
>> > especially in the next couple of weeks. Whenever you have the time
>> to review
>> > code, please consider giving priority to the following:
>> >
>> > Patches that target blueprints targeted for Mitaka;
>> > Patches that target bugs that are either critical or high;
>> > Patches that target rfe-approved 'bugs';
>> > Patches that target specs that have followed the most current
>> submission
>> > process;
>>
>> Is it possible to create Gerrit dashboards for patches that answer
>> these
>> criteria, and then persist the links in Neutron's dashboards devref
>> page?
>> http://docs.openstack.org/developer/neutron/dashboards/index.html
>> That'd be super useful.
>>
>>
>> We should look into that, but to be perfectly honest I am not sure how
>> easy it would be, since we'd need to cross-reference content that lives
>> into gerrit as well as launchpad. Would that even be possible?
>>
>
> To cross-reference we can use the bug ID or the blueprint name.
>
> I created a script that queries launchpad to get:
> 1) Bug number of the bugs tagged with approved-rfe
> 2) Bug number of the critical/high bugs
> 3) list of blueprints targeted for the current milestone (mitaka-1)
>
> With this info the script builds a .dash file that can be used by
> gerrit-dash-creator [2] to produce a dashboard url .
>
> The script prints also the queries that can be used in gerrit UI directly,
> e.g.:
> Critical/High Bugs
> (topic:bug/1399249 OR topic:bug/1399280 OR topic:bug/1443421 OR
> topic:bug/1453350 OR topic:bug/1462154 OR topic:bug/1478100 OR
> topic:bug/1490051 OR topic:bug/1491131 OR topic:bug/1498790 OR
> topic:bug/1505575 OR topic:bug/1505843 OR topic:bug/1513678 OR
> topic:bug/1513765 OR topic:bug/1514810)
>
>
> This is the dashboard I get right now [3]
>
> I tried in many ways to get Gerrit to filter patches if the commit message
> contains a bug ID. Something like:
>
> (message:"#1399249" OR message:"#1399280" OR message:"#1443421" OR
> message:"#1453350" OR message:"#1462154" OR message:"#1478100" OR
> message:"#1490051" OR message:"#1491131" OR message:"#1498790" OR
> message:"#1505575" OR message:"#1505843" OR message:"#1513678" OR
> message:"#1513765" OR message:"#1514810")
>
> but it doesn't work well, the result of the filter contains patches that
> have nothing to do with the bugs queried.
>

Try to drop the # and quote the bug number like this:

message:"'1399280'"

Otherwise I believe gerrit looks for substring matches.


That's why I had to filter using the topic.
>
> CAVEAT: To make the dashboard work, bug fixes must use the topic "bug/ID"
> and patches implementing a blueprint the topic "bp/name". If a patch is not
> following this convention it won't be showed in the dashboard, since the
> topic is used as filter. Most of us use this convention already anyway so I
> hope it's not too much of a burden.
>
> Feedback is appreciated :)
>

Nice one, I'll provide feedback on [1].


>
> [1] https://review.openstack.org/248645
> [2] https://github.com/openstack/gerrit-dash-creator
> [3] https://goo.gl/sglSbp
>
>
>> Btw, I was looking at the current blueprint assignments [1] for Mitaka:
>> there are some blueprints that still need assignee, approver and
>> drafter; we should close the gap. If there are volunteers, please reach
>> out to me.
>>
>> Thanks,
>> Armando
>>
>> [1] https://blueprints.launchpad.net/neutron/mitaka/+assignments
>>
>>
>> >
>> > Everything else should come later, no matter how easy or
>> interesting it is
>> > to review; remember that as a community we have the collective duty
>> to work
>> > towards a common (set of) target(s), as being planned in
>> collaboration with
>> > the Neutron Drivers team and the larger core team.
>> >
>> > I would invite submitters to ensure that the Launchpad resources
>> > (blueprints, and bug report) capture the most updated view in terms
>> of
>> > patches etc. Work with your approver to help him/her be focussed
>> where it
>> > matters most.
>> >
>> > Finally, we had plenty of discussions at the design summit, and
>> some of
>> > those discussions will have to be followed up with actions (aka
>> code in
>> > OpenStack lingo). Even though, we no longer have deadlines for
>> feature
>> > submission, I strongly advise you not to leave it last minute. We
>> can only
>> > handle so much work for any given release, and 

Re: [openstack-dev] [Neutron] Call for review focus

[Carl Baldwin]

On Fri, Nov 20, 2015 at 3:57 PM, Armando M.  wrote:
> On 20 November 2015 at 14:07, Kyle Mestery  wrote:
>> On Wed, Nov 18, 2015 at 8:14 PM, Armando M.  wrote:
>>>
>>> Hi Neutrites,
>>
>> Neutrinos?
>
> I am still experimenting to see what sticks...So far I got Neutrinos,
> Neutronians, and Neutrites...Neutrinos is the one I like most, but
> Neutronians is cool too. Ludicrous, uh?

I think of myself as a Neutronian and my kids as Neutrinos.  :)

Carl

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [Neutron] Call for review focus

[Kyle Mestery]

On Wed, Nov 18, 2015 at 8:14 PM, Armando M.  wrote:

> Hi Neutrites,
>
>
Neutrinos?


> We are nearly two weeks away from the end of Mitaka 1.
>
> I am writing this email to invite you to be mindful to what you review,
> especially in the next couple of weeks. Whenever you have the time to
> review code, please consider giving priority to the following:
>
>- Patches that target blueprints targeted for Mitaka
>;
>- Patches that target bugs that are either critical
>
> 
>or high
>
> 
>;
>- Patches that target rfe-approved
>
> 
> 'bugs';
>- Patches that target specs
>
> 
>  that
>have followed the most current submission process
>;
>
> Everything else should come later, no matter how easy or interesting it is
> to review; remember that as a community we have the collective duty to work
> towards a common (set of) target(s), as being planned in collaboration with
> the Neutron Drivers
>  team and the
> larger core  team.
>
> I would invite submitters to ensure that the Launchpad resources
> (blueprints, and bug report) capture the most updated view in terms of
> patches etc. Work with your approver to help him/her be focussed where it
> matters most.
>
> Finally, we had plenty of discussions at the design summit
> ,
> and some of those discussions will have to be followed up with actions (aka
> code in OpenStack lingo). Even though, we no longer have deadlines for
> feature submission, I strongly advise you not to leave it last minute. We
> can only handle so much work for any given release, and past experience
> tells us that we can easily hit a breaking point at around the ~30
> blueprint mark.
>
> Once we reached it, it's likely we'll have to start pushing back work for
> Mitaka and allow us some slack; things are fluid as we all know, and the
> random gate breakage is always lurking round the corner! :)
>
>
Thanks for sending this out Armando. Keeping focus is important, and your
occasional emails reminding people are super useful. I find them useful,
and as the previous PTL, I can backup the fact that the team should be
focusing on specific reviews.

Thanks!
Kyle


> Happy hacking,
> Armando
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [Neutron] Call for review focus

[Armando M.]

On 20 November 2015 at 14:07, Kyle Mestery  wrote:

> On Wed, Nov 18, 2015 at 8:14 PM, Armando M.  wrote:
>
>> Hi Neutrites,
>>
>>
> Neutrinos?
>

I am still experimenting to see what sticks...So far I got Neutrinos,
Neutronians, and Neutrites...Neutrinos is the one I like most, but
Neutronians is cool too. Ludicrous, uh?


>
>> We are nearly two weeks away from the end of Mitaka 1.
>>
>> I am writing this email to invite you to be mindful to what you review,
>> especially in the next couple of weeks. Whenever you have the time to
>> review code, please consider giving priority to the following:
>>
>>- Patches that target blueprints targeted for Mitaka
>>;
>>- Patches that target bugs that are either critical
>>
>> 
>>or high
>>
>> 
>>;
>>- Patches that target rfe-approved
>>
>> 
>> 'bugs';
>>- Patches that target specs
>>
>> 
>>  that
>>have followed the most current submission process
>>
>>;
>>
>> Everything else should come later, no matter how easy or interesting it
>> is to review; remember that as a community we have the collective duty to
>> work towards a common (set of) target(s), as being planned in collaboration
>> with the Neutron Drivers
>>  team and the
>> larger core 
>> team.
>>
>> I would invite submitters to ensure that the Launchpad resources
>> (blueprints, and bug report) capture the most updated view in terms of
>> patches etc. Work with your approver to help him/her be focussed where it
>> matters most.
>>
>> Finally, we had plenty of discussions at the design summit
>> ,
>> and some of those discussions will have to be followed up with actions (aka
>> code in OpenStack lingo). Even though, we no longer have deadlines for
>> feature submission, I strongly advise you not to leave it last minute. We
>> can only handle so much work for any given release, and past experience
>> tells us that we can easily hit a breaking point at around the ~30
>> blueprint mark.
>>
>> Once we reached it, it's likely we'll have to start pushing back work for
>> Mitaka and allow us some slack; things are fluid as we all know, and the
>> random gate breakage is always lurking round the corner! :)
>>
>>
> Thanks for sending this out Armando. Keeping focus is important, and your
> occasional emails reminding people are super useful. I find them useful,
> and as the previous PTL, I can backup the fact that the team should be
> focusing on specific reviews.
>

Appreciate the endorsement :)


>
> Thanks!
> Kyle
>
>
>> Happy hacking,
>> Armando
>>
>> __
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe:
>> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>>
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [Neutron] Call for review focus

[Armando M.]

On 19 November 2015 at 18:26, Assaf Muller  wrote:

> On Wed, Nov 18, 2015 at 9:14 PM, Armando M.  wrote:
> > Hi Neutrites,
> >
> > We are nearly two weeks away from the end of Mitaka 1.
> >
> > I am writing this email to invite you to be mindful to what you review,
> > especially in the next couple of weeks. Whenever you have the time to
> review
> > code, please consider giving priority to the following:
> >
> > Patches that target blueprints targeted for Mitaka;
> > Patches that target bugs that are either critical or high;
> > Patches that target rfe-approved 'bugs';
> > Patches that target specs that have followed the most current submission
> > process;
>
> Is it possible to create Gerrit dashboards for patches that answer these
> criteria, and then persist the links in Neutron's dashboards devref page?
> http://docs.openstack.org/developer/neutron/dashboards/index.html
> That'd be super useful.
>

We should look into that, but to be perfectly honest I am not sure how easy
it would be, since we'd need to cross-reference content that lives into
gerrit as well as launchpad. Would that even be possible?

Btw, I was looking at the current blueprint assignments [1] for Mitaka:
there are some blueprints that still need assignee, approver and drafter;
we should close the gap. If there are volunteers, please reach out to me.

Thanks,
Armando

[1] https://blueprints.launchpad.net/neutron/mitaka/+assignments


>
> >
> > Everything else should come later, no matter how easy or interesting it
> is
> > to review; remember that as a community we have the collective duty to
> work
> > towards a common (set of) target(s), as being planned in collaboration
> with
> > the Neutron Drivers team and the larger core team.
> >
> > I would invite submitters to ensure that the Launchpad resources
> > (blueprints, and bug report) capture the most updated view in terms of
> > patches etc. Work with your approver to help him/her be focussed where it
> > matters most.
> >
> > Finally, we had plenty of discussions at the design summit, and some of
> > those discussions will have to be followed up with actions (aka code in
> > OpenStack lingo). Even though, we no longer have deadlines for feature
> > submission, I strongly advise you not to leave it last minute. We can
> only
> > handle so much work for any given release, and past experience tells us
> that
> > we can easily hit a breaking point at around the ~30 blueprint mark.
> >
> > Once we reached it, it's likely we'll have to start pushing back work for
> > Mitaka and allow us some slack; things are fluid as we all know, and the
> > random gate breakage is always lurking round the corner! :)
> >
> > Happy hacking,
> > Armando
> >
> >
> __
> > OpenStack Development Mailing List (not for usage questions)
> > Unsubscribe:
> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> >
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [Neutron] Call for review focus

[Assaf Muller]

On Wed, Nov 18, 2015 at 9:14 PM, Armando M.  wrote:
> Hi Neutrites,
>
> We are nearly two weeks away from the end of Mitaka 1.
>
> I am writing this email to invite you to be mindful to what you review,
> especially in the next couple of weeks. Whenever you have the time to review
> code, please consider giving priority to the following:
>
> Patches that target blueprints targeted for Mitaka;
> Patches that target bugs that are either critical or high;
> Patches that target rfe-approved 'bugs';
> Patches that target specs that have followed the most current submission
> process;

Is it possible to create Gerrit dashboards for patches that answer these
criteria, and then persist the links in Neutron's dashboards devref page?
http://docs.openstack.org/developer/neutron/dashboards/index.html
That'd be super useful.

>
> Everything else should come later, no matter how easy or interesting it is
> to review; remember that as a community we have the collective duty to work
> towards a common (set of) target(s), as being planned in collaboration with
> the Neutron Drivers team and the larger core team.
>
> I would invite submitters to ensure that the Launchpad resources
> (blueprints, and bug report) capture the most updated view in terms of
> patches etc. Work with your approver to help him/her be focussed where it
> matters most.
>
> Finally, we had plenty of discussions at the design summit, and some of
> those discussions will have to be followed up with actions (aka code in
> OpenStack lingo). Even though, we no longer have deadlines for feature
> submission, I strongly advise you not to leave it last minute. We can only
> handle so much work for any given release, and past experience tells us that
> we can easily hit a breaking point at around the ~30 blueprint mark.
>
> Once we reached it, it's likely we'll have to start pushing back work for
> Mitaka and allow us some slack; things are fluid as we all know, and the
> random gate breakage is always lurking round the corner! :)
>
> Happy hacking,
> Armando
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [Neutron] Call for review focus

[Carl Baldwin]

++

On Wed, Nov 18, 2015 at 7:14 PM, Armando M.  wrote:
> Hi Neutrites,
>
> We are nearly two weeks away from the end of Mitaka 1.
>
> I am writing this email to invite you to be mindful to what you review,
> especially in the next couple of weeks. Whenever you have the time to review
> code, please consider giving priority to the following:
>
> Patches that target blueprints targeted for Mitaka;
> Patches that target bugs that are either critical or high;
> Patches that target rfe-approved 'bugs';
> Patches that target specs that have followed the most current submission
> process;
>
> Everything else should come later, no matter how easy or interesting it is
> to review; remember that as a community we have the collective duty to work
> towards a common (set of) target(s), as being planned in collaboration with
> the Neutron Drivers team and the larger core team.
>
> I would invite submitters to ensure that the Launchpad resources
> (blueprints, and bug report) capture the most updated view in terms of
> patches etc. Work with your approver to help him/her be focussed where it
> matters most.
>
> Finally, we had plenty of discussions at the design summit, and some of
> those discussions will have to be followed up with actions (aka code in
> OpenStack lingo). Even though, we no longer have deadlines for feature
> submission, I strongly advise you not to leave it last minute. We can only
> handle so much work for any given release, and past experience tells us that
> we can easily hit a breaking point at around the ~30 blueprint mark.
>
> Once we reached it, it's likely we'll have to start pushing back work for
> Mitaka and allow us some slack; things are fluid as we all know, and the
> random gate breakage is always lurking round the corner! :)
>
> Happy hacking,
> Armando
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

[openstack-dev] [Neutron] Call for review focus

[Armando M.]

Hi Neutrites,

We are nearly two weeks away from the end of Mitaka 1.

I am writing this email to invite you to be mindful to what you review,
especially in the next couple of weeks. Whenever you have the time to
review code, please consider giving priority to the following:

   - Patches that target blueprints targeted for Mitaka
   ;
   - Patches that target bugs that are either critical
   

   or high
   

   ;
   - Patches that target rfe-approved
   

'bugs';
   - Patches that target specs
   

that
   have followed the most current submission process
   ;

Everything else should come later, no matter how easy or interesting it is
to review; remember that as a community we have the collective duty to work
towards a common (set of) target(s), as being planned in collaboration with
the Neutron Drivers
 team and the
larger core  team.

I would invite submitters to ensure that the Launchpad resources
(blueprints, and bug report) capture the most updated view in terms of
patches etc. Work with your approver to help him/her be focussed where it
matters most.

Finally, we had plenty of discussions at the design summit
,
and some of those discussions will have to be followed up with actions (aka
code in OpenStack lingo). Even though, we no longer have deadlines for
feature submission, I strongly advise you not to leave it last minute. We
can only handle so much work for any given release, and past experience
tells us that we can easily hit a breaking point at around the ~30
blueprint mark.

Once we reached it, it's likely we'll have to start pushing back work for
Mitaka and allow us some slack; things are fluid as we all know, and the
random gate breakage is always lurking round the corner! :)

Happy hacking,
Armando
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev