Re: [openstack-dev] [all][gerrit] Showing all inline comments from all patch sets

[James Polley]

But equally I think finding out why the "New Screen" still doesn't do what
you want is valuable - it's likely other people want something similar to
what you want, so this kind of feedback can be used to decide on future
features

On Wed, Dec 17, 2014 at 8:38 AM, Radoslav Gerganov 
wrote:
>
> I am aware of this "New Screen" but it is not useful to me.  I'd like to
> see comments grouped by patchset, file and commented line rather than a
> flat view mixed with everything else.  Anyway, I guess there is no
> one-size-fits-all solution for this and everyone has different preferences
> which is cool.
>
> -Rado
>
> On 12/17/14, 8:58 AM, James Polley wrote:
>
>> I was looking at the new change screen on https://review.openstack.org
>> today[1] and it seems to do something vaguely similar.
>>
>> Rather than saying "James polley made 4 inline comments", the contents
>> of the comments are shown, along with a link to the file so you can see
>> the context.
>>
>> Have you seen this? It seems fairly similar to what you're wanting.
>>
>> Have
>> [1] To activate it, go to
>> https://review.openstack.org/#/settings/preferences and set "Change
>> view" to "New Screen", then look at a change screen (such as
>> https://review.openstack.org/#/c/127283/)
>>
>> On Tue, Dec 16, 2014 at 4:45 PM, Jeremy Stanley > > wrote:
>>
>> On 2014-12-16 17:19:55 +0200 (+0200), Radoslav Gerganov wrote:
>> > We don't need GoogleAppEngine if we decide that this is useful. We
>> > simply need to put the html page which renders the view on
>> >https://review.openstack.org. It is all javascript which talks
>> > asynchronously to the Gerrit backend.
>> >
>> > I am using GAE to simply illustrate the idea without having to
>> > spin up an entire Gerrit server.
>>
>> That makes a lot more sense--thanks for the clarification!
>>
>> > I guess I can also submit a patch to the infra project and see how
>> > this works onhttps://review-dev.openstack.org if you want.
>>
>> If there's a general desire from the developer community for it,
>> then that's probably the next step. However, ultimately this seems
>> like something better suited as an upstream feature request for
>> Gerrit (there may even already be thread-oriented improvements in
>> the works for the new change screen--I haven't kept up with their
>> progress lately).
>> --
>> Jeremy Stanley
>>
>> ___
>> OpenStack-dev mailing list
>> OpenStack-dev@lists.openstack.org
>> 
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>>
>>
>> ___
>> OpenStack-dev mailing list
>> OpenStack-dev@lists.openstack.org
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>>
> ___
> OpenStack-dev mailing list
> OpenStack-dev@lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [all][gerrit] Showing all inline comments from all patch sets

[Radoslav Gerganov]

I am aware of this "New Screen" but it is not useful to me.  I'd like to 
see comments grouped by patchset, file and commented line rather than a 
flat view mixed with everything else.  Anyway, I guess there is no 
one-size-fits-all solution for this and everyone has different 
preferences which is cool.


-Rado

On 12/17/14, 8:58 AM, James Polley wrote:

I was looking at the new change screen on https://review.openstack.org
today[1] and it seems to do something vaguely similar.

Rather than saying "James polley made 4 inline comments", the contents
of the comments are shown, along with a link to the file so you can see
the context.

Have you seen this? It seems fairly similar to what you're wanting.

Have
[1] To activate it, go to
https://review.openstack.org/#/settings/preferences and set "Change
view" to "New Screen", then look at a change screen (such as
https://review.openstack.org/#/c/127283/)

On Tue, Dec 16, 2014 at 4:45 PM, Jeremy Stanley mailto:fu...@yuggoth.org>> wrote:

On 2014-12-16 17:19:55 +0200 (+0200), Radoslav Gerganov wrote:
> We don't need GoogleAppEngine if we decide that this is useful. We
> simply need to put the html page which renders the view on
>https://review.openstack.org. It is all javascript which talks
> asynchronously to the Gerrit backend.
>
> I am using GAE to simply illustrate the idea without having to
> spin up an entire Gerrit server.

That makes a lot more sense--thanks for the clarification!

> I guess I can also submit a patch to the infra project and see how
> this works onhttps://review-dev.openstack.org if you want.

If there's a general desire from the developer community for it,
then that's probably the next step. However, ultimately this seems
like something better suited as an upstream feature request for
Gerrit (there may even already be thread-oriented improvements in
the works for the new change screen--I haven't kept up with their
progress lately).
--
Jeremy Stanley

___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org

http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev



___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev



___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [all][gerrit] Showing all inline comments from all patch sets

[James Polley]

I was looking at the new change screen on https://review.openstack.org
today[1] and it seems to do something vaguely similar.

Rather than saying "James polley made 4 inline comments", the contents of
the comments are shown, along with a link to the file so you can see the
context.

Have you seen this? It seems fairly similar to what you're wanting.

Have
[1] To activate it, go to
https://review.openstack.org/#/settings/preferences and set "Change view"
to "New Screen", then look at a change screen (such as
https://review.openstack.org/#/c/127283/)

On Tue, Dec 16, 2014 at 4:45 PM, Jeremy Stanley  wrote:
>
> On 2014-12-16 17:19:55 +0200 (+0200), Radoslav Gerganov wrote:
> > We don't need GoogleAppEngine if we decide that this is useful. We
> > simply need to put the html page which renders the view on
> > https://review.openstack.org. It is all javascript which talks
> > asynchronously to the Gerrit backend.
> >
> > I am using GAE to simply illustrate the idea without having to
> > spin up an entire Gerrit server.
>
> That makes a lot more sense--thanks for the clarification!
>
> > I guess I can also submit a patch to the infra project and see how
> > this works on https://review-dev.openstack.org if you want.
>
> If there's a general desire from the developer community for it,
> then that's probably the next step. However, ultimately this seems
> like something better suited as an upstream feature request for
> Gerrit (there may even already be thread-oriented improvements in
> the works for the new change screen--I haven't kept up with their
> progress lately).
> --
> Jeremy Stanley
>
> ___
> OpenStack-dev mailing list
> OpenStack-dev@lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [all][gerrit] Showing all inline comments from all patch sets

[Dolph Mathews]

I've envisioned basically the same feature before, but I don't find the
comments to be particularly useful without the complete context.

What I really want from gerrit is a 3-way diff, wherein the first column is
always the original state of the repo, the second column is a
user-selectable patchset between (patchset 1) and (latest patchset - 1),
and the third column is always the (latest patchset). And then make it easy
for me to switch the middle column to a different patchset, without
scrolling back to the top of the page. You'd be able to quickly skim
through the history of comments and see the evolution of a patch, which I
think is the same user experience that you're looking for?

I agree with Jeremy though, this is ideally an upstream effort to improve
gerrit itself.

On Tue, Dec 16, 2014 at 4:27 AM, Radoslav Gerganov 
wrote:

> I never liked how Gerrit is displaying inline comments and I find it hard
> to follow discussions on changes with many patch sets and inline comments.
> So I tried to hack together an html view which display all comments grouped
> by patch set, file and commented line.  You can see the result at
> http://gerrit-mirror.appspot.com/.  Some examples:
>
> http://gerrit-mirror.appspot.com/127283
> http://gerrit-mirror.appspot.com/128508
> http://gerrit-mirror.appspot.com/83207
>
> There is room for many improvements (my css skills are very limited) but I
> am just curious if someone else finds the idea useful.  The frontend is
> using the same APIs as the Gerrit UI and the backend running on
> GoogleAppEngine is just proxying the requests to review.openstack.org. So
> in theory if we serve the html page from our Gerrit it will work. You can
> find all sources here: https://github.com/rgerganov/gerrit-hacks.  Let me
> know what you think.
>
> Thanks,
> Rado
>
> ___
> OpenStack-dev mailing list
> OpenStack-dev@lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [all][gerrit] Showing all inline comments from all patch sets

[Jeremy Stanley]

On 2014-12-16 17:19:55 +0200 (+0200), Radoslav Gerganov wrote:
> We don't need GoogleAppEngine if we decide that this is useful. We
> simply need to put the html page which renders the view on
> https://review.openstack.org. It is all javascript which talks
> asynchronously to the Gerrit backend.
> 
> I am using GAE to simply illustrate the idea without having to
> spin up an entire Gerrit server.

That makes a lot more sense--thanks for the clarification!

> I guess I can also submit a patch to the infra project and see how
> this works on https://review-dev.openstack.org if you want.

If there's a general desire from the developer community for it,
then that's probably the next step. However, ultimately this seems
like something better suited as an upstream feature request for
Gerrit (there may even already be thread-oriented improvements in
the works for the new change screen--I haven't kept up with their
progress lately).
-- 
Jeremy Stanley

___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [all][gerrit] Showing all inline comments from all patch sets

[Radoslav Gerganov]

On 12/16/2014 03:59 PM, Jeremy Stanley wrote:

I'm having trouble locating the source code for Google App Engine,
and can instead only find source code for its SDK. How would we run
a GAE instance? (Please remember that our Infra team doesn't host
content backed by proprietary services, but do encourage Google to
release this under a free license if they haven't already.)



Hi Jeremy,

We don't need GoogleAppEngine if we decide that this is useful.  We 
simply need to put the html page which renders the view on 
https://review.openstack.org.  It is all javascript which talks 
asynchronously to the Gerrit backend.


I am using GAE to simply illustrate the idea without having to spin up 
an entire Gerrit server.  I guess I can also submit a patch to the infra 
project and see how this works on https://review-dev.openstack.org if 
you want.


Thanks,
Rado

___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [all][gerrit] Showing all inline comments from all patch sets

[Jeremy Stanley]

On 2014-12-16 12:27:15 +0200 (+0200), Radoslav Gerganov wrote:
[...]
> the backend running on GoogleAppEngine is just proxying the
> requests to review.openstack.org. So in theory if we serve the
> html page from our Gerrit it will work.
[...]

I'm having trouble locating the source code for Google App Engine,
and can instead only find source code for its SDK. How would we run
a GAE instance? (Please remember that our Infra team doesn't host
content backed by proprietary services, but do encourage Google to
release this under a free license if they haven't already.)
-- 
Jeremy Stanley

___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

[openstack-dev] [all][gerrit] Showing all inline comments from all patch sets

[Radoslav Gerganov]

I never liked how Gerrit is displaying inline comments and I find it 
hard to follow discussions on changes with many patch sets and inline 
comments.  So I tried to hack together an html view which display all 
comments grouped by patch set, file and commented line.  You can see the 
result at http://gerrit-mirror.appspot.com/.  Some examples:


http://gerrit-mirror.appspot.com/127283
http://gerrit-mirror.appspot.com/128508
http://gerrit-mirror.appspot.com/83207

There is room for many improvements (my css skills are very limited) but 
I am just curious if someone else finds the idea useful.  The frontend 
is using the same APIs as the Gerrit UI and the backend running on 
GoogleAppEngine is just proxying the requests to review.openstack.org. 
So in theory if we serve the html page from our Gerrit it will work. 
You can find all sources here: 
https://github.com/rgerganov/gerrit-hacks.  Let me know what you think.


Thanks,
Rado

___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev