Re: [openstack-dev] [horizon] Selenium (which is non-free) is back again in Horizon (Icehouse Beta 3)
On Fri, Mar 14, 2014 at 01:03:26PM +0100, Sascha Peilicke wrote:
>
>
>
> Am 14. März 2014 12:32:41 schrieb Thomas Goirand :
>
> >Hi,
> >
> >A few months ago, I raised the fact that Selenium *CANNOT* be a hard
> >test-requirements.txt build-dependency of Horizon, because it is
> >non-free (because of binaries like the browser plug-ins not being
> >build-able from source). So it was removed.
> >
> >Now, on the new Icehouse beta 3, it's back again, and I get some unit
> >tests errors (see below).
> >
> >Guys, could we stop having this kind of regressions, and make Selenium
> >tests not mandatory? They aren't runnable in Debian.
>
> Identical situation with openSUSE. And I guess Fedora is no different.
An additional note:
I was very astonished to see that now included in Fedora; it looks like
it was sufficient to remove the pre-compiled blob
%install
%{__python2} setup.py install --skip-build --root %{buildroot}
rm -f
%{buildroot}%{python2_sitelib}/selenium/webdriver/firefox/amd64/x_ignore_nofocus.so
rm -f
%{buildroot}%{python2_sitelib}/selenium/webdriver/firefox/x86/x_ignore_nofocus.so
%if %{with python3}
pushd %{py3dir}
%{__python3} setup.py install --skip-build --root %{buildroot}
popd
rm -f
%{buildroot}%{python3_sitelib}/selenium/webdriver/firefox/amd64/x_ignore_nofocus.so
rm -f
%{buildroot}%{python3_sitelib}/selenium/webdriver/firefox/x86/x_ignore_nofocus.so
%endif
(the review request is here: [1])
[1] https://bugzilla.redhat.com/show_bug.cgi?id=1070125
Matthias
--
Matthias Runge
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [horizon] Selenium (which is non-free) is back again in Horizon (Icehouse Beta 3)
On 03/14/2014 09:11 PM, Julie Pichon wrote: > On 14/03/14 11:31, Thomas Goirand wrote: >> Hi, >> >> A few months ago, I raised the fact that Selenium *CANNOT* be a hard >> test-requirements.txt build-dependency of Horizon, because it is >> non-free (because of binaries like the browser plug-ins not being >> build-able from source). So it was removed. >> >> Now, on the new Icehouse beta 3, it's back again, and I get some unit >> tests errors (see below). >> >> Guys, could we stop having this kind of regressions, and make Selenium >> tests not mandatory? They aren't runnable in Debian. > > We're aware of the issue, a fix [1] was merged in RC1 if that helps. > > Julie > > [1] https://bugs.launchpad.net/horizon/+bug/1289270 Hi Julie, This does help a lot indeed. Thanks! Thomas Goirand (zigo) ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [horizon] Selenium (which is non-free) is back again in Horizon (Icehouse Beta 3)
On 14/03/14 11:31, Thomas Goirand wrote: > Hi, > > A few months ago, I raised the fact that Selenium *CANNOT* be a hard > test-requirements.txt build-dependency of Horizon, because it is > non-free (because of binaries like the browser plug-ins not being > build-able from source). So it was removed. > > Now, on the new Icehouse beta 3, it's back again, and I get some unit > tests errors (see below). > > Guys, could we stop having this kind of regressions, and make Selenium > tests not mandatory? They aren't runnable in Debian. We're aware of the issue, a fix [1] was merged in RC1 if that helps. Julie [1] https://bugs.launchpad.net/horizon/+bug/1289270 > > Cheers, > > Thomas Goirand (zigo) > > == > ERROR: Failure: ImportError (No module named selenium) > -- > File "openstack_dashboard/test/integration_tests/helpers.py", line 17, > in > import selenium > ImportError: No module named selenium > > == > ERROR: Failure: ImportError (No module named selenium.webdriver.common.keys) > File "openstack_dashboard/test/integration_tests/tests/test_login.py", > line 15, in > import selenium.webdriver.common.keys as keys > > ___ > OpenStack-dev mailing list > OpenStack-dev@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [horizon] Selenium (which is non-free) is back again in Horizon (Icehouse Beta 3)
Am 14. März 2014 12:32:41 schrieb Thomas Goirand : Hi, A few months ago, I raised the fact that Selenium *CANNOT* be a hard test-requirements.txt build-dependency of Horizon, because it is non-free (because of binaries like the browser plug-ins not being build-able from source). So it was removed. Now, on the new Icehouse beta 3, it's back again, and I get some unit tests errors (see below). Guys, could we stop having this kind of regressions, and make Selenium tests not mandatory? They aren't runnable in Debian. Identical situation with openSUSE. And I guess Fedora is no different. Cheers, Thomas Goirand (zigo) == ERROR: Failure: ImportError (No module named selenium) -- File "openstack_dashboard/test/integration_tests/helpers.py", line 17, in import selenium ImportError: No module named selenium == ERROR: Failure: ImportError (No module named selenium.webdriver.common.keys) File "openstack_dashboard/test/integration_tests/tests/test_login.py", line 15, in import selenium.webdriver.common.keys as keys ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev Viele Grüße, Sascha Peilicke ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] [horizon] Selenium (which is non-free) is back again in Horizon (Icehouse Beta 3)
Hi, A few months ago, I raised the fact that Selenium *CANNOT* be a hard test-requirements.txt build-dependency of Horizon, because it is non-free (because of binaries like the browser plug-ins not being build-able from source). So it was removed. Now, on the new Icehouse beta 3, it's back again, and I get some unit tests errors (see below). Guys, could we stop having this kind of regressions, and make Selenium tests not mandatory? They aren't runnable in Debian. Cheers, Thomas Goirand (zigo) == ERROR: Failure: ImportError (No module named selenium) -- File "openstack_dashboard/test/integration_tests/helpers.py", line 17, in import selenium ImportError: No module named selenium == ERROR: Failure: ImportError (No module named selenium.webdriver.common.keys) File "openstack_dashboard/test/integration_tests/tests/test_login.py", line 15, in import selenium.webdriver.common.keys as keys ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
