Re: [openstack-dev] [infra] What do people think of YAPF (like gofmt, for python)?

2015-03-29 Thread Monty Taylor
On 03/27/2015 07:21 AM, Sean Dague wrote: On 03/26/2015 06:46 PM, Robert Collins wrote: On 27 March 2015 at 09:14, Ryan Brown rybr...@redhat.com wrote: Ooof, that's huge. If we can configure it to be less aggressive I love the *idea* of having everything formatted semantically, but that's

Re: [openstack-dev] [infra] What do people think of YAPF (like gofmt, for python)?

2015-03-27 Thread Sean Dague
On 03/26/2015 06:46 PM, Robert Collins wrote: On 27 March 2015 at 09:14, Ryan Brown rybr...@redhat.com wrote: Ooof, that's huge. If we can configure it to be less aggressive I love the *idea* of having everything formatted semantically, but that's a pretty major burden for everyone involved.

Re: [openstack-dev] [infra] What do people think of YAPF (like gofmt, for python)?

2015-03-26 Thread Kiall Mac Innes
binv2ijTsg9Fd.bin Description: PGP/MIME version identification encrypted.asc Description: OpenPGP encrypted message __ OpenStack Development Mailing List (not for usage questions) Unsubscribe:

Re: [openstack-dev] [infra] What do people think of YAPF (like gofmt, for python)?

2015-03-26 Thread Maru Newby
On Mar 25, 2015, at 4:22 PM, Monty Taylor mord...@inaugust.com wrote: On 03/25/2015 05:50 PM, Maru Newby wrote: I am excited by the release of YAPF [1], a gofmt-like too for python. I think it has the potential to simplify style enforcement, and as much as I appreciate our current hacking

Re: [openstack-dev] [infra] What do people think of YAPF (like gofmt, for python)?

2015-03-26 Thread Chmouel Boudjnah
On Thu, Mar 26, 2015 at 5:02 PM, James E. Blair cor...@inaugust.com wrote: This is purposefully done to ensure that developers do not inadvertently run code on their workstations from a source they may not trust. Sure, but is that really make a difference between having some scripts in a

Re: [openstack-dev] [infra] What do people think of YAPF (like gofmt, for python)?

2015-03-26 Thread Ryan Brown
On 03/26/2015 02:15 PM, Kiall Mac Innes wrote: I have no clue how I managed to send that last email encrypted - Apologies :) Re YAPF, or autofomatting, I've very little opinion.. But - I gave YAPF a go against the Designate codebase with the stock config: 258 files changed, 5242

Re: [openstack-dev] [infra] What do people think of YAPF (like gofmt, for python)?

2015-03-26 Thread Kiall Mac Innes
I have no clue how I managed to send that last email encrypted - Apologies :) Re YAPF, or autofomatting, I've very little opinion.. But - I gave YAPF a go against the Designate codebase with the stock config: 258 files changed, 5242 insertions(+), 5691 deletions(-) Getting changes like that

Re: [openstack-dev] [infra] What do people think of YAPF (like gofmt, for python)?

2015-03-26 Thread Robert Collins
On 27 March 2015 at 09:14, Ryan Brown rybr...@redhat.com wrote: Ooof, that's huge. If we can configure it to be less aggressive I love the *idea* of having everything formatted semantically, but that's a pretty major burden for everyone involved. It's huge today. It wouldn't be if we did it

Re: [openstack-dev] [infra] What do people think of YAPF (like gofmt, for python)?

2015-03-26 Thread Chmouel Boudjnah
On Thu, Mar 26, 2015 at 12:22 AM, Monty Taylor mord...@inaugust.com wrote: git review is used by a ton of people who write in non-python. I think adding openstack-specific style enforcement to it would make it way less generally useful. I think if we wanted to do that we could just extend

Re: [openstack-dev] [infra] What do people think of YAPF (like gofmt, for python)?

2015-03-26 Thread James E. Blair
Chmouel Boudjnah chmo...@chmouel.com writes: On Thu, Mar 26, 2015 at 12:22 AM, Monty Taylor mord...@inaugust.com wrote: git review is used by a ton of people who write in non-python. I think adding openstack-specific style enforcement to it would make it way less generally useful. I

[openstack-dev] [infra] What do people think of YAPF (like gofmt, for python)?

2015-03-25 Thread Maru Newby
I am excited by the release of YAPF [1], a gofmt-like too for python. I think it has the potential to simplify style enforcement, and as much as I appreciate our current hacking checks, I’d be much happier not requiring developers to manually conform to them. Maybe we can consider automation

Re: [openstack-dev] [infra] What do people think of YAPF (like gofmt, for python)?

2015-03-25 Thread Joshua Harlow
Unsure, I've always been iff on auto-tools like that. Especially with things like: https://github.com/google/yapf/issues/10 But maybe in time... IMHO the hacking rules aren't that much to learn and are good to know anyway. -Josh Maru Newby wrote: I am excited by the release of YAPF [1], a

Re: [openstack-dev] [infra] What do people think of YAPF (like gofmt, for python)?

2015-03-25 Thread Monty Taylor
On 03/25/2015 05:50 PM, Maru Newby wrote: I am excited by the release of YAPF [1], a gofmt-like too for python. I think it has the potential to simplify style enforcement, and as much as I appreciate our current hacking checks, I’d be much happier not requiring developers to manually conform