Re: [openstack-dev] [ironic] usage of ironic-lib

2016-05-24 Thread Loo, Ruby
Thanks for the feedback everyone. Lucas has submitted a patch to ironic-lib¹s README to clarify this: https://review.openstack.org/#/c/319251/. --ruby On 2016-05-20, 8:46 AM, "Jim Rollenhagen" wrote: >On Thu, May 19, 2016 at 01:21:35PM -0700, Devananda van der Veen wrote: >> On 05/16/2016 07:

Re: [openstack-dev] [ironic] usage of ironic-lib

2016-05-20 Thread Jim Rollenhagen
On Thu, May 19, 2016 at 01:21:35PM -0700, Devananda van der Veen wrote: > On 05/16/2016 07:14 AM, Lucas Alvares Gomes wrote: > > On Mon, May 16, 2016 at 2:57 PM, Loo, Ruby wrote: > >> Hi, > >> > >> A patch to ironic-lib made me wonder about what is our supported usage of > >> ironic-lib. Or even t

Re: [openstack-dev] [ironic] usage of ironic-lib

2016-05-19 Thread Devananda van der Veen
On 05/16/2016 07:14 AM, Lucas Alvares Gomes wrote: > On Mon, May 16, 2016 at 2:57 PM, Loo, Ruby wrote: >> Hi, >> >> A patch to ironic-lib made me wonder about what is our supported usage of >> ironic-lib. Or even the intent/scope of it. This patch changes a method, >> ‘bootable’ parameter is remov

Re: [openstack-dev] [ironic] usage of ironic-lib

2016-05-19 Thread Vladyslav Drok
On Thu, May 19, 2016 at 6:16 PM, Lucas Alvares Gomes wrote: > Hi, > > > So… how does any library get ready to be used by others? Clearly it is > being > > used now by the fuel-agent. Do we say ‘sorry fuel-agent, we don’t > guarantee > > yet that we won’t break you’? Or ‘fuel-agent, just so you kn

Re: [openstack-dev] [ironic] usage of ironic-lib

2016-05-19 Thread Lucas Alvares Gomes
Hi, > So… how does any library get ready to be used by others? Clearly it is being > used now by the fuel-agent. Do we say ‘sorry fuel-agent, we don’t guarantee > yet that we won’t break you’? Or ‘fuel-agent, just so you know. Ironic-lib > isn’t quite ready to be used so we cannot guarantee that w

Re: [openstack-dev] [ironic] usage of ironic-lib

2016-05-19 Thread Loo, Ruby
: "OpenStack Development Mailing List (not for usage questions)" Date: Monday, May 16, 2016 at 11:25 AM To: "OpenStack Development Mailing List (not for usage questions)" Subject: Re: [openstack-dev] [ironic] usage of ironic-lib Hi, I'd like to point that ironic-lib is alrea

Re: [openstack-dev] [ironic] usage of ironic-lib

2016-05-16 Thread Villalovos, John L
> -Original Message- > From: Lucas Alvares Gomes [mailto:lucasago...@gmail.com] > What I don't think we should do is say that the library's _right now_ > ready for it, the interfaces we have at the moment should not be > considered stable, Ironic is very opinionated in many aspects > (speci

Re: [openstack-dev] [ironic] usage of ironic-lib

2016-05-16 Thread Pavlo Shchelokovskyy
Hi, I'd like to point that ironic-lib is already used outside of Ironic tree - for the third-party deployment drivers, e.g this fuel-agent based one [0]. [0] https://github.com/openstack/fuel-agent/blob/master/contrib/ironic/ironic-fa-deploy/ironic_fa_deploy/modules/fuel_agent.py#L30 Best regard

Re: [openstack-dev] [ironic] usage of ironic-lib

2016-05-16 Thread Lucas Alvares Gomes
Hi, On Mon, May 16, 2016 at 3:56 PM, Sam Betts (sambetts) wrote: > I personally disagree with saying that if we wanted it make it usable by > projects other than ones in the Ironic umbrella it should go into oslo. I > think that non-ironic projects directly related to Ironic such as out of > tree

Re: [openstack-dev] [ironic] usage of ironic-lib

2016-05-16 Thread Shivanand Tendulker
I tend to agree with Lucas. I think ironic-lib was designed to have common code to be used primarily into ironic and IPA. It was not intended to be used in other projects. We tend to add methods in the ironic-lib with Ironic and IPA in mind and never thought of it could be used by out of tree drive

Re: [openstack-dev] [ironic] usage of ironic-lib

2016-05-16 Thread Sam Betts (sambetts)
I personally disagree with saying that if we wanted it make it usable by projects other than ones in the Ironic umbrella it should go into oslo. I think that non-ironic projects directly related to Ironic such as out of tree drivers etc, should be able to utilise the code placed into ironic-lib.

Re: [openstack-dev] [ironic] usage of ironic-lib

2016-05-16 Thread Lucas Alvares Gomes
Hi, Thanks for starting this discussion Ruby. On Mon, May 16, 2016 at 2:57 PM, Loo, Ruby wrote: > Hi, > > A patch to ironic-lib made me wonder about what is our supported usage of > ironic-lib. Or even the intent/scope of it. This patch changes a method, > ‘bootable’ parameter is removed and ‘bo

[openstack-dev] [ironic] usage of ironic-lib

2016-05-16 Thread Loo, Ruby
Hi, A patch to ironic-lib made me wonder about what is our supported usage of ironic-lib. Or even the intent/scope of it. This patch changes a method, ‘bootable’ parameter is removed and ‘boot_flag’ parameter is added [1]. If this library/method is used by some out-of-tree thing (or even some i